* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-01-28 11:15 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-01-28 11:15 UTC (permalink / raw)
To: Nicolas Boichat, Andrzej Hajda, Neil Armstrong
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Dan Carpenter,
David Airlie, Daniel Vetter, Boris Brezillon, Sam Ravnborg,
Hsin-Yi Wang, Torsten Duwe, Vasily Khoruzhick, Marek Szyprowski,
Sheng Pan, dri-devel, linux-kernel, devel
Enable DSI EOTP feature for fixing some panel screen constance
shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-01-28 11:15 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-01-28 11:15 UTC (permalink / raw)
To: Nicolas Boichat, Andrzej Hajda, Neil Armstrong
Cc: devel, Jernej Skrabec, Sheng Pan, Jonas Karlman, David Airlie,
linux-kernel, dri-devel, Vasily Khoruzhick, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg,
Dan Carpenter, Marek Szyprowski
Enable DSI EOTP feature for fixing some panel screen constance
shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-01-28 11:15 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-01-28 11:15 UTC (permalink / raw)
To: Nicolas Boichat, Andrzej Hajda, Neil Armstrong
Cc: devel, Jernej Skrabec, Sheng Pan, Jonas Karlman, David Airlie,
linux-kernel, dri-devel, Vasily Khoruzhick, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang,
Sam Ravnborg, Dan Carpenter, Marek Szyprowski
Enable DSI EOTP feature for fixing some panel screen constance
shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-01-28 11:15 ` Xin Ji
(?)
@ 2021-02-04 12:05 ` Robert Foss
-1 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-04 12:05 UTC (permalink / raw)
To: Xin Ji
Cc: Nicolas Boichat, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Dan Carpenter, David Airlie,
Daniel Vetter, Boris Brezillon, Sam Ravnborg, Hsin-Yi Wang,
Torsten Duwe, Vasily Khoruzhick, Marek Szyprowski, Sheng Pan,
dri-devel, linux-kernel, devel
Hi Xin,
Thanks for the patch.
On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>
> Enable DSI EOTP feature for fixing some panel screen constance
> shift issue.
> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
I don't think I quite understand how removing the
MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
you extrapolate on this in the commit message?
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc059..e31eeb1b 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> - MIPI_DSI_MODE_EOT_PACKET |
> MIPI_DSI_MODE_VIDEO_HSE;
>
> if (mipi_dsi_attach(dsi) < 0) {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:05 ` Robert Foss
0 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-04 12:05 UTC (permalink / raw)
To: Xin Ji
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Dan Carpenter,
Marek Szyprowski
Hi Xin,
Thanks for the patch.
On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>
> Enable DSI EOTP feature for fixing some panel screen constance
> shift issue.
> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
I don't think I quite understand how removing the
MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
you extrapolate on this in the commit message?
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc059..e31eeb1b 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> - MIPI_DSI_MODE_EOT_PACKET |
> MIPI_DSI_MODE_VIDEO_HSE;
>
> if (mipi_dsi_attach(dsi) < 0) {
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:05 ` Robert Foss
0 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-04 12:05 UTC (permalink / raw)
To: Xin Ji
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang, Sam Ravnborg,
Dan Carpenter, Marek Szyprowski
Hi Xin,
Thanks for the patch.
On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>
> Enable DSI EOTP feature for fixing some panel screen constance
> shift issue.
> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
I don't think I quite understand how removing the
MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
you extrapolate on this in the commit message?
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc059..e31eeb1b 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> - MIPI_DSI_MODE_EOT_PACKET |
> MIPI_DSI_MODE_VIDEO_HSE;
>
> if (mipi_dsi_attach(dsi) < 0) {
> --
> 2.7.4
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-02-04 12:05 ` Robert Foss
(?)
@ 2021-02-04 12:34 ` Nicolas Boichat
-1 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 12:34 UTC (permalink / raw)
To: Robert Foss
Cc: Xin Ji, Nicolas Boichat, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Dan Carpenter,
David Airlie, Daniel Vetter, Boris Brezillon, Sam Ravnborg,
Hsin-Yi Wang, Torsten Duwe, Vasily Khoruzhick, Marek Szyprowski,
Sheng Pan, dri-devel, linux-kernel, devel
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Xin,
>
> Thanks for the patch.
>
> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constance
> > shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> I don't think I quite understand how removing the
> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> you extrapolate on this in the commit message?
That confused me as well, but it turns out that's how the flag is defined:
```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```
(https://elixir.bootlin.com/linux/latest/source/include/drm/drm_mipi_dsi.h#L129)
I'm almost tempted to put together a mass patch to rename all of these flags...
>
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:34 ` Nicolas Boichat
0 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 12:34 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Xin Ji,
Dan Carpenter, Marek Szyprowski
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Xin,
>
> Thanks for the patch.
>
> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constance
> > shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> I don't think I quite understand how removing the
> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> you extrapolate on this in the commit message?
That confused me as well, but it turns out that's how the flag is defined:
```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```
(https://elixir.bootlin.com/linux/latest/source/include/drm/drm_mipi_dsi.h#L129)
I'm almost tempted to put together a mass patch to rename all of these flags...
>
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:34 ` Nicolas Boichat
0 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 12:34 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang, Sam Ravnborg,
Xin Ji, Dan Carpenter, Marek Szyprowski
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Xin,
>
> Thanks for the patch.
>
> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constance
> > shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> I don't think I quite understand how removing the
> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> you extrapolate on this in the commit message?
That confused me as well, but it turns out that's how the flag is defined:
```
/* disable EoT packets in HS mode */
#define MIPI_DSI_MODE_EOT_PACKET BIT(9)
```
(https://elixir.bootlin.com/linux/latest/source/include/drm/drm_mipi_dsi.h#L129)
I'm almost tempted to put together a mass patch to rename all of these flags...
>
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-02-04 12:34 ` Nicolas Boichat
(?)
@ 2021-02-04 12:59 ` Andrzej Hajda
-1 siblings, 0 replies; 27+ messages in thread
From: Andrzej Hajda @ 2021-02-04 12:59 UTC (permalink / raw)
To: Nicolas Boichat, Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Xin Ji,
Dan Carpenter, Marek Szyprowski
W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>> Hi Xin,
>>
>> Thanks for the patch.
>>
>> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>>> Enable DSI EOTP feature for fixing some panel screen constance
>>> shift issue.
>>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>> I don't think I quite understand how removing the
>> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
>> you extrapolate on this in the commit message?
> That confused me as well, but it turns out that's how the flag is defined:
> ```
> /* disable EoT packets in HS mode */
> #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> ```
> (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
>
> I'm almost tempted to put together a mass patch to rename all of these flags...
Yes that would be good, many of these flags were just copy pasted from
some hw datasheet, without good analysis how to adapt them to the framework.
Regards
Andrzej
>
>>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>>> ---
>>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> index 65cc059..e31eeb1b 100644
>>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
>>> dsi->format = MIPI_DSI_FMT_RGB888;
>>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
>>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>>> - MIPI_DSI_MODE_EOT_PACKET |
>>> MIPI_DSI_MODE_VIDEO_HSE;
>>>
>>> if (mipi_dsi_attach(dsi) < 0) {
>>> --
>>> 2.7.4
>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:59 ` Andrzej Hajda
0 siblings, 0 replies; 27+ messages in thread
From: Andrzej Hajda @ 2021-02-04 12:59 UTC (permalink / raw)
To: Nicolas Boichat, Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Boris Brezillon, Torsten Duwe, Sheng Pan,
Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>> Hi Xin,
>>
>> Thanks for the patch.
>>
>> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>>> Enable DSI EOTP feature for fixing some panel screen constance
>>> shift issue.
>>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>> I don't think I quite understand how removing the
>> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
>> you extrapolate on this in the commit message?
> That confused me as well, but it turns out that's how the flag is defined:
> ```
> /* disable EoT packets in HS mode */
> #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> ```
> (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
>
> I'm almost tempted to put together a mass patch to rename all of these flags...
Yes that would be good, many of these flags were just copy pasted from
some hw datasheet, without good analysis how to adapt them to the framework.
Regards
Andrzej
>
>>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>>> ---
>>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> index 65cc059..e31eeb1b 100644
>>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
>>> dsi->format = MIPI_DSI_FMT_RGB888;
>>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
>>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>>> - MIPI_DSI_MODE_EOT_PACKET |
>>> MIPI_DSI_MODE_VIDEO_HSE;
>>>
>>> if (mipi_dsi_attach(dsi) < 0) {
>>> --
>>> 2.7.4
>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 12:59 ` Andrzej Hajda
0 siblings, 0 replies; 27+ messages in thread
From: Andrzej Hajda @ 2021-02-04 12:59 UTC (permalink / raw)
To: Nicolas Boichat, Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Boris Brezillon, Torsten Duwe, Sheng Pan,
Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>> Hi Xin,
>>
>> Thanks for the patch.
>>
>> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
>>> Enable DSI EOTP feature for fixing some panel screen constance
>>> shift issue.
>>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>> I don't think I quite understand how removing the
>> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
>> you extrapolate on this in the commit message?
> That confused me as well, but it turns out that's how the flag is defined:
> ```
> /* disable EoT packets in HS mode */
> #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> ```
> (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
>
> I'm almost tempted to put together a mass patch to rename all of these flags...
Yes that would be good, many of these flags were just copy pasted from
some hw datasheet, without good analysis how to adapt them to the framework.
Regards
Andrzej
>
>>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>>> ---
>>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> index 65cc059..e31eeb1b 100644
>>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
>>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
>>> dsi->format = MIPI_DSI_FMT_RGB888;
>>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
>>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>>> - MIPI_DSI_MODE_EOT_PACKET |
>>> MIPI_DSI_MODE_VIDEO_HSE;
>>>
>>> if (mipi_dsi_attach(dsi) < 0) {
>>> --
>>> 2.7.4
>>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-02-04 12:59 ` Andrzej Hajda
(?)
@ 2021-02-04 22:25 ` Nicolas Boichat
-1 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 22:25 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Robert Foss, devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan,
Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Xin Ji,
Dan Carpenter, Marek Szyprowski
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
>
>
> W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> >> Hi Xin,
> >>
> >> Thanks for the patch.
> >>
> >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >>> Enable DSI EOTP feature for fixing some panel screen constance
> >>> shift issue.
> >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >> I don't think I quite understand how removing the
> >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> >> you extrapolate on this in the commit message?
> > That confused me as well, but it turns out that's how the flag is defined:
> > ```
> > /* disable EoT packets in HS mode */
> > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > ```
> > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> >
> > I'm almost tempted to put together a mass patch to rename all of these flags...
>
>
> Yes that would be good, many of these flags were just copy pasted from
> some hw datasheet, without good analysis how to adapt them to the framework.
I'll look into it (but that shouldn't block this patch).
>
>
> Regards
>
> Andrzej
>
>
> >
> >>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> >>> ---
> >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> index 65cc059..e31eeb1b 100644
> >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> >>> dsi->format = MIPI_DSI_FMT_RGB888;
> >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> >>> - MIPI_DSI_MODE_EOT_PACKET |
> >>> MIPI_DSI_MODE_VIDEO_HSE;
> >>>
> >>> if (mipi_dsi_attach(dsi) < 0) {
> >>> --
> >>> 2.7.4
> >>>
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
> >
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 22:25 ` Nicolas Boichat
0 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 22:25 UTC (permalink / raw)
To: Andrzej Hajda
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, dri-devel, Neil Armstrong, linux-kernel,
Robert Foss, Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Sheng Pan, Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
>
>
> W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> >> Hi Xin,
> >>
> >> Thanks for the patch.
> >>
> >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >>> Enable DSI EOTP feature for fixing some panel screen constance
> >>> shift issue.
> >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >> I don't think I quite understand how removing the
> >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> >> you extrapolate on this in the commit message?
> > That confused me as well, but it turns out that's how the flag is defined:
> > ```
> > /* disable EoT packets in HS mode */
> > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > ```
> > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> >
> > I'm almost tempted to put together a mass patch to rename all of these flags...
>
>
> Yes that would be good, many of these flags were just copy pasted from
> some hw datasheet, without good analysis how to adapt them to the framework.
I'll look into it (but that shouldn't block this patch).
>
>
> Regards
>
> Andrzej
>
>
> >
> >>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> >>> ---
> >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> index 65cc059..e31eeb1b 100644
> >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> >>> dsi->format = MIPI_DSI_FMT_RGB888;
> >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> >>> - MIPI_DSI_MODE_EOT_PACKET |
> >>> MIPI_DSI_MODE_VIDEO_HSE;
> >>>
> >>> if (mipi_dsi_attach(dsi) < 0) {
> >>> --
> >>> 2.7.4
> >>>
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-04 22:25 ` Nicolas Boichat
0 siblings, 0 replies; 27+ messages in thread
From: Nicolas Boichat @ 2021-02-04 22:25 UTC (permalink / raw)
To: Andrzej Hajda
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, dri-devel, Neil Armstrong, linux-kernel,
Robert Foss, Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Sheng Pan, Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
>
>
> W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> >> Hi Xin,
> >>
> >> Thanks for the patch.
> >>
> >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> >>> Enable DSI EOTP feature for fixing some panel screen constance
> >>> shift issue.
> >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >> I don't think I quite understand how removing the
> >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> >> you extrapolate on this in the commit message?
> > That confused me as well, but it turns out that's how the flag is defined:
> > ```
> > /* disable EoT packets in HS mode */
> > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > ```
> > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> >
> > I'm almost tempted to put together a mass patch to rename all of these flags...
>
>
> Yes that would be good, many of these flags were just copy pasted from
> some hw datasheet, without good analysis how to adapt them to the framework.
I'll look into it (but that shouldn't block this patch).
>
>
> Regards
>
> Andrzej
>
>
> >
> >>> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> >>> ---
> >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> index 65cc059..e31eeb1b 100644
> >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> >>> dsi->format = MIPI_DSI_FMT_RGB888;
> >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> >>> - MIPI_DSI_MODE_EOT_PACKET |
> >>> MIPI_DSI_MODE_VIDEO_HSE;
> >>>
> >>> if (mipi_dsi_attach(dsi) < 0) {
> >>> --
> >>> 2.7.4
> >>>
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel
> >
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-02-04 22:25 ` Nicolas Boichat
(?)
@ 2021-02-05 9:43 ` Robert Foss
-1 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-05 9:43 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Andrzej Hajda, devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan,
Jonas Karlman, David Airlie, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Xin Ji,
Dan Carpenter, Marek Szyprowski
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >
> >
> > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >> Hi Xin,
> > >>
> > >> Thanks for the patch.
> > >>
> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > >>> shift issue.
> > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Does "constance shift" have a typo? Should it be "constant shift"?
With that sorted out feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > >> I don't think I quite understand how removing the
> > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > >> you extrapolate on this in the commit message?
> > > That confused me as well, but it turns out that's how the flag is defined:
> > > ```
> > > /* disable EoT packets in HS mode */
> > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > ```
> > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > >
> > > I'm almost tempted to put together a mass patch to rename all of these flags...
> >
> >
> > Yes that would be good, many of these flags were just copy pasted from
> > some hw datasheet, without good analysis how to adapt them to the framework.
>
> I'll look into it (but that shouldn't block this patch).
Thanks for clearing this up Nicolas & Andrzej!
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 9:43 ` Robert Foss
0 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-05 9:43 UTC (permalink / raw)
To: Nicolas Boichat
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Sheng Pan, Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >
> >
> > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >> Hi Xin,
> > >>
> > >> Thanks for the patch.
> > >>
> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > >>> shift issue.
> > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Does "constance shift" have a typo? Should it be "constant shift"?
With that sorted out feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > >> I don't think I quite understand how removing the
> > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > >> you extrapolate on this in the commit message?
> > > That confused me as well, but it turns out that's how the flag is defined:
> > > ```
> > > /* disable EoT packets in HS mode */
> > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > ```
> > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > >
> > > I'm almost tempted to put together a mass patch to rename all of these flags...
> >
> >
> > Yes that would be good, many of these flags were just copy pasted from
> > some hw datasheet, without good analysis how to adapt them to the framework.
>
> I'll look into it (but that shouldn't block this patch).
Thanks for clearing this up Nicolas & Andrzej!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 9:43 ` Robert Foss
0 siblings, 0 replies; 27+ messages in thread
From: Robert Foss @ 2021-02-05 9:43 UTC (permalink / raw)
To: Nicolas Boichat
Cc: devel, Nicolas Boichat, Jernej Skrabec, Jonas Karlman,
David Airlie, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon, Torsten Duwe,
Sheng Pan, Hsin-Yi Wang, Marek Szyprowski, Sam Ravnborg, Xin Ji,
Dan Carpenter, Laurent Pinchart
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >
> >
> > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >> Hi Xin,
> > >>
> > >> Thanks for the patch.
> > >>
> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > >>> shift issue.
> > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Does "constance shift" have a typo? Should it be "constant shift"?
With that sorted out feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > >> I don't think I quite understand how removing the
> > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > >> you extrapolate on this in the commit message?
> > > That confused me as well, but it turns out that's how the flag is defined:
> > > ```
> > > /* disable EoT packets in HS mode */
> > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > ```
> > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > >
> > > I'm almost tempted to put together a mass patch to rename all of these flags...
> >
> >
> > Yes that would be good, many of these flags were just copy pasted from
> > some hw datasheet, without good analysis how to adapt them to the framework.
>
> I'll look into it (but that shouldn't block this patch).
Thanks for clearing this up Nicolas & Andrzej!
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
2021-02-05 9:43 ` Robert Foss
(?)
@ 2021-02-05 11:05 ` Xin Ji
-1 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:05 UTC (permalink / raw)
To: Robert Foss
Cc: Nicolas Boichat, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Dan Carpenter, David Airlie,
Daniel Vetter, Boris Brezillon, Sam Ravnborg, Hsin-Yi Wang,
Torsten Duwe, Vasily Khoruzhick, Marek Szyprowski, Sheng Pan,
Bernie Liang, dri-devel, linux-kernel, devel
On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote:
> On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
> >
> > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> > >
> > >
> > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > >> Hi Xin,
> > > >>
> > > >> Thanks for the patch.
> > > >>
> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > > >>> shift issue.
> > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> Does "constance shift" have a typo? Should it be "constant shift"?
>
> With that sorted out feel free to add my r-b.
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Hi Robert Foss, thanks, I'll correct it.
Thanks,
Xin
>
> > > >> I don't think I quite understand how removing the
> > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > > >> you extrapolate on this in the commit message?
> > > > That confused me as well, but it turns out that's how the flag is defined:
> > > > ```
> > > > /* disable EoT packets in HS mode */
> > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > > ```
> > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > > >
> > > > I'm almost tempted to put together a mass patch to rename all of these flags...
> > >
> > >
> > > Yes that would be good, many of these flags were just copy pasted from
> > > some hw datasheet, without good analysis how to adapt them to the framework.
> >
> > I'll look into it (but that shouldn't block this patch).
>
> Thanks for clearing this up Nicolas & Andrzej!
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:05 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:05 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Bernie Liang, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg,
Dan Carpenter, Marek Szyprowski
On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote:
> On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
> >
> > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> > >
> > >
> > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > >> Hi Xin,
> > > >>
> > > >> Thanks for the patch.
> > > >>
> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > > >>> shift issue.
> > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> Does "constance shift" have a typo? Should it be "constant shift"?
>
> With that sorted out feel free to add my r-b.
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Hi Robert Foss, thanks, I'll correct it.
Thanks,
Xin
>
> > > >> I don't think I quite understand how removing the
> > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > > >> you extrapolate on this in the commit message?
> > > > That confused me as well, but it turns out that's how the flag is defined:
> > > > ```
> > > > /* disable EoT packets in HS mode */
> > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > > ```
> > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > > >
> > > > I'm almost tempted to put together a mass patch to rename all of these flags...
> > >
> > >
> > > Yes that would be good, many of these flags were just copy pasted from
> > > some hw datasheet, without good analysis how to adapt them to the framework.
> >
> > I'll look into it (but that shouldn't block this patch).
>
> Thanks for clearing this up Nicolas & Andrzej!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:05 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:05 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Bernie Liang, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang,
Sam Ravnborg, Dan Carpenter, Marek Szyprowski
On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote:
> On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat <drinkcat@chromium.org> wrote:
> >
> > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
> > >
> > >
> > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > >> Hi Xin,
> > > >>
> > > >> Thanks for the patch.
> > > >>
> > > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji <xji@analogixsemi.com> wrote:
> > > >>> Enable DSI EOTP feature for fixing some panel screen constance
> > > >>> shift issue.
> > > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
>
> Does "constance shift" have a typo? Should it be "constant shift"?
>
> With that sorted out feel free to add my r-b.
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Hi Robert Foss, thanks, I'll correct it.
Thanks,
Xin
>
> > > >> I don't think I quite understand how removing the
> > > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could
> > > >> you extrapolate on this in the commit message?
> > > > That confused me as well, but it turns out that's how the flag is defined:
> > > > ```
> > > > /* disable EoT packets in HS mode */
> > > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9)
> > > > ```
> > > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129)
> > > >
> > > > I'm almost tempted to put together a mass patch to rename all of these flags...
> > >
> > >
> > > Yes that would be good, many of these flags were just copy pasted from
> > > some hw datasheet, without good analysis how to adapt them to the framework.
> >
> > I'll look into it (but that shouldn't block this patch).
>
> Thanks for clearing this up Nicolas & Andrzej!
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:13 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:13 UTC (permalink / raw)
To: Robert Foss, Nicolas Boichat, Andrzej Hajda
Cc: Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Dan Carpenter, David Airlie, Daniel Vetter, Boris Brezillon,
Sam Ravnborg, Hsin-Yi Wang, Torsten Duwe, Vasily Khoruzhick,
Marek Szyprowski, Sheng Pan, Bernie Liang, dri-devel,
linux-kernel, devel
Enable DSI EOTP feature for fixing some panel screen constant shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:13 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:13 UTC (permalink / raw)
To: Robert Foss, Nicolas Boichat, Andrzej Hajda
Cc: devel, Jernej Skrabec, Sheng Pan, Jonas Karlman, David Airlie,
Bernie Liang, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg, Dan Carpenter,
Marek Szyprowski
Enable DSI EOTP feature for fixing some panel screen constant shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:13 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:13 UTC (permalink / raw)
To: Robert Foss, Nicolas Boichat, Andrzej Hajda
Cc: devel, Jernej Skrabec, Sheng Pan, Jonas Karlman, David Airlie,
Bernie Liang, Neil Armstrong, linux-kernel, dri-devel,
Vasily Khoruzhick, Boris Brezillon, Torsten Duwe,
Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang, Sam Ravnborg,
Dan Carpenter, Marek Szyprowski
Enable DSI EOTP feature for fixing some panel screen constant shift issue.
Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 65cc059..e31eeb1b 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
- MIPI_DSI_MODE_EOT_PACKET |
MIPI_DSI_MODE_VIDEO_HSE;
if (mipi_dsi_attach(dsi) < 0) {
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread[parent not found: <CAG3jFys6QoGpo7C2t=P2pgsY1CfwU=vNkx2SZgGfRbzmVneKog@mail.gmail.com>]
* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
[not found] ` <CAG3jFys6QoGpo7C2t=P2pgsY1CfwU=vNkx2SZgGfRbzmVneKog@mail.gmail.com>
2021-02-05 11:35 ` Xin Ji
@ 2021-02-05 11:35 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:35 UTC (permalink / raw)
To: Robert Foss
Cc: Nicolas Boichat, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Dan Carpenter, David Airlie,
Daniel Vetter, Boris Brezillon, Sam Ravnborg, Hsin-Yi Wang,
Torsten Duwe, Vasily Khoruzhick, Marek Szyprowski, Sheng Pan,
Bernie Liang, dri-devel, linux-kernel, devel
On Fri, Feb 05, 2021 at 12:30:45PM +0100, Robert Foss wrote:
> Hey Xin,
>
> Thanks for the quick response. I think this is ok.
>
> But going forward it is easier for maintainers to keep track of
> patches if they're submitted with a version tag. [PATCH] -> [PATCH v2]
> -> [PATCH v3] etc.
>
> git send-email -v1
> git send-email -v2
> git send-email -v3
>
> ^^^ does this for you
>
>
> Rob.
Hi Rob, thanks, I'll follow the rules in the next upstream.
Thanks,
xin
>
> On Fri, 5 Feb 2021 at 12:14, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constant shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:35 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:35 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Bernie Liang, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Hsin-Yi Wang, Sam Ravnborg,
Dan Carpenter, Marek Szyprowski
On Fri, Feb 05, 2021 at 12:30:45PM +0100, Robert Foss wrote:
> Hey Xin,
>
> Thanks for the quick response. I think this is ok.
>
> But going forward it is easier for maintainers to keep track of
> patches if they're submitted with a version tag. [PATCH] -> [PATCH v2]
> -> [PATCH v3] etc.
>
> git send-email -v1
> git send-email -v2
> git send-email -v3
>
> ^^^ does this for you
>
>
> Rob.
Hi Rob, thanks, I'll follow the rules in the next upstream.
Thanks,
xin
>
> On Fri, 5 Feb 2021 at 12:14, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constant shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP
@ 2021-02-05 11:35 ` Xin Ji
0 siblings, 0 replies; 27+ messages in thread
From: Xin Ji @ 2021-02-05 11:35 UTC (permalink / raw)
To: Robert Foss
Cc: devel, Nicolas Boichat, Jernej Skrabec, Sheng Pan, Jonas Karlman,
David Airlie, Bernie Liang, Neil Armstrong, linux-kernel,
dri-devel, Vasily Khoruzhick, Andrzej Hajda, Boris Brezillon,
Torsten Duwe, Laurent Pinchart, Daniel Vetter, Hsin-Yi Wang,
Sam Ravnborg, Dan Carpenter, Marek Szyprowski
On Fri, Feb 05, 2021 at 12:30:45PM +0100, Robert Foss wrote:
> Hey Xin,
>
> Thanks for the quick response. I think this is ok.
>
> But going forward it is easier for maintainers to keep track of
> patches if they're submitted with a version tag. [PATCH] -> [PATCH v2]
> -> [PATCH v3] etc.
>
> git send-email -v1
> git send-email -v2
> git send-email -v3
>
> ^^^ does this for you
>
>
> Rob.
Hi Rob, thanks, I'll follow the rules in the next upstream.
Thanks,
xin
>
> On Fri, 5 Feb 2021 at 12:14, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > Enable DSI EOTP feature for fixing some panel screen constant shift issue.
> > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 65cc059..e31eeb1b 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > - MIPI_DSI_MODE_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > --
> > 2.7.4
> >
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2021-02-05 13:43 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 11:15 [PATCH] drm/bridge: anx7625: enable DSI EOTP Xin Ji
2021-01-28 11:15 ` Xin Ji
2021-01-28 11:15 ` Xin Ji
2021-02-04 12:05 ` Robert Foss
2021-02-04 12:05 ` Robert Foss
2021-02-04 12:05 ` Robert Foss
2021-02-04 12:34 ` Nicolas Boichat
2021-02-04 12:34 ` Nicolas Boichat
2021-02-04 12:34 ` Nicolas Boichat
2021-02-04 12:59 ` Andrzej Hajda
2021-02-04 12:59 ` Andrzej Hajda
2021-02-04 12:59 ` Andrzej Hajda
2021-02-04 22:25 ` Nicolas Boichat
2021-02-04 22:25 ` Nicolas Boichat
2021-02-04 22:25 ` Nicolas Boichat
2021-02-05 9:43 ` Robert Foss
2021-02-05 9:43 ` Robert Foss
2021-02-05 9:43 ` Robert Foss
2021-02-05 11:05 ` Xin Ji
2021-02-05 11:05 ` Xin Ji
2021-02-05 11:05 ` Xin Ji
2021-02-05 11:13 Xin Ji
2021-02-05 11:13 ` Xin Ji
2021-02-05 11:13 ` Xin Ji
[not found] ` <CAG3jFys6QoGpo7C2t=P2pgsY1CfwU=vNkx2SZgGfRbzmVneKog@mail.gmail.com>
2021-02-05 11:35 ` Xin Ji
2021-02-05 11:35 ` Xin Ji
2021-02-05 11:35 ` Xin Ji
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.