From: Julius Werner <jwerner@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>,
Chris Zhong <zyw@rock-chips.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Sonny Rao <sonnyrao@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st
Date: Mon, 7 Dec 2015 17:41:39 -0800 [thread overview]
Message-ID: <CAODwPW8XmGkPNTw4y_UG7Qy4P1B6y4VH6MOHi1905S_VCrnTPg@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=Wx2E+sVOyMuNyzBnkJrzYuG_yoC7b54EApLg7QTu2sxQ@mail.gmail.com>
> Technically you could still implement this and if firmware happens to
> read the RTC (and doesn't correct things) then we won't be able to
> correct things. ...but certainly if you read the old time and then
> the new time and the old time was < 11/31 and the new time was >=
> 11/31 you know you need to correct.
>
> I'd say that there's a good chance that other firmware (UBoot) doesn't
> actually read the RTC anyway. Why would it? We only do it for even
> log, right?
Hah! Sounds like you assume U-Boot was doing the things it does with
comprehensible reasoning. From my experience, that's a dangerous wager
(not that I'm biased or anything... ;) ). FWIW, they seem to be having
a huge (175kloc, of only the finest copied kernel code from 10+ years
ago, I presume) repository of RTC drivers, a separate command line
command to read/write to it, and an SNTP client.
Still, you're right that adding the GET_TIME check wouldn't hurt... at
worst it just does nothing. I'll try it out.
WARNING: multiple messages have this Message-ID (diff)
From: Julius Werner <jwerner@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>,
Chris Zhong <zyw@rock-chips.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Sonny Rao <sonnyrao@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: [rtc-linux] Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st
Date: Mon, 7 Dec 2015 17:41:39 -0800 [thread overview]
Message-ID: <CAODwPW8XmGkPNTw4y_UG7Qy4P1B6y4VH6MOHi1905S_VCrnTPg@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=Wx2E+sVOyMuNyzBnkJrzYuG_yoC7b54EApLg7QTu2sxQ@mail.gmail.com>
> Technically you could still implement this and if firmware happens to
> read the RTC (and doesn't correct things) then we won't be able to
> correct things. ...but certainly if you read the old time and then
> the new time and the old time was < 11/31 and the new time was >=
> 11/31 you know you need to correct.
>
> I'd say that there's a good chance that other firmware (UBoot) doesn't
> actually read the RTC anyway. Why would it? We only do it for even
> log, right?
Hah! Sounds like you assume U-Boot was doing the things it does with
comprehensible reasoning. From my experience, that's a dangerous wager
(not that I'm biased or anything... ;) ). FWIW, they seem to be having
a huge (175kloc, of only the finest copied kernel code from 10+ years
ago, I presume) repository of RTC drivers, a separate command line
command to read/write to it, and an SNTP client.
Still, you're right that adding the GET_TIME check wouldn't hurt... at
worst it just does nothing. I'll try it out.
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-12-08 1:41 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:53 [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner
2015-12-03 1:53 ` [rtc-linux] " Julius Werner
2015-12-03 14:42 ` Alexandre Belloni
2015-12-03 14:42 ` Alexandre Belloni
2015-12-03 16:53 ` Julius Werner
2015-12-03 16:53 ` Julius Werner
2015-12-04 23:50 ` Doug Anderson
2015-12-04 23:50 ` [rtc-linux] " Doug Anderson
2015-12-05 0:25 ` Julius Werner
2015-12-05 0:25 ` [rtc-linux] " Julius Werner
2015-12-05 0:58 ` Doug Anderson
2015-12-05 0:58 ` [rtc-linux] " Doug Anderson
2015-12-05 1:54 ` Julius Werner
2015-12-05 1:54 ` [rtc-linux] " Julius Werner
2015-12-05 4:02 ` Doug Anderson
2015-12-05 4:02 ` [rtc-linux] " Doug Anderson
2015-12-05 4:53 ` Doug Anderson
2015-12-05 4:53 ` [rtc-linux] " Doug Anderson
2015-12-05 7:17 ` Julius Werner
2015-12-05 7:17 ` [rtc-linux] " Julius Werner
2015-12-06 0:36 ` Doug Anderson
2015-12-06 0:36 ` [rtc-linux] " Doug Anderson
2015-12-07 1:33 ` Chris Zhong
2015-12-07 1:33 ` [rtc-linux] " Chris Zhong
2015-12-07 2:50 ` Doug Anderson
2015-12-07 2:50 ` [rtc-linux] " Doug Anderson
2015-12-07 2:52 ` Doug Anderson
2015-12-07 2:52 ` [rtc-linux] " Doug Anderson
2015-12-07 3:08 ` Chris Zhong
2015-12-07 3:08 ` [rtc-linux] " Chris Zhong
2015-12-07 20:28 ` Julius Werner
2015-12-07 20:28 ` [rtc-linux] " Julius Werner
2015-12-07 22:40 ` Julius Werner
2015-12-07 22:40 ` [rtc-linux] " Julius Werner
2015-12-08 1:17 ` Doug Anderson
2015-12-08 1:17 ` [rtc-linux] " Doug Anderson
2015-12-08 1:41 ` Julius Werner [this message]
2015-12-08 1:41 ` Julius Werner
2015-12-08 5:19 ` Julius Werner
2015-12-08 5:19 ` [rtc-linux] " Julius Werner
2015-12-08 5:21 ` [PATCH v2] " Julius Werner
2015-12-08 5:21 ` [rtc-linux] " Julius Werner
2015-12-09 5:44 ` Doug Anderson
2015-12-09 5:44 ` [rtc-linux] " Doug Anderson
2015-12-09 21:32 ` Julius Werner
2015-12-09 21:32 ` [rtc-linux] " Julius Werner
2015-12-10 18:41 ` Alexandre Belloni
2015-12-10 18:41 ` [rtc-linux] " Alexandre Belloni
2015-12-10 18:57 ` Julius Werner
2015-12-10 18:57 ` [rtc-linux] " Julius Werner
2015-12-15 23:02 ` [PATCHv3] RTC: RK808: Compensate for Rockchip calendar deviation " Julius Werner
2015-12-15 23:02 ` [rtc-linux] " Julius Werner
2015-12-15 23:14 ` Julius Werner
2015-12-15 23:14 ` [rtc-linux] " Julius Werner
2015-12-19 0:25 ` Doug Anderson
2015-12-19 0:25 ` [rtc-linux] " Doug Anderson
2015-12-19 0:31 ` Julius Werner
2015-12-19 0:31 ` [rtc-linux] " Julius Werner
2015-12-19 0:26 ` Doug Anderson
2015-12-19 0:26 ` [rtc-linux] " Doug Anderson
2015-12-21 8:16 ` Alexandre Belloni
2015-12-21 8:16 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAODwPW8XmGkPNTw4y_UG7Qy4P1B6y4VH6MOHi1905S_VCrnTPg@mail.gmail.com \
--to=jwerner@chromium.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sonnyrao@chromium.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.