From: Suman Tripathi <stripathi@apm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>,
anton@enomsg.org, linux-mmc@vger.kernel.org, chris@printf.net,
patches <patches@apm.com>, Don Dutile <ddutile@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 28 Jan 2015 18:52:20 +0530 [thread overview]
Message-ID: <CAOHikRDb8aVbP+5yMxxE-d4qeO3gbz2wnZGmMB7b7+eoF+pm=g@mail.gmail.com> (raw)
In-Reply-To: <2323575.nqxsEzcHbG@wuerfel>
On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>
> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
> In the next version Also I will remove the IOMMU hacks from arasan
> driver
Hmm, I guess you have a required ordering between the patches either
way, which makes it hard to merge in a way that is bisectable.
You are correct that you should not merge a patch with the iommu
reference before adding the iommu device node, because it would
otherwise break building the mmc tree.
One more point is the binding for IOMMU needs to be in the same patch
in which the IOMMU support is added. So to provide the binding info of
the master node we require the sdhc nodes to be merged first.
Usually, the right answer is to merged the dts changes through the
arm-soc tree, and then you can just add the node for the sdhc device
after the one for the iommu device.
On Wed, Jan 28, 2015 at 6:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>>
>> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
>> In the next version Also I will remove the IOMMU hacks from arasan
>> driver
>
> Hmm, I guess you have a required ordering between the patches either
> way, which makes it hard to merge in a way that is bisectable.
>
> You are correct that you should not merge a patch with the iommu
> reference before adding the iommu device node, because it would
> otherwise break building the mmc tree.
>
> Usually, the right answer is to merged the dts changes through the
> arm-soc tree, and then you can just add the node for the sdhc device
> after the one for the iommu device.
>
> Arnd
--
Thanks,
with regards,
Suman Tripathi
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
WARNING: multiple messages have this Message-ID (diff)
From: Suman Tripathi <stripathi@apm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>,
anton@enomsg.org, linux-mmc@vger.kernel.org, chris@printf.net,
patches <patches@apm.com>, Don Dutile <ddutile@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 28 Jan 2015 18:52:20 +0530 [thread overview]
Message-ID: <CAOHikRDb8aVbP+5yMxxE-d4qeO3gbz2wnZGmMB7b7+eoF+pm=g@mail.gmail.com> (raw)
In-Reply-To: <2323575.nqxsEzcHbG@wuerfel>
On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>
> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
> In the next version Also I will remove the IOMMU hacks from arasan
> driver
Hmm, I guess you have a required ordering between the patches either
way, which makes it hard to merge in a way that is bisectable.
You are correct that you should not merge a patch with the iommu
reference before adding the iommu device node, because it would
otherwise break building the mmc tree.
One more point is the binding for IOMMU needs to be in the same patch
in which the IOMMU support is added. So to provide the binding info of
the master node we require the sdhc nodes to be merged first.
Usually, the right answer is to merged the dts changes through the
arm-soc tree, and then you can just add the node for the sdhc device
after the one for the iommu device.
On Wed, Jan 28, 2015 at 6:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>>
>> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
>> In the next version Also I will remove the IOMMU hacks from arasan
>> driver
>
> Hmm, I guess you have a required ordering between the patches either
> way, which makes it hard to merge in a way that is bisectable.
>
> You are correct that you should not merge a patch with the iommu
> reference before adding the iommu device node, because it would
> otherwise break building the mmc tree.
>
> Usually, the right answer is to merged the dts changes through the
> arm-soc tree, and then you can just add the node for the sdhc device
> after the one for the iommu device.
>
> Arnd
--
Thanks,
with regards,
Suman Tripathi
WARNING: multiple messages have this Message-ID (diff)
From: stripathi@apm.com (Suman Tripathi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 28 Jan 2015 18:52:20 +0530 [thread overview]
Message-ID: <CAOHikRDb8aVbP+5yMxxE-d4qeO3gbz2wnZGmMB7b7+eoF+pm=g@mail.gmail.com> (raw)
In-Reply-To: <2323575.nqxsEzcHbG@wuerfel>
On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>
> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
> In the next version Also I will remove the IOMMU hacks from arasan
> driver
Hmm, I guess you have a required ordering between the patches either
way, which makes it hard to merge in a way that is bisectable.
You are correct that you should not merge a patch with the iommu
reference before adding the iommu device node, because it would
otherwise break building the mmc tree.
One more point is the binding for IOMMU needs to be in the same patch
in which the IOMMU support is added. So to provide the binding info of
the master node we require the sdhc nodes to be merged first.
Usually, the right answer is to merged the dts changes through the
arm-soc tree, and then you can just add the node for the sdhc device
after the one for the iommu device.
On Wed, Jan 28, 2015 at 6:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote:
>>
>> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
>> In the next version Also I will remove the IOMMU hacks from arasan
>> driver
>
> Hmm, I guess you have a required ordering between the patches either
> way, which makes it hard to merge in a way that is bisectable.
>
> You are correct that you should not merge a patch with the iommu
> reference before adding the iommu device node, because it would
> otherwise break building the mmc tree.
>
> Usually, the right answer is to merged the dts changes through the
> arm-soc tree, and then you can just add the node for the sdhc device
> after the one for the iommu device.
>
> Arnd
--
Thanks,
with regards,
Suman Tripathi
next prev parent reply other threads:[~2015-01-28 13:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 17:20 [PATCH v1 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-01-27 17:20 ` Suman Tripathi
2015-01-27 17:20 ` [PATCH v1 1/2] mmc: host: arasan: Add addition of-arasan quirks and IOMMU support for arasan SDHCI driver Suman Tripathi
2015-01-27 17:20 ` Suman Tripathi
2015-01-27 20:12 ` Arnd Bergmann
2015-01-27 20:12 ` Arnd Bergmann
2015-01-27 20:12 ` Arnd Bergmann
2015-01-27 17:21 ` [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-01-27 17:21 ` Suman Tripathi
2015-01-27 20:13 ` Arnd Bergmann
2015-01-27 20:13 ` Arnd Bergmann
2015-01-27 20:13 ` Arnd Bergmann
2015-01-28 4:18 ` Suman Tripathi
2015-01-28 4:18 ` Suman Tripathi
2015-01-28 4:23 ` Suman Tripathi
2015-01-28 4:23 ` Suman Tripathi
2015-01-28 12:46 ` Arnd Bergmann
2015-01-28 12:46 ` Arnd Bergmann
2015-01-28 13:22 ` Suman Tripathi [this message]
2015-01-28 13:22 ` Suman Tripathi
2015-01-28 13:22 ` Suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOHikRDb8aVbP+5yMxxE-d4qeO3gbz2wnZGmMB7b7+eoF+pm=g@mail.gmail.com' \
--to=stripathi@apm.com \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=chris@printf.net \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mlangsdo@redhat.com \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.