* [PATCH] arm64: dts: remove big-endian filed from IFC controller
@ 2018-08-28 6:59 ` Prabhakar Kushwaha
0 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28 6:59 UTC (permalink / raw)
To: linux-arm-kernel
As per IFC binding, Absence of "little-endian" field causes registers
access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and
LS1046A.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index b9f5d2ff4ff2..68af84a8ade8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -280,7 +281,6 @@
ifc: ifc at 1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <0 43 0x4>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 65ce1c3cb568..9f5acb4dfaf3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -4,6 +4,8 @@
*
* Copyright 2016 Freescale Semiconductor, Inc.
*
+ * Copyright 2018 NXP
+ *
* Mingkai Hu <mingkai.hu@nxp.com>
*/
@@ -198,7 +200,6 @@
ifc: ifc at 1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 6:59 ` Prabhakar Kushwaha
-1 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28 6:59 UTC (permalink / raw)
To: devicetree, robh, mark.rutland, shawnguo
Cc: Prabhakar Kushwaha, linux-arm-kernel, leoyang.li
NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
RESEND keeping Li Yang <leoyang.li@nxp.com>
arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 499f41a2c6f0..923a25760516 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -1,5 +1,6 @@
/*
* Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -235,6 +236,7 @@
#size-cells = <1>;
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index f0c949d74833..8b48c3c7cd21 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -1,5 +1,6 @@
/*
* Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -203,6 +204,7 @@
#size-cells = <1>;
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-08-28 6:59 ` Prabhakar Kushwaha
0 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28 6:59 UTC (permalink / raw)
To: linux-arm-kernel
NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
RESEND keeping Li Yang <leoyang.li@nxp.com>
arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 499f41a2c6f0..923a25760516 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -1,5 +1,6 @@
/*
* Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -235,6 +236,7 @@
#size-cells = <1>;
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index f0c949d74833..8b48c3c7cd21 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -1,5 +1,6 @@
/*
* Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -203,6 +204,7 @@
#size-cells = <1>;
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 20:46 ` Li Yang
-1 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 20:46 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring
On Tue, Aug 28, 2018 at 2:00 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
> RESEND keeping Li Yang <leoyang.li@nxp.com>
>
> arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
> arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 499f41a2c6f0..923a25760516 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -235,6 +236,7 @@
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
> index f0c949d74833..8b48c3c7cd21 100644
> --- a/arch/arm/boot/dts/ls1021a-twr.dts
> +++ b/arch/arm/boot/dts/ls1021a-twr.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -203,6 +204,7 @@
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-08-28 20:46 ` Li Yang
0 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 20:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 2:00 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
> RESEND keeping Li Yang <leoyang.li@nxp.com>
>
> arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
> arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 499f41a2c6f0..923a25760516 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -235,6 +236,7 @@
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
> index f0c949d74833..8b48c3c7cd21 100644
> --- a/arch/arm/boot/dts/ls1021a-twr.dts
> +++ b/arch/arm/boot/dts/ls1021a-twr.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -203,6 +204,7 @@
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 22:25 ` Fabio Estevam
-1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2018-08-28 22:25 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Li Yang, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 499f41a2c6f0..923a25760516 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
This line is unrelated to the big-endian change.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-08-28 22:25 ` Fabio Estevam
0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2018-08-28 22:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 499f41a2c6f0..923a25760516 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -1,5 +1,6 @@
> /*
> * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
This line is unrelated to the big-endian change.
^ permalink raw reply [flat|nested] 20+ messages in thread
* RE: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
2018-08-28 22:25 ` Fabio Estevam
@ 2018-08-29 2:55 ` Prabhakar Kushwaha
-1 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-29 2:55 UTC (permalink / raw)
To: Fabio Estevam
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Leo Li, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Dear Fabio,
> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Wednesday, August 29, 2018 3:56 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Rob Herring <robh@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@lists.infradead.org>; Leo Li <leoyang.li@nxp.com>
> Subject: Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for
> ls1021a
>
> On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
>
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index 499f41a2c6f0..923a25760516 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -1,5 +1,6 @@
> > /*
> > * Copyright 2013-2014 Freescale Semiconductor, Inc.
> > + * Copyright 2018 NXP
>
> This line is unrelated to the big-endian change.
Yes, this line is unrelated to this change.
Freeescale has been acquired by NXP in 2016.
We want to add NXP copyright wherever freescale's copyright is present. But it is not possible in one-go.
So we are adding NXP copyright as and when any file having freescale's copyright being touched.
--pk
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-08-29 2:55 ` Prabhakar Kushwaha
0 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-29 2:55 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio,
> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Wednesday, August 29, 2018 3:56 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Rob Herring <robh@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel at lists.infradead.org>; Leo Li <leoyang.li@nxp.com>
> Subject: Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for
> ls1021a
>
> On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
>
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index 499f41a2c6f0..923a25760516 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -1,5 +1,6 @@
> > /*
> > * Copyright 2013-2014 Freescale Semiconductor, Inc.
> > + * Copyright 2018 NXP
>
> This line is unrelated to the big-endian change.
Yes, this line is unrelated to this change.
Freeescale has been acquired by NXP in 2016.
We want to add NXP copyright wherever freescale's copyright is present. But it is not possible in one-go.
So we are adding NXP copyright as and when any file having freescale's copyright being touched.
--pk
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-09-02 23:58 ` Shawn Guo
-1 siblings, 0 replies; 20+ messages in thread
From: Shawn Guo @ 2018-09-02 23:58 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: mark.rutland, devicetree, leoyang.li, linux-arm-kernel, robh
On Tue, Aug 28, 2018 at 12:29:35PM +0530, Prabhakar Kushwaha wrote:
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-09-02 23:58 ` Shawn Guo
0 siblings, 0 replies; 20+ messages in thread
From: Shawn Guo @ 2018-09-02 23:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 12:29:35PM +0530, Prabhakar Kushwaha wrote:
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 6:59 ` Prabhakar Kushwaha
-1 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28 6:59 UTC (permalink / raw)
To: devicetree, robh, mark.rutland, shawnguo
Cc: Prabhakar Kushwaha, linux-arm-kernel, leoyang.li
NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
RESEND keeping Li Yang <leoyang.li@nxp.com>
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index c7b8d2c009cd..dff3d648172e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -50,6 +51,7 @@
nor@0,0 {
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 7b01ba8d3b7e..17ca357e854f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -65,6 +66,7 @@
#address-cells = <1>;
#size-cells = <1>;
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e69306e6b0b1..e58a8ca1386c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1046A family SoC.
*
* Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Shaohui Xie <Shaohui.Xie@nxp.com>
*/
@@ -141,6 +142,7 @@
nor@0,0 {
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
@ 2018-08-28 6:59 ` Prabhakar Kushwaha
0 siblings, 0 replies; 20+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28 6:59 UTC (permalink / raw)
To: linux-arm-kernel
NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
RESEND keeping Li Yang <leoyang.li@nxp.com>
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index c7b8d2c009cd..dff3d648172e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -50,6 +51,7 @@
nor at 0,0 {
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 7b01ba8d3b7e..17ca357e854f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -65,6 +66,7 @@
#address-cells = <1>;
#size-cells = <1>;
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e69306e6b0b1..e58a8ca1386c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1046A family SoC.
*
* Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Shaohui Xie <Shaohui.Xie@nxp.com>
*/
@@ -141,6 +142,7 @@
nor at 0,0 {
compatible = "cfi-flash";
reg = <0x0 0x0 0x8000000>;
+ big-endian;
bank-width = <2>;
device-width = <1>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 20:44 ` Li Yang
-1 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 20:44 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring
On Tue, Aug 28, 2018 at 2:03 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
> RESEND keeping Li Yang <leoyang.li@nxp.com>
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index c7b8d2c009cd..dff3d648172e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -50,6 +51,7 @@
> nor@0,0 {
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 7b01ba8d3b7e..17ca357e854f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -65,6 +66,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index e69306e6b0b1..e58a8ca1386c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Shaohui Xie <Shaohui.Xie@nxp.com>
> */
> @@ -141,6 +142,7 @@
> nor@0,0 {
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
@ 2018-08-28 20:44 ` Li Yang
0 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 20:44 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 2:03 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> NOR and IFC controller connectivity is big-endian.
> So add big-endian field in nor device tree node allowing
> IFC controller to read/write data from/to the flash correctly.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports"
> RESEND keeping Li Yang <leoyang.li@nxp.com>
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index c7b8d2c009cd..dff3d648172e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -50,6 +51,7 @@
> nor at 0,0 {
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 7b01ba8d3b7e..17ca357e854f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -65,6 +66,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index e69306e6b0b1..e58a8ca1386c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Shaohui Xie <Shaohui.Xie@nxp.com>
> */
> @@ -141,6 +142,7 @@
> nor at 0,0 {
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> + big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 22:26 ` Fabio Estevam
-1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2018-08-28 22:26 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Li Yang, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index c7b8d2c009cd..dff3d648172e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
Same comment as in the other patch.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa
@ 2018-08-28 22:26 ` Fabio Estevam
0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2018-08-28 22:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index c7b8d2c009cd..dff3d648172e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
Same comment as in the other patch.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] arm64: dts: remove big-endian filed from IFC controller
2018-08-28 6:59 ` Prabhakar Kushwaha
@ 2018-08-28 18:38 ` Li Yang
-1 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 18:38 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring
On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -280,7 +281,6 @@
> ifc: ifc@1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <0 43 0x4>;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..9f5acb4dfaf3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -4,6 +4,8 @@
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> *
> + * Copyright 2018 NXP
> + *
Probably better to align with the other files to not have empty line
between copyright claims?
> * Mingkai Hu <mingkai.hu@nxp.com>
> */
>
> @@ -198,7 +200,6 @@
> ifc: ifc@1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64: dts: remove big-endian filed from IFC controller
@ 2018-08-28 18:38 ` Li Yang
0 siblings, 0 replies; 20+ messages in thread
From: Li Yang @ 2018-08-28 18:38 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -280,7 +281,6 @@
> ifc: ifc at 1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <0 43 0x4>;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..9f5acb4dfaf3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -4,6 +4,8 @@
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> *
> + * Copyright 2018 NXP
> + *
Probably better to align with the other files to not have empty line
between copyright claims?
> * Mingkai Hu <mingkai.hu@nxp.com>
> */
>
> @@ -198,7 +200,6 @@
> ifc: ifc at 1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 20+ messages in thread