All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Jens Axboe <axboe@kernel.dk>, Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH 1/3] block: Introduce __blk_segment_map_sg() helper
Date: Tue, 19 Jun 2012 11:00:51 -0700	[thread overview]
Message-ID: <CAOS58YOzQ-fgLMCBYC=1zg=mXTmb96YcueNc3pu+ZLZVo1Xj7Q@mail.gmail.com> (raw)
In-Reply-To: <4FDFDDBE.3050506@redhat.com>

Hello,

On Mon, Jun 18, 2012 at 7:02 PM, Asias He <asias@redhat.com> wrote:
>> I *hope* this is a bit prettier.  e.g. Do we really need to pass in
>> @sglist and keep using "goto new_segment"?
>
> I think this deserves another patch on top of this splitting one. I'd like
> to clean this up later.

Yeap, doing it in a separate patch would be better. It would be great
if you can include such patch in this series. :)

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Asias He <asias@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Shaohua Li <shli@kernel.org>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] block: Introduce __blk_segment_map_sg() helper
Date: Tue, 19 Jun 2012 11:00:51 -0700	[thread overview]
Message-ID: <CAOS58YOzQ-fgLMCBYC=1zg=mXTmb96YcueNc3pu+ZLZVo1Xj7Q@mail.gmail.com> (raw)
In-Reply-To: <4FDFDDBE.3050506@redhat.com>

Hello,

On Mon, Jun 18, 2012 at 7:02 PM, Asias He <asias@redhat.com> wrote:
>> I *hope* this is a bit prettier.  e.g. Do we really need to pass in
>> @sglist and keep using "goto new_segment"?
>
> I think this deserves another patch on top of this splitting one. I'd like
> to clean this up later.

Yeap, doing it in a separate patch would be better. It would be great
if you can include such patch in this series. :)

Thanks.

-- 
tejun

  reply	other threads:[~2012-06-19 18:00 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  6:53 [PATCH v2 0/3] Improve virtio-blk performance Asias He
2012-06-18  6:53 ` Asias He
2012-06-18  6:53 ` [PATCH 1/3] block: Introduce __blk_segment_map_sg() helper Asias He
2012-06-18  6:53   ` Asias He
2012-06-18 21:31   ` Tejun Heo
2012-06-18 21:31     ` Tejun Heo
2012-06-19  2:02     ` Asias He
2012-06-19  2:02       ` Asias He
2012-06-19 18:00       ` Tejun Heo [this message]
2012-06-19 18:00         ` Tejun Heo
2012-06-18  6:53 ` [PATCH v2 2/3] block: Add blk_bio_map_sg() helper Asias He
2012-06-18  6:53   ` Asias He
2012-06-18  6:53 ` [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk Asias He
2012-06-18  6:53   ` Asias He
2012-06-18  7:46   ` Rusty Russell
2012-06-18  7:46     ` Rusty Russell
2012-06-18  8:03     ` Asias He
2012-06-18  8:03       ` Asias He
2012-06-18 10:05       ` Rusty Russell
2012-06-18 10:05         ` Rusty Russell
2012-06-18 11:14         ` Dor Laor
2012-06-18 11:14           ` Dor Laor
2012-06-18 11:39           ` Sasha Levin
2012-06-18 11:39             ` Sasha Levin
2012-06-19  2:51             ` Asias He
2012-06-19  2:51               ` Asias He
2012-06-19  6:21               ` Dor Laor
2012-06-19  6:21                 ` Dor Laor
2012-06-20  4:46                 ` Asias He
2012-06-20  4:46                   ` Asias He
2012-06-21  9:49                   ` Dor Laor
2012-06-21  9:49                     ` Dor Laor
2012-07-01 23:54               ` Rusty Russell
2012-07-02  2:45                 ` Asias He
2012-07-02  2:45                   ` Asias He
2012-07-02  6:41                   ` Rusty Russell
2012-07-02  6:41                     ` Rusty Russell
2012-07-03  0:39                     ` Asias He
2012-07-03  0:39                       ` Asias He
2012-07-04  2:40                       ` Rusty Russell
2012-07-04  2:40                         ` Rusty Russell
2012-07-06  1:03                         ` Asias He
2012-07-06  1:03                           ` Asias He
2012-07-03 13:31                     ` Paolo Bonzini
2012-07-03 13:31                     ` Paolo Bonzini
2012-07-03 14:02                       ` Asias He
2012-07-03 14:02                         ` Asias He
2012-07-01 23:54               ` Rusty Russell
2012-07-03 14:22           ` Ronen Hod
2012-07-03 14:22             ` Ronen Hod
2012-07-03 14:28             ` Dor Laor
2012-07-03 14:28               ` Dor Laor
2012-07-04 14:10               ` Paolo Bonzini
2012-07-04 14:10                 ` Paolo Bonzini
2012-06-18 21:28         ` Tejun Heo
2012-06-18 21:28           ` Tejun Heo
2012-06-19  2:39         ` Asias He
2012-06-19  2:39           ` Asias He
2012-06-18 10:13       ` Michael S. Tsirkin
2012-06-18 10:13         ` Michael S. Tsirkin
2012-06-19  2:21         ` Asias He
2012-06-19  2:21           ` Asias He
2012-06-18  9:37   ` Stefan Hajnoczi
2012-06-18  9:37     ` Stefan Hajnoczi
2012-06-18 10:21   ` Michael S. Tsirkin
2012-06-18 10:21     ` Michael S. Tsirkin
2012-06-18 10:45     ` Stefan Hajnoczi
2012-06-18 10:45       ` Stefan Hajnoczi
2012-06-19  2:30     ` Asias He
2012-06-19  2:30       ` Asias He
2012-06-18  9:14 ` [PATCH v2 0/3] Improve virtio-blk performance Stefan Hajnoczi
2012-06-18  9:14   ` Stefan Hajnoczi
2012-06-18  9:39   ` Asias He
2012-06-18  9:39     ` Asias He
2012-06-18 10:58     ` Stefan Hajnoczi
2012-06-18 10:58       ` Stefan Hajnoczi
2012-06-19  4:24       ` Asias He
2012-06-19  4:24         ` Asias He
2012-06-19 10:14         ` Stefan Hajnoczi
2012-06-19 10:14           ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOS58YOzQ-fgLMCBYC=1zg=mXTmb96YcueNc3pu+ZLZVo1Xj7Q@mail.gmail.com' \
    --to=tj@kernel.org \
    --cc=asias@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.