All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@stlinux.com" <kernel@stlinux.com>,
	Maxime Coquelin <maxime.coquelin@st.com>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Nathan Lynch <Nathan_Lynch@mentor.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	ludovic.barre@st.com, Suman Anna <s-anna@ti.com>
Subject: Re: [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc
Date: Wed, 13 Apr 2016 15:04:13 -0700	[thread overview]
Message-ID: <CAOesGMj1zAgr+urvJHUu9=-P5RR5d9Ko6bUpXKTUcwkXMeYydg@mail.gmail.com> (raw)
In-Reply-To: <1452602781-22424-7-git-send-email-lee.jones@linaro.org>

Hi,

On Tue, Jan 12, 2016 at 4:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 40 +++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 1e4e01925..15c20b6 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -650,5 +650,45 @@
>                         mbox-name       = "st231_audio_video";
>                         status          = "okay";
>                 };
> +
> +               st231_gp0: st231-gp0@40000000 {

These node names seem odd. Should probably be more generic
"remoteproc@40000000".

> +                       compatible      = "st,st231-rproc";
> +                       reg             = <0x40000000 0x01000000>;

This isn't what the binding says, it uses a memory region instead.



-Olof

WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc
Date: Wed, 13 Apr 2016 15:04:13 -0700	[thread overview]
Message-ID: <CAOesGMj1zAgr+urvJHUu9=-P5RR5d9Ko6bUpXKTUcwkXMeYydg@mail.gmail.com> (raw)
In-Reply-To: <1452602781-22424-7-git-send-email-lee.jones@linaro.org>

Hi,

On Tue, Jan 12, 2016 at 4:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 40 +++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 1e4e01925..15c20b6 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -650,5 +650,45 @@
>                         mbox-name       = "st231_audio_video";
>                         status          = "okay";
>                 };
> +
> +               st231_gp0: st231-gp0 at 40000000 {

These node names seem odd. Should probably be more generic
"remoteproc at 40000000".

> +                       compatible      = "st,st231-rproc";
> +                       reg             = <0x40000000 0x01000000>;

This isn't what the binding says, it uses a memory region instead.



-Olof

  reply	other threads:[~2016-04-13 22:04 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 12:46 [PATCH v5 0/7] remoteproc: Add driver for STMicroelectronics platforms Lee Jones
2016-01-12 12:46 ` Lee Jones
2016-01-12 12:46 ` Lee Jones
2016-01-12 12:46 ` [PATCH v5 1/7] remoteproc: debugfs: Check of invalid 'count' value Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 12:46 ` [PATCH v5 2/7] remoteproc: dt: Provide bindings for ST's Remote Processor Controller driver Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 14:33   ` Rob Herring
2016-01-12 14:33     ` Rob Herring
2016-01-12 14:33     ` Rob Herring
2016-01-12 14:46     ` Lee Jones
2016-01-12 14:46       ` Lee Jones
2016-03-16 16:39   ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:39     ` Peter Griffin
2016-01-12 12:46 ` [PATCH v5 3/7] remoteproc: debugfs: Add ability to boot remote processor using debugfs Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-03-16 16:44   ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:44     ` Peter Griffin
2016-03-16 16:44     ` Peter Griffin
2016-01-12 12:46 ` [PATCH v5 4/7] remoteproc: Supply controller driver for ST's Remote Processors Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 14:47   ` Lee Jones
2016-01-12 14:47     ` Lee Jones
2016-03-16 16:38   ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:38     ` Peter Griffin
2016-01-12 12:46 ` [PATCH v5 5/7] MAINTAINERS: Add ST's Remote Processor Driver to ARM/STI ARCHITECTURE Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-03-16 16:40   ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:40     ` Peter Griffin
2016-01-12 12:46 ` [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-04-13 22:04   ` Olof Johansson [this message]
2016-04-13 22:04     ` Olof Johansson
2016-04-13 22:04     ` Olof Johansson
2016-01-12 12:46 ` [PATCH v5 7/7] ARM: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory Lee Jones
2016-01-12 12:46   ` Lee Jones
2016-03-16 16:35   ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:35     ` Peter Griffin
2016-03-16 16:35     ` Peter Griffin
2016-03-16 16:55     ` Lee Jones
2016-03-16 16:55       ` Lee Jones
2016-03-16 16:55       ` Lee Jones
2016-03-16 20:10       ` Peter Griffin
2016-03-16 20:10         ` Peter Griffin
2016-03-16 20:10         ` Peter Griffin
2016-03-17  9:05         ` Loic PALLARDY
2016-03-17  9:05           ` Loic PALLARDY
2016-03-17  9:05           ` Loic PALLARDY
2016-03-17 10:18           ` Lee Jones
2016-03-17 10:18             ` Lee Jones
2016-03-17 10:18             ` Lee Jones
2016-01-27  7:31 ` [PATCH v5 0/7] remoteproc: Add driver for STMicroelectronics platforms Lee Jones
2016-01-27  7:31   ` Lee Jones
2016-01-27  7:31   ` Lee Jones
2016-01-27 19:19   ` Bjorn Andersson
2016-01-27 19:19     ` Bjorn Andersson
2016-03-02 15:43     ` Lee Jones
2016-03-02 15:43       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOesGMj1zAgr+urvJHUu9=-P5RR5d9Ko6bUpXKTUcwkXMeYydg@mail.gmail.com' \
    --to=olof@lixom.net \
    --cc=Nathan_Lynch@mentor.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=maxime.coquelin@st.com \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.