[meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Werner Grift]

Signed-off-by: Werner Grift <sky.captin@gmail.com>
---
 classes/image_types_fsl.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index 53f8767..91c418a 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -168,9 +168,9 @@ generate_imx_sdcard () {
 	if test -n "${KERNEL_DEVICETREE}"; then
 		for DTS_FILE in ${KERNEL_DEVICETREE}; do
 			DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
-			if [ -e "${KERNEL_IMAGETYPE}-${DTS_BASE_NAME}.dtb" ]; then
-				kernel_bin="`readlink ${KERNEL_IMAGETYPE}-${MACHINE}.bin`"
-				kernel_bin_for_dtb="`readlink ${KERNEL_IMAGETYPE}-${DTS_BASE_NAME}.dtb | sed "s,$DTS_BASE_NAME,${MACHINE},g;s,\.dtb$,.bin,g"`"
+			if [ -e "${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${DTS_BASE_NAME}.dtb" ]; then
+				kernel_bin="`readlink ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin`"
+				kernel_bin_for_dtb="`readlink ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${DTS_BASE_NAME}.dtb | sed "s,$DTS_BASE_NAME,${MACHINE},g;s,\.dtb$,.bin,g"`"
 				if [ $kernel_bin = $kernel_bin_for_dtb ]; then
 					mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${DTS_BASE_NAME}.dtb ::/${DTS_BASE_NAME}.dtb
 				fi
-- 
2.0.0

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Otavio Salvador]

Hello Werner,

On Wed, Feb 11, 2015 at 7:19 AM, Werner Grift <sky.captin@gmail.com> wrote:
> Signed-off-by: Werner Grift <sky.captin@gmail.com>

I am wondering how this has been working previously. Any idea what
changed which causes the behaviour change?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Werner Grift]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

Hi Otavio.

I received the recipes (and a working version of it on our build server)
from a colleague that only introduced the following patch
<http://c7b9611ad0ead17a624fc73a60c321ff249c2214> to oe at
rev c7b9611ad0ead17a624fc73a60c321ff249c2214. The rest of the system was
untouched.

I made a fresh build system on my development machine. My build ran a
couple of times without above mentioned patch, but broke because it was not
applied. After applying the patch my build worked, but the copy device tree
issue remained. (But not on the build server) I then ran ./oebb.sh update
to make sure everything is cozy (which removed the patch mentioned above
without me realizing) and miraculously the build continued to succeed, but
the device tree issue remained. I suspect I broke sstate by doing this. My
sstate is not shared between dev and build.

Therefor, I suspect that the issue was generated in house. Regardless, the
rest of create_image.sdcard does not make assumptions as to pwd, so I
figured the patch is needed for completeness.

Regards,

Werner.


On Fri, Feb 13, 2015 at 2:37 AM, Otavio Salvador <otavio@ossystems.com.br>
wrote:

> Hello Werner,
>
> On Wed, Feb 11, 2015 at 7:19 AM, Werner Grift <sky.captin@gmail.com>
> wrote:
> > Signed-off-by: Werner Grift <sky.captin@gmail.com>
>
> I am wondering how this has been working previously. Any idea what
> changed which causes the behaviour change?
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 2835 bytes --]

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Werner Grift]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

I screwed up the patch link in my previous email:
http://hastebin.com/yaxisokuqo.py

On Tue, Feb 17, 2015 at 9:45 AM, Werner Grift <sky.captin@gmail.com> wrote:

> Hi Otavio.
>
> I received the recipes (and a working version of it on our build server)
> from a colleague that only introduced the following patch
> <http://c7b9611ad0ead17a624fc73a60c321ff249c2214> to oe at
> rev c7b9611ad0ead17a624fc73a60c321ff249c2214. The rest of the system was
> untouched.
>
> I made a fresh build system on my development machine. My build ran a
> couple of times without above mentioned patch, but broke because it was not
> applied. After applying the patch my build worked, but the copy device tree
> issue remained. (But not on the build server) I then ran ./oebb.sh update
> to make sure everything is cozy (which removed the patch mentioned above
> without me realizing) and miraculously the build continued to succeed, but
> the device tree issue remained. I suspect I broke sstate by doing this. My
> sstate is not shared between dev and build.
>
> Therefor, I suspect that the issue was generated in house. Regardless,
> the rest of create_image.sdcard does not make assumptions as to pwd, so I
> figured the patch is needed for completeness.
>
> Regards,
>
> Werner.
>
>
> On Fri, Feb 13, 2015 at 2:37 AM, Otavio Salvador <otavio@ossystems.com.br>
> wrote:
>
>> Hello Werner,
>>
>> On Wed, Feb 11, 2015 at 7:19 AM, Werner Grift <sky.captin@gmail.com>
>> wrote:
>> > Signed-off-by: Werner Grift <sky.captin@gmail.com>
>>
>> I am wondering how this has been working previously. Any idea what
>> changed which causes the behaviour change?
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>>
>
>

[-- Attachment #2: Type: text/html, Size: 3455 bytes --]

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Otavio Salvador]

On Tue, Feb 17, 2015 at 5:45 AM, Werner Grift <sky.captin@gmail.com> wrote:
...
> without me realizing) and miraculously the build continued to succeed, but
> the device tree issue remained. I suspect I broke sstate by doing this. My
> sstate is not shared between dev and build.
...

Which device tree issue?

We need to understand where the issue come from as this is a code used
by all people using meta-fsl-arm and I'd like to avoid to apply
something we don't fully understand the need.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Werner Grift]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

The device tree issue I refer too is the device tree file that is not being
copied to the boot partition because the generated script
create_image.sdcard contains if statements that assume that the current
working directory is ${DEPLOY_DIR_IMAGE} which it is not. In my case it was
${OE_BASE} which makes sense since it is where bitbake is called from.

On Tue, Feb 17, 2015 at 3:08 PM, Otavio Salvador <otavio@ossystems.com.br>
wrote:

> On Tue, Feb 17, 2015 at 5:45 AM, Werner Grift <sky.captin@gmail.com>
> wrote:
> ...
> > without me realizing) and miraculously the build continued to succeed,
> but
> > the device tree issue remained. I suspect I broke sstate by doing this.
> My
> > sstate is not shared between dev and build.
> ...
>
> Which device tree issue?
>
> We need to understand where the issue come from as this is a code used
> by all people using meta-fsl-arm and I'd like to avoid to apply
> something we don't fully understand the need.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 2005 bytes --]

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Otavio Salvador]

On Tue, Feb 17, 2015 at 1:09 PM, Werner Grift <sky.captin@gmail.com> wrote:
> The device tree issue I refer too is the device tree file that is not being
> copied to the boot partition because the generated script
> create_image.sdcard contains if statements that assume that the current
> working directory is ${DEPLOY_DIR_IMAGE} which it is not. In my case it was
> ${OE_BASE} which makes sense since it is where bitbake is called from.

How is your platform setup?

FSL Community BSP usually looks like:

.
├── build
│   └── conf
├── README
├── setup-environment
└── sources
    ├── base
    ├── Documentation
    ├── meta-fsl-arm
    ├── meta-fsl-arm-extra
    ├── meta-fsl-demos
    ├── meta-openembedded
    └── poky

Is yours same layout?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Werner Grift]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

We use the Angstrom distro 1.7

Our structure does not look like that. Whats this Yocto business?

Looks like script is being called from the wrong directory then.



On Tue, Feb 17, 2015 at 6:18 PM, Otavio Salvador <otavio@ossystems.com.br>
wrote:

> On Tue, Feb 17, 2015 at 1:09 PM, Werner Grift <sky.captin@gmail.com>
> wrote:
> > The device tree issue I refer too is the device tree file that is not
> being
> > copied to the boot partition because the generated script
> > create_image.sdcard contains if statements that assume that the current
> > working directory is ${DEPLOY_DIR_IMAGE} which it is not. In my case it
> was
> > ${OE_BASE} which makes sense since it is where bitbake is called from.
>
> How is your platform setup?
>
> FSL Community BSP usually looks like:
>
> .
> ├── build
> │   └── conf
> ├── README
> ├── setup-environment
> └── sources
>     ├── base
>     ├── Documentation
>     ├── meta-fsl-arm
>     ├── meta-fsl-arm-extra
>     ├── meta-fsl-demos
>     ├── meta-openembedded
>     └── poky
>
> Is yours same layout?
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>

[-- Attachment #2: Type: text/html, Size: 2215 bytes --]

Re: [meta-fsl-arm][PATCH 73/73] Added absolute paths to checks when copying the device tree

[Otavio Salvador]

On Tue, Feb 17, 2015 at 3:30 PM, Werner Grift <sky.captin@gmail.com> wrote:
> We use the Angstrom distro 1.7

Ok.

> Our structure does not look like that. Whats this Yocto business?

This is the FSL Community BSP. You can find more information about it
in http://freescale.github.io

> Looks like script is being called from the wrong directory then.

Nothing wrong. The system must to behave right and to support all
different type of platform setups.

Can you give me (might be private - if preferable) more information
about your platform layout?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750