[PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack

[PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack

[Mats Karrman]

From: Mats Karrman <mats@southpole.se>
Date: Thu, 13 Apr 2017 17:11:58 +0200
Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on 
do_unpack

Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
However as the use of 'externalsrc' will do away with the do_patch
task, do_preconfigure is in risk of being run before the defconfig
is copied to the build directory. This patch adds a second dependency
on 'do_unpack' that makes sure this does not happen.
---
  classes/fsl-kernel-localversion.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Typical error message:
ERROR: linux-rabbit-4.10-r0 do_preconfigure: Function failed: 
do_preconfigure (log file is located at 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Logfile of failure stored in: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215
Log data follows:
| DEBUG: Executing shell function do_preconfigure
| 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215: 
line 116: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig: 
No such file or directory
| WARNING: 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215:1 
exit 1 from 'sed -e "${CONF_SED_SCRIPT}" < 
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig' 
 >> 
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/linux-rabbit-4.10//.config''
| ERROR: Function failed: do_preconfigure (log file is located at 
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Task 49 
(/home/mats/projects/cubox/oe/meta-local/recipes-kernel/linux/linux-rabbit_4.10.bb, 
do_preconfigure) failed with exit code '1'

The fix is tested on krogoth but should apply equally to master as 
nothing has
changed here as far as I can tell.

---

diff --git a/classes/fsl-kernel-localversion.bbclass 
b/classes/fsl-kernel-localversion.bbclass
index 48e5403..c0306a0 100644
--- a/classes/fsl-kernel-localversion.bbclass
+++ b/classes/fsl-kernel-localversion.bbclass
@@ -38,4 +38,4 @@ do_preconfigure() {
          printf "%s%s" +g $head > ${S}/.scmversion
      fi
  }
-addtask preconfigure before do_configure after do_patch
+addtask preconfigure before do_configure after do_unpack do_patch
-- 
2.1.4

Re: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack

[Otavio Salvador]

Hello Mats,

On Thu, Apr 13, 2017 at 12:33 PM, Mats Karrman <mats.dev.list@gmail.com> wrote:
> From: Mats Karrman <mats@southpole.se>
> Date: Thu, 13 Apr 2017 17:11:58 +0200
> Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on
> do_unpack
>
> Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
> However as the use of 'externalsrc' will do away with the do_patch
> task, do_preconfigure is in risk of being run before the defconfig
> is copied to the build directory. This patch adds a second dependency
> on 'do_unpack' that makes sure this does not happen.

It does not apply on master; can you reproduce it on master? Use
meta-freescale please.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack

[Mats Karrman]

Hi Otavio,

On 04/25/2017 03:51 PM, Otavio Salvador wrote:

> Hello Mats,
>
> On Thu, Apr 13, 2017 at 12:33 PM, Mats Karrman <mats.dev.list@gmail.com> wrote:
>> From: Mats Karrman <mats@southpole.se>
>> Date: Thu, 13 Apr 2017 17:11:58 +0200
>> Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on
>> do_unpack
>>
>> Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
>> However as the use of 'externalsrc' will do away with the do_patch
>> task, do_preconfigure is in risk of being run before the defconfig
>> is copied to the build directory. This patch adds a second dependency
>> on 'do_unpack' that makes sure this does not happen.
> It does not apply on master; can you reproduce it on master? Use
> meta-freescale please.

I will try to do this shortly.

I haven't been active with Yocto for a while and totaly missed the
switch to (?) meta-freescale... Is there an announcement or something
you can point me to to put me on track?

BR // Mats

Re: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack

[Otavio Salvador]

On Tue, Apr 25, 2017 at 5:28 PM, Mats Karrman <mats.dev.list@gmail.com> wrote:
> On 04/25/2017 03:51 PM, Otavio Salvador wrote:
...
>> It does not apply on master; can you reproduce it on master? Use
>> meta-freescale please.
>
> I will try to do this shortly.
>
> I haven't been active with Yocto for a while and totaly missed the
> switch to (?) meta-freescale... Is there an announcement or something
> you can point me to to put me on track?

http://freescale.github.io/doc/release-notes/2.2/index.html#project-name-scope

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750