* [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack
@ 2017-04-13 15:33 Mats Karrman
2017-04-25 13:51 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Mats Karrman @ 2017-04-13 15:33 UTC (permalink / raw)
To: meta-freescale, fabio.berton
From: Mats Karrman <mats@southpole.se>
Date: Thu, 13 Apr 2017 17:11:58 +0200
Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on
do_unpack
Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
However as the use of 'externalsrc' will do away with the do_patch
task, do_preconfigure is in risk of being run before the defconfig
is copied to the build directory. This patch adds a second dependency
on 'do_unpack' that makes sure this does not happen.
---
classes/fsl-kernel-localversion.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Typical error message:
ERROR: linux-rabbit-4.10-r0 do_preconfigure: Function failed:
do_preconfigure (log file is located at
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Logfile of failure stored in:
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215
Log data follows:
| DEBUG: Executing shell function do_preconfigure
|
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215:
line 116:
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig:
No such file or directory
| WARNING:
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/run.do_preconfigure.10215:1
exit 1 from 'sed -e "${CONF_SED_SCRIPT}" <
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/defconfig'
>>
'/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/linux-rabbit-4.10//.config''
| ERROR: Function failed: do_preconfigure (log file is located at
/home/mats/projects/cubox/oe/build/tmp/work/rabbit-poky-linux-gnueabi/linux-rabbit/4.10-r0/temp/log.do_preconfigure.10215)
ERROR: Task 49
(/home/mats/projects/cubox/oe/meta-local/recipes-kernel/linux/linux-rabbit_4.10.bb,
do_preconfigure) failed with exit code '1'
The fix is tested on krogoth but should apply equally to master as
nothing has
changed here as far as I can tell.
---
diff --git a/classes/fsl-kernel-localversion.bbclass
b/classes/fsl-kernel-localversion.bbclass
index 48e5403..c0306a0 100644
--- a/classes/fsl-kernel-localversion.bbclass
+++ b/classes/fsl-kernel-localversion.bbclass
@@ -38,4 +38,4 @@ do_preconfigure() {
printf "%s%s" +g $head > ${S}/.scmversion
fi
}
-addtask preconfigure before do_configure after do_patch
+addtask preconfigure before do_configure after do_unpack do_patch
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack
2017-04-13 15:33 [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack Mats Karrman
@ 2017-04-25 13:51 ` Otavio Salvador
2017-04-25 20:28 ` Mats Karrman
0 siblings, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2017-04-25 13:51 UTC (permalink / raw)
To: Mats Karrman; +Cc: meta-freescale
Hello Mats,
On Thu, Apr 13, 2017 at 12:33 PM, Mats Karrman <mats.dev.list@gmail.com> wrote:
> From: Mats Karrman <mats@southpole.se>
> Date: Thu, 13 Apr 2017 17:11:58 +0200
> Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on
> do_unpack
>
> Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
> However as the use of 'externalsrc' will do away with the do_patch
> task, do_preconfigure is in risk of being run before the defconfig
> is copied to the build directory. This patch adds a second dependency
> on 'do_unpack' that makes sure this does not happen.
It does not apply on master; can you reproduce it on master? Use
meta-freescale please.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack
2017-04-25 13:51 ` Otavio Salvador
@ 2017-04-25 20:28 ` Mats Karrman
2017-04-25 20:35 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Mats Karrman @ 2017-04-25 20:28 UTC (permalink / raw)
To: Otavio Salvador; +Cc: meta-freescale
Hi Otavio,
On 04/25/2017 03:51 PM, Otavio Salvador wrote:
> Hello Mats,
>
> On Thu, Apr 13, 2017 at 12:33 PM, Mats Karrman <mats.dev.list@gmail.com> wrote:
>> From: Mats Karrman <mats@southpole.se>
>> Date: Thu, 13 Apr 2017 17:11:58 +0200
>> Subject: [PATCH] fsl-kernel-localversion: Add preconfigure dependency on
>> do_unpack
>>
>> Even if 'externalsrc' is used, SRC_URI may specify a 'defconfig'.
>> However as the use of 'externalsrc' will do away with the do_patch
>> task, do_preconfigure is in risk of being run before the defconfig
>> is copied to the build directory. This patch adds a second dependency
>> on 'do_unpack' that makes sure this does not happen.
> It does not apply on master; can you reproduce it on master? Use
> meta-freescale please.
I will try to do this shortly.
I haven't been active with Yocto for a while and totaly missed the
switch to (?) meta-freescale... Is there an announcement or something
you can point me to to put me on track?
BR // Mats
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-25 20:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 15:33 [PATCH] fsl-kernel-localversion: Add preconfigure dependency on do_unpack Mats Karrman
2017-04-25 13:51 ` Otavio Salvador
2017-04-25 20:28 ` Mats Karrman
2017-04-25 20:35 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.