[meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering

[meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering

[Bob Cochran]

The procps append file that overwrites sysctl.conf and disables reverse
path filtering isn't needed in the default QorIQ configuration.  It is
only needed if Application Specific Fastpath is enabled in the
linux-qoriq kernel.

Signed-off-by: Bob Cochran <yocto@mindchasers.com>
---
 recipes-extended/procps/procps_%.bbappend |    9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 recipes-extended/procps/procps_%.bbappend

diff --git a/recipes-extended/procps/procps_%.bbappend b/recipes-extended/procps/procps_%.bbappend
deleted file mode 100644
index face0cc..0000000
--- a/recipes-extended/procps/procps_%.bbappend
+++ /dev/null
@@ -1,9 +0,0 @@
-do_install_append_qoriq-ppc() {
-    for keyword in \
-        net.ipv4.conf.default.rp_filter \
-        net.ipv4.conf.all.rp_filter \
-    ; do
-        sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
-    done
-}
-
-- 
1.7.9.5

Re: [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering

[zhenhua.luo]

Hi Bob, 

It would be better if ASF enablement can be checked dynamically, then the rp_filter option can be enabled/disabled automatically. 

Maybe we can check the AS_FASTPATH option enablement in ${STAGING_KERNEL_DIR}/.config. 
	if [ "`grep "CONFIG_AS_FAST=y" ${STAGING_KERNEL_DIR}/.config`" ]; then
		for keyword in
			net.ipv4.conf.default.rp_filter \
			net.ipv4.conf.all.rp_filter \
		do
			sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
		done
	fi


Best Regards,

Zhenhua

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Thursday, January 08, 2015 1:27 AM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-ppc][PATCH] procps: stop disabling reverse
> path filtering
> 
> The procps append file that overwrites sysctl.conf and disables reverse path
> filtering isn't needed in the default QorIQ configuration.  It is only needed if
> Application Specific Fastpath is enabled in the linux-qoriq kernel.
> 
> Signed-off-by: Bob Cochran <yocto@mindchasers.com>
> ---
>  recipes-extended/procps/procps_%.bbappend |    9 ---------
>  1 file changed, 9 deletions(-)
>  delete mode 100644 recipes-extended/procps/procps_%.bbappend
> 
> diff --git a/recipes-extended/procps/procps_%.bbappend b/recipes-
> extended/procps/procps_%.bbappend
> deleted file mode 100644
> index face0cc..0000000
> --- a/recipes-extended/procps/procps_%.bbappend
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -do_install_append_qoriq-ppc() {
> -    for keyword in \
> -        net.ipv4.conf.default.rp_filter \
> -        net.ipv4.conf.all.rp_filter \
> -    ; do
> -        sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
> -    done
> -}
> -
> --
> 1.7.9.5
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering

[Otavio Salvador]

On Fri, Jan 9, 2015 at 1:15 AM, zhenhua.luo@freescale.com
<zhenhua.luo@freescale.com> wrote:
> Maybe we can check the AS_FASTPATH option enablement in ${STAGING_KERNEL_DIR}/.config.
>         if [ "`grep "CONFIG_AS_FAST=y" ${STAGING_KERNEL_DIR}/.config`" ]; then
>                 for keyword in
>                         net.ipv4.conf.default.rp_filter \
>                         net.ipv4.conf.all.rp_filter \
>                 do
>                         sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
>                 done
>         fi

This should be done in a init script. This is a runtime configuration
and there is no reason to diverge procps package for it.

I see some possible ways to address it:

* make a qoriq-asfastpath-init recipe

 This would check the kernel, at runtime, and see if it is enabled. In
case it does, it uses sysctl to set the values accordingly.

* add a do_install_append *in kernel* which makes a
${sysconfdir}/sysctl.conf.d/99-as-fast.conf

 This makes this fine and install it when the kernel has it enabled.

So in no means changing procps seems the best alternative. It is
related *to the kernel* and may - and likely will - vary from one
machine to another.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750