* [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering
@ 2015-01-07 17:27 Bob Cochran
2015-01-09 3:15 ` zhenhua.luo
0 siblings, 1 reply; 3+ messages in thread
From: Bob Cochran @ 2015-01-07 17:27 UTC (permalink / raw)
To: meta-freescale
The procps append file that overwrites sysctl.conf and disables reverse
path filtering isn't needed in the default QorIQ configuration. It is
only needed if Application Specific Fastpath is enabled in the
linux-qoriq kernel.
Signed-off-by: Bob Cochran <yocto@mindchasers.com>
---
recipes-extended/procps/procps_%.bbappend | 9 ---------
1 file changed, 9 deletions(-)
delete mode 100644 recipes-extended/procps/procps_%.bbappend
diff --git a/recipes-extended/procps/procps_%.bbappend b/recipes-extended/procps/procps_%.bbappend
deleted file mode 100644
index face0cc..0000000
--- a/recipes-extended/procps/procps_%.bbappend
+++ /dev/null
@@ -1,9 +0,0 @@
-do_install_append_qoriq-ppc() {
- for keyword in \
- net.ipv4.conf.default.rp_filter \
- net.ipv4.conf.all.rp_filter \
- ; do
- sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
- done
-}
-
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering
2015-01-07 17:27 [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering Bob Cochran
@ 2015-01-09 3:15 ` zhenhua.luo
2015-01-09 11:48 ` Otavio Salvador
0 siblings, 1 reply; 3+ messages in thread
From: zhenhua.luo @ 2015-01-09 3:15 UTC (permalink / raw)
To: Bob Cochran; +Cc: meta-freescale, Sandeep.Malik
Hi Bob,
It would be better if ASF enablement can be checked dynamically, then the rp_filter option can be enabled/disabled automatically.
Maybe we can check the AS_FASTPATH option enablement in ${STAGING_KERNEL_DIR}/.config.
if [ "`grep "CONFIG_AS_FAST=y" ${STAGING_KERNEL_DIR}/.config`" ]; then
for keyword in
net.ipv4.conf.default.rp_filter \
net.ipv4.conf.all.rp_filter \
do
sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
done
fi
Best Regards,
Zhenhua
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Thursday, January 08, 2015 1:27 AM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-ppc][PATCH] procps: stop disabling reverse
> path filtering
>
> The procps append file that overwrites sysctl.conf and disables reverse path
> filtering isn't needed in the default QorIQ configuration. It is only needed if
> Application Specific Fastpath is enabled in the linux-qoriq kernel.
>
> Signed-off-by: Bob Cochran <yocto@mindchasers.com>
> ---
> recipes-extended/procps/procps_%.bbappend | 9 ---------
> 1 file changed, 9 deletions(-)
> delete mode 100644 recipes-extended/procps/procps_%.bbappend
>
> diff --git a/recipes-extended/procps/procps_%.bbappend b/recipes-
> extended/procps/procps_%.bbappend
> deleted file mode 100644
> index face0cc..0000000
> --- a/recipes-extended/procps/procps_%.bbappend
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -do_install_append_qoriq-ppc() {
> - for keyword in \
> - net.ipv4.conf.default.rp_filter \
> - net.ipv4.conf.all.rp_filter \
> - ; do
> - sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
> - done
> -}
> -
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering
2015-01-09 3:15 ` zhenhua.luo
@ 2015-01-09 11:48 ` Otavio Salvador
0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2015-01-09 11:48 UTC (permalink / raw)
To: zhenhua.luo; +Cc: meta-freescale, Sandeep.Malik
On Fri, Jan 9, 2015 at 1:15 AM, zhenhua.luo@freescale.com
<zhenhua.luo@freescale.com> wrote:
> Maybe we can check the AS_FASTPATH option enablement in ${STAGING_KERNEL_DIR}/.config.
> if [ "`grep "CONFIG_AS_FAST=y" ${STAGING_KERNEL_DIR}/.config`" ]; then
> for keyword in
> net.ipv4.conf.default.rp_filter \
> net.ipv4.conf.all.rp_filter \
> do
> sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
> done
> fi
This should be done in a init script. This is a runtime configuration
and there is no reason to diverge procps package for it.
I see some possible ways to address it:
* make a qoriq-asfastpath-init recipe
This would check the kernel, at runtime, and see if it is enabled. In
case it does, it uses sysctl to set the values accordingly.
* add a do_install_append *in kernel* which makes a
${sysconfdir}/sysctl.conf.d/99-as-fast.conf
This makes this fine and install it when the kernel has it enabled.
So in no means changing procps seems the best alternative. It is
related *to the kernel* and may - and likely will - vary from one
machine to another.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-09 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-07 17:27 [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering Bob Cochran
2015-01-09 3:15 ` zhenhua.luo
2015-01-09 11:48 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.