All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Chris Ball <chris@printf.net>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Corneliu Doban <cdoban@broadcom.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	bcm-kernel-feedback-list@broadcom.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
Date: Fri, 13 Mar 2015 11:15:44 +0100	[thread overview]
Message-ID: <CAPDyKFpZQyOC3=TdQe8ymwnzCn0BXFJCgmYBHH+3qhDB_9AXgg@mail.gmail.com> (raw)
In-Reply-To: <20150313011101.GA24853@dtor-ws>

On 13 March 2015 at 02:11, Dmitry Torokhov <dtor@chromium.org> wrote:
> The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
> access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>

Thanks, applied!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-iproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 4139d34..3b423b0 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
>  static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
>  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> -       struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
> +       struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
>         u32 word_shift = REG_OFFSET_IN_BITS(reg);
>         u32 mask = 0xffff << word_shift;
>         u32 oldval, newval;
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
Date: Fri, 13 Mar 2015 11:15:44 +0100	[thread overview]
Message-ID: <CAPDyKFpZQyOC3=TdQe8ymwnzCn0BXFJCgmYBHH+3qhDB_9AXgg@mail.gmail.com> (raw)
In-Reply-To: <20150313011101.GA24853@dtor-ws>

On 13 March 2015 at 02:11, Dmitry Torokhov <dtor@chromium.org> wrote:
> The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
> access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>

Thanks, applied!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-iproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 4139d34..3b423b0 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
>  static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
>  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> -       struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
> +       struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
>         u32 word_shift = REG_OFFSET_IN_BITS(reg);
>         u32 mask = 0xffff << word_shift;
>         u32 oldval, newval;
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry

  reply	other threads:[~2015-03-13 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  1:11 [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew Dmitry Torokhov
2015-03-13  1:11 ` Dmitry Torokhov
2015-03-13 10:15 ` Ulf Hansson [this message]
2015-03-13 10:15   ` Ulf Hansson
2015-03-13 10:15   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFpZQyOC3=TdQe8ymwnzCn0BXFJCgmYBHH+3qhDB_9AXgg@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cdoban@broadcom.com \
    --cc=chris@printf.net \
    --cc=dtor@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.