* [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
@ 2015-03-13 1:11 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2015-03-13 1:11 UTC (permalink / raw)
To: Ulf Hansson
Cc: Chris Ball, Ray Jui, Scott Branden, Corneliu Doban, linux-mmc,
linux-arm-kernel, bcm-kernel-feedback-list, linux-kernel
The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
drivers/mmc/host/sdhci-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 4139d34..3b423b0 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
+ struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
u32 word_shift = REG_OFFSET_IN_BITS(reg);
u32 mask = 0xffff << word_shift;
u32 oldval, newval;
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
@ 2015-03-13 1:11 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2015-03-13 1:11 UTC (permalink / raw)
To: linux-arm-kernel
The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
drivers/mmc/host/sdhci-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 4139d34..3b423b0 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
+ struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
u32 word_shift = REG_OFFSET_IN_BITS(reg);
u32 mask = 0xffff << word_shift;
u32 oldval, newval;
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
2015-03-13 1:11 ` Dmitry Torokhov
(?)
@ 2015-03-13 10:15 ` Ulf Hansson
-1 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2015-03-13 10:15 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Chris Ball, Ray Jui, Scott Branden, Corneliu Doban, linux-mmc,
linux-arm-kernel, bcm-kernel-feedback-list, linux-kernel
On 13 March 2015 at 02:11, Dmitry Torokhov <dtor@chromium.org> wrote:
> The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
> access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 4139d34..3b423b0 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
> static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
> + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
> u32 word_shift = REG_OFFSET_IN_BITS(reg);
> u32 mask = 0xffff << word_shift;
> u32 oldval, newval;
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
@ 2015-03-13 10:15 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2015-03-13 10:15 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Chris Ball, Ray Jui, Scott Branden, Corneliu Doban, linux-mmc,
linux-arm-kernel, bcm-kernel-feedback-list, linux-kernel
On 13 March 2015 at 02:11, Dmitry Torokhov <dtor@chromium.org> wrote:
> The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
> access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 4139d34..3b423b0 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
> static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
> + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
> u32 word_shift = REG_OFFSET_IN_BITS(reg);
> u32 mask = 0xffff << word_shift;
> u32 oldval, newval;
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew
@ 2015-03-13 10:15 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2015-03-13 10:15 UTC (permalink / raw)
To: linux-arm-kernel
On 13 March 2015 at 02:11, Dmitry Torokhov <dtor@chromium.org> wrote:
> The driver co-allocates sdhci_iproc_host with sdhci_pltfm_host and so to
> access it we need to use sdhci_pltfm_priv() and not pltfm_host->priv.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 4139d34..3b423b0 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -97,7 +97,7 @@ static inline void sdhci_iproc_writel(struct sdhci_host *host, u32 val, int reg)
> static void sdhci_iproc_writew(struct sdhci_host *host, u16 val, int reg)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct sdhci_iproc_host *iproc_host = pltfm_host->priv;
> + struct sdhci_iproc_host *iproc_host = sdhci_pltfm_priv(pltfm_host);
> u32 word_shift = REG_OFFSET_IN_BITS(reg);
> u32 mask = 0xffff << word_shift;
> u32 oldval, newval;
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-13 10:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 1:11 [PATCH] mmc: sdhci-iproc: fix oops in sdhci_iproc_writew Dmitry Torokhov
2015-03-13 1:11 ` Dmitry Torokhov
2015-03-13 10:15 ` Ulf Hansson
2015-03-13 10:15 ` Ulf Hansson
2015-03-13 10:15 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.