* [PATCH] arm: apple: Disable debug UART @ 2022-02-11 20:00 Mark Kettenis 2022-02-11 20:29 ` Simon Glass 0 siblings, 1 reply; 5+ messages in thread From: Mark Kettenis @ 2022-02-11 20:00 UTC (permalink / raw) To: u-boot; +Cc: trini, sjg, Mark Kettenis The address of the debug UART varies differs between the M1 and the M1 Pro/Max SoCs. So we have to disable it to make a single U-Boot binary that works on all SoC generations. Leave the settings for the base address and clock rate of the M1 in place to make it easier to re-enable the debug UART when needed. Signed-off-by: Mark Kettenis <kettenis@openbsd.org> --- configs/apple_m1_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index ef5b7ffd1a..396fe63114 100644 --- a/configs/apple_m1_defconfig +++ b/configs/apple_m1_defconfig @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" CONFIG_DEBUG_UART_BASE=0x235200000 CONFIG_DEBUG_UART_CLOCK=24000000 -CONFIG_DEBUG_UART=y CONFIG_SYS_LOAD_ADDR=0x0 CONFIG_USE_PREBOOT=y # CONFIG_DISPLAY_CPUINFO is not set -- 2.35.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: apple: Disable debug UART 2022-02-11 20:00 [PATCH] arm: apple: Disable debug UART Mark Kettenis @ 2022-02-11 20:29 ` Simon Glass 2022-02-11 20:50 ` Mark Kettenis 0 siblings, 1 reply; 5+ messages in thread From: Simon Glass @ 2022-02-11 20:29 UTC (permalink / raw) To: Mark Kettenis; +Cc: U-Boot Mailing List, Tom Rini Hi Mark, On Fri, 11 Feb 2022 at 13:00, Mark Kettenis <kettenis@openbsd.org> wrote: > > The address of the debug UART varies differs between the M1 and > the M1 Pro/Max SoCs. So we have to disable it to make a single > U-Boot binary that works on all SoC generations. Leave the > settings for the base address and clock rate of the M1 in place > to make it easier to re-enable the debug UART when needed. How about adding some docs about how to, and what the addresses are? > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > --- > configs/apple_m1_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > index ef5b7ffd1a..396fe63114 100644 > --- a/configs/apple_m1_defconfig > +++ b/configs/apple_m1_defconfig > @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y > CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" > CONFIG_DEBUG_UART_BASE=0x235200000 > CONFIG_DEBUG_UART_CLOCK=24000000 > -CONFIG_DEBUG_UART=y > CONFIG_SYS_LOAD_ADDR=0x0 > CONFIG_USE_PREBOOT=y > # CONFIG_DISPLAY_CPUINFO is not set > -- > 2.35.1 > Regards, SImon ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: apple: Disable debug UART 2022-02-11 20:29 ` Simon Glass @ 2022-02-11 20:50 ` Mark Kettenis 2022-02-11 21:01 ` Simon Glass 0 siblings, 1 reply; 5+ messages in thread From: Mark Kettenis @ 2022-02-11 20:50 UTC (permalink / raw) To: Simon Glass; +Cc: kettenis, u-boot, trini > From: Simon Glass <sjg@chromium.org> > Date: Fri, 11 Feb 2022 13:29:15 -0700 > > Hi Mark, > > On Fri, 11 Feb 2022 at 13:00, Mark Kettenis <kettenis@openbsd.org> wrote: > > > > The address of the debug UART varies differs between the M1 and > > the M1 Pro/Max SoCs. So we have to disable it to make a single > > U-Boot binary that works on all SoC generations. Leave the > > settings for the base address and clock rate of the M1 in place > > to make it easier to re-enable the debug UART when needed. > > How about adding some docs about how to, and what the addresses are? Yes I can do that. A section at the end of doc/board/apple/m1.rst? Is it ok if I provide a single update to that file for the M1 Pro/Max support? > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > > --- > > configs/apple_m1_defconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > > index ef5b7ffd1a..396fe63114 100644 > > --- a/configs/apple_m1_defconfig > > +++ b/configs/apple_m1_defconfig > > @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y > > CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" > > CONFIG_DEBUG_UART_BASE=0x235200000 > > CONFIG_DEBUG_UART_CLOCK=24000000 > > -CONFIG_DEBUG_UART=y > > CONFIG_SYS_LOAD_ADDR=0x0 > > CONFIG_USE_PREBOOT=y > > # CONFIG_DISPLAY_CPUINFO is not set > > -- > > 2.35.1 > > > > Regards, > SImon > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: apple: Disable debug UART 2022-02-11 20:50 ` Mark Kettenis @ 2022-02-11 21:01 ` Simon Glass 2022-02-11 22:31 ` Heinrich Schuchardt 0 siblings, 1 reply; 5+ messages in thread From: Simon Glass @ 2022-02-11 21:01 UTC (permalink / raw) To: Mark Kettenis; +Cc: Mark Kettenis, U-Boot Mailing List, Tom Rini Hi Mark, On Fri, 11 Feb 2022 at 13:50, Mark Kettenis <mark.kettenis@xs4all.nl> wrote: > > > From: Simon Glass <sjg@chromium.org> > > Date: Fri, 11 Feb 2022 13:29:15 -0700 > > > > Hi Mark, > > > > On Fri, 11 Feb 2022 at 13:00, Mark Kettenis <kettenis@openbsd.org> wrote: > > > > > > The address of the debug UART varies differs between the M1 and > > > the M1 Pro/Max SoCs. So we have to disable it to make a single > > > U-Boot binary that works on all SoC generations. Leave the > > > settings for the base address and clock rate of the M1 in place > > > to make it easier to re-enable the debug UART when needed. > > > > How about adding some docs about how to, and what the addresses are? > > Yes I can do that. A section at the end of doc/board/apple/m1.rst? > Is it ok if I provide a single update to that file for the M1 Pro/Max > support? Sounds right, just enough to explain how to enable it. Regards, Simon > > > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > > > --- > > > configs/apple_m1_defconfig | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig > > > index ef5b7ffd1a..396fe63114 100644 > > > --- a/configs/apple_m1_defconfig > > > +++ b/configs/apple_m1_defconfig > > > @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y > > > CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" > > > CONFIG_DEBUG_UART_BASE=0x235200000 > > > CONFIG_DEBUG_UART_CLOCK=24000000 > > > -CONFIG_DEBUG_UART=y > > > CONFIG_SYS_LOAD_ADDR=0x0 > > > CONFIG_USE_PREBOOT=y > > > # CONFIG_DISPLAY_CPUINFO is not set > > > -- > > > 2.35.1 > > > > > > > Regards, > > SImon > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: apple: Disable debug UART 2022-02-11 21:01 ` Simon Glass @ 2022-02-11 22:31 ` Heinrich Schuchardt 0 siblings, 0 replies; 5+ messages in thread From: Heinrich Schuchardt @ 2022-02-11 22:31 UTC (permalink / raw) To: Mark Kettenis; +Cc: Mark Kettenis, U-Boot Mailing List, Tom Rini, Simon Glass On 2/11/22 22:01, Simon Glass wrote: > Hi Mark, > > On Fri, 11 Feb 2022 at 13:50, Mark Kettenis <mark.kettenis@xs4all.nl> wrote: >> >>> From: Simon Glass <sjg@chromium.org> >>> Date: Fri, 11 Feb 2022 13:29:15 -0700 >>> >>> Hi Mark, >>> >>> On Fri, 11 Feb 2022 at 13:00, Mark Kettenis <kettenis@openbsd.org> wrote: >>>> >>>> The address of the debug UART varies differs between the M1 and >>>> the M1 Pro/Max SoCs. So we have to disable it to make a single >>>> U-Boot binary that works on all SoC generations. Leave the >>>> settings for the base address and clock rate of the M1 in place >>>> to make it easier to re-enable the debug UART when needed. >>> >>> How about adding some docs about how to, and what the addresses are? >> >> Yes I can do that. A section at the end of doc/board/apple/m1.rst? Just list the relevant settings like in doc/board/sipeed/maix.rst:591 doc/board/emulation/qemu-arm.rst:118 >> Is it ok if I provide a single update to that file for the M1 Pro/Max >> support? > > Sounds right, just enough to explain how to enable it. > > Regards, > Simon > >> >>>> Signed-off-by: Mark Kettenis <kettenis@openbsd.org> >>>> --- >>>> configs/apple_m1_defconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig >>>> index ef5b7ffd1a..396fe63114 100644 >>>> --- a/configs/apple_m1_defconfig >>>> +++ b/configs/apple_m1_defconfig >>>> @@ -3,7 +3,6 @@ CONFIG_ARCH_APPLE=y >>>> CONFIG_DEFAULT_DEVICE_TREE="t8103-j274" >>>> CONFIG_DEBUG_UART_BASE=0x235200000 >>>> CONFIG_DEBUG_UART_CLOCK=24000000 Please, use 'make savedefconfig' to create a consistent defconfig, and copy the generated defconfig to configs/apple_m1_defconfig before resubmitting. Best regards Heinrich >>>> -CONFIG_DEBUG_UART=y >>>> CONFIG_SYS_LOAD_ADDR=0x0 >>>> CONFIG_USE_PREBOOT=y >>>> # CONFIG_DISPLAY_CPUINFO is not set >>>> -- >>>> 2.35.1 >>>> >>> >>> Regards, >>> SImon >>> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-11 22:31 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-11 20:00 [PATCH] arm: apple: Disable debug UART Mark Kettenis 2022-02-11 20:29 ` Simon Glass 2022-02-11 20:50 ` Mark Kettenis 2022-02-11 21:01 ` Simon Glass 2022-02-11 22:31 ` Heinrich Schuchardt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.