RE: [PATCH 00/43] DC Patches March 18, 2024

["Wheeler, Daniel" <Daniel.Wheeler@amd.com>]

[Public]

Hi all,

This week this patchset was tested on the following systems:
        * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
        * MSI Gaming X Trio RX 6800
        * Gigabyte Gaming OC RX 7900 XTX

These systems were tested on the following display/connection types:
        * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U])
        * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI])
        * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters])
        * Thunderbolt (LG Ultrafine 5k)
        * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays)
        * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display)
        * USB 4 (Kensington SD5700T and 1x 4k 60Hz display)
        * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports])

The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to):
        * Changing display configurations and settings
        * Benchmark testing
        * Feature testing (Freesync, etc.)

Automated testing includes (but is not limited to):
        * Script testing (scripts to automate some of the manual checks)
        * IGT testing

The patchset consists of the amd-staging-drm-next branch (Head commit - 0b233252a7c1 drm/amd/display: 3.2.275) with new patches added on top of it.

Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.


Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>


Thank you,

Dan Wheeler
Sr. Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com

-----Original Message-----
From: Wayne Lin <Wayne.Lin@amd.com>
Sent: Tuesday, March 12, 2024 5:20 AM
To: amd-gfx@lists.freedesktop.org
Cc: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Li, Roman <Roman.Li@amd.com>; Lin, Wayne <Wayne.Lin@amd.com>; Gutierrez, Agustin <Agustin.Gutierrez@amd.com>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@amd.com>; Wu, Hersen <hersenxs.wu@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com>; Lin, Wayne <Wayne.Lin@amd.com>; Wheeler, Daniel <Daniel.Wheeler@amd.com>
Subject: [PATCH 00/43] DC Patches March 18, 2024

This DC patchset brings improvements in multiple areas. In summary, we highlight:

- Clear mpc_tree in init_pipes
- Program pixclk according to dcn revision
- Add stream clock source to DP DTO params
- Enabling urgent latency adjustment for DCN35
- To adjust dprefclk by down spread percentage
- Add debug option for idle reg checks
- Revert few patches which cause regression
- skip forcing odm in minimal transition
- Fix noise issue on HDMI AV mute
- Enable fast update for DCN314
- Enable 2to1 ODM policy for DCN35
- Fix DCN31 underflow problem
- Add the MALL size in the fallback function
- Modify coding style/errors and remove redundant codes
- Add missing registers and offset
- Fix few problems for DCN35
- Fix a bug which dereferences freed memory
- Enable new interface design for alternate scrambling
- Enhance IPS handshake
- Increase Z8 watermark times
- Fix DML2 problem
- Revert patch which cause regression
- Fix problems for dmub idle power optimization

Cc: Daniel Wheeler <daniel.wheeler@amd.com>
---

Alex Hung (2):
  drm/amd/display: Delete duplicated function prototypes
  drm/amd/display: Correct indentations and spaces

Anthony Koo (1):
  drm/amd/display: [FW Promotion] Release 0.0.208.0

Aric Cyr (2):
  drm/amd/display: 3.2.276
  drm/amd/display: 3.2.277

Chaitanya Dhere (1):
  drm/amd/display: Add TB_BORROWED_MAX definition

Charlene Liu (2):
  drm/amd/display: fix debug key not working on dml2
  drm/amd/display: change aux_init to apu version

Chris Park (1):
  drm/amd/display: Prevent crash on bring-up

Dillon Varone (3):
  drm/amd/display: add stream clock source to DP DTO params
  drm/amd/display: Program pixclk according to dcn revision
  drm/amd/display: Power on VPG memory unconditionally if off

Gabe Teeger (1):
  drm/amd/display: Revert Add left edge pixel + ODM pipe split

Leo Ma (1):
  drm/amd/display: Fix noise issue on HDMI AV mute

Martin Leung (1):
  drm/amd/display: revert Exit idle optimizations before HDCP execution

Natanel Roizenman (2):
  drm/amd/display: Added debug prints for zstate_support and
    StutterPeriod
  drm/amd/display: Increase Z8 watermark times.

Nicholas Kazlauskas (6):
  drm/amd/display: Add debug option for idle reg checks
  drm/amd/display: Workaround register access in idle race with cursor
  drm/amd/display: Detect and disallow idle reallow during reentrancy
  drm/amd/display: Add optional optimization for IPS handshake
  drm/amd/display: Enable optimized handshake for DCN35
  drm/amd/display: Enable reallow for idle on DCN35

Nicholas Susanto (1):
  drm/amd/display: Enabling urgent latency adjustment for DCN35

Ovidiu Bunea (1):
  drm/amd/display: Revert "Set the power_down_on_boot function pointer
    to null"

Rodrigo Siqueira (9):
  drm/amd/display: Remove code duplication
  drm/amd/display: Remove wrong signal from vrr calculation
  drm/amd/display: Enable 2to1 ODM policy for DCN35
  drm/amd/display: Add the MALL size in the fallback function
  drm/amd/display: Move define to the proper header
  drm/amd/display: Enable fast update for DCN314
  drm/amd/display: Remove legacy code
  drm/amd/display: Comments adjustments
  drm/amd/display: Add missing registers and offset

Samson Tam (1):
  drm/amd/display: clear mpc_tree in init_pipes

Sherry Wang (1):
  drm/amd/display: correct hostvm flag

Sung Joon Kim (1):
  drm/amd/display: Enable new interface design for alternate scrambling

Wenjing Liu (3):
  drm/amd/display: skip forcing odm in minimal transition
  drm/amd/display: Revert Remove pixle rate limit for subvp
  drm/amd/display: fix a bug to dereference already freed old current
    state memory

Xi Liu (2):
  drm/amd/display: increase bb clock for DCN351
  drm/amd/display: Remove unnecessary hard coded DPM states

Zhongwei (1):
  drm/amd/display: To adjust dprefclk by down spread percentage

 .../gpu/drm/amd/display/dc/bios/bios_parser.c |   1 +
 .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c  |  15 ++-
 .../display/dc/clk_mgr/dcn314/dcn314_smu.h    |  42 +++----
 .../dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.h  |   3 +-
 .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c  |  50 ++++++++
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 118 +++++++++++-------
 .../gpu/drm/amd/display/dc/core/dc_resource.c |  40 +-----
 drivers/gpu/drm/amd/display/dc/core/dc_stat.c |   2 +-
 drivers/gpu/drm/amd/display/dc/dc.h           |   5 +-
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c  |  44 +++++--
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h  |   1 +
 .../display/dc/dcn31/dcn31_dio_link_encoder.c |   2 +-
 .../display/dc/dcn31/dcn31_dio_link_encoder.h |   2 +
 .../gpu/drm/amd/display/dc/dcn31/dcn31_vpg.c  |   7 +-
 .../display/dc/dcn35/dcn35_dio_link_encoder.c |   2 +-
 .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.h  |   1 +
 .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c  |   1 +
 .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c  |  12 +-
 .../amd/display/dc/dml/dcn351/dcn351_fpu.c    |  94 +++++++++++---
 .../amd/display/dc/dml2/display_mode_core.c   |   2 +
 .../display/dc/dml2/dml2_translation_helper.c |  17 ++-
 .../gpu/drm/amd/display/dc/dml2/dml2_utils.c  |   6 +
 .../amd/display/dc/hwss/dce110/dce110_hwseq.c |   3 +-
 .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c   |  16 +++
 .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c   |  10 --
 .../amd/display/dc/hwss/dcn30/dcn30_hwseq.c   |  12 +-
 .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c   |  16 +++
 .../amd/display/dc/hwss/dcn35/dcn35_init.c    |   2 +-
 .../gpu/drm/amd/display/dc/inc/core_types.h   |   2 -
 drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h  |   1 +
 drivers/gpu/drm/amd/display/dc/inc/resource.h |   4 -
 .../gpu/drm/amd/display/dc/link/link_dpms.c   |   3 +
 .../dc/link/protocols/link_dp_training.c      |  16 +--
 .../link/protocols/link_edp_panel_control.c   |  64 ++++++++++
 .../link/protocols/link_edp_panel_control.h   |   2 +
 .../dc/resource/dcn20/dcn20_resource.c        |   7 +-
 .../dc/resource/dcn31/dcn31_resource.c        |   5 +-
 .../dc/resource/dcn314/dcn314_resource.c      |  21 +---
 .../dc/resource/dcn316/dcn316_resource.c      |   1 -
 .../dc/resource/dcn32/dcn32_resource.c        |   3 +-
 .../dc/resource/dcn321/dcn321_resource.c      |   4 +-
 .../dc/resource/dcn35/dcn35_resource.c        |   5 +-
 .../dc/resource/dcn351/dcn351_resource.c      |   3 +
 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   |  73 ++++++++++-
 .../amd/display/modules/freesync/freesync.c   |   2 +-
 .../gpu/drm/amd/display/modules/hdcp/hdcp.c   |  10 --
 .../drm/amd/display/modules/inc/mod_hdcp.h    |   8 --
 .../display/modules/info_packet/info_packet.c |   2 -
 .../include/asic_reg/dcn/dcn_3_2_1_offset.h   |  37 +++++-
 .../include/asic_reg/dcn/dcn_3_2_1_sh_mask.h  |  16 +++
 50 files changed, 581 insertions(+), 234 deletions(-)

--
2.37.3