All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Michal Simek <michal.simek@xilinx.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
	Harini Katakam <harinik@xilinx.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH CFT v2 net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write()
Date: Tue, 04 Jan 2022 10:46:55 +0000	[thread overview]
Message-ID: <E1n4hLD-002NWF-0a@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YdQlI8gcVwg2sR+5@shell.armlinux.org.uk>

Commit 0ebecb2644c8 ("net: mdio: Add helper functions for accessing
MDIO devices") added support for mdiodev accessor operations that
neatly wrap the mdiobus accessor operations. Since we are dealing with
a mdio device here, update the driver to use mdiodev_write().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 7a28355114a8..42ffa8500c2b 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1540,8 +1540,7 @@ static int axienet_pcs_config(struct phylink_pcs *pcs, unsigned int mode,
 	int ret;
 
 	if (lp->switch_x_sgmii) {
-		ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr,
-				    XLNX_MII_STD_SELECT_REG,
+		ret = mdiodev_write(pcs_phy, XLNX_MII_STD_SELECT_REG,
 				    interface == PHY_INTERFACE_MODE_SGMII ?
 					XLNX_MII_STD_SELECT_SGMII : 0);
 		if (ret < 0) {
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Michal Simek <michal.simek@xilinx.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
	Harini Katakam <harinik@xilinx.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH CFT v2 net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write()
Date: Tue, 04 Jan 2022 10:46:55 +0000	[thread overview]
Message-ID: <E1n4hLD-002NWF-0a@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YdQlI8gcVwg2sR+5@shell.armlinux.org.uk>

Commit 0ebecb2644c8 ("net: mdio: Add helper functions for accessing
MDIO devices") added support for mdiodev accessor operations that
neatly wrap the mdiobus accessor operations. Since we are dealing with
a mdio device here, update the driver to use mdiodev_write().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 7a28355114a8..42ffa8500c2b 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1540,8 +1540,7 @@ static int axienet_pcs_config(struct phylink_pcs *pcs, unsigned int mode,
 	int ret;
 
 	if (lp->switch_x_sgmii) {
-		ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr,
-				    XLNX_MII_STD_SELECT_REG,
+		ret = mdiodev_write(pcs_phy, XLNX_MII_STD_SELECT_REG,
 				    interface == PHY_INTERFACE_MODE_SGMII ?
 					XLNX_MII_STD_SELECT_SGMII : 0);
 		if (ret < 0) {
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-01-04 10:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 12:47 [PATCH CFT 0/2] net: axienet: modernise pcs implementation Russell King (Oracle)
2021-12-16 12:47 ` Russell King (Oracle)
2021-12-16 12:48 ` [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Russell King (Oracle)
2021-12-16 12:48   ` Russell King (Oracle)
2021-12-16 15:15   ` Jakub Kicinski
2021-12-16 15:15     ` Jakub Kicinski
2021-12-16 17:02     ` Russell King (Oracle)
2021-12-16 17:02       ` Russell King (Oracle)
2021-12-17  8:24       ` Radhey Shyam Pandey
2021-12-17  8:24         ` Radhey Shyam Pandey
2021-12-17  8:25       ` Harini Katakam
2021-12-17  8:25         ` Harini Katakam
2022-01-04  7:56         ` Harini Katakam
2022-01-04  7:56           ` Harini Katakam
2022-01-04  9:00           ` Russell King (Oracle)
2022-01-04  9:00             ` Russell King (Oracle)
2022-01-04  9:12             ` Harini Katakam
2022-01-04  9:12               ` Harini Katakam
2022-01-04 10:34               ` Russell King (Oracle)
2022-01-04 10:34                 ` Russell King (Oracle)
2021-12-16 12:48 ` [PATCH CFT net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write() Russell King (Oracle)
2021-12-16 12:48   ` Russell King (Oracle)
2021-12-16 15:14   ` Jakub Kicinski
2021-12-16 15:14     ` Jakub Kicinski
2022-01-04 10:44 ` [PATCH CFT v2 0/2] net: axienet: modernise pcs implementation Russell King (Oracle)
2022-01-04 10:44   ` Russell King (Oracle)
2022-01-04 10:46   ` [PATCH CFT v2 net-next 1/2] net: axienet: convert to phylink_pcs Russell King (Oracle)
2022-01-04 10:46     ` Russell King (Oracle)
2022-01-04 10:46   ` Russell King (Oracle) [this message]
2022-01-04 10:46     ` [PATCH CFT v2 net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write() Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1n4hLD-002NWF-0a@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=davem@davemloft.net \
    --cc=harinik@xilinx.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.