Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Harini Katakam <harinik@xilinx.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
	Sean Anderson <sean.anderson@seco.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs
Date: Tue, 4 Jan 2022 09:00:57 +0000	[thread overview]
Message-ID: <YdQMyfYU0wxHrT40@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAFcVEC+N0Y7ESFe-qcfpmkbPjRSvCJ=AOXoM6XSK6xGo=J1YNw@mail.gmail.com>

On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote:
> On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@xilinx.com> wrote:
> >
> > Hi Russell,
> >
> > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle)
> > <linux@armlinux.org.uk> wrote:
> > >
> > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote:
> > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote:
> > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer
> > > > > being a legacy driver.
> > > > >
> > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether
> > > > > we support switching between SGMII and 1000baseX. However, when clear,
> > > > > this also blocks updating the 1000baseX advertisement, which it
> > > > > probably should not be doing. Nevertheless, this behaviour is preserved
> > > > > but a comment is added.
> > > > >
> > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > > >
> > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local'
> > >
> > > Fixed that and the sha1 issue you raised in patch 2. Since both are
> > > "documentation" issues, I won't send out replacement patches until
> > > I've heard they've been tested on hardware though.
> >
> > Thanks for the patches.
> > Series looks good and we're testing at our end; will get back to you
> > early next week.
> 
> Thanks Russell. I've tested AXI Ethernet and it works fine.

Happy new year!

Thanks - can I use that as a tested-by please, and would you be happy
for me to send the patches for merging this week?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!