From: Radhey Shyam Pandey <radheys@xilinx.com> To: Russell King <linux@armlinux.org.uk>, Jakub Kicinski <kuba@kernel.org> Cc: Michal Simek <michals@xilinx.com>, Sean Anderson <sean.anderson@seco.com>, "David S. Miller" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Harini Katakam <harinik@xilinx.com> Subject: RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Date: Fri, 17 Dec 2021 08:24:11 +0000 [thread overview] Message-ID: <SA1PR02MB85609F657BBBD0BF62D070B1C7789@SA1PR02MB8560.namprd02.prod.outlook.com> (raw) In-Reply-To: <YbtxGLrXoR9oHRmM@shell.armlinux.org.uk> + Harini > -----Original Message----- > From: Russell King <linux@armlinux.org.uk> > Sent: Thursday, December 16, 2021 10:32 PM > To: Jakub Kicinski <kuba@kernel.org> > Cc: Michal Simek <michals@xilinx.com>; Radhey Shyam Pandey > <radheys@xilinx.com>; Sean Anderson <sean.anderson@seco.com>; David S. > Miller <davem@davemloft.net>; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > Convert axienet to use the phylink_pcs layer, resulting in it no > > > longer being a legacy driver. > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls > > > whether we support switching between SGMII and 1000baseX. However, > > > when clear, this also blocks updating the 1000baseX advertisement, > > > which it probably should not be doing. Nevertheless, this behaviour > > > is preserved but a comment is added. > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function > parameter or member 'pcs' not described in 'axienet_local' > > Fixed that and the sha1 issue you raised in patch 2. Since both are > "documentation" issues, I won't send out replacement patches until I've heard > they've been tested on hardware though. Thanks, series looks fine. I have added Harini to this thread and she will confirm it on hardware. > > Thanks! > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Radhey Shyam Pandey <radheys@xilinx.com> To: Russell King <linux@armlinux.org.uk>, Jakub Kicinski <kuba@kernel.org> Cc: Michal Simek <michals@xilinx.com>, Sean Anderson <sean.anderson@seco.com>, "David S. Miller" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Harini Katakam <harinik@xilinx.com> Subject: RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Date: Fri, 17 Dec 2021 08:24:11 +0000 [thread overview] Message-ID: <SA1PR02MB85609F657BBBD0BF62D070B1C7789@SA1PR02MB8560.namprd02.prod.outlook.com> (raw) In-Reply-To: <YbtxGLrXoR9oHRmM@shell.armlinux.org.uk> + Harini > -----Original Message----- > From: Russell King <linux@armlinux.org.uk> > Sent: Thursday, December 16, 2021 10:32 PM > To: Jakub Kicinski <kuba@kernel.org> > Cc: Michal Simek <michals@xilinx.com>; Radhey Shyam Pandey > <radheys@xilinx.com>; Sean Anderson <sean.anderson@seco.com>; David S. > Miller <davem@davemloft.net>; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > Convert axienet to use the phylink_pcs layer, resulting in it no > > > longer being a legacy driver. > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls > > > whether we support switching between SGMII and 1000baseX. However, > > > when clear, this also blocks updating the 1000baseX advertisement, > > > which it probably should not be doing. Nevertheless, this behaviour > > > is preserved but a comment is added. > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function > parameter or member 'pcs' not described in 'axienet_local' > > Fixed that and the sha1 issue you raised in patch 2. Since both are > "documentation" issues, I won't send out replacement patches until I've heard > they've been tested on hardware though. Thanks, series looks fine. I have added Harini to this thread and she will confirm it on hardware. > > Thanks! > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-17 8:24 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-16 12:47 [PATCH CFT 0/2] net: axienet: modernise pcs implementation Russell King (Oracle) 2021-12-16 12:47 ` Russell King (Oracle) 2021-12-16 12:48 ` [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Russell King (Oracle) 2021-12-16 12:48 ` Russell King (Oracle) 2021-12-16 15:15 ` Jakub Kicinski 2021-12-16 15:15 ` Jakub Kicinski 2021-12-16 17:02 ` Russell King (Oracle) 2021-12-16 17:02 ` Russell King (Oracle) 2021-12-17 8:24 ` Radhey Shyam Pandey [this message] 2021-12-17 8:24 ` Radhey Shyam Pandey 2021-12-17 8:25 ` Harini Katakam 2021-12-17 8:25 ` Harini Katakam 2022-01-04 7:56 ` Harini Katakam 2022-01-04 7:56 ` Harini Katakam 2022-01-04 9:00 ` Russell King (Oracle) 2022-01-04 9:00 ` Russell King (Oracle) 2022-01-04 9:12 ` Harini Katakam 2022-01-04 9:12 ` Harini Katakam 2022-01-04 10:34 ` Russell King (Oracle) 2022-01-04 10:34 ` Russell King (Oracle) 2021-12-16 12:48 ` [PATCH CFT net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write() Russell King (Oracle) 2021-12-16 12:48 ` Russell King (Oracle) 2021-12-16 15:14 ` Jakub Kicinski 2021-12-16 15:14 ` Jakub Kicinski 2022-01-04 10:44 ` [PATCH CFT v2 0/2] net: axienet: modernise pcs implementation Russell King (Oracle) 2022-01-04 10:44 ` Russell King (Oracle) 2022-01-04 10:46 ` [PATCH CFT v2 net-next 1/2] net: axienet: convert to phylink_pcs Russell King (Oracle) 2022-01-04 10:46 ` Russell King (Oracle) 2022-01-04 10:46 ` [PATCH CFT v2 net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write() Russell King (Oracle) 2022-01-04 10:46 ` Russell King (Oracle)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SA1PR02MB85609F657BBBD0BF62D070B1C7789@SA1PR02MB8560.namprd02.prod.outlook.com \ --to=radheys@xilinx.com \ --cc=davem@davemloft.net \ --cc=harinik@xilinx.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=michals@xilinx.com \ --cc=netdev@vger.kernel.org \ --cc=sean.anderson@seco.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.