From: Jimmy RUBIN <jimmy.rubin@stericsson.com> To: linux-arm-kernel@lists.infradead.org Subject: RE: [PATCH 07/10] MCDE: Add display subsystem framework Date: Thu, 25 Nov 2010 07:16:38 +0000 [thread overview] Message-ID: <F45880696056844FA6A73F415B568C695365D85C41@EXDCVYMBSTM006.EQ1STM.local> (raw) In-Reply-To: <201011121738.53536.arnd@arndb.de> Hi, > > +struct kobj_type ovly_type = { > > + .release = overlay_release, > > +}; > > You certainly should not define a new kobj_type for use in a device > driver. > This is an internal data structure of the linux core code. It might > make > sense if you were trying to become the new frame buffer layer > maintainer > and rewrite all the existing drivers to be based on the concept of > overlays, but even then there is probably a better way. > > Maybe you were thinking of using kref instead of kobj? > Good point, I looked at kref and that is what we want to do. > > +int __init mcde_dss_init(void) > > +{ > > + return 0; > > +} > > + > > +void mcde_dss_exit(void) > > +{ > > +} > > If they don't do anything, don't define them. > Agree, will remove them /Jimmy
WARNING: multiple messages have this Message-ID (diff)
From: jimmy.rubin@stericsson.com (Jimmy RUBIN) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/10] MCDE: Add display subsystem framework Date: Thu, 25 Nov 2010 08:16:38 +0100 [thread overview] Message-ID: <F45880696056844FA6A73F415B568C695365D85C41@EXDCVYMBSTM006.EQ1STM.local> (raw) In-Reply-To: <201011121738.53536.arnd@arndb.de> Hi, > > +struct kobj_type ovly_type = { > > + .release = overlay_release, > > +}; > > You certainly should not define a new kobj_type for use in a device > driver. > This is an internal data structure of the linux core code. It might > make > sense if you were trying to become the new frame buffer layer > maintainer > and rewrite all the existing drivers to be based on the concept of > overlays, but even then there is probably a better way. > > Maybe you were thinking of using kref instead of kobj? > Good point, I looked at kref and that is what we want to do. > > +int __init mcde_dss_init(void) > > +{ > > + return 0; > > +} > > + > > +void mcde_dss_exit(void) > > +{ > > +} > > If they don't do anything, don't define them. > Agree, will remove them /Jimmy
next prev parent reply other threads:[~2010-11-25 7:16 UTC|newest] Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-10 12:04 [PATCH 00/10] MCDE: Add frame buffer device driver Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 01/10] MCDE: Add hardware abstraction layer Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 02/10] MCDE: Add configuration registers Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 03/10] MCDE: Add pixel processing registers Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 04/10] MCDE: Add formatter registers Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 05/10] MCDE: Add dsi link registers Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 06/10] MCDE: Add generic display Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 07/10] MCDE: Add display subsystem framework Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 08/10] MCDE: Add frame buffer device Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 09/10] MCDE: Add build files and bus Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` [PATCH 10/10] ux500: MCDE: Add platform specific data Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-10 12:04 ` Jimmy Rubin 2010-11-12 16:03 ` Arnd Bergmann 2010-11-12 16:03 ` Arnd Bergmann 2010-11-12 16:03 ` Arnd Bergmann 2010-11-25 11:20 ` Jimmy RUBIN 2010-11-25 11:20 ` Jimmy RUBIN 2010-11-12 16:23 ` [PATCH 09/10] MCDE: Add build files and bus Arnd Bergmann 2010-11-12 16:23 ` Arnd Bergmann 2010-11-12 16:23 ` Arnd Bergmann 2010-11-12 16:29 ` [PATCH 08/10] MCDE: Add frame buffer device Arnd Bergmann 2010-11-12 16:29 ` Arnd Bergmann 2010-11-12 16:29 ` Arnd Bergmann 2010-11-25 11:52 ` Jimmy RUBIN 2010-11-25 11:52 ` Jimmy RUBIN 2010-11-12 16:38 ` [PATCH 07/10] MCDE: Add display subsystem framework Arnd Bergmann 2010-11-12 16:38 ` Arnd Bergmann 2010-11-12 16:38 ` Arnd Bergmann 2010-11-25 7:16 ` Jimmy RUBIN [this message] 2010-11-25 7:16 ` Jimmy RUBIN 2010-11-12 15:46 ` [PATCH 03/10] MCDE: Add pixel processing registers Arnd Bergmann 2010-11-12 15:46 ` Arnd Bergmann 2010-11-12 15:46 ` Arnd Bergmann 2010-11-12 15:14 ` [PATCH 02/10] MCDE: Add configuration registers Arnd Bergmann 2010-11-12 15:14 ` Arnd Bergmann 2010-11-12 15:14 ` Arnd Bergmann 2010-11-12 15:34 ` Russell King - ARM Linux 2010-11-12 15:34 ` Russell King - ARM Linux 2010-11-12 15:34 ` Russell King - ARM Linux 2010-11-15 14:25 ` Arnd Bergmann 2010-11-15 14:25 ` Arnd Bergmann 2010-11-15 14:25 ` Arnd Bergmann 2010-11-15 14:59 ` Russell King - ARM Linux 2010-11-15 14:59 ` Russell King - ARM Linux 2010-11-15 14:59 ` Russell King - ARM Linux 2010-11-15 18:24 ` Geert Uytterhoeven 2010-11-15 18:24 ` Geert Uytterhoeven 2010-11-15 18:24 ` Geert Uytterhoeven 2010-11-25 11:30 ` Jimmy RUBIN 2010-11-25 11:30 ` Jimmy RUBIN 2010-11-25 16:21 ` Arnd Bergmann 2010-11-25 16:21 ` Arnd Bergmann 2010-11-10 17:14 ` [PATCH 01/10] MCDE: Add hardware abstraction layer Joe Perches 2010-11-10 17:14 ` Joe Perches 2010-11-10 17:14 ` Joe Perches 2010-11-15 9:52 ` Jimmy RUBIN 2010-11-15 9:52 ` Jimmy RUBIN 2010-11-15 9:52 ` Jimmy RUBIN 2010-11-15 16:30 ` Joe Perches 2010-11-15 16:30 ` Joe Perches 2010-11-15 16:30 ` Joe Perches 2010-11-12 15:43 ` Arnd Bergmann 2010-11-12 15:43 ` Arnd Bergmann 2010-11-12 15:43 ` Arnd Bergmann 2010-11-16 15:29 ` Jimmy RUBIN 2010-11-16 15:29 ` Jimmy RUBIN 2010-11-16 15:29 ` Jimmy RUBIN 2010-11-16 16:12 ` Arnd Bergmann 2010-11-16 16:12 ` Arnd Bergmann 2010-11-16 16:12 ` Arnd Bergmann 2010-11-16 16:16 ` Arnd Bergmann 2010-11-16 16:16 ` Arnd Bergmann 2010-11-16 16:16 ` Arnd Bergmann 2010-11-16 19:46 ` Joe Perches 2010-11-16 19:46 ` Joe Perches 2010-11-16 19:46 ` Joe Perches 2010-11-17 9:55 ` Arnd Bergmann 2010-11-17 9:55 ` Arnd Bergmann 2010-11-17 9:55 ` Arnd Bergmann 2010-11-17 16:01 ` Joe Perches 2010-11-17 16:01 ` Joe Perches 2010-11-17 16:01 ` Joe Perches 2010-11-10 14:42 ` [PATCH 00/10] MCDE: Add frame buffer device driver Alex Deucher 2010-11-10 14:42 ` Alex Deucher 2010-11-10 14:42 ` Alex Deucher 2010-11-12 13:18 ` Jimmy RUBIN 2010-11-12 13:18 ` Jimmy RUBIN 2010-11-12 13:18 ` Jimmy RUBIN 2010-11-12 15:52 ` Alex Deucher 2010-11-12 15:52 ` Alex Deucher 2010-11-12 15:52 ` Alex Deucher 2010-11-12 16:46 ` Marcus LORENTZON 2010-11-12 16:46 ` Marcus LORENTZON 2010-11-12 16:46 ` Marcus LORENTZON 2010-11-12 17:22 ` Alex Deucher 2010-11-12 17:22 ` Alex Deucher 2010-11-12 17:22 ` Alex Deucher 2010-11-15 11:05 ` Michel Dänzer 2010-11-15 11:05 ` Michel Dänzer 2010-11-15 11:05 ` Michel Dänzer 2010-11-13 11:54 ` Hans Verkuil 2010-11-13 11:54 ` Hans Verkuil 2010-11-13 11:54 ` Hans Verkuil 2010-11-13 17:26 ` Marcus LORENTZON 2010-11-13 17:26 ` Marcus LORENTZON 2010-11-13 17:26 ` Marcus LORENTZON 2010-11-13 17:57 ` Hans Verkuil 2010-11-13 17:57 ` Hans Verkuil 2010-11-13 17:57 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F45880696056844FA6A73F415B568C695365D85C41@EXDCVYMBSTM006.EQ1STM.local \ --to=jimmy.rubin@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.