From: Biju Das <biju.das@bp.renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support
Date: Thu, 28 Mar 2019 13:04:06 +0000 [thread overview]
Message-ID: <OSBPR01MB2103A7BB0AF6B9B97B30D684B8590@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190327232802.GA28701@bogus>
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support
>
> On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote:
> > Add support for renesas_usb3 to receive connect and disconnect
> > notification using extcon framework.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > index d366555..ae35674 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > @@ -21,6 +21,8 @@ Required properties:
> > Optional properties:
> > - phys: phandle + phy specifier pair
> > - phy-names: must be "usb"
> > + - extcon: phandle for the extcon device renesas usb3 uses to detect
> > + connect/disconnect events.
>
> Please don't use extcon and use usb-connector binding instead.
I have switched to usb role switch framework instead of extcon and sent V2 based on the below feedback.
https://patchwork.kernel.org/patch/10840659/
On V2, I have sent a patch series which uses " usb-connector " binding [1] and "usb-role-switch" property[2]
[1] https://patchwork.kernel.org/patch/10852495/
[2] https://patchwork.kernel.org/patch/10852497/
Support for "usb-role-switch" compatible can be found in the below patch set
https://patchwork.kernel.org/project/linux-usb/list/?series=97707
Please can you comment, is this approach is acceptable or not?
Regards,
Biju
WARNING: multiple messages have this Message-ID (diff)
From: Biju Das <biju.das@bp.renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: [2/9] dt-bindings: usb: renesas_usb3: add extcon support
Date: Thu, 28 Mar 2019 13:04:06 +0000 [thread overview]
Message-ID: <OSBPR01MB2103A7BB0AF6B9B97B30D684B8590@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support
>
> On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote:
> > Add support for renesas_usb3 to receive connect and disconnect
> > notification using extcon framework.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > index d366555..ae35674 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > @@ -21,6 +21,8 @@ Required properties:
> > Optional properties:
> > - phys: phandle + phy specifier pair
> > - phy-names: must be "usb"
> > + - extcon: phandle for the extcon device renesas usb3 uses to detect
> > + connect/disconnect events.
>
> Please don't use extcon and use usb-connector binding instead.
I have switched to usb role switch framework instead of extcon and sent V2 based on the below feedback.
https://patchwork.kernel.org/patch/10840659/
On V2, I have sent a patch series which uses " usb-connector " binding [1] and "usb-role-switch" property[2]
[1] https://patchwork.kernel.org/patch/10852495/
[2] https://patchwork.kernel.org/patch/10852497/
Support for "usb-role-switch" compatible can be found in the below patch set
https://patchwork.kernel.org/project/linux-usb/list/?series=97707
Please can you comment, is this approach is acceptable or not?
Regards,
Biju
next prev parent reply other threads:[~2019-03-28 13:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 9:07 [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support Biju Das
2019-03-06 9:07 ` [PATCH 1/9] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das
2019-03-06 9:07 ` [1/9] " Biju Das
2019-03-06 9:07 ` [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support Biju Das
2019-03-06 9:07 ` [2/9] " Biju Das
2019-03-27 23:28 ` [PATCH 2/9] " Rob Herring
2019-03-27 23:28 ` [2/9] " Rob Herring
2019-03-28 13:04 ` Biju Das [this message]
2019-03-28 13:04 ` Biju Das
2019-03-28 13:04 ` [PATCH 2/9] " Biju Das
2019-03-06 9:07 ` [PATCH 3/9] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das
2019-03-06 9:07 ` [3/9] " Biju Das
2019-03-06 11:34 ` [PATCH 3/9] " Heikki Krogerus
2019-03-06 11:34 ` [3/9] " Heikki Krogerus
2019-03-07 15:57 ` [PATCH 3/9] " Biju Das
2019-03-07 15:57 ` [3/9] " Biju Das
2019-03-06 9:07 ` [PATCH 4/9] usb: gadget: udc: renesas_usb3: use extcon framework to receive connect/disconnect Biju Das
2019-03-06 9:07 ` [4/9] " Biju Das
2019-03-06 12:43 ` [PATCH 4/9] " Heikki Krogerus
2019-03-06 12:43 ` [4/9] " Heikki Krogerus
2019-03-07 16:02 ` [PATCH 4/9] " Biju Das
2019-03-07 16:02 ` [4/9] " Biju Das
2019-03-06 9:07 ` [PATCH 5/9] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das
2019-03-06 9:07 ` [5/9] " Biju Das
2019-03-06 9:07 ` [PATCH 6/9] arm64: renesas_defconfig: Enable " Biju Das
2019-03-06 9:07 ` [PATCH 7/9] arm64: dts: renesas: r8a774c0-cat874: enable USB3.0 host/peripheral device node Biju Das
2019-03-06 9:07 ` [PATCH 8/9] arm64: dts: renesas: r8a774c0-cat874: Enable TI HD3SS3220 support Biju Das
2019-03-06 9:07 ` [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Enable extcon support Biju Das
2019-03-06 13:09 ` [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB2103A7BB0AF6B9B97B30D684B8590@OSBPR01MB2103.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.