From: Alan Stern <stern@rowland.harvard.edu> To: Ohad Ben-Cohen <ohad@wizery.com> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, <linux-pm@lists.linux-foundation.org>, Johannes Berg <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>, <linux-mmc@vger.kernel.org>, Ido Yariv <ido@wizery.com>, Kevin Hilman <khilman@deeprootsystems.com> Subject: Re: [linux-pm] subtle pm_runtime_put_sync race and sdio functions Date: Wed, 29 Dec 2010 23:25:36 -0500 (EST) [thread overview] Message-ID: <Pine.LNX.4.44L0.1012292314280.13580-100000@netrider.rowland.org> (raw) In-Reply-To: <AANLkTikrd3JpBG4JYUUxQhPPNhSmJaE5j5ozz=_vpU52@mail.gmail.com> On Wed, 29 Dec 2010, Ohad Ben-Cohen wrote: > On Tue, Dec 28, 2010 at 11:46 PM, Alan Stern <stern@rowland.harvard.edu> wrote: > > What's the relation between mmc_power_off() and mmc_power_save_host()? > > Essentially they are the same - mmc_power_off() is the one that > actually powers off the card. > > mmc_power_save_host() just invokes first a bus-specific ->power_save() > handler (if one exists). > > > Does one merely go into a low-power state whereas the other does the > > complete-power-off reset? > > No, think of them as the same. Both will lead to a complete power off. > The mmc_power_off() is just an internal function which belongs to the > MMC core. Then what routine does the power down without the full reset? That's why you run into trouble, isn't it? The device has been powered down, but if the system sleep transition is aborted then the device doesn't get reset (by mmc_power_save_host?), so you can't wake it up again. Also, what routine tries to do the failing wakeup, and what is its call path? > > During wlan-interface-down, it's not necessary to reduce the power > > level; it's merely desirable. That's exactly the sort of thing runtime > > PM is meant for. Hence the existing call to pm_runtime_put_sync() is > > sufficient. > > Not exactly - think of airplane mode, where we must ensure the radios > are disabled, without being blocked by /sys/devices/.../power/control > - we will need to bypass runtime PM in this scenario too. I don't see why. Turning off the radio is different from powering the device down -- you should be able to do the first without doing the second (although probably not vice versa). Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu> To: Ohad Ben-Cohen <ohad@wizery.com> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-pm@lists.linux-foundation.org, Johannes Berg <johannes@sipsolutions.net>, linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, Ido Yariv <ido@wizery.com>, Kevin Hilman <khilman@deeprootsystems.com> Subject: Re: [linux-pm] subtle pm_runtime_put_sync race and sdio functions Date: Wed, 29 Dec 2010 23:25:36 -0500 (EST) [thread overview] Message-ID: <Pine.LNX.4.44L0.1012292314280.13580-100000@netrider.rowland.org> (raw) In-Reply-To: <AANLkTikrd3JpBG4JYUUxQhPPNhSmJaE5j5ozz=_vpU52@mail.gmail.com> On Wed, 29 Dec 2010, Ohad Ben-Cohen wrote: > On Tue, Dec 28, 2010 at 11:46 PM, Alan Stern <stern@rowland.harvard.edu> wrote: > > What's the relation between mmc_power_off() and mmc_power_save_host()? > > Essentially they are the same - mmc_power_off() is the one that > actually powers off the card. > > mmc_power_save_host() just invokes first a bus-specific ->power_save() > handler (if one exists). > > > Does one merely go into a low-power state whereas the other does the > > complete-power-off reset? > > No, think of them as the same. Both will lead to a complete power off. > The mmc_power_off() is just an internal function which belongs to the > MMC core. Then what routine does the power down without the full reset? That's why you run into trouble, isn't it? The device has been powered down, but if the system sleep transition is aborted then the device doesn't get reset (by mmc_power_save_host?), so you can't wake it up again. Also, what routine tries to do the failing wakeup, and what is its call path? > > During wlan-interface-down, it's not necessary to reduce the power > > level; it's merely desirable. That's exactly the sort of thing runtime > > PM is meant for. Hence the existing call to pm_runtime_put_sync() is > > sufficient. > > Not exactly - think of airplane mode, where we must ensure the radios > are disabled, without being blocked by /sys/devices/.../power/control > - we will need to bypass runtime PM in this scenario too. I don't see why. Turning off the radio is different from powering the device down -- you should be able to do the first without doing the second (although probably not vice versa). Alan Stern
next prev parent reply other threads:[~2010-12-30 4:25 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-09 23:37 subtle pm_runtime_put_sync race and sdio functions Ohad Ben-Cohen 2010-12-10 0:00 ` Rafael J. Wysocki 2010-12-10 0:00 ` [linux-pm] " Rafael J. Wysocki 2010-12-10 17:24 ` Alan Stern 2010-12-10 17:24 ` [linux-pm] " Alan Stern 2010-12-10 22:01 ` Rafael J. Wysocki 2010-12-10 22:01 ` [linux-pm] " Rafael J. Wysocki 2010-12-10 23:02 ` Ohad Ben-Cohen 2010-12-10 23:02 ` [linux-pm] " Ohad Ben-Cohen 2010-12-10 22:59 ` Ohad Ben-Cohen 2010-12-10 22:59 ` [linux-pm] " Ohad Ben-Cohen 2010-12-11 1:17 ` Ohad Ben-Cohen 2010-12-11 14:53 ` Alan Stern 2010-12-11 1:17 ` Ohad Ben-Cohen 2010-12-11 14:50 ` Alan Stern 2010-12-18 13:29 ` Ohad Ben-Cohen 2010-12-18 13:29 ` [linux-pm] " Ohad Ben-Cohen 2010-12-18 14:16 ` David Vrabel 2010-12-18 15:12 ` Ohad Ben-Cohen 2010-12-18 15:12 ` Ohad Ben-Cohen 2010-12-18 14:16 ` David Vrabel 2010-12-18 15:07 ` [linux-pm] " Rafael J. Wysocki 2010-12-18 16:00 ` Ohad Ben-Cohen 2010-12-18 16:00 ` [linux-pm] " Ohad Ben-Cohen 2010-12-18 16:40 ` Johannes Berg 2010-12-18 19:08 ` Ohad Ben-Cohen 2010-12-18 19:08 ` Ohad Ben-Cohen 2010-12-18 21:30 ` Alan Stern 2010-12-18 21:30 ` Alan Stern 2010-12-18 22:57 ` Rafael J. Wysocki 2010-12-18 22:57 ` [linux-pm] " Rafael J. Wysocki 2010-12-18 21:30 ` Alan Stern 2010-12-18 22:52 ` Rafael J. Wysocki 2010-12-18 22:52 ` [linux-pm] " Rafael J. Wysocki 2010-12-18 19:08 ` Ohad Ben-Cohen 2010-12-18 21:29 ` [linux-pm] " Alan Stern 2010-12-18 21:29 ` Alan Stern 2010-12-18 21:29 ` Alan Stern 2010-12-18 22:50 ` Rafael J. Wysocki 2010-12-18 22:50 ` [linux-pm] " Rafael J. Wysocki 2010-12-18 16:40 ` Johannes Berg 2010-12-18 22:47 ` [linux-pm] " Rafael J. Wysocki 2010-12-18 22:47 ` Rafael J. Wysocki 2010-12-19 7:48 ` Ohad Ben-Cohen 2010-12-19 7:48 ` Ohad Ben-Cohen 2010-12-19 7:48 ` Ohad Ben-Cohen 2010-12-19 10:22 ` Rafael J. Wysocki 2010-12-19 10:22 ` [linux-pm] " Rafael J. Wysocki 2010-12-20 3:37 ` Alan Stern 2010-12-20 3:37 ` Alan Stern 2010-12-20 21:17 ` Rafael J. Wysocki 2010-12-21 0:57 ` Alan Stern 2010-12-21 0:57 ` Alan Stern 2010-12-21 21:31 ` Rafael J. Wysocki 2010-12-22 1:42 ` Alan Stern 2010-12-22 1:42 ` Alan Stern 2010-12-22 12:29 ` Rafael J. Wysocki 2010-12-22 12:29 ` Rafael J. Wysocki 2011-01-26 23:28 ` Kevin Hilman 2011-01-26 23:28 ` Kevin Hilman 2011-01-27 18:13 ` Alan Stern 2011-01-27 18:13 ` [linux-pm] " Alan Stern 2011-01-27 18:13 ` Alan Stern 2011-01-27 19:22 ` Kevin Hilman 2011-01-27 19:22 ` [linux-pm] " Kevin Hilman 2011-01-27 19:22 ` Kevin Hilman 2011-01-27 19:49 ` Alan Stern 2011-01-27 19:49 ` [linux-pm] " Alan Stern 2011-01-27 19:49 ` Alan Stern 2011-01-27 20:15 ` Kevin Hilman 2011-01-27 20:15 ` [linux-pm] " Kevin Hilman 2011-01-27 20:15 ` Kevin Hilman 2011-01-27 22:18 ` Vitaly Wool 2011-01-27 22:18 ` Vitaly Wool 2011-01-27 22:18 ` Vitaly Wool 2011-01-27 23:21 ` Rafael J. Wysocki 2011-01-27 23:21 ` [linux-pm] " Rafael J. Wysocki 2011-01-27 23:49 ` Kevin Hilman 2011-01-27 23:49 ` [linux-pm] " Kevin Hilman 2011-01-27 23:11 ` Rafael J. Wysocki 2011-01-27 23:11 ` [linux-pm] " Rafael J. Wysocki 2011-01-27 18:20 ` Vitaly Wool 2011-01-27 18:20 ` [linux-pm] " Vitaly Wool 2011-01-27 18:20 ` Vitaly Wool 2011-01-27 18:54 ` Kevin Hilman 2011-01-27 18:54 ` [linux-pm] " Kevin Hilman 2010-12-22 12:29 ` Rafael J. Wysocki 2010-12-22 1:42 ` Alan Stern 2010-12-21 21:31 ` Rafael J. Wysocki 2010-12-21 0:57 ` Alan Stern 2010-12-20 21:17 ` Rafael J. Wysocki 2010-12-20 3:37 ` Alan Stern 2010-12-21 22:23 ` Kevin Hilman 2010-12-21 22:23 ` [linux-pm] " Kevin Hilman 2010-12-22 1:48 ` Alan Stern 2010-12-22 1:48 ` Alan Stern 2010-12-22 1:48 ` Alan Stern 2010-12-23 7:51 ` Ohad Ben-Cohen 2010-12-23 7:51 ` [linux-pm] " Ohad Ben-Cohen 2010-12-23 16:03 ` Alan Stern 2010-12-23 16:03 ` [linux-pm] " Alan Stern 2010-12-23 16:03 ` Alan Stern 2010-12-25 7:34 ` Ohad Ben-Cohen 2010-12-25 7:34 ` Ohad Ben-Cohen 2010-12-25 16:21 ` Alan Stern 2010-12-25 16:21 ` Alan Stern 2010-12-25 20:58 ` Ohad Ben-Cohen 2010-12-25 20:58 ` [linux-pm] " Ohad Ben-Cohen 2010-12-25 20:58 ` Ohad Ben-Cohen 2010-12-25 21:50 ` Vitaly Wool 2010-12-25 21:50 ` [linux-pm] " Vitaly Wool 2010-12-26 5:27 ` Ohad Ben-Cohen 2010-12-26 5:27 ` [linux-pm] " Ohad Ben-Cohen 2010-12-25 21:54 ` Vitaly Wool 2010-12-25 21:54 ` Vitaly Wool 2010-12-25 21:54 ` Vitaly Wool 2010-12-26 2:48 ` [linux-pm] " Alan Stern 2010-12-26 2:48 ` Alan Stern 2010-12-26 5:55 ` Ohad Ben-Cohen 2010-12-26 5:55 ` [linux-pm] " Ohad Ben-Cohen 2010-12-26 5:55 ` Ohad Ben-Cohen 2010-12-26 11:45 ` Rafael J. Wysocki 2010-12-26 12:43 ` Ohad Ben-Cohen 2010-12-26 12:43 ` [linux-pm] " Ohad Ben-Cohen 2010-12-26 12:43 ` Ohad Ben-Cohen 2010-12-26 18:35 ` Rafael J. Wysocki 2010-12-28 19:11 ` Ohad Ben-Cohen 2010-12-28 19:11 ` [linux-pm] " Ohad Ben-Cohen 2010-12-28 19:21 ` Rafael J. Wysocki 2010-12-28 19:21 ` [linux-pm] " Rafael J. Wysocki 2010-12-28 19:21 ` Rafael J. Wysocki 2010-12-28 19:34 ` Ohad Ben-Cohen 2010-12-28 20:36 ` Rafael J. Wysocki 2010-12-28 20:36 ` [linux-pm] " Rafael J. Wysocki 2010-12-28 19:34 ` Ohad Ben-Cohen 2010-12-26 18:35 ` Rafael J. Wysocki 2010-12-26 14:53 ` [linux-pm] " Ohad Ben-Cohen 2010-12-26 18:37 ` Rafael J. Wysocki 2010-12-26 18:37 ` [linux-pm] " Rafael J. Wysocki 2010-12-28 19:15 ` Ohad Ben-Cohen 2010-12-28 20:04 ` Rafael J. Wysocki 2010-12-28 20:04 ` [linux-pm] " Rafael J. Wysocki 2010-12-28 20:04 ` Rafael J. Wysocki 2010-12-28 20:41 ` Ohad Ben-Cohen 2010-12-28 20:41 ` [linux-pm] " Ohad Ben-Cohen 2010-12-28 20:41 ` Ohad Ben-Cohen 2010-12-28 19:15 ` Ohad Ben-Cohen 2010-12-26 14:53 ` Ohad Ben-Cohen 2010-12-26 11:45 ` Rafael J. Wysocki 2010-12-26 17:00 ` [linux-pm] " Alan Stern 2010-12-26 17:00 ` Alan Stern 2010-12-28 19:04 ` Ohad Ben-Cohen 2010-12-28 19:04 ` [linux-pm] " Ohad Ben-Cohen 2010-12-28 19:04 ` Ohad Ben-Cohen 2010-12-28 21:46 ` Alan Stern 2010-12-28 21:46 ` [linux-pm] " Alan Stern 2010-12-28 21:46 ` Alan Stern 2010-12-29 6:34 ` Ohad Ben-Cohen 2010-12-30 4:25 ` Alan Stern [this message] 2010-12-30 4:25 ` Alan Stern 2010-12-30 4:25 ` Alan Stern 2010-12-29 6:34 ` Ohad Ben-Cohen 2010-12-29 8:01 ` Ohad Ben-Cohen 2010-12-29 8:01 ` [linux-pm] " Ohad Ben-Cohen 2010-12-30 4:30 ` Alan Stern 2010-12-30 4:30 ` [linux-pm] " Alan Stern 2010-12-30 4:30 ` Alan Stern 2010-12-26 17:00 ` Alan Stern 2010-12-26 2:48 ` Alan Stern 2010-12-25 16:21 ` Alan Stern 2010-12-25 7:34 ` Ohad Ben-Cohen 2010-12-18 22:47 ` Rafael J. Wysocki 2010-12-18 15:07 ` Rafael J. Wysocki 2010-12-18 21:20 ` [linux-pm] " Alan Stern 2010-12-18 23:03 ` Rafael J. Wysocki 2010-12-18 23:03 ` Rafael J. Wysocki 2010-12-19 10:00 ` [linux-pm] " Ohad Ben-Cohen 2010-12-19 10:00 ` Ohad Ben-Cohen 2010-12-18 21:20 ` Alan Stern
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Pine.LNX.4.44L0.1012292314280.13580-100000@netrider.rowland.org \ --to=stern@rowland.harvard.edu \ --cc=ido@wizery.com \ --cc=johannes@sipsolutions.net \ --cc=khilman@deeprootsystems.com \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=linux-wireless@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=rjw@sisk.pl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.