From: Brent Casavant <bcasavan@sgi.com> To: Hugh Dickins <hugh@veritas.com> Cc: "Martin J. Bligh" <mbligh@aracnet.com>, Andi Kleen <ak@suse.de>, "Adam J. Richter" <adam@yggdrasil.com>, colpatch@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Use MPOL_INTERLEAVE for tmpfs files Date: Thu, 11 Nov 2004 17:10:48 -0600 [thread overview] Message-ID: <Pine.SGI.4.58.0411111645000.106380@kzerza.americas.sgi.com> (raw) In-Reply-To: <Pine.LNX.4.44.0411111929370.2939-300000@localhost.localdomain> On Thu, 11 Nov 2004, Hugh Dickins wrote: > The first (against 2.6.10-rc1-mm5) being my reversion of NULL sbinfo > in shmem.c, to make it easier for others to add things into sbinfo > without having to worry about NULL cases. So that goes back to > allocating an sbinfo even for the internal mount: I've rounded up to > L1_CACHE_BYTES to avoid false sharing, but even so, please test it out > on your 512-way to make sure I haven't screwed up the scalability we > got before - thanks. If you find it okay, I'll send to akpm soonish. I won't be able to get a 512 run in until Monday, due to test machine availability. However runs at 32P and 64P indicate nothing disastrous. Results seem to be in line with the numbers we were getting when doing the NULL sbinfo work. So, thus far a preliminary "Looks good". > The second (against the first) being my take on your patch, with > mpol=interleave, and minor alterations which may irritate you so much > you'll revert them immediately! (mainly, using MPOL_INTERLEAVE and > MPOL_DEFAULT within shmem.c rather than defining separate flags). > Only slightly tested at this end. Seems to work just fine, and I rather like how this was made a bit more general. Thumbs up! Brent -- Brent Casavant If you had nothing to fear, bcasavan@sgi.com how then could you be brave? Silicon Graphics, Inc. -- Queen Dama, Source Wars
WARNING: multiple messages have this Message-ID (diff)
From: Brent Casavant <bcasavan@sgi.com> To: Hugh Dickins <hugh@veritas.com> Cc: "Martin J. Bligh" <mbligh@aracnet.com>, Andi Kleen <ak@suse.de>, "Adam J. Richter" <adam@yggdrasil.com>, colpatch@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Use MPOL_INTERLEAVE for tmpfs files Date: Thu, 11 Nov 2004 17:10:48 -0600 [thread overview] Message-ID: <Pine.SGI.4.58.0411111645000.106380@kzerza.americas.sgi.com> (raw) In-Reply-To: <Pine.LNX.4.44.0411111929370.2939-300000@localhost.localdomain> On Thu, 11 Nov 2004, Hugh Dickins wrote: > The first (against 2.6.10-rc1-mm5) being my reversion of NULL sbinfo > in shmem.c, to make it easier for others to add things into sbinfo > without having to worry about NULL cases. So that goes back to > allocating an sbinfo even for the internal mount: I've rounded up to > L1_CACHE_BYTES to avoid false sharing, but even so, please test it out > on your 512-way to make sure I haven't screwed up the scalability we > got before - thanks. If you find it okay, I'll send to akpm soonish. I won't be able to get a 512 run in until Monday, due to test machine availability. However runs at 32P and 64P indicate nothing disastrous. Results seem to be in line with the numbers we were getting when doing the NULL sbinfo work. So, thus far a preliminary "Looks good". > The second (against the first) being my take on your patch, with > mpol=interleave, and minor alterations which may irritate you so much > you'll revert them immediately! (mainly, using MPOL_INTERLEAVE and > MPOL_DEFAULT within shmem.c rather than defining separate flags). > Only slightly tested at this end. Seems to work just fine, and I rather like how this was made a bit more general. Thumbs up! Brent -- Brent Casavant If you had nothing to fear, bcasavan@sgi.com how then could you be brave? Silicon Graphics, Inc. -- Queen Dama, Source Wars -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-11 23:17 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-11-02 1:07 [PATCH] Use MPOL_INTERLEAVE for tmpfs files Brent Casavant 2004-11-02 1:07 ` Brent Casavant 2004-11-02 1:43 ` Dave Hansen 2004-11-02 1:43 ` Dave Hansen 2004-11-02 9:13 ` Andi Kleen 2004-11-02 9:13 ` Andi Kleen 2004-11-02 15:46 ` Martin J. Bligh 2004-11-02 15:46 ` Martin J. Bligh 2004-11-02 15:55 ` Andi Kleen 2004-11-02 15:55 ` Andi Kleen 2004-11-02 16:55 ` Martin J. Bligh 2004-11-02 16:55 ` Martin J. Bligh 2004-11-02 22:17 ` Brent Casavant 2004-11-02 22:17 ` Brent Casavant 2004-11-02 22:51 ` Martin J. Bligh 2004-11-02 22:51 ` Martin J. Bligh 2004-11-03 1:12 ` Brent Casavant 2004-11-03 1:12 ` Brent Casavant 2004-11-03 1:30 ` Martin J. Bligh 2004-11-03 8:44 ` Hugh Dickins 2004-11-03 8:44 ` Hugh Dickins 2004-11-03 9:01 ` Andi Kleen 2004-11-03 9:01 ` Andi Kleen 2004-11-03 16:32 ` Brent Casavant 2004-11-03 16:32 ` Brent Casavant 2004-11-03 21:00 ` Martin J. Bligh 2004-11-03 21:00 ` Martin J. Bligh 2004-11-08 19:58 ` Brent Casavant 2004-11-08 19:58 ` Brent Casavant 2004-11-08 20:57 ` Martin J. Bligh 2004-11-08 20:57 ` Martin J. Bligh 2004-11-09 19:04 ` Hugh Dickins 2004-11-09 19:04 ` Hugh Dickins 2004-11-09 20:09 ` Martin J. Bligh 2004-11-09 20:09 ` Martin J. Bligh 2004-11-09 21:08 ` Hugh Dickins 2004-11-09 21:08 ` Hugh Dickins 2004-11-09 22:07 ` Martin J. Bligh 2004-11-09 22:07 ` Martin J. Bligh 2004-11-10 2:41 ` Brent Casavant 2004-11-10 2:41 ` Brent Casavant 2004-11-10 14:20 ` Hugh Dickins 2004-11-10 14:20 ` Hugh Dickins 2004-11-11 19:48 ` Hugh Dickins 2004-11-11 19:48 ` Hugh Dickins 2004-11-11 23:10 ` Brent Casavant [this message] 2004-11-11 23:10 ` Brent Casavant 2004-11-15 22:07 ` Brent Casavant 2004-11-15 22:07 ` Brent Casavant
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Pine.SGI.4.58.0411111645000.106380@kzerza.americas.sgi.com \ --to=bcasavan@sgi.com \ --cc=adam@yggdrasil.com \ --cc=ak@suse.de \ --cc=colpatch@us.ibm.com \ --cc=hugh@veritas.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mbligh@aracnet.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.