RE: [RFC PATCH 5/6] crypto: xilinx: Add Xilinx SHA3 driver

[Harsha Harsha <harshah@xilinx.com>]

Hi Randy,

Thanks for reviewing the patch. I will make the following changes:
-  ZynqMP SHA3 hw accelerator -> ZynqMP SHA3 hardware accelerator
-  SHA3 hw engine -> SHA3 hardware engine

Regards,
Harsha

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Tuesday, November 30, 2021 7:44 PM
> To: Harsha Harsha <harshah@xilinx.com>; herbert@gondor.apana.org.au; davem@davemloft.net; linux-crypto@vger.kernel.org;
> linux-kernel@vger.kernel.org; Michal Simek <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org;
> devicetree@vger.kernel.org
> Cc: Sarat Chand Savitala <saratcha@xilinx.com>; Harsh Jain <harshj@xilinx.com>
> Subject: Re: [RFC PATCH 5/6] crypto: xilinx: Add Xilinx SHA3 driver
> 
> Hi--
> 
> On 11/30/21 00:54, Harsha wrote:
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index 51690e7..5df252e 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -796,6 +796,16 @@ config CRYPTO_DEV_ZYNQMP_AES
> >  	  accelerator. Select this if you want to use the ZynqMP module
> >  	  for AES algorithms.
> >
> > +config CRYPTO_DEV_ZYNQMP_SHA3
> > +	bool "Support for Xilinx ZynqMP SHA3 hw accelerator"
> 
> s/hw/hardware/
> 
> > +	depends on ARCH_ZYNQMP || COMPILE_TEST
> > +	select CRYPTO_SHA3
> > +	help
> > +	  Xilinx ZynqMP has SHA3 engine used for secure hash calculation.
> > +	  This driver interfaces with SHA3 hw engine.
> 
> s/hw/hardware/
> 
> > +	  Select this if you want to use the ZynqMP module
> > +	  for SHA3 hash computation.
> 
> thanks.
> --
> ~Randy