All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	axboe@kernel.dk, stefanha@redhat.com, ebiggers@kernel.org,
	me@demsh.org
Subject: Re: [PATCH 0/3] fix direct io errors on dm-crypt
Date: Thu, 3 Nov 2022 14:39:27 -0600	[thread overview]
Message-ID: <Y2Qm/yGlVbDRskkr@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.LRH.2.21.2211031224060.10758@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote:
> Hi
> 
> The patchset seems OK - but dm-integrity also has a limitation that the 
> bio vectors must be aligned on logical block size.
> 
> dm-writecache and dm-verity seem to handle unaligned bioset, but you 
> should check them anyway.
> 
> I'm not sure about dm-log-writes.

Yeah, dm-integrity definitly needs it too. This is easy enough to use
the same io_hint that I added for dm-crypt.

dm-log-writes is doing some weird things with writes that I don't think
would work with some low level drivers without the same alignment
constraint.

The other two appear to handle this fine, but I'll run everything
through some focused test cases to be sure.

In the meantime, do you want to see the remaining mappers fixed in a v2,
or are you okay if they follow after this series?

WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: axboe@kernel.dk, ebiggers@kernel.org,
	Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	stefanha@redhat.com, me@demsh.org
Subject: Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt
Date: Thu, 3 Nov 2022 14:39:27 -0600	[thread overview]
Message-ID: <Y2Qm/yGlVbDRskkr@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.LRH.2.21.2211031224060.10758@file01.intranet.prod.int.rdu2.redhat.com>

On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote:
> Hi
> 
> The patchset seems OK - but dm-integrity also has a limitation that the 
> bio vectors must be aligned on logical block size.
> 
> dm-writecache and dm-verity seem to handle unaligned bioset, but you 
> should check them anyway.
> 
> I'm not sure about dm-log-writes.

Yeah, dm-integrity definitly needs it too. This is easy enough to use
the same io_hint that I added for dm-crypt.

dm-log-writes is doing some weird things with writes that I don't think
would work with some low level drivers without the same alignment
constraint.

The other two appear to handle this fine, but I'll run everything
through some focused test cases to be sure.

In the meantime, do you want to see the remaining mappers fixed in a v2,
or are you okay if they follow after this series?

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-11-03 20:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:25 [PATCH 0/3] fix direct io errors on dm-crypt Keith Busch
2022-11-03 15:25 ` [dm-devel] " Keith Busch
2022-11-03 15:25 ` [PATCH 1/3] block: make dma_alignment a stacking queue_limit Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-04  5:14   ` Christoph Hellwig
2022-11-04  5:14     ` [dm-devel] " Christoph Hellwig
2022-11-03 15:25 ` [PATCH 2/3] dm-crypt: provide dma_alignment limit in io_hints Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-03 15:25 ` [PATCH 3/3] block: make blk_set_default_limits() private Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-04  5:15   ` Christoph Hellwig
2022-11-04  5:15     ` [dm-devel] " Christoph Hellwig
2022-11-03 16:33 ` [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt Mikulas Patocka
2022-11-03 16:33   ` Mikulas Patocka
2022-11-03 20:39   ` Keith Busch [this message]
2022-11-03 20:39     ` [dm-devel] " Keith Busch
2022-11-04 13:09     ` Mikulas Patocka
2022-11-04 13:09       ` Mikulas Patocka
2022-11-03 16:41 ` Dmitrii Tcvetkov
2022-11-03 16:41   ` [dm-devel] " Dmitrii Tcvetkov
2022-11-10 18:24 ` Eric Biggers
2022-11-10 18:24   ` [dm-devel] " Eric Biggers
2022-11-10 18:45   ` Keith Busch
2022-11-10 18:45     ` [dm-devel] " Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2Qm/yGlVbDRskkr@kbusch-mbp.dhcp.thefacebook.com \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=me@demsh.org \
    --cc=mpatocka@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.