All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
	axboe@kernel.dk, stefanha@redhat.com, ebiggers@kernel.org,
	me@demsh.org, mpatocka@redhat.com,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/3] block: make dma_alignment a stacking queue_limit
Date: Thu, 3 Nov 2022 22:14:38 -0700	[thread overview]
Message-ID: <Y2Sfvk1EtG9XwxPC@infradead.org> (raw)
In-Reply-To: <20221103152559.1909328-2-kbusch@meta.com>

On Thu, Nov 03, 2022 at 08:25:57AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Device mappers had always been getting the default 511 dma mask, but
> the underlying device might have a larger alignment requirement. Since
> this value is used to determine alloweable direct-io alignment, this
> needs to be a stackable limit.

This can also remove the just added blk_queue_dma_alignment in
nvme_mpath_alloc_disk again as it is right next to the
blk_set_stacking_limits call.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: axboe@kernel.dk, ebiggers@kernel.org,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	mpatocka@redhat.com, stefanha@redhat.com,
	Keith Busch <kbusch@kernel.org>,
	me@demsh.org
Subject: Re: [dm-devel] [PATCH 1/3] block: make dma_alignment a stacking queue_limit
Date: Thu, 3 Nov 2022 22:14:38 -0700	[thread overview]
Message-ID: <Y2Sfvk1EtG9XwxPC@infradead.org> (raw)
In-Reply-To: <20221103152559.1909328-2-kbusch@meta.com>

On Thu, Nov 03, 2022 at 08:25:57AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Device mappers had always been getting the default 511 dma mask, but
> the underlying device might have a larger alignment requirement. Since
> this value is used to determine alloweable direct-io alignment, this
> needs to be a stackable limit.

This can also remove the just added blk_queue_dma_alignment in
nvme_mpath_alloc_disk again as it is right next to the
blk_set_stacking_limits call.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-11-04  5:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:25 [PATCH 0/3] fix direct io errors on dm-crypt Keith Busch
2022-11-03 15:25 ` [dm-devel] " Keith Busch
2022-11-03 15:25 ` [PATCH 1/3] block: make dma_alignment a stacking queue_limit Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-04  5:14   ` Christoph Hellwig [this message]
2022-11-04  5:14     ` Christoph Hellwig
2022-11-03 15:25 ` [PATCH 2/3] dm-crypt: provide dma_alignment limit in io_hints Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-03 15:25 ` [PATCH 3/3] block: make blk_set_default_limits() private Keith Busch
2022-11-03 15:25   ` [dm-devel] " Keith Busch
2022-11-04  5:15   ` Christoph Hellwig
2022-11-04  5:15     ` [dm-devel] " Christoph Hellwig
2022-11-03 16:33 ` [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt Mikulas Patocka
2022-11-03 16:33   ` Mikulas Patocka
2022-11-03 20:39   ` Keith Busch
2022-11-03 20:39     ` [dm-devel] " Keith Busch
2022-11-04 13:09     ` Mikulas Patocka
2022-11-04 13:09       ` Mikulas Patocka
2022-11-03 16:41 ` Dmitrii Tcvetkov
2022-11-03 16:41   ` [dm-devel] " Dmitrii Tcvetkov
2022-11-10 18:24 ` Eric Biggers
2022-11-10 18:24   ` [dm-devel] " Eric Biggers
2022-11-10 18:45   ` Keith Busch
2022-11-10 18:45     ` [dm-devel] " Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2Sfvk1EtG9XwxPC@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=me@demsh.org \
    --cc=mpatocka@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.