[PATCH] staging: wimax/i2400m: fix coding style issues

[PATCH] staging: wimax/i2400m: fix coding style issues

[Ayush]

- fix "multiple blank lines" issues.
- fix a couple of parenthesis alignment issues.
- fix no space before parenthesis issue.
- fix no blank line after declaration.

compile tested only (on next-20210202).

Signed-off-by: Ayush <ayush@disroot.org>
---
 drivers/staging/wimax/i2400m/debugfs.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wimax/i2400m/debugfs.c b/drivers/staging/wimax/i2400m/debugfs.c
index 1c640b41ea4c..80a6f833d1c2 100644
--- a/drivers/staging/wimax/i2400m/debugfs.c
+++ b/drivers/staging/wimax/i2400m/debugfs.c
@@ -15,7 +15,6 @@
 #include <linux/export.h>
 #include "i2400m.h"
 
-
 #define D_SUBMODULE debugfs
 #include "debug-levels.h"
 
@@ -27,8 +26,8 @@ int debugfs_netdev_queue_stopped_get(void *data, u64 *val)
 	return 0;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_netdev_queue_stopped,
-			debugfs_netdev_queue_stopped_get,
-			NULL, "%llu\n");
+			 debugfs_netdev_queue_stopped_get,
+			 NULL, "%llu\n");
 
 /*
  * We don't allow partial reads of this file, as then the reader would
@@ -59,7 +58,6 @@ ssize_t i2400m_rx_stats_read(struct file *filp, char __user *buffer,
 	return simple_read_from_buffer(buffer, count, ppos, buf, strlen(buf));
 }
 
-
 /* Any write clears the stats */
 static
 ssize_t i2400m_rx_stats_write(struct file *filp, const char __user *buffer,
@@ -89,7 +87,6 @@ const struct file_operations i2400m_rx_stats_fops = {
 	.llseek =	default_llseek,
 };
 
-
 /* See i2400m_rx_stats_read() */
 static
 ssize_t i2400m_tx_stats_read(struct file *filp, char __user *buffer,
@@ -142,21 +139,21 @@ const struct file_operations i2400m_tx_stats_fops = {
 	.llseek =	default_llseek,
 };
 
-
 /* Write 1 to ask the device to go into suspend */
 static
 int debugfs_i2400m_suspend_set(void *data, u64 val)
 {
 	int result;
 	struct i2400m *i2400m = data;
+
 	result = i2400m_cmd_enter_powersave(i2400m);
 	if (result >= 0)
 		result = 0;
 	return result;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_suspend,
-			NULL, debugfs_i2400m_suspend_set,
-			"%llu\n");
+			 NULL, debugfs_i2400m_suspend_set,
+			 "%llu\n");
 
 /*
  * Reset the device
@@ -170,7 +167,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
 	int result;
 	struct i2400m *i2400m = data;
 	enum i2400m_reset_type rt = val;
-	switch(rt) {
+
+	switch (rt) {
 	case I2400M_RT_WARM:
 	case I2400M_RT_COLD:
 	case I2400M_RT_BUS:
@@ -184,8 +182,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
 	return result;
 }
 DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_reset,
-			NULL, debugfs_i2400m_reset_set,
-			"%llu\n");
+			 NULL, debugfs_i2400m_reset_set,
+			 "%llu\n");
 
 void i2400m_debugfs_add(struct i2400m *i2400m)
 {
-- 
2.30.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

[Greg KH]

On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote:
> - fix "multiple blank lines" issues.
> - fix a couple of parenthesis alignment issues.
> - fix no space before parenthesis issue.
> - fix no blank line after declaration.
> 
> compile tested only (on next-20210202).
> 
> Signed-off-by: Ayush <ayush@disroot.org>
> ---
>  drivers/staging/wimax/i2400m/debugfs.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/wimax/i2400m/debugfs.c b/drivers/staging/wimax/i2400m/debugfs.c
> index 1c640b41ea4c..80a6f833d1c2 100644
> --- a/drivers/staging/wimax/i2400m/debugfs.c
> +++ b/drivers/staging/wimax/i2400m/debugfs.c
> @@ -15,7 +15,6 @@
>  #include <linux/export.h>
>  #include "i2400m.h"
>  
> -
>  #define D_SUBMODULE debugfs
>  #include "debug-levels.h"
>  
> @@ -27,8 +26,8 @@ int debugfs_netdev_queue_stopped_get(void *data, u64 *val)
>  	return 0;
>  }
>  DEFINE_DEBUGFS_ATTRIBUTE(fops_netdev_queue_stopped,
> -			debugfs_netdev_queue_stopped_get,
> -			NULL, "%llu\n");
> +			 debugfs_netdev_queue_stopped_get,
> +			 NULL, "%llu\n");
>  
>  /*
>   * We don't allow partial reads of this file, as then the reader would
> @@ -59,7 +58,6 @@ ssize_t i2400m_rx_stats_read(struct file *filp, char __user *buffer,
>  	return simple_read_from_buffer(buffer, count, ppos, buf, strlen(buf));
>  }
>  
> -
>  /* Any write clears the stats */
>  static
>  ssize_t i2400m_rx_stats_write(struct file *filp, const char __user *buffer,
> @@ -89,7 +87,6 @@ const struct file_operations i2400m_rx_stats_fops = {
>  	.llseek =	default_llseek,
>  };
>  
> -
>  /* See i2400m_rx_stats_read() */
>  static
>  ssize_t i2400m_tx_stats_read(struct file *filp, char __user *buffer,
> @@ -142,21 +139,21 @@ const struct file_operations i2400m_tx_stats_fops = {
>  	.llseek =	default_llseek,
>  };
>  
> -
>  /* Write 1 to ask the device to go into suspend */
>  static
>  int debugfs_i2400m_suspend_set(void *data, u64 val)
>  {
>  	int result;
>  	struct i2400m *i2400m = data;
> +
>  	result = i2400m_cmd_enter_powersave(i2400m);
>  	if (result >= 0)
>  		result = 0;
>  	return result;
>  }
>  DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_suspend,
> -			NULL, debugfs_i2400m_suspend_set,
> -			"%llu\n");
> +			 NULL, debugfs_i2400m_suspend_set,
> +			 "%llu\n");
>  
>  /*
>   * Reset the device
> @@ -170,7 +167,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
>  	int result;
>  	struct i2400m *i2400m = data;
>  	enum i2400m_reset_type rt = val;
> -	switch(rt) {
> +
> +	switch (rt) {
>  	case I2400M_RT_WARM:
>  	case I2400M_RT_COLD:
>  	case I2400M_RT_BUS:
> @@ -184,8 +182,8 @@ int debugfs_i2400m_reset_set(void *data, u64 val)
>  	return result;
>  }
>  DEFINE_DEBUGFS_ATTRIBUTE(fops_i2400m_reset,
> -			NULL, debugfs_i2400m_reset_set,
> -			"%llu\n");
> +			 NULL, debugfs_i2400m_reset_set,
> +			 "%llu\n");
>  
>  void i2400m_debugfs_add(struct i2400m *i2400m)
>  {
> -- 
> 2.30.0
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

[Dan Carpenter]

Do you really not have a last name, like Cher?

On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote:
> - fix "multiple blank lines" issues.
> - fix a couple of parenthesis alignment issues.
> - fix no space before parenthesis issue.
> - fix no blank line after declaration.
> 

We generally want people to send these as separate patches.

But in this case, we're just going to delete the driver.  Don't bother
sending cleanups for this because it will be deleted soon.

> compile tested only (on next-20210202).

Don't put this in the commit message.  Put it under the --- cut off line
if you want.

> 
> Signed-off-by: Ayush <ayush@disroot.org>

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

[Ayush]

>
> - Your patch did many different things all at once, making it difficult
> to review. All Linux kernel patches need to only do one thing at a
> time. If you need to do multiple things (such as clean up all coding
> style issues in a file/driver), do it in a sequence of patches, each
> one doing only one thing. This will make it easier to review the
> patches to ensure that they are correct, and to help alleviate any
> merge issues that larger patches can cause.
>

Okay sir, I will break down the patch and send the patch series in v2.
 
> - It looks like you did not use your "real" name for the patch on either
> the Signed-off-by: line, or the From: line (both of which have to
> match). Please read the kernel file, Documentation/SubmittingPatches
> for how to do this correctly.
> 

Actually my legal name is only "Ayush", I do not have a last name.
I use my name as "Ayush Ayush" wherever I need last name.
So for signing off commits, should I use "Ayush Ayush" or "Ayush" will also work?

Regards,
Ayush
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

[Greg KH]

On Wed, Feb 03, 2021 at 03:40:06PM +0000, Ayush wrote:
> >
> > - Your patch did many different things all at once, making it difficult
> > to review. All Linux kernel patches need to only do one thing at a
> > time. If you need to do multiple things (such as clean up all coding
> > style issues in a file/driver), do it in a sequence of patches, each
> > one doing only one thing. This will make it easier to review the
> > patches to ensure that they are correct, and to help alleviate any
> > merge issues that larger patches can cause.
> >
> 
> Okay sir, I will break down the patch and send the patch series in v2.
>  
> > - It looks like you did not use your "real" name for the patch on either
> > the Signed-off-by: line, or the From: line (both of which have to
> > match). Please read the kernel file, Documentation/SubmittingPatches
> > for how to do this correctly.
> > 
> 
> Actually my legal name is only "Ayush", I do not have a last name.

Ok, if that is your legal name, that is fine to use, thanks.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

[Ayush]

> Do you really not have a last name, like Cher?
Exactly, my legal name only has first name.

> 
> We generally want people to send these as separate patches.
> 
> But in this case, we're just going to delete the driver. Don't bother
> sending cleanups for this because it will be deleted soon.
> 
>> compile tested only (on next-20210202).
> 
> Don't put this in the commit message. Put it under the --- cut off line
> if you want.
>
Noted.

Regards,
Ayush
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel