All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	maz@kernel.org, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sj Huang <sj.huang@mediatek.com>,
	youlin.pei@mediatek.com, chuanjia.liu@mediatek.com,
	qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com,
	drinkcat@chromium.org, Rex-BC.Chen@mediatek.com,
	anson.chuang@mediatek.com
Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support
Date: Wed, 24 Feb 2021 15:24:59 +0100	[thread overview]
Message-ID: <YDZhuwbgdUsnBD/0@rocinante> (raw)
In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com>

Hi Jianjun,

[...]
> +/**
> + * mtk_intx_eoi
> + * @data: pointer to chip specific data
> + *
> + * As an emulated level IRQ, its interrupt status will remain
> + * until the corresponding de-assert message is received; hence that
> + * the status can only be cleared when the interrupt has been serviced.
> + */
[...]

See my comment about the kernel-doc from the following:

  https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/

[...]
> +	if (err) {
> +		dev_err(dev, "failed to init PCIe IRQ domain\n");
> +		return err;
> +	}
[...]

Just a nitpick.  What about using "initialize" in the above?

Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rex-BC.Chen@mediatek.com, qizhong.cheng@mediatek.com,
	chuanjia.liu@mediatek.com, maz@kernel.org, drinkcat@chromium.org,
	Ryder Lee <ryder.lee@mediatek.com>,
	linux-kernel@vger.kernel.org, sin_jieyang@mediatek.com,
	Sj Huang <sj.huang@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-pci@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org, anson.chuang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support
Date: Wed, 24 Feb 2021 15:24:59 +0100	[thread overview]
Message-ID: <YDZhuwbgdUsnBD/0@rocinante> (raw)
In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com>

Hi Jianjun,

[...]
> +/**
> + * mtk_intx_eoi
> + * @data: pointer to chip specific data
> + *
> + * As an emulated level IRQ, its interrupt status will remain
> + * until the corresponding de-assert message is received; hence that
> + * the status can only be cleared when the interrupt has been serviced.
> + */
[...]

See my comment about the kernel-doc from the following:

  https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/

[...]
> +	if (err) {
> +		dev_err(dev, "failed to init PCIe IRQ domain\n");
> +		return err;
> +	}
[...]

Just a nitpick.  What about using "initialize" in the above?

Krzysztof

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rex-BC.Chen@mediatek.com, qizhong.cheng@mediatek.com,
	chuanjia.liu@mediatek.com, maz@kernel.org, drinkcat@chromium.org,
	Ryder Lee <ryder.lee@mediatek.com>,
	linux-kernel@vger.kernel.org, sin_jieyang@mediatek.com,
	Sj Huang <sj.huang@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-pci@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org, anson.chuang@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support
Date: Wed, 24 Feb 2021 15:24:59 +0100	[thread overview]
Message-ID: <YDZhuwbgdUsnBD/0@rocinante> (raw)
In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com>

Hi Jianjun,

[...]
> +/**
> + * mtk_intx_eoi
> + * @data: pointer to chip specific data
> + *
> + * As an emulated level IRQ, its interrupt status will remain
> + * until the corresponding de-assert message is received; hence that
> + * the status can only be cleared when the interrupt has been serviced.
> + */
[...]

See my comment about the kernel-doc from the following:

  https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/

[...]
> +	if (err) {
> +		dev_err(dev, "failed to init PCIe IRQ domain\n");
> +		return err;
> +	}
[...]

Just a nitpick.  What about using "initialize" in the above?

Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-24 15:15 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  6:11 [v8,0/7] PCI: mediatek: Add new generation controller support Jianjun Wang
2021-02-24  6:11 ` Jianjun Wang
2021-02-24  6:11 ` Jianjun Wang
2021-02-24  6:11 ` [v8,1/7] dt-bindings: PCI: mediatek-gen3: Add YAML schema Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-03-06 20:09   ` Rob Herring
2021-03-06 20:09     ` Rob Herring
2021-03-06 20:09     ` Rob Herring
2021-02-24  6:11 ` [v8,2/7] PCI: Export pci_pio_to_address() for module use Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11 ` [v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192 Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24 13:36   ` Krzysztof Wilczyński
2021-02-24 13:36     ` Krzysztof Wilczyński
2021-02-24 13:36     ` Krzysztof Wilczyński
2021-02-25  3:07     ` Jianjun Wang
2021-02-25  3:07       ` Jianjun Wang
2021-02-25  3:07       ` Jianjun Wang
2021-03-11 12:38   ` Pali Rohár
2021-03-11 12:38     ` Pali Rohár
2021-03-11 12:38     ` Pali Rohár
2021-03-13  7:43     ` Jianjun Wang
2021-03-13  7:43       ` Jianjun Wang
2021-03-13  7:43       ` Jianjun Wang
2021-03-18  0:02       ` Pali Rohár
2021-03-18  0:02         ` Pali Rohár
2021-03-18  0:02         ` Pali Rohár
2021-03-18  5:48         ` Jianjun Wang
2021-03-18  5:48           ` Jianjun Wang
2021-03-18  5:48           ` Jianjun Wang
2021-03-19 18:53           ` Pali Rohár
2021-03-19 18:53             ` Pali Rohár
2021-03-19 18:53             ` Pali Rohár
2021-03-23  1:31             ` Jianjun Wang
2021-03-23  1:31               ` Jianjun Wang
2021-03-23  1:31               ` Jianjun Wang
2021-03-23 14:51               ` Pali Rohár
2021-03-23 14:51                 ` Pali Rohár
2021-03-23 14:51                 ` Pali Rohár
2021-03-29 22:58           ` Pali Rohár
2021-03-29 22:58             ` Pali Rohár
2021-03-29 22:58             ` Pali Rohár
2021-02-24  6:11 ` [v8,4/7] PCI: mediatek-gen3: Add INTx support Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24 14:24   ` Krzysztof Wilczyński [this message]
2021-02-24 14:24     ` Krzysztof Wilczyński
2021-02-24 14:24     ` Krzysztof Wilczyński
2021-02-25  3:10     ` Jianjun Wang
2021-02-25  3:10       ` Jianjun Wang
2021-02-25  3:10       ` Jianjun Wang
2021-03-09 11:10   ` Marc Zyngier
2021-03-09 11:10     ` Marc Zyngier
2021-03-09 11:10     ` Marc Zyngier
2021-03-10  3:05     ` Jianjun Wang
2021-03-10  3:05       ` Jianjun Wang
2021-03-10  3:05       ` Jianjun Wang
2021-03-10  9:29       ` Marc Zyngier
2021-03-10  9:29         ` Marc Zyngier
2021-02-24  6:11 ` [v8,5/7] PCI: mediatek-gen3: Add MSI support Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24 14:31   ` Krzysztof Wilczyński
2021-02-24 14:31     ` Krzysztof Wilczyński
2021-02-24 14:31     ` Krzysztof Wilczyński
2021-02-25  3:09     ` Jianjun Wang
2021-02-25  3:09       ` Jianjun Wang
2021-02-25  3:09       ` Jianjun Wang
2021-03-09 11:23   ` Marc Zyngier
2021-03-09 11:23     ` Marc Zyngier
2021-03-09 11:23     ` Marc Zyngier
2021-03-10  6:48     ` Jianjun Wang
2021-03-10  6:48       ` Jianjun Wang
2021-03-10  6:48       ` Jianjun Wang
2021-03-10  9:41       ` Marc Zyngier
2021-03-10  9:41         ` Marc Zyngier
2021-03-11  9:47         ` Jianjun Wang
2021-03-11  9:47           ` Jianjun Wang
2021-03-11  9:47           ` Jianjun Wang
2021-03-12  9:14           ` Marc Zyngier
2021-03-12  9:14             ` Marc Zyngier
2021-03-11  0:05   ` Pali Rohár
2021-03-11  0:05     ` Pali Rohár
2021-03-11  0:05     ` Pali Rohár
2021-03-11  8:19     ` Marc Zyngier
2021-03-11  8:19       ` Marc Zyngier
2021-03-11  8:19       ` Marc Zyngier
2021-03-11  9:50       ` Jianjun Wang
2021-03-11  9:50         ` Jianjun Wang
2021-03-11  9:50         ` Jianjun Wang
2021-02-24  6:11 ` [v8,6/7] PCI: mediatek-gen3: Add system PM support Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24 14:10   ` Krzysztof Wilczyński
2021-02-24 14:10     ` Krzysztof Wilczyński
2021-02-24 14:10     ` Krzysztof Wilczyński
2021-02-25  3:34     ` Jianjun Wang
2021-02-25  3:34       ` Jianjun Wang
2021-02-25  3:34       ` Jianjun Wang
2021-02-25 22:00       ` Krzysztof Wilczyński
2021-02-25 22:00         ` Krzysztof Wilczyński
2021-02-25 22:00         ` Krzysztof Wilczyński
2021-02-26 10:06         ` Jianjun Wang
2021-02-26 10:06           ` Jianjun Wang
2021-02-26 10:06           ` Jianjun Wang
2021-02-24  6:11 ` [v8,7/7] MAINTAINERS: Add Jianjun Wang as MediaTek PCI co-maintainer Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang
2021-02-24  6:11   ` Jianjun Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDZhuwbgdUsnBD/0@rocinante \
    --to=kw@linux.com \
    --cc=Rex-BC.Chen@mediatek.com \
    --cc=anson.chuang@mediatek.com \
    --cc=chuanjia.liu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=helgaas@kernel.org \
    --cc=jianjun.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maz@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=qizhong.cheng@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=ryder.lee@mediatek.com \
    --cc=sin_jieyang@mediatek.com \
    --cc=sj.huang@mediatek.com \
    --cc=youlin.pei@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.