All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grzegorz Szymaszek <gszymaszek@short.pl>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Grzegorz Szymaszek <gszymaszek@short.pl>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Marcin Sloniewski <marcin.sloniewski@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins
Date: Thu, 3 Jun 2021 16:49:13 +0200	[thread overview]
Message-ID: <YLjr6XaK7q3r8dmi@nx64de-df6d00> (raw)
In-Reply-To: <fcee4f30-446e-f4da-6d95-c9223cf82981@pengutronix.de>

Hello Ahmad,

On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote:
> On 03.06.21 16:23, Grzegorz Szymaszek wrote:
> > The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output.
> > stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI
> > interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is
> > incompatible with the pins used on the Odyssey board, where:
> > - there are 8 data pins instead of 12,
> > - […]
> > 
> > Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in
> > the Odyssey device tree.
> 
> Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that
> instead of overriding an existing one.

Can I simply use dcmi_pins_b (as the first unused identifier) or is
there some way to match specific pin groups to an identifier (b, c, d,
and so on)?

> Current convention is also to place all STM32MP1 pinctrl nodes into
> a central file, not in the individual board device trees.

Sure, I will update the patch.

Thanks for your comments!

-- 
Grzegorz

WARNING: multiple messages have this Message-ID (diff)
From: Grzegorz Szymaszek <gszymaszek@short.pl>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Grzegorz Szymaszek <gszymaszek@short.pl>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Marcin Sloniewski <marcin.sloniewski@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins
Date: Thu, 3 Jun 2021 16:49:13 +0200	[thread overview]
Message-ID: <YLjr6XaK7q3r8dmi@nx64de-df6d00> (raw)
In-Reply-To: <fcee4f30-446e-f4da-6d95-c9223cf82981@pengutronix.de>

Hello Ahmad,

On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote:
> On 03.06.21 16:23, Grzegorz Szymaszek wrote:
> > The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output.
> > stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI
> > interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is
> > incompatible with the pins used on the Odyssey board, where:
> > - there are 8 data pins instead of 12,
> > - […]
> > 
> > Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in
> > the Odyssey device tree.
> 
> Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that
> instead of overriding an existing one.

Can I simply use dcmi_pins_b (as the first unused identifier) or is
there some way to match specific pin groups to an identifier (b, c, d,
and so on)?

> Current convention is also to place all STM32MP1 pinctrl nodes into
> a central file, not in the individual board device trees.

Sure, I will update the patch.

Thanks for your comments!

-- 
Grzegorz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-03 14:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 14:23 [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins Grzegorz Szymaszek
2021-06-03 14:23 ` Grzegorz Szymaszek
2021-06-03 14:26 ` Ahmad Fatoum
2021-06-03 14:26   ` Ahmad Fatoum
2021-06-03 14:49   ` Grzegorz Szymaszek [this message]
2021-06-03 14:49     ` Grzegorz Szymaszek
2021-06-03 14:58     ` Ahmad Fatoum
2021-06-03 14:58       ` Ahmad Fatoum
2021-06-03 15:34   ` [PATCH v2] ARM: dts: stm32: add a new DCMI pins group Grzegorz Szymaszek
2021-06-03 15:34     ` Grzegorz Szymaszek
2021-06-10 13:35     ` Alexandre TORGUE
2021-06-10 13:35       ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLjr6XaK7q3r8dmi@nx64de-df6d00 \
    --to=gszymaszek@short.pl \
    --cc=a.fatoum@pengutronix.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marcin.sloniewski@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.