From: Al Viro <viro@zeniv.linux.org.uk> To: Christoph Hellwig <hch@lst.de> Cc: Vivek Goyal <vgoyal@redhat.com>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com Subject: Re: [PATCH 1/2] init: split get_fs_names Date: Mon, 21 Jun 2021 14:46:37 +0000 [thread overview] Message-ID: <YNCmTSTcubslmj7k@zeniv-ca.linux.org.uk> (raw) In-Reply-To: <20210621062657.3641879-2-hch@lst.de> On Mon, Jun 21, 2021 at 08:26:56AM +0200, Christoph Hellwig wrote: > Split get_fs_names into one function that splits up the command line > argument, and one that gets the list of all registered file systems. > +static void __init get_all_fs_names(char *page) > +{ > + int len = get_filesystem_list(page); > + char *s = page, *p, *next; > + > + page[len] = '\0'; > + for (p = page - 1; p; p = next) { > + next = strchr(++p, '\n'); > + if (*p++ != '\t') > + continue; > + while ((*s++ = *p++) != '\n') > + ; > + s[-1] = '\0'; > } > + > *s = '\0'; > } TBH, I would rather take that one into fs/filesystems.c. Rationale: get_filesystem_list(), for all its resemblance to /proc/filesystems contents, is used only by init/*.c and it's not a big deal to make it int __init get_filesystem_list(char *buf, bool is_dev) { int f = is_dev ? FS_REQUIRES_DEV : 0; int left = PAGE_SIZE, count = 0; struct file_system_type *p; read_lock(&file_systems_lock); for (p = file_systems; p; p = p->next) { if ((p->fs_flags & FS_REQUIRES_DEV) == f) { size_t len = strlen(p->name) + 1; if (len > left) break; memcpy(buf, p->name, len); buf += len; left -= len; count++; } } read_unlock(&file_systems_lock); return count; } Generates NUL-separated list, returns the number of list elements, the second argument is "what kind do you want"...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk> To: Christoph Hellwig <hch@lst.de> Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com> Subject: Re: [Virtio-fs] [PATCH 1/2] init: split get_fs_names Date: Mon, 21 Jun 2021 14:46:37 +0000 [thread overview] Message-ID: <YNCmTSTcubslmj7k@zeniv-ca.linux.org.uk> (raw) In-Reply-To: <20210621062657.3641879-2-hch@lst.de> On Mon, Jun 21, 2021 at 08:26:56AM +0200, Christoph Hellwig wrote: > Split get_fs_names into one function that splits up the command line > argument, and one that gets the list of all registered file systems. > +static void __init get_all_fs_names(char *page) > +{ > + int len = get_filesystem_list(page); > + char *s = page, *p, *next; > + > + page[len] = '\0'; > + for (p = page - 1; p; p = next) { > + next = strchr(++p, '\n'); > + if (*p++ != '\t') > + continue; > + while ((*s++ = *p++) != '\n') > + ; > + s[-1] = '\0'; > } > + > *s = '\0'; > } TBH, I would rather take that one into fs/filesystems.c. Rationale: get_filesystem_list(), for all its resemblance to /proc/filesystems contents, is used only by init/*.c and it's not a big deal to make it int __init get_filesystem_list(char *buf, bool is_dev) { int f = is_dev ? FS_REQUIRES_DEV : 0; int left = PAGE_SIZE, count = 0; struct file_system_type *p; read_lock(&file_systems_lock); for (p = file_systems; p; p = p->next) { if ((p->fs_flags & FS_REQUIRES_DEV) == f) { size_t len = strlen(p->name) + 1; if (len > left) break; memcpy(buf, p->name, len); buf += len; left -= len; count++; } } read_unlock(&file_systems_lock); return count; } Generates NUL-separated list, returns the number of list elements, the second argument is "what kind do you want"...
next prev parent reply other threads:[~2021-06-21 14:46 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-21 6:26 support booting of arbitrary non-blockdevice file systems v2 Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 6:26 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 14:46 ` Al Viro [this message] 2021-06-21 14:46 ` Al Viro 2021-06-21 14:51 ` Al Viro 2021-06-21 14:51 ` [Virtio-fs] " Al Viro 2021-06-21 14:53 ` Christoph Hellwig 2021-06-21 14:53 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 14:59 ` Al Viro 2021-06-21 14:59 ` [Virtio-fs] " Al Viro 2021-06-21 15:09 ` Matthew Wilcox 2021-06-21 15:09 ` [Virtio-fs] " Matthew Wilcox 2021-06-21 15:22 ` Christoph Hellwig 2021-06-21 15:22 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 6:26 ` [PATCH 2/2] init: allow mounting arbitrary non-blockdevice filesystems as root Christoph Hellwig 2021-06-21 6:26 ` [Virtio-fs] " Christoph Hellwig 2021-06-21 13:31 ` [Virtio-fs] support booting of arbitrary non-blockdevice file systems v2 Stefan Hajnoczi 2021-06-21 13:31 ` Stefan Hajnoczi 2021-06-21 14:35 ` Vivek Goyal 2021-06-21 14:35 ` [Virtio-fs] " Vivek Goyal 2021-06-22 8:12 ` [PATCH 3/2] fs: simplify get_filesystem_list / get_all_fs_names Christoph Hellwig 2021-06-22 8:12 ` [Virtio-fs] " Christoph Hellwig 2021-06-22 8:36 ` Stefan Hajnoczi 2021-06-22 8:36 ` Stefan Hajnoczi 2021-06-29 20:50 ` Vivek Goyal 2021-06-29 20:50 ` Vivek Goyal 2021-06-30 5:36 ` Christoph Hellwig 2021-06-30 5:36 ` Christoph Hellwig 2021-06-30 17:33 ` Vivek Goyal 2021-06-30 17:33 ` Vivek Goyal 2021-07-07 21:04 ` Vivek Goyal 2021-07-07 21:04 ` Vivek Goyal 2021-07-07 21:06 ` Vivek Goyal 2021-07-07 21:06 ` Vivek Goyal 2021-07-08 12:59 ` Vivek Goyal 2021-07-08 12:59 ` Vivek Goyal 2021-07-12 18:21 ` Vivek Goyal 2021-07-12 18:21 ` Vivek Goyal 2021-07-13 5:40 ` Christoph Hellwig 2021-07-13 5:40 ` Christoph Hellwig -- strict thread matches above, loose matches on Subject: below -- 2021-06-17 15:36 support booting of arbitrary non-blockdevice file systems Christoph Hellwig 2021-06-17 15:36 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNCmTSTcubslmj7k@zeniv-ca.linux.org.uk \ --to=viro@zeniv.linux.org.uk \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vgoyal@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.