All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up
Date: Sat, 23 Oct 2021 11:53:39 +0200	[thread overview]
Message-ID: <YXPbozFVw25gVGvW@rocinante> (raw)
In-Reply-To: <AS8PR04MB867697359A6D51903D0098308C809@AS8PR04MB8676.eurprd04.prod.outlook.com>

Hi,

[...]
> > > > > -	default:
> > > > > -		break;
> > >
> > > While you're at it, this "default: break;" thing is pointless.
> > > Normally it's better to just *move* something without changing it at
> > > all, but this is such a simple thing I think you could drop this at
> > > the same time as the move.
> > >
> > [Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks.
> [Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP.
>  So I just don't drop them in v3 patch-set.

I hope you don't mind me asking, but how is an empty default case in the
switch statement helping IMX6Q and IMX6QP?  What does it achieve for these
two controllers specifically?

	Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up
Date: Sat, 23 Oct 2021 11:53:39 +0200	[thread overview]
Message-ID: <YXPbozFVw25gVGvW@rocinante> (raw)
In-Reply-To: <AS8PR04MB867697359A6D51903D0098308C809@AS8PR04MB8676.eurprd04.prod.outlook.com>

Hi,

[...]
> > > > > -	default:
> > > > > -		break;
> > >
> > > While you're at it, this "default: break;" thing is pointless.
> > > Normally it's better to just *move* something without changing it at
> > > all, but this is such a simple thing I think you could drop this at
> > > the same time as the move.
> > >
> > [Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks.
> [Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP.
>  So I just don't drop them in v3 patch-set.

I hope you don't mind me asking, but how is an empty default case in the
switch statement helping IMX6Q and IMX6QP?  What does it achieve for these
two controllers specifically?

	Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-23  9:53 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  6:05 [RESEND v2 0/5] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2021-10-15  6:05 ` Richard Zhu
2021-10-15  6:05 ` [RESEND v2 1/5] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2021-10-15  6:05   ` Richard Zhu
2021-10-15 18:13   ` Lucas Stach
2021-10-15 18:13     ` Lucas Stach
2021-10-19  7:32     ` Richard Zhu
2021-10-19  7:32       ` Richard Zhu
2021-10-15  6:05 ` [RESEND v2 2/5] PCI: imx6: Add the error propagation from host_init Richard Zhu
2021-10-15  6:05   ` Richard Zhu
2021-10-15 18:16   ` Lucas Stach
2021-10-15 18:16     ` Lucas Stach
2021-10-19  7:33     ` Richard Zhu
2021-10-19  7:33       ` Richard Zhu
2021-10-15  6:05 ` [RESEND v2 3/5] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu
2021-10-15  6:05   ` Richard Zhu
2021-10-15 18:22   ` Lucas Stach
2021-10-15 18:22     ` Lucas Stach
2021-10-19  7:39     ` Richard Zhu
2021-10-19  7:39       ` Richard Zhu
2021-10-20  3:22       ` Richard Zhu
2021-10-20  3:22         ` Richard Zhu
2021-10-15 18:34   ` Fabio Estevam
2021-10-15 18:34     ` Fabio Estevam
2021-10-19  7:44     ` Richard Zhu
2021-10-19  7:44       ` Richard Zhu
2021-10-15  6:05 ` [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance " Richard Zhu
2021-10-15  6:05   ` Richard Zhu
2021-10-15 18:24   ` Lucas Stach
2021-10-15 18:24     ` Lucas Stach
2021-10-19  7:43     ` Richard Zhu
2021-10-19  7:43       ` Richard Zhu
2021-10-15 18:49   ` Bjorn Helgaas
2021-10-15 18:49     ` Bjorn Helgaas
2021-10-15 18:51     ` Bjorn Helgaas
2021-10-15 18:51       ` Bjorn Helgaas
2021-10-19  7:56       ` Richard Zhu
2021-10-19  7:56         ` Richard Zhu
2021-10-22  8:02         ` Richard Zhu
2021-10-22  8:02           ` Richard Zhu
2021-10-23  9:53           ` Krzysztof Wilczyński [this message]
2021-10-23  9:53             ` Krzysztof Wilczyński
2021-10-25  2:35             ` Richard Zhu
2021-10-25  2:35               ` Richard Zhu
2021-10-26 22:21               ` Bjorn Helgaas
2021-10-26 22:21                 ` Bjorn Helgaas
2021-10-27  1:30                 ` Richard Zhu
2021-10-27  1:30                   ` Richard Zhu
2021-10-26 16:38           ` Bjorn Helgaas
2021-10-26 16:38             ` Bjorn Helgaas
2021-10-27  1:29             ` Richard Zhu
2021-10-27  1:29               ` Richard Zhu
2021-10-19  7:45     ` Richard Zhu
2021-10-19  7:45       ` Richard Zhu
2021-10-15  6:05 ` [RESEND v2 5/5] PCI: imx6: Add the compliance tests mode support Richard Zhu
2021-10-15  6:05   ` Richard Zhu
2021-10-15 18:28   ` Lucas Stach
2021-10-15 18:28     ` Lucas Stach
2021-10-19  8:12     ` Richard Zhu
2021-10-19  8:12       ` Richard Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXPbozFVw25gVGvW@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.