All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fsstress: improve error message on check_cwd() error
@ 2021-11-01 15:55 Luis Chamberlain
  2021-11-03 16:24 ` Darrick J. Wong
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-11-01 15:55 UTC (permalink / raw)
  To: fstests; +Cc: fdmanana, Luis Chamberlain, Anthony Iliopoulos

I ran into an error with generic/083 with xfs due to check_cwd() but
why it failed is not clear because there are two types of
failures:

  o stat64() failed (likely -ENOMEM is my guess)
  o the inode actually changed

Throw a bone out to developers so that in case en error does happen
they know which rabbit hole to go down on.

Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 ltp/fsstress.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 90ae432e..a576afea 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -9,6 +9,7 @@
 #include <sys/uio.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <string.h>
 #include "global.h"
 
 #ifdef HAVE_BTRFSUTIL_H
@@ -943,9 +944,21 @@ check_cwd(void)
 {
 #ifdef DEBUG
 	struct stat64	statbuf;
+	int ret;
+
+	ret = stat64(".", &statbuf);
+	if (ret !=0) {
+		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
+			ret, strerror(ret));
+		goto out;
+	}
 
-	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
+	if (statbuf.st_ino == top_ino)
 		return;
+
+	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
+		statbuf.st_ino, top_ino);
+out:
 	assert(chdir(homedir) == 0);
 	fprintf(stderr, "fsstress: check_cwd failure\n");
 	abort();
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] fsstress: improve error message on check_cwd() error
@ 2021-09-21 17:50 Luis Chamberlain
  2021-09-22 10:15 ` Filipe Manana
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-09-21 17:50 UTC (permalink / raw)
  To: fstests; +Cc: Luis Chamberlain, Anthony Iliopoulos

I ran into an error with generic/083 with xfs due to check_cwd() but
why it failed is not clear because there are two types of
failures:

  o stat64() failed (likely -ENOMEM is my guess)
  o the inode actually changed

Thow a bone out to developers so that in case en error does happen
they know which rabbit hole to go down on.

Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 ltp/fsstress.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index b4ddf5e2..d2f09901 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -9,6 +9,7 @@
 #include <sys/uio.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <string.h>
 #include "global.h"
 
 #ifdef HAVE_BTRFSUTIL_H
@@ -943,9 +944,21 @@ check_cwd(void)
 {
 #ifdef DEBUG
 	struct stat64	statbuf;
+	int ret;
+
+	ret = stat64(".", &statbuf);
+	if (ret !=0) {
+		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
+			ret, strerror(ret));
+		goto out;
+	}
 
-	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
+	if (statbuf.st_ino == top_ino)
 		return;
+
+	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
+		(long)statbuf.st_ino, (long)top_ino);
+out:
 	assert(chdir(homedir) == 0);
 	fprintf(stderr, "fsstress: check_cwd failure\n");
 	abort();
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-11-05 16:09 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-01 15:55 [PATCH] fsstress: improve error message on check_cwd() error Luis Chamberlain
2021-11-03 16:24 ` Darrick J. Wong
2021-11-03 18:18   ` Luis Chamberlain
2021-11-05 16:04     ` Luis Chamberlain
2021-11-05 16:09       ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2021-09-21 17:50 Luis Chamberlain
2021-09-22 10:15 ` Filipe Manana
2021-09-22 20:07   ` Luis Chamberlain
2021-09-23 12:37     ` Filipe Manana
2021-11-01 15:50       ` Luis Chamberlain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.