* [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-01 23:37 ` jae.hyun.yoo
0 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Hello all,
This series is for appliying below fix to all Aspped LPC sub drivers.
https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
An LPC sub driver can be enabled without using the lpc-ctrl driver or it
can be registered ahead of lpc-ctrl depends on each system configuration and
this difference introduces that LPC can be enabled without heart beating of
LCLK so it causes improper handling on host interrupts when the host sends
interrupts in that time frame. Then kernel eventually forcibly disables the
interrupt with dumping stack and printing a 'nobody cared this irq' message
out.
To prevent this issue, all LPC sub drivers should enable LCLK individually
so this patch adds clock control logic into the remaining Aspeed LPC sub
drivers.
Please review this series.
Thanks,
Jae
Jae Hyun Yoo (4):
ARM: dts: aspeed: add LCLK setting into LPC IBT node
ipmi: bt: add clock control logic
ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
ipmi: kcs_bmc_aspeed: add clock control logic
arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
5 files changed, 61 insertions(+), 5 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:36 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:36 UTC (permalink / raw)
To: Jae Hyun Yoo, Zev Weiss
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Hello all,
>
> This series is for appliying below fix to all Aspped LPC sub drivers.
> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>
> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
> can be registered ahead of lpc-ctrl depends on each system configuration and
> this difference introduces that LPC can be enabled without heart beating of
> LCLK so it causes improper handling on host interrupts when the host sends
> interrupts in that time frame. Then kernel eventually forcibly disables the
> interrupt with dumping stack and printing a 'nobody cared this irq' message
> out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK individually
> so this patch adds clock control logic into the remaining Aspeed LPC sub
> drivers.
Thanks for sending this out!
This will resolve a few of the issues we have in the issue tracker:
https://github.com/openbmc/linux/issues/210
https://github.com/openbmc/linux/issues/130
The patches look good to me. I think you've just missed Corey's PR for
v5.16, but I will stick them in the openbmc tree once they've had a
review.
Cheers,
Joel
>
> Please review this series.
>
> Thanks,
> Jae
>
> Jae Hyun Yoo (4):
> ARM: dts: aspeed: add LCLK setting into LPC IBT node
> ipmi: bt: add clock control logic
> ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
> ipmi: kcs_bmc_aspeed: add clock control logic
>
> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
> arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
> drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> 5 files changed, 61 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-01 23:36 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:36 UTC (permalink / raw)
To: Jae Hyun Yoo, Zev Weiss
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Hello all,
>
> This series is for appliying below fix to all Aspped LPC sub drivers.
> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>
> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
> can be registered ahead of lpc-ctrl depends on each system configuration and
> this difference introduces that LPC can be enabled without heart beating of
> LCLK so it causes improper handling on host interrupts when the host sends
> interrupts in that time frame. Then kernel eventually forcibly disables the
> interrupt with dumping stack and printing a 'nobody cared this irq' message
> out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK individually
> so this patch adds clock control logic into the remaining Aspeed LPC sub
> drivers.
Thanks for sending this out!
This will resolve a few of the issues we have in the issue tracker:
https://github.com/openbmc/linux/issues/210
https://github.com/openbmc/linux/issues/130
The patches look good to me. I think you've just missed Corey's PR for
v5.16, but I will stick them in the openbmc tree once they've had a
review.
Cheers,
Joel
>
> Please review this series.
>
> Thanks,
> Jae
>
> Jae Hyun Yoo (4):
> ARM: dts: aspeed: add LCLK setting into LPC IBT node
> ipmi: bt: add clock control logic
> ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
> ipmi: kcs_bmc_aspeed: add clock control logic
>
> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
> arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
> drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> 5 files changed, 61 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-01 23:36 ` Joel Stanley
@ 2021-11-02 12:22 ` Corey Minyard
-1 siblings, 0 replies; 66+ messages in thread
From: Corey Minyard @ 2021-11-02 12:22 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Zev Weiss, Rob Herring, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Mon, Nov 01, 2021 at 11:36:38PM +0000, Joel Stanley wrote:
> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
> >
> > From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >
> > Hello all,
> >
> > This series is for appliying below fix to all Aspped LPC sub drivers.
> > https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
> >
> > An LPC sub driver can be enabled without using the lpc-ctrl driver or it
> > can be registered ahead of lpc-ctrl depends on each system configuration and
> > this difference introduces that LPC can be enabled without heart beating of
> > LCLK so it causes improper handling on host interrupts when the host sends
> > interrupts in that time frame. Then kernel eventually forcibly disables the
> > interrupt with dumping stack and printing a 'nobody cared this irq' message
> > out.
> >
> > To prevent this issue, all LPC sub drivers should enable LCLK individually
> > so this patch adds clock control logic into the remaining Aspeed LPC sub
> > drivers.
>
> Thanks for sending this out!
>
> This will resolve a few of the issues we have in the issue tracker:
>
> https://github.com/openbmc/linux/issues/210
> https://github.com/openbmc/linux/issues/130
>
> The patches look good to me. I think you've just missed Corey's PR for
> v5.16, but I will stick them in the openbmc tree once they've had a
> review.
We can still get them in to 5.16 if it's important for that; this is a
bug fix, after all, and it's early. I just need to know the urgency.
Get the Reviewed-by's in and add the bindings and I can get it into the
next tree for a bit, then I can submit. We may be in rc1 by then, but
that's ok.
-corey
>
> Cheers,
>
> Joel
>
> >
> > Please review this series.
> >
> > Thanks,
> > Jae
> >
> > Jae Hyun Yoo (4):
> > ARM: dts: aspeed: add LCLK setting into LPC IBT node
> > ipmi: bt: add clock control logic
> > ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
> > ipmi: kcs_bmc_aspeed: add clock control logic
> >
> > arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> > arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
> > arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
> > drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
> > drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> > 5 files changed, 61 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-02 12:22 ` Corey Minyard
0 siblings, 0 replies; 66+ messages in thread
From: Corey Minyard @ 2021-11-02 12:22 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Zev Weiss, Rob Herring, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Mon, Nov 01, 2021 at 11:36:38PM +0000, Joel Stanley wrote:
> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
> >
> > From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >
> > Hello all,
> >
> > This series is for appliying below fix to all Aspped LPC sub drivers.
> > https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
> >
> > An LPC sub driver can be enabled without using the lpc-ctrl driver or it
> > can be registered ahead of lpc-ctrl depends on each system configuration and
> > this difference introduces that LPC can be enabled without heart beating of
> > LCLK so it causes improper handling on host interrupts when the host sends
> > interrupts in that time frame. Then kernel eventually forcibly disables the
> > interrupt with dumping stack and printing a 'nobody cared this irq' message
> > out.
> >
> > To prevent this issue, all LPC sub drivers should enable LCLK individually
> > so this patch adds clock control logic into the remaining Aspeed LPC sub
> > drivers.
>
> Thanks for sending this out!
>
> This will resolve a few of the issues we have in the issue tracker:
>
> https://github.com/openbmc/linux/issues/210
> https://github.com/openbmc/linux/issues/130
>
> The patches look good to me. I think you've just missed Corey's PR for
> v5.16, but I will stick them in the openbmc tree once they've had a
> review.
We can still get them in to 5.16 if it's important for that; this is a
bug fix, after all, and it's early. I just need to know the urgency.
Get the Reviewed-by's in and add the bindings and I can get it into the
next tree for a bit, then I can submit. We may be in rc1 by then, but
that's ok.
-corey
>
> Cheers,
>
> Joel
>
> >
> > Please review this series.
> >
> > Thanks,
> > Jae
> >
> > Jae Hyun Yoo (4):
> > ARM: dts: aspeed: add LCLK setting into LPC IBT node
> > ipmi: bt: add clock control logic
> > ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
> > ipmi: kcs_bmc_aspeed: add clock control logic
> >
> > arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> > arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
> > arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
> > drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
> > drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> > 5 files changed, 61 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-02 12:22 ` Corey Minyard
@ 2021-11-02 16:38 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:38 UTC (permalink / raw)
To: minyard, Joel Stanley
Cc: Jae Hyun Yoo, Zev Weiss, Rob Herring, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On 11/2/2021 5:22 AM, Corey Minyard wrote:
> On Mon, Nov 01, 2021 at 11:36:38PM +0000, Joel Stanley wrote:
>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> Hello all,
>>>
>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>> can be registered ahead of lpc-ctrl depends on each system configuration and
>>> this difference introduces that LPC can be enabled without heart beating of
>>> LCLK so it causes improper handling on host interrupts when the host sends
>>> interrupts in that time frame. Then kernel eventually forcibly disables the
>>> interrupt with dumping stack and printing a 'nobody cared this irq' message
>>> out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK individually
>>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>>> drivers.
>>
>> Thanks for sending this out!
>>
>> This will resolve a few of the issues we have in the issue tracker:
>>
>> https://github.com/openbmc/linux/issues/210
>> https://github.com/openbmc/linux/issues/130
>>
>> The patches look good to me. I think you've just missed Corey's PR for
>> v5.16, but I will stick them in the openbmc tree once they've had a
>> review.
>
> We can still get them in to 5.16 if it's important for that; this is a
> bug fix, after all, and it's early. I just need to know the urgency.
>
> Get the Reviewed-by's in and add the bindings and I can get it into the
> next tree for a bit, then I can submit. We may be in rc1 by then, but
> that's ok.
Thanks Corey! I'll submit v2 soon.
Jae
>
> -corey
>
>>
>> Cheers,
>>
>> Joel
>>
>>>
>>> Please review this series.
>>>
>>> Thanks,
>>> Jae
>>>
>>> Jae Hyun Yoo (4):
>>> ARM: dts: aspeed: add LCLK setting into LPC IBT node
>>> ipmi: bt: add clock control logic
>>> ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
>>> ipmi: kcs_bmc_aspeed: add clock control logic
>>>
>>> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
>>> arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
>>> drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
>>> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
>>> 5 files changed, 61 insertions(+), 5 deletions(-)
>>>
>>> --
>>> 2.25.1
>>>
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-02 16:38 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:38 UTC (permalink / raw)
To: minyard, Joel Stanley
Cc: Jae Hyun Yoo, Zev Weiss, Rob Herring, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On 11/2/2021 5:22 AM, Corey Minyard wrote:
> On Mon, Nov 01, 2021 at 11:36:38PM +0000, Joel Stanley wrote:
>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> Hello all,
>>>
>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>> can be registered ahead of lpc-ctrl depends on each system configuration and
>>> this difference introduces that LPC can be enabled without heart beating of
>>> LCLK so it causes improper handling on host interrupts when the host sends
>>> interrupts in that time frame. Then kernel eventually forcibly disables the
>>> interrupt with dumping stack and printing a 'nobody cared this irq' message
>>> out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK individually
>>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>>> drivers.
>>
>> Thanks for sending this out!
>>
>> This will resolve a few of the issues we have in the issue tracker:
>>
>> https://github.com/openbmc/linux/issues/210
>> https://github.com/openbmc/linux/issues/130
>>
>> The patches look good to me. I think you've just missed Corey's PR for
>> v5.16, but I will stick them in the openbmc tree once they've had a
>> review.
>
> We can still get them in to 5.16 if it's important for that; this is a
> bug fix, after all, and it's early. I just need to know the urgency.
>
> Get the Reviewed-by's in and add the bindings and I can get it into the
> next tree for a bit, then I can submit. We may be in rc1 by then, but
> that's ok.
Thanks Corey! I'll submit v2 soon.
Jae
>
> -corey
>
>>
>> Cheers,
>>
>> Joel
>>
>>>
>>> Please review this series.
>>>
>>> Thanks,
>>> Jae
>>>
>>> Jae Hyun Yoo (4):
>>> ARM: dts: aspeed: add LCLK setting into LPC IBT node
>>> ipmi: bt: add clock control logic
>>> ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
>>> ipmi: kcs_bmc_aspeed: add clock control logic
>>>
>>> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
>>> arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++
>>> arch/arm/boot/dts/aspeed-g6.dtsi | 5 +++++
>>> drivers/char/ipmi/bt-bmc.c | 24 ++++++++++++++++++++++-
>>> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
>>> 5 files changed, 61 insertions(+), 5 deletions(-)
>>>
>>> --
>>> 2.25.1
>>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-01 23:36 ` Joel Stanley
@ 2021-11-03 0:04 ` Zev Weiss
-1 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 0:04 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>
>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>
>> Hello all,
>>
>> This series is for appliying below fix to all Aspped LPC sub drivers.
>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>
>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>> can be registered ahead of lpc-ctrl depends on each system configuration and
>> this difference introduces that LPC can be enabled without heart beating of
>> LCLK so it causes improper handling on host interrupts when the host sends
>> interrupts in that time frame. Then kernel eventually forcibly disables the
>> interrupt with dumping stack and printing a 'nobody cared this irq' message
>> out.
>>
>> To prevent this issue, all LPC sub drivers should enable LCLK individually
>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>> drivers.
>
>Thanks for sending this out!
>
>This will resolve a few of the issues we have in the issue tracker:
>
>https://github.com/openbmc/linux/issues/210
>https://github.com/openbmc/linux/issues/130
>
>The patches look good to me. I think you've just missed Corey's PR for
>v5.16, but I will stick them in the openbmc tree once they've had a
>review.
>
Hi Jae,
I tried this series out on the same in-progress OpenBMC port from issue
number 210 linked above and am still seeing problems (dmesg pasted
below).
I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
routing to device tree") from linux-next to allow the first patch to
apply cleanly; is there anything else I might be missing that'd be
needed to test the series properly?
Thanks,
Zev
[ 0.417811] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 0.417858] CPU: 0 PID: 1 Comm: swapper Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 0.417899] Hardware name: Generic DT based system
[ 0.417922] Backtrace:
[ 0.417958] [<807e64e4>] (dump_backtrace) from [<807e6738>] (show_stack+0x20/0x24)
[ 0.418052] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 0.418074] [<807e6718>] (show_stack) from [<807f09d0>] (dump_stack+0x28/0x30)
[ 0.418133] [<807f09a8>] (dump_stack) from [<807e76c0>] (__report_bad_irq+0x40/0xc0)
[ 0.418189] r5:00000000 r4:80d43900
[ 0.418211] [<807e7680>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 0.418286] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 0.418307] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 0.418366] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 0.418390] r4:80d43900 r3:00000000
[ 0.418408] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 0.418464] r5:00000000 r4:80d43900
[ 0.418484] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 0.418539] r5:00000000 r4:80b8e7c8
[ 0.418558] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 0.418618] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
[ 0.418639] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 0.418685] Exception stack(0x80cbdc60 to 0x80cbdca8)
[ 0.418722] dc60: 00000000 00000000 00000000 00000000 80d43900 00000000 8529d180 00000020
[ 0.418756] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000 80cbdcb0 8015a520 80157d4c
[ 0.418781] dca0: 40000053 ffffffff
[ 0.418807] r5:40000053 r4:80157d4c
[ 0.418824] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 0.418887] r9:852acb60 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:8529d180
[ 0.418908] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 0.418979] r10:8092ed9c r9:00000000 r8:852acb60 r7:80d42410 r6:00000020 r5:8045ff98
[ 0.419004] r4:8529d760 r3:00000080
[ 0.419021] [<8015bd08>] (devm_request_threaded_irq) from [<8046049c>] (aspeed_lpc_snoop_probe+0x110/0x2e0)
[ 0.419116] r10:80bab000 r9:80d42410 r8:8529d140 r7:00000000 r6:80d42400 r5:852acb60
[ 0.419138] r4:00000000
[ 0.419155] [<8046038c>] (aspeed_lpc_snoop_probe) from [<804e6980>] (platform_probe+0x54/0x9c)
[ 0.419237] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
[ 0.419259] [<804e692c>] (platform_probe) from [<804e450c>] (really_probe+0x1c4/0x46c)
[ 0.419309] r5:00000000 r4:80d42410
[ 0.419329] [<804e4348>] (really_probe) from [<804e4888>] (__driver_probe_device+0xd4/0x1bc)
[ 0.419381] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
[ 0.419401] [<804e47b4>] (__driver_probe_device) from [<804e49b0>] (driver_probe_device+0x40/0xd8)
[ 0.419460] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
[ 0.419480] [<804e4970>] (driver_probe_device) from [<804e4d14>] (__driver_attach+0xa4/0x1c8)
[ 0.419538] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc r5:80d42454 r4:80d42410
[ 0.419556] [<804e4c70>] (__driver_attach) from [<804e2124>] (bus_for_each_dev+0x84/0xd0)
[ 0.419608] r7:80b71638 r6:804e4c70 r5:80b6f3dc r4:00000000
[ 0.419628] [<804e20a0>] (bus_for_each_dev) from [<804e5440>] (driver_attach+0x28/0x30)
[ 0.419681] r6:00000000 r5:852abd20 r4:80b6f3dc
[ 0.419700] [<804e5418>] (driver_attach) from [<804e2ac0>] (bus_add_driver+0x114/0x200)
[ 0.419745] [<804e29ac>] (bus_add_driver) from [<804e5adc>] (driver_register+0x98/0x128)
[ 0.419798] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
[ 0.419818] [<804e5a44>] (driver_register) from [<804e7c2c>] (__platform_driver_register+0x2c/0x34)
[ 0.419874] r5:80c03e40 r4:80a1997c
[ 0.419890] [<804e7c00>] (__platform_driver_register) from [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
[ 0.419951] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from [<80a01408>] (do_one_initcall+0x64/0x144)
[ 0.420024] [<80a013a4>] (do_one_initcall) from [<80a016e4>] (kernel_init_freeable+0x198/0x218)
[ 0.420086] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
[ 0.420108] [<80a0154c>] (kernel_init_freeable) from [<807f0c28>] (kernel_init+0x20/0x134)
[ 0.420172] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:807f0c08
[ 0.420194] r4:00000000
[ 0.420211] [<807f0c08>] (kernel_init) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 0.420259] Exception stack(0x80cbdfb0 to 0x80cbdff8)
[ 0.420292] dfa0: 00000000 00000000 00000000 00000000
[ 0.420326] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 0.420356] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 0.420382] r5:807f0c08 r4:00000000
[ 0.420400] handlers:
[ 0.420417] [<(ptrval)>] aspeed_lpc_snoop_irq
[ 0.420482] Disabling IRQ #32
[ 0.638932] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
[ 0.643436] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32, base_baud = 1546875) is a 8250
[ 0.645555] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31, base_baud = 1500000) is a 16550A
[ 2.010064] Freeing initrd memory: 1072K
[ 2.232890] printk: console [ttyS4] enabled
[ 2.239349] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x6961cb32 @ 1us
[ 2.262322] loop: module loaded
[ 2.284029] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
[ 2.290471] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
[ 2.296451] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 - 0x24000000 ] 64MB
[ 2.303977] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 - 0x2a000000 ] 96MB
[ 2.311486] aspeed-smc 1e620000.spi: read control register: 203c0641
[ 2.542638] 5 fixed-partitions partitions found on MTD device bmc
[ 2.548875] Creating 5 MTD partitions on "bmc":
[ 2.553458] 0x000000000000-0x0000000e0000 : "u-boot"
[ 2.561247] 0x0000000e0000-0x000000100000 : "u-boot-env"
[ 2.569559] 0x000000100000-0x000000a00000 : "kernel"
[ 2.577301] 0x000000a00000-0x000002a00000 : "rofs"
[ 2.585054] 0x000002a00000-0x000004000000 : "rwfs"
[ 2.628232] libphy: Fixed MDIO Bus: probed
[ 2.634437] ftgmac100 1e660000.ethernet: Read MAC address d0:50:99:f4:1e:18 from chip
[ 2.651029] libphy: ftgmac100_mdio: probed
[ 2.656253] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00: attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
[ 2.669669] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 1ecc0872
[ 2.680442] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in USB2 mode
[ 2.688464] Mass Storage Function, version: 2009/09/11
[ 2.693666] LUN: removable file: (no medium)
[ 2.698021] no file given for LUN0
[ 2.701605] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start g_mass_storage: -22
[ 2.710113] i2c /dev entries driver
[ 2.715459] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered, irq 33
[ 2.724045] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered, irq 34
[ 2.733972] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered, irq 35
[ 2.742252] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered, irq 36
[ 2.750599] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered, irq 37
[ 2.759769] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered, irq 38
[ 2.767994] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered, irq 39
[ 2.777783] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16 bytes/write
[ 2.785096] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered, irq 40
[ 2.793373] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered, irq 41
[ 2.801709] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered, irq 42
[ 2.814947] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
[ 2.820929] i2c i2c-2: Added multiplexed i2c bus 14
[ 2.826513] i2c i2c-2: Added multiplexed i2c bus 15
[ 2.832192] i2c i2c-2: Added multiplexed i2c bus 16
[ 2.837821] i2c i2c-2: Added multiplexed i2c bus 17
[ 2.842944] pca954x 2-0070: registered 4 multiplexed busses for I2C switch pca9545
[ 2.852110] i2c i2c-5: Added multiplexed i2c bus 18
[ 2.857847] i2c i2c-5: Added multiplexed i2c bus 19
[ 2.863603] i2c i2c-5: Added multiplexed i2c bus 20
[ 2.869410] i2c i2c-5: Added multiplexed i2c bus 21
[ 2.874378] pca954x 5-0073: registered 4 multiplexed busses for I2C switch pca9545
[ 2.884631] Driver for 1-wire Dallas network protocol.
[ 3.009394] NET: Registered PF_INET6 protocol family
[ 3.017326] Segment Routing with IPv6
[ 3.021945] NET: Registered PF_PACKET protocol family
[ 3.027562] 8021q: 802.1Q VLAN Support v1.8
[ 3.263306] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 3.270074] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 3.278889] Hardware name: Generic DT based system
[ 3.283699] Workqueue: events_unbound deferred_probe_work_func
[ 3.289601] Backtrace:
[ 3.292079] [<807e64e4>] (dump_backtrace) from [<807e6738>] (show_stack+0x20/0x24)
[ 3.299716] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 3.305382] [<807e6718>] (show_stack) from [<807f09d0>] (dump_stack+0x28/0x30)
[ 3.312646] [<807f09a8>] (dump_stack) from [<807e76c0>] (__report_bad_irq+0x40/0xc0)
[ 3.320433] r5:00000000 r4:80d43900
[ 3.324022] [<807e7680>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 3.332349] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 3.340101] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 3.348242] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 3.356077] r4:80d43900 r3:00000400
[ 3.359660] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 3.368047] r5:00000000 r4:80d43900
[ 3.371629] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 3.380024] r5:00000000 r4:80b8e7c8
[ 3.383607] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 3.391919] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
[ 3.397586] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 3.405187] Exception stack(0x80cc7c50 to 0x80cc7c98)
[ 3.410262] 7c40: 00000000 00000000 00000000 00000000
[ 3.418458] 7c60: 80d43900 8529d180 85120d00 00000020 80d439a8 a0000013 00000000 80cc7ccc
[ 3.426647] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
[ 3.433271] r5:40000013 r4:80157d4c
[ 3.436854] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 3.445171] r9:8505fa20 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:85120d00
[ 3.452922] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 3.462366] r10:80d4ea20 r9:00000000 r8:8505fa20 r7:80d42c10 r6:00000020 r5:8044fd64
[ 3.470208] r4:851208e0 r3:00000080
[ 3.473792] [<8015bd08>] (devm_request_threaded_irq) from [<80450644>] (aspeed_kcs_probe+0x298/0x650)
[ 3.483072] r10:8505fa54 r9:80833650 r8:ffffffea r7:80d42c10 r6:00000020 r5:8505fa20
[ 3.490912] r4:80d42c00
[ 3.493456] [<804503ac>] (aspeed_kcs_probe) from [<804e6980>] (platform_probe+0x54/0x9c)
[ 3.501617] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10 r6:80b6e7b0 r5:80b6e7b0
[ 3.509458] r4:80d42c10
[ 3.512003] [<804e692c>] (platform_probe) from [<804e450c>] (really_probe+0x1c4/0x46c)
[ 3.519957] r5:00000000 r4:80d42c10
[ 3.523538] [<804e4348>] (really_probe) from [<804e4888>] (__driver_probe_device+0xd4/0x1bc)
[ 3.532017] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
[ 3.537682] [<804e47b4>] (__driver_probe_device) from [<804e49b0>] (driver_probe_device+0x40/0xd8)
[ 3.546683] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
[ 3.553386] [<804e4970>] (driver_probe_device) from [<804e4be0>] (__device_attach_driver+0xb8/0x148)
[ 3.562568] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84 r5:80b6e7b0 r4:00000001
[ 3.570313] [<804e4b28>] (__device_attach_driver) from [<804e2648>] (bus_for_each_drv+0x90/0xe0)
[ 3.579145] r7:80b71484 r6:804e4b28 r5:80cc7e84 r4:00000000
[ 3.584812] [<804e25b8>] (bus_for_each_drv) from [<804e4f3c>] (__device_attach+0x104/0x18c)
[ 3.593201] r6:80d42c54 r5:00000001 r4:80d42c10
[ 3.597828] [<804e4e38>] (__device_attach) from [<804e536c>] (device_initial_probe+0x1c/0x20)
[ 3.606390] r6:80d42c10 r5:80b71638 r4:80d4ca50
[ 3.611019] [<804e5350>] (device_initial_probe) from [<804e2860>] (bus_probe_device+0x94/0x9c)
[ 3.619662] [<804e27cc>] (bus_probe_device) from [<804e3f3c>] (deferred_probe_work_func+0xa0/0xe8)
[ 3.628657] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
[ 3.634324] [<804e3e9c>] (deferred_probe_work_func) from [<801301ac>] (process_one_work+0x1b4/0x46c)
[ 3.643506] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00 r6:00000040 r5:80c045a0
[ 3.651342] r4:80b7148c r3:804e3e9c
[ 3.654925] [<8012fff8>] (process_one_work) from [<8013066c>] (worker_thread+0x208/0x528)
[ 3.663145] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14 r6:80c045b4 r5:80c08a00
[ 3.670979] r4:80c045a0
[ 3.673524] [<80130464>] (worker_thread) from [<80136f18>] (kthread+0x138/0x160)
[ 3.680982] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0 r6:80130464 r5:80c03840
[ 3.688822] r4:80c02b80
[ 3.691369] [<80136de0>] (kthread) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 3.698633] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
[ 3.703707] 7fa0: 00000000 00000000 00000000 00000000
[ 3.711904] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 3.720091] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 3.726722] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:80136de0
[ 3.734559] r4:80c02b80 r3:00000000
[ 3.738142] handlers:
[ 3.740420] [<8337d287>] aspeed_lpc_snoop_irq
[ 3.744851] [<d8d6aeaf>] aspeed_kcs_irq
[ 3.748741] Disabling IRQ #32
[ 3.752597] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for channel 3
[ 3.760184] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for channel 3
[ 3.767235] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 0:04 ` Zev Weiss
0 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 0:04 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>
>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>
>> Hello all,
>>
>> This series is for appliying below fix to all Aspped LPC sub drivers.
>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>
>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>> can be registered ahead of lpc-ctrl depends on each system configuration and
>> this difference introduces that LPC can be enabled without heart beating of
>> LCLK so it causes improper handling on host interrupts when the host sends
>> interrupts in that time frame. Then kernel eventually forcibly disables the
>> interrupt with dumping stack and printing a 'nobody cared this irq' message
>> out.
>>
>> To prevent this issue, all LPC sub drivers should enable LCLK individually
>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>> drivers.
>
>Thanks for sending this out!
>
>This will resolve a few of the issues we have in the issue tracker:
>
>https://github.com/openbmc/linux/issues/210
>https://github.com/openbmc/linux/issues/130
>
>The patches look good to me. I think you've just missed Corey's PR for
>v5.16, but I will stick them in the openbmc tree once they've had a
>review.
>
Hi Jae,
I tried this series out on the same in-progress OpenBMC port from issue
number 210 linked above and am still seeing problems (dmesg pasted
below).
I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
routing to device tree") from linux-next to allow the first patch to
apply cleanly; is there anything else I might be missing that'd be
needed to test the series properly?
Thanks,
Zev
[ 0.417811] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 0.417858] CPU: 0 PID: 1 Comm: swapper Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 0.417899] Hardware name: Generic DT based system
[ 0.417922] Backtrace:
[ 0.417958] [<807e64e4>] (dump_backtrace) from [<807e6738>] (show_stack+0x20/0x24)
[ 0.418052] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 0.418074] [<807e6718>] (show_stack) from [<807f09d0>] (dump_stack+0x28/0x30)
[ 0.418133] [<807f09a8>] (dump_stack) from [<807e76c0>] (__report_bad_irq+0x40/0xc0)
[ 0.418189] r5:00000000 r4:80d43900
[ 0.418211] [<807e7680>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 0.418286] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 0.418307] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 0.418366] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 0.418390] r4:80d43900 r3:00000000
[ 0.418408] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 0.418464] r5:00000000 r4:80d43900
[ 0.418484] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 0.418539] r5:00000000 r4:80b8e7c8
[ 0.418558] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 0.418618] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
[ 0.418639] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 0.418685] Exception stack(0x80cbdc60 to 0x80cbdca8)
[ 0.418722] dc60: 00000000 00000000 00000000 00000000 80d43900 00000000 8529d180 00000020
[ 0.418756] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000 80cbdcb0 8015a520 80157d4c
[ 0.418781] dca0: 40000053 ffffffff
[ 0.418807] r5:40000053 r4:80157d4c
[ 0.418824] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 0.418887] r9:852acb60 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:8529d180
[ 0.418908] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 0.418979] r10:8092ed9c r9:00000000 r8:852acb60 r7:80d42410 r6:00000020 r5:8045ff98
[ 0.419004] r4:8529d760 r3:00000080
[ 0.419021] [<8015bd08>] (devm_request_threaded_irq) from [<8046049c>] (aspeed_lpc_snoop_probe+0x110/0x2e0)
[ 0.419116] r10:80bab000 r9:80d42410 r8:8529d140 r7:00000000 r6:80d42400 r5:852acb60
[ 0.419138] r4:00000000
[ 0.419155] [<8046038c>] (aspeed_lpc_snoop_probe) from [<804e6980>] (platform_probe+0x54/0x9c)
[ 0.419237] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
[ 0.419259] [<804e692c>] (platform_probe) from [<804e450c>] (really_probe+0x1c4/0x46c)
[ 0.419309] r5:00000000 r4:80d42410
[ 0.419329] [<804e4348>] (really_probe) from [<804e4888>] (__driver_probe_device+0xd4/0x1bc)
[ 0.419381] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
[ 0.419401] [<804e47b4>] (__driver_probe_device) from [<804e49b0>] (driver_probe_device+0x40/0xd8)
[ 0.419460] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
[ 0.419480] [<804e4970>] (driver_probe_device) from [<804e4d14>] (__driver_attach+0xa4/0x1c8)
[ 0.419538] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc r5:80d42454 r4:80d42410
[ 0.419556] [<804e4c70>] (__driver_attach) from [<804e2124>] (bus_for_each_dev+0x84/0xd0)
[ 0.419608] r7:80b71638 r6:804e4c70 r5:80b6f3dc r4:00000000
[ 0.419628] [<804e20a0>] (bus_for_each_dev) from [<804e5440>] (driver_attach+0x28/0x30)
[ 0.419681] r6:00000000 r5:852abd20 r4:80b6f3dc
[ 0.419700] [<804e5418>] (driver_attach) from [<804e2ac0>] (bus_add_driver+0x114/0x200)
[ 0.419745] [<804e29ac>] (bus_add_driver) from [<804e5adc>] (driver_register+0x98/0x128)
[ 0.419798] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
[ 0.419818] [<804e5a44>] (driver_register) from [<804e7c2c>] (__platform_driver_register+0x2c/0x34)
[ 0.419874] r5:80c03e40 r4:80a1997c
[ 0.419890] [<804e7c00>] (__platform_driver_register) from [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
[ 0.419951] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from [<80a01408>] (do_one_initcall+0x64/0x144)
[ 0.420024] [<80a013a4>] (do_one_initcall) from [<80a016e4>] (kernel_init_freeable+0x198/0x218)
[ 0.420086] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
[ 0.420108] [<80a0154c>] (kernel_init_freeable) from [<807f0c28>] (kernel_init+0x20/0x134)
[ 0.420172] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:807f0c08
[ 0.420194] r4:00000000
[ 0.420211] [<807f0c08>] (kernel_init) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 0.420259] Exception stack(0x80cbdfb0 to 0x80cbdff8)
[ 0.420292] dfa0: 00000000 00000000 00000000 00000000
[ 0.420326] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 0.420356] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 0.420382] r5:807f0c08 r4:00000000
[ 0.420400] handlers:
[ 0.420417] [<(ptrval)>] aspeed_lpc_snoop_irq
[ 0.420482] Disabling IRQ #32
[ 0.638932] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
[ 0.643436] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32, base_baud = 1546875) is a 8250
[ 0.645555] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31, base_baud = 1500000) is a 16550A
[ 2.010064] Freeing initrd memory: 1072K
[ 2.232890] printk: console [ttyS4] enabled
[ 2.239349] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x6961cb32 @ 1us
[ 2.262322] loop: module loaded
[ 2.284029] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
[ 2.290471] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
[ 2.296451] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 - 0x24000000 ] 64MB
[ 2.303977] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 - 0x2a000000 ] 96MB
[ 2.311486] aspeed-smc 1e620000.spi: read control register: 203c0641
[ 2.542638] 5 fixed-partitions partitions found on MTD device bmc
[ 2.548875] Creating 5 MTD partitions on "bmc":
[ 2.553458] 0x000000000000-0x0000000e0000 : "u-boot"
[ 2.561247] 0x0000000e0000-0x000000100000 : "u-boot-env"
[ 2.569559] 0x000000100000-0x000000a00000 : "kernel"
[ 2.577301] 0x000000a00000-0x000002a00000 : "rofs"
[ 2.585054] 0x000002a00000-0x000004000000 : "rwfs"
[ 2.628232] libphy: Fixed MDIO Bus: probed
[ 2.634437] ftgmac100 1e660000.ethernet: Read MAC address d0:50:99:f4:1e:18 from chip
[ 2.651029] libphy: ftgmac100_mdio: probed
[ 2.656253] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00: attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
[ 2.669669] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 1ecc0872
[ 2.680442] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in USB2 mode
[ 2.688464] Mass Storage Function, version: 2009/09/11
[ 2.693666] LUN: removable file: (no medium)
[ 2.698021] no file given for LUN0
[ 2.701605] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start g_mass_storage: -22
[ 2.710113] i2c /dev entries driver
[ 2.715459] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered, irq 33
[ 2.724045] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered, irq 34
[ 2.733972] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered, irq 35
[ 2.742252] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered, irq 36
[ 2.750599] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered, irq 37
[ 2.759769] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered, irq 38
[ 2.767994] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered, irq 39
[ 2.777783] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16 bytes/write
[ 2.785096] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered, irq 40
[ 2.793373] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered, irq 41
[ 2.801709] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered, irq 42
[ 2.814947] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
[ 2.820929] i2c i2c-2: Added multiplexed i2c bus 14
[ 2.826513] i2c i2c-2: Added multiplexed i2c bus 15
[ 2.832192] i2c i2c-2: Added multiplexed i2c bus 16
[ 2.837821] i2c i2c-2: Added multiplexed i2c bus 17
[ 2.842944] pca954x 2-0070: registered 4 multiplexed busses for I2C switch pca9545
[ 2.852110] i2c i2c-5: Added multiplexed i2c bus 18
[ 2.857847] i2c i2c-5: Added multiplexed i2c bus 19
[ 2.863603] i2c i2c-5: Added multiplexed i2c bus 20
[ 2.869410] i2c i2c-5: Added multiplexed i2c bus 21
[ 2.874378] pca954x 5-0073: registered 4 multiplexed busses for I2C switch pca9545
[ 2.884631] Driver for 1-wire Dallas network protocol.
[ 3.009394] NET: Registered PF_INET6 protocol family
[ 3.017326] Segment Routing with IPv6
[ 3.021945] NET: Registered PF_PACKET protocol family
[ 3.027562] 8021q: 802.1Q VLAN Support v1.8
[ 3.263306] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 3.270074] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 3.278889] Hardware name: Generic DT based system
[ 3.283699] Workqueue: events_unbound deferred_probe_work_func
[ 3.289601] Backtrace:
[ 3.292079] [<807e64e4>] (dump_backtrace) from [<807e6738>] (show_stack+0x20/0x24)
[ 3.299716] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 3.305382] [<807e6718>] (show_stack) from [<807f09d0>] (dump_stack+0x28/0x30)
[ 3.312646] [<807f09a8>] (dump_stack) from [<807e76c0>] (__report_bad_irq+0x40/0xc0)
[ 3.320433] r5:00000000 r4:80d43900
[ 3.324022] [<807e7680>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 3.332349] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 3.340101] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 3.348242] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 3.356077] r4:80d43900 r3:00000400
[ 3.359660] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 3.368047] r5:00000000 r4:80d43900
[ 3.371629] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 3.380024] r5:00000000 r4:80b8e7c8
[ 3.383607] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 3.391919] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
[ 3.397586] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 3.405187] Exception stack(0x80cc7c50 to 0x80cc7c98)
[ 3.410262] 7c40: 00000000 00000000 00000000 00000000
[ 3.418458] 7c60: 80d43900 8529d180 85120d00 00000020 80d439a8 a0000013 00000000 80cc7ccc
[ 3.426647] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
[ 3.433271] r5:40000013 r4:80157d4c
[ 3.436854] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 3.445171] r9:8505fa20 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:85120d00
[ 3.452922] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 3.462366] r10:80d4ea20 r9:00000000 r8:8505fa20 r7:80d42c10 r6:00000020 r5:8044fd64
[ 3.470208] r4:851208e0 r3:00000080
[ 3.473792] [<8015bd08>] (devm_request_threaded_irq) from [<80450644>] (aspeed_kcs_probe+0x298/0x650)
[ 3.483072] r10:8505fa54 r9:80833650 r8:ffffffea r7:80d42c10 r6:00000020 r5:8505fa20
[ 3.490912] r4:80d42c00
[ 3.493456] [<804503ac>] (aspeed_kcs_probe) from [<804e6980>] (platform_probe+0x54/0x9c)
[ 3.501617] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10 r6:80b6e7b0 r5:80b6e7b0
[ 3.509458] r4:80d42c10
[ 3.512003] [<804e692c>] (platform_probe) from [<804e450c>] (really_probe+0x1c4/0x46c)
[ 3.519957] r5:00000000 r4:80d42c10
[ 3.523538] [<804e4348>] (really_probe) from [<804e4888>] (__driver_probe_device+0xd4/0x1bc)
[ 3.532017] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
[ 3.537682] [<804e47b4>] (__driver_probe_device) from [<804e49b0>] (driver_probe_device+0x40/0xd8)
[ 3.546683] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
[ 3.553386] [<804e4970>] (driver_probe_device) from [<804e4be0>] (__device_attach_driver+0xb8/0x148)
[ 3.562568] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84 r5:80b6e7b0 r4:00000001
[ 3.570313] [<804e4b28>] (__device_attach_driver) from [<804e2648>] (bus_for_each_drv+0x90/0xe0)
[ 3.579145] r7:80b71484 r6:804e4b28 r5:80cc7e84 r4:00000000
[ 3.584812] [<804e25b8>] (bus_for_each_drv) from [<804e4f3c>] (__device_attach+0x104/0x18c)
[ 3.593201] r6:80d42c54 r5:00000001 r4:80d42c10
[ 3.597828] [<804e4e38>] (__device_attach) from [<804e536c>] (device_initial_probe+0x1c/0x20)
[ 3.606390] r6:80d42c10 r5:80b71638 r4:80d4ca50
[ 3.611019] [<804e5350>] (device_initial_probe) from [<804e2860>] (bus_probe_device+0x94/0x9c)
[ 3.619662] [<804e27cc>] (bus_probe_device) from [<804e3f3c>] (deferred_probe_work_func+0xa0/0xe8)
[ 3.628657] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
[ 3.634324] [<804e3e9c>] (deferred_probe_work_func) from [<801301ac>] (process_one_work+0x1b4/0x46c)
[ 3.643506] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00 r6:00000040 r5:80c045a0
[ 3.651342] r4:80b7148c r3:804e3e9c
[ 3.654925] [<8012fff8>] (process_one_work) from [<8013066c>] (worker_thread+0x208/0x528)
[ 3.663145] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14 r6:80c045b4 r5:80c08a00
[ 3.670979] r4:80c045a0
[ 3.673524] [<80130464>] (worker_thread) from [<80136f18>] (kthread+0x138/0x160)
[ 3.680982] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0 r6:80130464 r5:80c03840
[ 3.688822] r4:80c02b80
[ 3.691369] [<80136de0>] (kthread) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 3.698633] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
[ 3.703707] 7fa0: 00000000 00000000 00000000 00000000
[ 3.711904] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 3.720091] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 3.726722] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:80136de0
[ 3.734559] r4:80c02b80 r3:00000000
[ 3.738142] handlers:
[ 3.740420] [<8337d287>] aspeed_lpc_snoop_irq
[ 3.744851] [<d8d6aeaf>] aspeed_kcs_irq
[ 3.748741] Disabling IRQ #32
[ 3.752597] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for channel 3
[ 3.760184] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for channel 3
[ 3.767235] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 0:04 ` Zev Weiss
@ 2021-11-03 0:17 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 0:17 UTC (permalink / raw)
To: Zev Weiss, Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
Hi Zev,
On 11/2/2021 5:04 PM, Zev Weiss wrote:
> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> Hello all,
>>>
>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>>
>>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>> can be registered ahead of lpc-ctrl depends on each system
>>> configuration and
>>> this difference introduces that LPC can be enabled without heart
>>> beating of
>>> LCLK so it causes improper handling on host interrupts when the host
>>> sends
>>> interrupts in that time frame. Then kernel eventually forcibly
>>> disables the
>>> interrupt with dumping stack and printing a 'nobody cared this irq'
>>> message
>>> out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>> individually
>>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>>> drivers.
>>
>> Thanks for sending this out!
>>
>> This will resolve a few of the issues we have in the issue tracker:
>>
>> https://github.com/openbmc/linux/issues/210
>> https://github.com/openbmc/linux/issues/130
>>
>> The patches look good to me. I think you've just missed Corey's PR for
>> v5.16, but I will stick them in the openbmc tree once they've had a
>> review.
>>
>
> Hi Jae,
>
> I tried this series out on the same in-progress OpenBMC port from issue
> number 210 linked above and am still seeing problems (dmesg pasted below).
>
> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
> routing to device tree") from linux-next to allow the first patch to
> apply cleanly; is there anything else I might be missing that'd be
> needed to test the series properly?
Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
which this series doesn't touch. Do you have below fix in your code
tree?
https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
Thanks,
Jae
>
> Thanks,
> Zev
>
> [ 0.417811] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 0.417858] CPU: 0 PID: 1 Comm: swapper Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 0.417899] Hardware name: Generic DT based system
> [ 0.417922] Backtrace: [ 0.417958] [<807e64e4>] (dump_backtrace)
> from [<807e6738>] (show_stack+0x20/0x24)
> [ 0.418052] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 0.418074] [<807e6718>] (show_stack) from [<807f09d0>]
> (dump_stack+0x28/0x30)
> [ 0.418133] [<807f09a8>] (dump_stack) from [<807e76c0>]
> (__report_bad_irq+0x40/0xc0)
> [ 0.418189] r5:00000000 r4:80d43900
> [ 0.418211] [<807e7680>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 0.418286] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 0.418307] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 0.418366] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 0.418390] r4:80d43900 r3:00000000
> [ 0.418408] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 0.418464] r5:00000000 r4:80d43900
> [ 0.418484] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 0.418539] r5:00000000 r4:80b8e7c8
> [ 0.418558] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 0.418618] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
> [ 0.418639] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 0.418685] Exception stack(0x80cbdc60 to 0x80cbdca8)
> [ 0.418722] dc60: 00000000 00000000 00000000 00000000 80d43900
> 00000000 8529d180 00000020
> [ 0.418756] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000
> 80cbdcb0 8015a520 80157d4c
> [ 0.418781] dca0: 40000053 ffffffff
> [ 0.418807] r5:40000053 r4:80157d4c
> [ 0.418824] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 0.418887] r9:852acb60 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:8529d180
> [ 0.418908] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 0.418979] r10:8092ed9c r9:00000000 r8:852acb60 r7:80d42410
> r6:00000020 r5:8045ff98
> [ 0.419004] r4:8529d760 r3:00000080
> [ 0.419021] [<8015bd08>] (devm_request_threaded_irq) from
> [<8046049c>] (aspeed_lpc_snoop_probe+0x110/0x2e0)
> [ 0.419116] r10:80bab000 r9:80d42410 r8:8529d140 r7:00000000
> r6:80d42400 r5:852acb60
> [ 0.419138] r4:00000000
> [ 0.419155] [<8046038c>] (aspeed_lpc_snoop_probe) from [<804e6980>]
> (platform_probe+0x54/0x9c)
> [ 0.419237] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc
> r5:80b6f3dc r4:80d42410
> [ 0.419259] [<804e692c>] (platform_probe) from [<804e450c>]
> (really_probe+0x1c4/0x46c)
> [ 0.419309] r5:00000000 r4:80d42410
> [ 0.419329] [<804e4348>] (really_probe) from [<804e4888>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 0.419381] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
> [ 0.419401] [<804e47b4>] (__driver_probe_device) from [<804e49b0>]
> (driver_probe_device+0x40/0xd8)
> [ 0.419460] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
> [ 0.419480] [<804e4970>] (driver_probe_device) from [<804e4d14>]
> (__driver_attach+0xa4/0x1c8)
> [ 0.419538] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc
> r5:80d42454 r4:80d42410
> [ 0.419556] [<804e4c70>] (__driver_attach) from [<804e2124>]
> (bus_for_each_dev+0x84/0xd0)
> [ 0.419608] r7:80b71638 r6:804e4c70 r5:80b6f3dc r4:00000000
> [ 0.419628] [<804e20a0>] (bus_for_each_dev) from [<804e5440>]
> (driver_attach+0x28/0x30)
> [ 0.419681] r6:00000000 r5:852abd20 r4:80b6f3dc
> [ 0.419700] [<804e5418>] (driver_attach) from [<804e2ac0>]
> (bus_add_driver+0x114/0x200)
> [ 0.419745] [<804e29ac>] (bus_add_driver) from [<804e5adc>]
> (driver_register+0x98/0x128)
> [ 0.419798] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
> [ 0.419818] [<804e5a44>] (driver_register) from [<804e7c2c>]
> (__platform_driver_register+0x2c/0x34)
> [ 0.419874] r5:80c03e40 r4:80a1997c
> [ 0.419890] [<804e7c00>] (__platform_driver_register) from
> [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
> [ 0.419951] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from
> [<80a01408>] (do_one_initcall+0x64/0x144)
> [ 0.420024] [<80a013a4>] (do_one_initcall) from [<80a016e4>]
> (kernel_init_freeable+0x198/0x218)
> [ 0.420086] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
> [ 0.420108] [<80a0154c>] (kernel_init_freeable) from [<807f0c28>]
> (kernel_init+0x20/0x134)
> [ 0.420172] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:807f0c08
> [ 0.420194] r4:00000000
> [ 0.420211] [<807f0c08>] (kernel_init) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 0.420259] Exception stack(0x80cbdfb0 to 0x80cbdff8)
> [ 0.420292] dfa0: 00000000
> 00000000 00000000 00000000
> [ 0.420326] dfc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.420356] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 0.420382] r5:807f0c08 r4:00000000
> [ 0.420400] handlers:
> [ 0.420417] [<(ptrval)>] aspeed_lpc_snoop_irq
> [ 0.420482] Disabling IRQ #32
> [ 0.638932] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
> [ 0.643436] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32,
> base_baud = 1546875) is a 8250
> [ 0.645555] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31,
> base_baud = 1500000) is a 16550A
> [ 2.010064] Freeing initrd memory: 1072K
> [ 2.232890] printk: console [ttyS4] enabled
> [ 2.239349] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x6961cb32 @ 1us
> [ 2.262322] loop: module loaded
> [ 2.284029] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
> [ 2.290471] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
> [ 2.296451] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 -
> 0x24000000 ] 64MB
> [ 2.303977] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 -
> 0x2a000000 ] 96MB
> [ 2.311486] aspeed-smc 1e620000.spi: read control register: 203c0641
> [ 2.542638] 5 fixed-partitions partitions found on MTD device bmc
> [ 2.548875] Creating 5 MTD partitions on "bmc":
> [ 2.553458] 0x000000000000-0x0000000e0000 : "u-boot"
> [ 2.561247] 0x0000000e0000-0x000000100000 : "u-boot-env"
> [ 2.569559] 0x000000100000-0x000000a00000 : "kernel"
> [ 2.577301] 0x000000a00000-0x000002a00000 : "rofs"
> [ 2.585054] 0x000002a00000-0x000004000000 : "rwfs"
> [ 2.628232] libphy: Fixed MDIO Bus: probed
> [ 2.634437] ftgmac100 1e660000.ethernet: Read MAC address
> d0:50:99:f4:1e:18 from chip
> [ 2.651029] libphy: ftgmac100_mdio: probed
> [ 2.656253] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00:
> attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
> [ 2.669669] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 1ecc0872
> [ 2.680442] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in
> USB2 mode
> [ 2.688464] Mass Storage Function, version: 2009/09/11
> [ 2.693666] LUN: removable file: (no medium)
> [ 2.698021] no file given for LUN0
> [ 2.701605] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start
> g_mass_storage: -22
> [ 2.710113] i2c /dev entries driver
> [ 2.715459] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered,
> irq 33
> [ 2.724045] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered,
> irq 34
> [ 2.733972] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered,
> irq 35
> [ 2.742252] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered,
> irq 36
> [ 2.750599] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered,
> irq 37
> [ 2.759769] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered,
> irq 38
> [ 2.767994] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered,
> irq 39
> [ 2.777783] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16
> bytes/write
> [ 2.785096] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered,
> irq 40
> [ 2.793373] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered,
> irq 41
> [ 2.801709] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered,
> irq 42
> [ 2.814947] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
> [ 2.820929] i2c i2c-2: Added multiplexed i2c bus 14
> [ 2.826513] i2c i2c-2: Added multiplexed i2c bus 15
> [ 2.832192] i2c i2c-2: Added multiplexed i2c bus 16
> [ 2.837821] i2c i2c-2: Added multiplexed i2c bus 17
> [ 2.842944] pca954x 2-0070: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.852110] i2c i2c-5: Added multiplexed i2c bus 18
> [ 2.857847] i2c i2c-5: Added multiplexed i2c bus 19
> [ 2.863603] i2c i2c-5: Added multiplexed i2c bus 20
> [ 2.869410] i2c i2c-5: Added multiplexed i2c bus 21
> [ 2.874378] pca954x 5-0073: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.884631] Driver for 1-wire Dallas network protocol.
> [ 3.009394] NET: Registered PF_INET6 protocol family
> [ 3.017326] Segment Routing with IPv6
> [ 3.021945] NET: Registered PF_PACKET protocol family
> [ 3.027562] 8021q: 802.1Q VLAN Support v1.8
> [ 3.263306] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 3.270074] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 3.278889] Hardware name: Generic DT based system
> [ 3.283699] Workqueue: events_unbound deferred_probe_work_func
> [ 3.289601] Backtrace: [ 3.292079] [<807e64e4>] (dump_backtrace)
> from [<807e6738>] (show_stack+0x20/0x24)
> [ 3.299716] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 3.305382] [<807e6718>] (show_stack) from [<807f09d0>]
> (dump_stack+0x28/0x30)
> [ 3.312646] [<807f09a8>] (dump_stack) from [<807e76c0>]
> (__report_bad_irq+0x40/0xc0)
> [ 3.320433] r5:00000000 r4:80d43900
> [ 3.324022] [<807e7680>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 3.332349] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 3.340101] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 3.348242] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 3.356077] r4:80d43900 r3:00000400
> [ 3.359660] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 3.368047] r5:00000000 r4:80d43900
> [ 3.371629] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 3.380024] r5:00000000 r4:80b8e7c8
> [ 3.383607] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 3.391919] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
> [ 3.397586] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 3.405187] Exception stack(0x80cc7c50 to 0x80cc7c98)
> [ 3.410262] 7c40: 00000000
> 00000000 00000000 00000000
> [ 3.418458] 7c60: 80d43900 8529d180 85120d00 00000020 80d439a8
> a0000013 00000000 80cc7ccc
> [ 3.426647] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
> [ 3.433271] r5:40000013 r4:80157d4c
> [ 3.436854] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 3.445171] r9:8505fa20 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:85120d00
> [ 3.452922] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 3.462366] r10:80d4ea20 r9:00000000 r8:8505fa20 r7:80d42c10
> r6:00000020 r5:8044fd64
> [ 3.470208] r4:851208e0 r3:00000080
> [ 3.473792] [<8015bd08>] (devm_request_threaded_irq) from
> [<80450644>] (aspeed_kcs_probe+0x298/0x650)
> [ 3.483072] r10:8505fa54 r9:80833650 r8:ffffffea r7:80d42c10
> r6:00000020 r5:8505fa20
> [ 3.490912] r4:80d42c00
> [ 3.493456] [<804503ac>] (aspeed_kcs_probe) from [<804e6980>]
> (platform_probe+0x54/0x9c)
> [ 3.501617] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10
> r6:80b6e7b0 r5:80b6e7b0
> [ 3.509458] r4:80d42c10
> [ 3.512003] [<804e692c>] (platform_probe) from [<804e450c>]
> (really_probe+0x1c4/0x46c)
> [ 3.519957] r5:00000000 r4:80d42c10
> [ 3.523538] [<804e4348>] (really_probe) from [<804e4888>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 3.532017] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
> [ 3.537682] [<804e47b4>] (__driver_probe_device) from [<804e49b0>]
> (driver_probe_device+0x40/0xd8)
> [ 3.546683] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
> [ 3.553386] [<804e4970>] (driver_probe_device) from [<804e4be0>]
> (__device_attach_driver+0xb8/0x148)
> [ 3.562568] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84
> r5:80b6e7b0 r4:00000001
> [ 3.570313] [<804e4b28>] (__device_attach_driver) from [<804e2648>]
> (bus_for_each_drv+0x90/0xe0)
> [ 3.579145] r7:80b71484 r6:804e4b28 r5:80cc7e84 r4:00000000
> [ 3.584812] [<804e25b8>] (bus_for_each_drv) from [<804e4f3c>]
> (__device_attach+0x104/0x18c)
> [ 3.593201] r6:80d42c54 r5:00000001 r4:80d42c10
> [ 3.597828] [<804e4e38>] (__device_attach) from [<804e536c>]
> (device_initial_probe+0x1c/0x20)
> [ 3.606390] r6:80d42c10 r5:80b71638 r4:80d4ca50
> [ 3.611019] [<804e5350>] (device_initial_probe) from [<804e2860>]
> (bus_probe_device+0x94/0x9c)
> [ 3.619662] [<804e27cc>] (bus_probe_device) from [<804e3f3c>]
> (deferred_probe_work_func+0xa0/0xe8)
> [ 3.628657] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
> [ 3.634324] [<804e3e9c>] (deferred_probe_work_func) from [<801301ac>]
> (process_one_work+0x1b4/0x46c)
> [ 3.643506] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00
> r6:00000040 r5:80c045a0
> [ 3.651342] r4:80b7148c r3:804e3e9c
> [ 3.654925] [<8012fff8>] (process_one_work) from [<8013066c>]
> (worker_thread+0x208/0x528)
> [ 3.663145] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14
> r6:80c045b4 r5:80c08a00
> [ 3.670979] r4:80c045a0
> [ 3.673524] [<80130464>] (worker_thread) from [<80136f18>]
> (kthread+0x138/0x160)
> [ 3.680982] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0
> r6:80130464 r5:80c03840
> [ 3.688822] r4:80c02b80
> [ 3.691369] [<80136de0>] (kthread) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 3.698633] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
> [ 3.703707] 7fa0: 00000000
> 00000000 00000000 00000000
> [ 3.711904] 7fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 3.720091] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 3.726722] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:80136de0
> [ 3.734559] r4:80c02b80 r3:00000000
> [ 3.738142] handlers:
> [ 3.740420] [<8337d287>] aspeed_lpc_snoop_irq
> [ 3.744851] [<d8d6aeaf>] aspeed_kcs_irq
> [ 3.748741] Disabling IRQ #32
> [ 3.752597] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for
> channel 3
> [ 3.760184] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for
> channel 3
> [ 3.767235] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 0:17 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 0:17 UTC (permalink / raw)
To: Zev Weiss, Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
Hi Zev,
On 11/2/2021 5:04 PM, Zev Weiss wrote:
> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> Hello all,
>>>
>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>>
>>> An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>> can be registered ahead of lpc-ctrl depends on each system
>>> configuration and
>>> this difference introduces that LPC can be enabled without heart
>>> beating of
>>> LCLK so it causes improper handling on host interrupts when the host
>>> sends
>>> interrupts in that time frame. Then kernel eventually forcibly
>>> disables the
>>> interrupt with dumping stack and printing a 'nobody cared this irq'
>>> message
>>> out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>> individually
>>> so this patch adds clock control logic into the remaining Aspeed LPC sub
>>> drivers.
>>
>> Thanks for sending this out!
>>
>> This will resolve a few of the issues we have in the issue tracker:
>>
>> https://github.com/openbmc/linux/issues/210
>> https://github.com/openbmc/linux/issues/130
>>
>> The patches look good to me. I think you've just missed Corey's PR for
>> v5.16, but I will stick them in the openbmc tree once they've had a
>> review.
>>
>
> Hi Jae,
>
> I tried this series out on the same in-progress OpenBMC port from issue
> number 210 linked above and am still seeing problems (dmesg pasted below).
>
> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
> routing to device tree") from linux-next to allow the first patch to
> apply cleanly; is there anything else I might be missing that'd be
> needed to test the series properly?
Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
which this series doesn't touch. Do you have below fix in your code
tree?
https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
Thanks,
Jae
>
> Thanks,
> Zev
>
> [ 0.417811] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 0.417858] CPU: 0 PID: 1 Comm: swapper Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 0.417899] Hardware name: Generic DT based system
> [ 0.417922] Backtrace: [ 0.417958] [<807e64e4>] (dump_backtrace)
> from [<807e6738>] (show_stack+0x20/0x24)
> [ 0.418052] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 0.418074] [<807e6718>] (show_stack) from [<807f09d0>]
> (dump_stack+0x28/0x30)
> [ 0.418133] [<807f09a8>] (dump_stack) from [<807e76c0>]
> (__report_bad_irq+0x40/0xc0)
> [ 0.418189] r5:00000000 r4:80d43900
> [ 0.418211] [<807e7680>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 0.418286] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 0.418307] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 0.418366] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 0.418390] r4:80d43900 r3:00000000
> [ 0.418408] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 0.418464] r5:00000000 r4:80d43900
> [ 0.418484] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 0.418539] r5:00000000 r4:80b8e7c8
> [ 0.418558] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 0.418618] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
> [ 0.418639] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 0.418685] Exception stack(0x80cbdc60 to 0x80cbdca8)
> [ 0.418722] dc60: 00000000 00000000 00000000 00000000 80d43900
> 00000000 8529d180 00000020
> [ 0.418756] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000
> 80cbdcb0 8015a520 80157d4c
> [ 0.418781] dca0: 40000053 ffffffff
> [ 0.418807] r5:40000053 r4:80157d4c
> [ 0.418824] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 0.418887] r9:852acb60 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:8529d180
> [ 0.418908] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 0.418979] r10:8092ed9c r9:00000000 r8:852acb60 r7:80d42410
> r6:00000020 r5:8045ff98
> [ 0.419004] r4:8529d760 r3:00000080
> [ 0.419021] [<8015bd08>] (devm_request_threaded_irq) from
> [<8046049c>] (aspeed_lpc_snoop_probe+0x110/0x2e0)
> [ 0.419116] r10:80bab000 r9:80d42410 r8:8529d140 r7:00000000
> r6:80d42400 r5:852acb60
> [ 0.419138] r4:00000000
> [ 0.419155] [<8046038c>] (aspeed_lpc_snoop_probe) from [<804e6980>]
> (platform_probe+0x54/0x9c)
> [ 0.419237] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc
> r5:80b6f3dc r4:80d42410
> [ 0.419259] [<804e692c>] (platform_probe) from [<804e450c>]
> (really_probe+0x1c4/0x46c)
> [ 0.419309] r5:00000000 r4:80d42410
> [ 0.419329] [<804e4348>] (really_probe) from [<804e4888>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 0.419381] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
> [ 0.419401] [<804e47b4>] (__driver_probe_device) from [<804e49b0>]
> (driver_probe_device+0x40/0xd8)
> [ 0.419460] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
> [ 0.419480] [<804e4970>] (driver_probe_device) from [<804e4d14>]
> (__driver_attach+0xa4/0x1c8)
> [ 0.419538] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc
> r5:80d42454 r4:80d42410
> [ 0.419556] [<804e4c70>] (__driver_attach) from [<804e2124>]
> (bus_for_each_dev+0x84/0xd0)
> [ 0.419608] r7:80b71638 r6:804e4c70 r5:80b6f3dc r4:00000000
> [ 0.419628] [<804e20a0>] (bus_for_each_dev) from [<804e5440>]
> (driver_attach+0x28/0x30)
> [ 0.419681] r6:00000000 r5:852abd20 r4:80b6f3dc
> [ 0.419700] [<804e5418>] (driver_attach) from [<804e2ac0>]
> (bus_add_driver+0x114/0x200)
> [ 0.419745] [<804e29ac>] (bus_add_driver) from [<804e5adc>]
> (driver_register+0x98/0x128)
> [ 0.419798] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
> [ 0.419818] [<804e5a44>] (driver_register) from [<804e7c2c>]
> (__platform_driver_register+0x2c/0x34)
> [ 0.419874] r5:80c03e40 r4:80a1997c
> [ 0.419890] [<804e7c00>] (__platform_driver_register) from
> [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
> [ 0.419951] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from
> [<80a01408>] (do_one_initcall+0x64/0x144)
> [ 0.420024] [<80a013a4>] (do_one_initcall) from [<80a016e4>]
> (kernel_init_freeable+0x198/0x218)
> [ 0.420086] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
> [ 0.420108] [<80a0154c>] (kernel_init_freeable) from [<807f0c28>]
> (kernel_init+0x20/0x134)
> [ 0.420172] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:807f0c08
> [ 0.420194] r4:00000000
> [ 0.420211] [<807f0c08>] (kernel_init) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 0.420259] Exception stack(0x80cbdfb0 to 0x80cbdff8)
> [ 0.420292] dfa0: 00000000
> 00000000 00000000 00000000
> [ 0.420326] dfc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.420356] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 0.420382] r5:807f0c08 r4:00000000
> [ 0.420400] handlers:
> [ 0.420417] [<(ptrval)>] aspeed_lpc_snoop_irq
> [ 0.420482] Disabling IRQ #32
> [ 0.638932] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
> [ 0.643436] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32,
> base_baud = 1546875) is a 8250
> [ 0.645555] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31,
> base_baud = 1500000) is a 16550A
> [ 2.010064] Freeing initrd memory: 1072K
> [ 2.232890] printk: console [ttyS4] enabled
> [ 2.239349] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x6961cb32 @ 1us
> [ 2.262322] loop: module loaded
> [ 2.284029] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
> [ 2.290471] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
> [ 2.296451] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 -
> 0x24000000 ] 64MB
> [ 2.303977] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 -
> 0x2a000000 ] 96MB
> [ 2.311486] aspeed-smc 1e620000.spi: read control register: 203c0641
> [ 2.542638] 5 fixed-partitions partitions found on MTD device bmc
> [ 2.548875] Creating 5 MTD partitions on "bmc":
> [ 2.553458] 0x000000000000-0x0000000e0000 : "u-boot"
> [ 2.561247] 0x0000000e0000-0x000000100000 : "u-boot-env"
> [ 2.569559] 0x000000100000-0x000000a00000 : "kernel"
> [ 2.577301] 0x000000a00000-0x000002a00000 : "rofs"
> [ 2.585054] 0x000002a00000-0x000004000000 : "rwfs"
> [ 2.628232] libphy: Fixed MDIO Bus: probed
> [ 2.634437] ftgmac100 1e660000.ethernet: Read MAC address
> d0:50:99:f4:1e:18 from chip
> [ 2.651029] libphy: ftgmac100_mdio: probed
> [ 2.656253] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00:
> attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
> [ 2.669669] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 1ecc0872
> [ 2.680442] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in
> USB2 mode
> [ 2.688464] Mass Storage Function, version: 2009/09/11
> [ 2.693666] LUN: removable file: (no medium)
> [ 2.698021] no file given for LUN0
> [ 2.701605] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start
> g_mass_storage: -22
> [ 2.710113] i2c /dev entries driver
> [ 2.715459] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered,
> irq 33
> [ 2.724045] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered,
> irq 34
> [ 2.733972] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered,
> irq 35
> [ 2.742252] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered,
> irq 36
> [ 2.750599] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered,
> irq 37
> [ 2.759769] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered,
> irq 38
> [ 2.767994] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered,
> irq 39
> [ 2.777783] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16
> bytes/write
> [ 2.785096] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered,
> irq 40
> [ 2.793373] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered,
> irq 41
> [ 2.801709] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered,
> irq 42
> [ 2.814947] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
> [ 2.820929] i2c i2c-2: Added multiplexed i2c bus 14
> [ 2.826513] i2c i2c-2: Added multiplexed i2c bus 15
> [ 2.832192] i2c i2c-2: Added multiplexed i2c bus 16
> [ 2.837821] i2c i2c-2: Added multiplexed i2c bus 17
> [ 2.842944] pca954x 2-0070: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.852110] i2c i2c-5: Added multiplexed i2c bus 18
> [ 2.857847] i2c i2c-5: Added multiplexed i2c bus 19
> [ 2.863603] i2c i2c-5: Added multiplexed i2c bus 20
> [ 2.869410] i2c i2c-5: Added multiplexed i2c bus 21
> [ 2.874378] pca954x 5-0073: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.884631] Driver for 1-wire Dallas network protocol.
> [ 3.009394] NET: Registered PF_INET6 protocol family
> [ 3.017326] Segment Routing with IPv6
> [ 3.021945] NET: Registered PF_PACKET protocol family
> [ 3.027562] 8021q: 802.1Q VLAN Support v1.8
> [ 3.263306] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 3.270074] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 3.278889] Hardware name: Generic DT based system
> [ 3.283699] Workqueue: events_unbound deferred_probe_work_func
> [ 3.289601] Backtrace: [ 3.292079] [<807e64e4>] (dump_backtrace)
> from [<807e6738>] (show_stack+0x20/0x24)
> [ 3.299716] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 3.305382] [<807e6718>] (show_stack) from [<807f09d0>]
> (dump_stack+0x28/0x30)
> [ 3.312646] [<807f09a8>] (dump_stack) from [<807e76c0>]
> (__report_bad_irq+0x40/0xc0)
> [ 3.320433] r5:00000000 r4:80d43900
> [ 3.324022] [<807e7680>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 3.332349] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 3.340101] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 3.348242] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 3.356077] r4:80d43900 r3:00000400
> [ 3.359660] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 3.368047] r5:00000000 r4:80d43900
> [ 3.371629] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 3.380024] r5:00000000 r4:80b8e7c8
> [ 3.383607] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 3.391919] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
> [ 3.397586] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 3.405187] Exception stack(0x80cc7c50 to 0x80cc7c98)
> [ 3.410262] 7c40: 00000000
> 00000000 00000000 00000000
> [ 3.418458] 7c60: 80d43900 8529d180 85120d00 00000020 80d439a8
> a0000013 00000000 80cc7ccc
> [ 3.426647] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
> [ 3.433271] r5:40000013 r4:80157d4c
> [ 3.436854] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 3.445171] r9:8505fa20 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:85120d00
> [ 3.452922] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 3.462366] r10:80d4ea20 r9:00000000 r8:8505fa20 r7:80d42c10
> r6:00000020 r5:8044fd64
> [ 3.470208] r4:851208e0 r3:00000080
> [ 3.473792] [<8015bd08>] (devm_request_threaded_irq) from
> [<80450644>] (aspeed_kcs_probe+0x298/0x650)
> [ 3.483072] r10:8505fa54 r9:80833650 r8:ffffffea r7:80d42c10
> r6:00000020 r5:8505fa20
> [ 3.490912] r4:80d42c00
> [ 3.493456] [<804503ac>] (aspeed_kcs_probe) from [<804e6980>]
> (platform_probe+0x54/0x9c)
> [ 3.501617] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10
> r6:80b6e7b0 r5:80b6e7b0
> [ 3.509458] r4:80d42c10
> [ 3.512003] [<804e692c>] (platform_probe) from [<804e450c>]
> (really_probe+0x1c4/0x46c)
> [ 3.519957] r5:00000000 r4:80d42c10
> [ 3.523538] [<804e4348>] (really_probe) from [<804e4888>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 3.532017] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
> [ 3.537682] [<804e47b4>] (__driver_probe_device) from [<804e49b0>]
> (driver_probe_device+0x40/0xd8)
> [ 3.546683] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
> [ 3.553386] [<804e4970>] (driver_probe_device) from [<804e4be0>]
> (__device_attach_driver+0xb8/0x148)
> [ 3.562568] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84
> r5:80b6e7b0 r4:00000001
> [ 3.570313] [<804e4b28>] (__device_attach_driver) from [<804e2648>]
> (bus_for_each_drv+0x90/0xe0)
> [ 3.579145] r7:80b71484 r6:804e4b28 r5:80cc7e84 r4:00000000
> [ 3.584812] [<804e25b8>] (bus_for_each_drv) from [<804e4f3c>]
> (__device_attach+0x104/0x18c)
> [ 3.593201] r6:80d42c54 r5:00000001 r4:80d42c10
> [ 3.597828] [<804e4e38>] (__device_attach) from [<804e536c>]
> (device_initial_probe+0x1c/0x20)
> [ 3.606390] r6:80d42c10 r5:80b71638 r4:80d4ca50
> [ 3.611019] [<804e5350>] (device_initial_probe) from [<804e2860>]
> (bus_probe_device+0x94/0x9c)
> [ 3.619662] [<804e27cc>] (bus_probe_device) from [<804e3f3c>]
> (deferred_probe_work_func+0xa0/0xe8)
> [ 3.628657] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
> [ 3.634324] [<804e3e9c>] (deferred_probe_work_func) from [<801301ac>]
> (process_one_work+0x1b4/0x46c)
> [ 3.643506] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00
> r6:00000040 r5:80c045a0
> [ 3.651342] r4:80b7148c r3:804e3e9c
> [ 3.654925] [<8012fff8>] (process_one_work) from [<8013066c>]
> (worker_thread+0x208/0x528)
> [ 3.663145] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14
> r6:80c045b4 r5:80c08a00
> [ 3.670979] r4:80c045a0
> [ 3.673524] [<80130464>] (worker_thread) from [<80136f18>]
> (kthread+0x138/0x160)
> [ 3.680982] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0
> r6:80130464 r5:80c03840
> [ 3.688822] r4:80c02b80
> [ 3.691369] [<80136de0>] (kthread) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 3.698633] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
> [ 3.703707] 7fa0: 00000000
> 00000000 00000000 00000000
> [ 3.711904] 7fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 3.720091] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 3.726722] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:80136de0
> [ 3.734559] r4:80c02b80 r3:00000000
> [ 3.738142] handlers:
> [ 3.740420] [<8337d287>] aspeed_lpc_snoop_irq
> [ 3.744851] [<d8d6aeaf>] aspeed_kcs_irq
> [ 3.748741] Disabling IRQ #32
> [ 3.752597] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for
> channel 3
> [ 3.760184] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for
> channel 3
> [ 3.767235] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 0:17 ` Jae Hyun Yoo
@ 2021-11-03 0:30 ` Zev Weiss
-1 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 0:30 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>Hi Zev,
>
>On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>
>>>>From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>
>>>>Hello all,
>>>>
>>>>This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>
>>>>
>>>>An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>>>can be registered ahead of lpc-ctrl depends on each system
>>>>configuration and
>>>>this difference introduces that LPC can be enabled without heart
>>>>beating of
>>>>LCLK so it causes improper handling on host interrupts when the
>>>>host sends
>>>>interrupts in that time frame. Then kernel eventually forcibly
>>>>disables the
>>>>interrupt with dumping stack and printing a 'nobody cared this
>>>>irq' message
>>>>out.
>>>>
>>>>To prevent this issue, all LPC sub drivers should enable LCLK
>>>>individually
>>>>so this patch adds clock control logic into the remaining Aspeed LPC sub
>>>>drivers.
>>>
>>>Thanks for sending this out!
>>>
>>>This will resolve a few of the issues we have in the issue tracker:
>>>
>>>https://github.com/openbmc/linux/issues/210
>>>https://github.com/openbmc/linux/issues/130
>>>
>>>The patches look good to me. I think you've just missed Corey's PR for
>>>v5.16, but I will stick them in the openbmc tree once they've had a
>>>review.
>>>
>>
>>Hi Jae,
>>
>>I tried this series out on the same in-progress OpenBMC port from
>>issue number 210 linked above and am still seeing problems (dmesg
>>pasted below).
>>
>>I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>routing to device tree") from linux-next to allow the first patch to
>>apply cleanly; is there anything else I might be missing that'd be
>>needed to test the series properly?
>
>Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>which this series doesn't touch. Do you have below fix in your code
>tree?
>
>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>
>Thanks,
>Jae
>
Yes, I've got that patch (commit 3f94cf1558), and the accompanying dts
update to add the clocks property to the lpc-snoop device (commit
d050d049f8).
However, while there is an aspeed_lpc_snoop_probe() backtrace there,
note that there's *also* one from aspeed_kcs_probe() further on
(starting at timestamp 3.263306).
Zev
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 0:30 ` Zev Weiss
0 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 0:30 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>Hi Zev,
>
>On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>
>>>>From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>
>>>>Hello all,
>>>>
>>>>This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>
>>>>
>>>>An LPC sub driver can be enabled without using the lpc-ctrl driver or it
>>>>can be registered ahead of lpc-ctrl depends on each system
>>>>configuration and
>>>>this difference introduces that LPC can be enabled without heart
>>>>beating of
>>>>LCLK so it causes improper handling on host interrupts when the
>>>>host sends
>>>>interrupts in that time frame. Then kernel eventually forcibly
>>>>disables the
>>>>interrupt with dumping stack and printing a 'nobody cared this
>>>>irq' message
>>>>out.
>>>>
>>>>To prevent this issue, all LPC sub drivers should enable LCLK
>>>>individually
>>>>so this patch adds clock control logic into the remaining Aspeed LPC sub
>>>>drivers.
>>>
>>>Thanks for sending this out!
>>>
>>>This will resolve a few of the issues we have in the issue tracker:
>>>
>>>https://github.com/openbmc/linux/issues/210
>>>https://github.com/openbmc/linux/issues/130
>>>
>>>The patches look good to me. I think you've just missed Corey's PR for
>>>v5.16, but I will stick them in the openbmc tree once they've had a
>>>review.
>>>
>>
>>Hi Jae,
>>
>>I tried this series out on the same in-progress OpenBMC port from
>>issue number 210 linked above and am still seeing problems (dmesg
>>pasted below).
>>
>>I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>routing to device tree") from linux-next to allow the first patch to
>>apply cleanly; is there anything else I might be missing that'd be
>>needed to test the series properly?
>
>Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>which this series doesn't touch. Do you have below fix in your code
>tree?
>
>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>
>Thanks,
>Jae
>
Yes, I've got that patch (commit 3f94cf1558), and the accompanying dts
update to add the clocks property to the lpc-snoop device (commit
d050d049f8).
However, while there is an aspeed_lpc_snoop_probe() backtrace there,
note that there's *also* one from aspeed_kcs_probe() further on
(starting at timestamp 3.263306).
Zev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 0:30 ` Zev Weiss
@ 2021-11-03 0:54 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 0:54 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/2/2021 5:30 PM, Zev Weiss wrote:
> On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>> Hi Zev,
>>
>> On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>
>>>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>
>>>>> Hello all,
>>>>>
>>>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>
>>>>>
>>>>>
>>>>> An LPC sub driver can be enabled without using the lpc-ctrl driver
>>>>> or it
>>>>> can be registered ahead of lpc-ctrl depends on each system
>>>>> configuration and
>>>>> this difference introduces that LPC can be enabled without heart
>>>>> beating of
>>>>> LCLK so it causes improper handling on host interrupts when the
>>>>> host sends
>>>>> interrupts in that time frame. Then kernel eventually forcibly
>>>>> disables the
>>>>> interrupt with dumping stack and printing a 'nobody cared this irq'
>>>>> message
>>>>> out.
>>>>>
>>>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>>>> individually
>>>>> so this patch adds clock control logic into the remaining Aspeed
>>>>> LPC sub
>>>>> drivers.
>>>>
>>>> Thanks for sending this out!
>>>>
>>>> This will resolve a few of the issues we have in the issue tracker:
>>>>
>>>> https://github.com/openbmc/linux/issues/210
>>>> https://github.com/openbmc/linux/issues/130
>>>>
>>>> The patches look good to me. I think you've just missed Corey's PR for
>>>> v5.16, but I will stick them in the openbmc tree once they've had a
>>>> review.
>>>>
>>>
>>> Hi Jae,
>>>
>>> I tried this series out on the same in-progress OpenBMC port from
>>> issue number 210 linked above and am still seeing problems (dmesg
>>> pasted below).
>>>
>>> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>> routing to device tree") from linux-next to allow the first patch to
>>> apply cleanly; is there anything else I might be missing that'd be
>>> needed to test the series properly?
>>
>> Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>> which this series doesn't touch. Do you have below fix in your code
>> tree?
>>
>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>
>>
>> Thanks,
>> Jae
>>
>
> Yes, I've got that patch (commit 3f94cf1558), and the accompanying dts
> update to add the clocks property to the lpc-snoop device (commit
> d050d049f8).
>
> However, while there is an aspeed_lpc_snoop_probe() backtrace there,
> note that there's *also* one from aspeed_kcs_probe() further on
> (starting at timestamp 3.263306).
>
>
> Zev
>
Can you please test additional changes below?
Thanks,
Jae
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c
b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 00706472cc4d..af03aea0f3ce 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -644,6 +644,17 @@ static int aspeed_kcs_probe(struct platform_device
*pdev)
if (rc)
goto err;
+ platform_set_drvdata(pdev, priv);
+
+ aspeed_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF |
KCS_BMC_EVENT_TYPE_OBE), 0);
+ aspeed_kcs_enable_channel(kcs_bmc, true);
+
+ rc = kcs_bmc_add_device(&priv->kcs_bmc);
+ if (rc) {
+ dev_warn(&pdev->dev, "Failed to register channel %d:
%d\n", kcs_bmc->channel, rc);
+ goto err;
+ }
+
/* Host to BMC IRQ */
rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
if (rc)
@@ -658,17 +669,6 @@ static int aspeed_kcs_probe(struct platform_device
*pdev)
priv->upstream_irq.mode = aspeed_kcs_irq_none;
}
- platform_set_drvdata(pdev, priv);
-
- aspeed_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF |
KCS_BMC_EVENT_TYPE_OBE), 0);
- aspeed_kcs_enable_channel(kcs_bmc, true);
-
- rc = kcs_bmc_add_device(&priv->kcs_bmc);
- if (rc) {
- dev_warn(&pdev->dev, "Failed to register channel %d:
%d\n", kcs_bmc->channel, rc);
- goto err;
- }
-
dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
kcs_bmc->channel, addrs[0]);
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c
b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index eceeaf8dfbeb..044c8f6665b7 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -306,10 +306,6 @@ static int aspeed_lpc_snoop_probe(struct
platform_device *pdev)
return rc;
}
- rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev);
- if (rc)
- goto err;
-
rc = aspeed_lpc_enable_snoop(lpc_snoop, dev, 0, port);
if (rc)
goto err;
@@ -324,6 +320,10 @@ static int aspeed_lpc_snoop_probe(struct
platform_device *pdev)
}
}
+ rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev);
+ if (rc)
+ goto err;
+
return 0;
err:
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 0:54 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 0:54 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/2/2021 5:30 PM, Zev Weiss wrote:
> On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>> Hi Zev,
>>
>> On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>
>>>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>
>>>>> Hello all,
>>>>>
>>>>> This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>
>>>>>
>>>>>
>>>>> An LPC sub driver can be enabled without using the lpc-ctrl driver
>>>>> or it
>>>>> can be registered ahead of lpc-ctrl depends on each system
>>>>> configuration and
>>>>> this difference introduces that LPC can be enabled without heart
>>>>> beating of
>>>>> LCLK so it causes improper handling on host interrupts when the
>>>>> host sends
>>>>> interrupts in that time frame. Then kernel eventually forcibly
>>>>> disables the
>>>>> interrupt with dumping stack and printing a 'nobody cared this irq'
>>>>> message
>>>>> out.
>>>>>
>>>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>>>> individually
>>>>> so this patch adds clock control logic into the remaining Aspeed
>>>>> LPC sub
>>>>> drivers.
>>>>
>>>> Thanks for sending this out!
>>>>
>>>> This will resolve a few of the issues we have in the issue tracker:
>>>>
>>>> https://github.com/openbmc/linux/issues/210
>>>> https://github.com/openbmc/linux/issues/130
>>>>
>>>> The patches look good to me. I think you've just missed Corey's PR for
>>>> v5.16, but I will stick them in the openbmc tree once they've had a
>>>> review.
>>>>
>>>
>>> Hi Jae,
>>>
>>> I tried this series out on the same in-progress OpenBMC port from
>>> issue number 210 linked above and am still seeing problems (dmesg
>>> pasted below).
>>>
>>> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>> routing to device tree") from linux-next to allow the first patch to
>>> apply cleanly; is there anything else I might be missing that'd be
>>> needed to test the series properly?
>>
>> Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>> which this series doesn't touch. Do you have below fix in your code
>> tree?
>>
>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>
>>
>> Thanks,
>> Jae
>>
>
> Yes, I've got that patch (commit 3f94cf1558), and the accompanying dts
> update to add the clocks property to the lpc-snoop device (commit
> d050d049f8).
>
> However, while there is an aspeed_lpc_snoop_probe() backtrace there,
> note that there's *also* one from aspeed_kcs_probe() further on
> (starting at timestamp 3.263306).
>
>
> Zev
>
Can you please test additional changes below?
Thanks,
Jae
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c
b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 00706472cc4d..af03aea0f3ce 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -644,6 +644,17 @@ static int aspeed_kcs_probe(struct platform_device
*pdev)
if (rc)
goto err;
+ platform_set_drvdata(pdev, priv);
+
+ aspeed_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF |
KCS_BMC_EVENT_TYPE_OBE), 0);
+ aspeed_kcs_enable_channel(kcs_bmc, true);
+
+ rc = kcs_bmc_add_device(&priv->kcs_bmc);
+ if (rc) {
+ dev_warn(&pdev->dev, "Failed to register channel %d:
%d\n", kcs_bmc->channel, rc);
+ goto err;
+ }
+
/* Host to BMC IRQ */
rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
if (rc)
@@ -658,17 +669,6 @@ static int aspeed_kcs_probe(struct platform_device
*pdev)
priv->upstream_irq.mode = aspeed_kcs_irq_none;
}
- platform_set_drvdata(pdev, priv);
-
- aspeed_kcs_irq_mask_update(kcs_bmc, (KCS_BMC_EVENT_TYPE_IBF |
KCS_BMC_EVENT_TYPE_OBE), 0);
- aspeed_kcs_enable_channel(kcs_bmc, true);
-
- rc = kcs_bmc_add_device(&priv->kcs_bmc);
- if (rc) {
- dev_warn(&pdev->dev, "Failed to register channel %d:
%d\n", kcs_bmc->channel, rc);
- goto err;
- }
-
dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
kcs_bmc->channel, addrs[0]);
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c
b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index eceeaf8dfbeb..044c8f6665b7 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -306,10 +306,6 @@ static int aspeed_lpc_snoop_probe(struct
platform_device *pdev)
return rc;
}
- rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev);
- if (rc)
- goto err;
-
rc = aspeed_lpc_enable_snoop(lpc_snoop, dev, 0, port);
if (rc)
goto err;
@@ -324,6 +320,10 @@ static int aspeed_lpc_snoop_probe(struct
platform_device *pdev)
}
}
+ rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev);
+ if (rc)
+ goto err;
+
return 0;
err:
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 0:54 ` Jae Hyun Yoo
@ 2021-11-03 1:09 ` Zev Weiss
-1 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 1:09 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Tue, Nov 02, 2021 at 05:54:30PM PDT, Jae Hyun Yoo wrote:
>
>
>On 11/2/2021 5:30 PM, Zev Weiss wrote:
>>On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>>>Hi Zev,
>>>
>>>On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>>>On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>>>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>>
>>>>>>From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>>
>>>>>>Hello all,
>>>>>>
>>>>>>This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>>
>>>>>>
>>>>>>
>>>>>>An LPC sub driver can be enabled without using the lpc-ctrl
>>>>>>driver or it
>>>>>>can be registered ahead of lpc-ctrl depends on each system
>>>>>>configuration and
>>>>>>this difference introduces that LPC can be enabled without
>>>>>>heart beating of
>>>>>>LCLK so it causes improper handling on host interrupts when
>>>>>>the host sends
>>>>>>interrupts in that time frame. Then kernel eventually
>>>>>>forcibly disables the
>>>>>>interrupt with dumping stack and printing a 'nobody cared
>>>>>>this irq' message
>>>>>>out.
>>>>>>
>>>>>>To prevent this issue, all LPC sub drivers should enable
>>>>>>LCLK individually
>>>>>>so this patch adds clock control logic into the remaining
>>>>>>Aspeed LPC sub
>>>>>>drivers.
>>>>>
>>>>>Thanks for sending this out!
>>>>>
>>>>>This will resolve a few of the issues we have in the issue tracker:
>>>>>
>>>>>https://github.com/openbmc/linux/issues/210
>>>>>https://github.com/openbmc/linux/issues/130
>>>>>
>>>>>The patches look good to me. I think you've just missed Corey's PR for
>>>>>v5.16, but I will stick them in the openbmc tree once they've had a
>>>>>review.
>>>>>
>>>>
>>>>Hi Jae,
>>>>
>>>>I tried this series out on the same in-progress OpenBMC port
>>>>from issue number 210 linked above and am still seeing problems
>>>>(dmesg pasted below).
>>>>
>>>>I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add
>>>>uart routing to device tree") from linux-next to allow the first
>>>>patch to apply cleanly; is there anything else I might be
>>>>missing that'd be needed to test the series properly?
>>>
>>>Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>>>which this series doesn't touch. Do you have below fix in your code
>>>tree?
>>>
>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>>
>>>Thanks,
>>>Jae
>>>
>>
>>Yes, I've got that patch (commit 3f94cf1558), and the accompanying
>>dts update to add the clocks property to the lpc-snoop device
>>(commit d050d049f8).
>>
>>However, while there is an aspeed_lpc_snoop_probe() backtrace there,
>>note that there's *also* one from aspeed_kcs_probe() further on
>>(starting at timestamp 3.263306).
>>
>>
>>Zev
>>
>
>Can you please test additional changes below?
>
No clear improvement with that unfortunately (note that the formatting
of the patch got pretty mangled there and required a lot of manual
tweaking to apply, but I think I tested the intended thing).
dmesg results below.
Zev
[ 0.425073] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 0.425118] CPU: 0 PID: 1 Comm: swapper Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 0.425161] Hardware name: Generic DT based system
[ 0.425185] Backtrace:
[ 0.425219] [<807e6504>] (dump_backtrace) from [<807e6758>] (show_stack+0x20/0x24)
[ 0.425315] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 0.425339] [<807e6738>] (show_stack) from [<807f09f0>] (dump_stack+0x28/0x30)
[ 0.425397] [<807f09c8>] (dump_stack) from [<807e76e0>] (__report_bad_irq+0x40/0xc0)
[ 0.425454] r5:00000000 r4:80d43900
[ 0.425473] [<807e76a0>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 0.425555] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 0.425577] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 0.425637] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 0.425663] r4:80d43900 r3:00000000
[ 0.425681] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 0.425738] r5:00000000 r4:80d43900
[ 0.425758] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 0.425811] r5:00000000 r4:80b8e7c8
[ 0.425829] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 0.425886] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
[ 0.425908] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 0.425954] Exception stack(0x80cbdc60 to 0x80cbdca8)
[ 0.425994] dc60: 00000000 00000000 00000000 00000000 80d43900 00000000 8529d700 00000020
[ 0.426029] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000 80cbdcb0 8015a520 80157d4c
[ 0.426057] dca0: 40000053 ffffffff
[ 0.426083] r5:40000053 r4:80157d4c
[ 0.426101] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 0.426166] r9:852b07a0 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:8529d700
[ 0.426186] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 0.426257] r10:8092ed9c r9:00000000 r8:852b07a0 r7:80d42410 r6:00000020 r5:804600bc
[ 0.426283] r4:8529d220 r3:00000080
[ 0.426302] [<8015bd08>] (devm_request_threaded_irq) from [<80460514>] (aspeed_lpc_snoop_probe+0x15c/0x2e0)
[ 0.426392] r10:80bab000 r9:80983b68 r8:80d42410 r7:8529d100 r6:80d42400 r5:852b07a0
[ 0.426414] r4:00000000
[ 0.426431] [<804603b8>] (aspeed_lpc_snoop_probe) from [<804e69a8>] (platform_probe+0x54/0x9c)
[ 0.426515] r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
[ 0.426535] [<804e6954>] (platform_probe) from [<804e4534>] (really_probe+0x1c4/0x46c)
[ 0.426588] r5:00000000 r4:80d42410
[ 0.426609] [<804e4370>] (really_probe) from [<804e48b0>] (__driver_probe_device+0xd4/0x1bc)
[ 0.426661] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
[ 0.426679] [<804e47dc>] (__driver_probe_device) from [<804e49d8>] (driver_probe_device+0x40/0xd8)
[ 0.426736] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
[ 0.426757] [<804e4998>] (driver_probe_device) from [<804e4d3c>] (__driver_attach+0xa4/0x1c8)
[ 0.426814] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc r5:80d42454 r4:80d42410
[ 0.426834] [<804e4c98>] (__driver_attach) from [<804e214c>] (bus_for_each_dev+0x84/0xd0)
[ 0.426890] r7:80b71638 r6:804e4c98 r5:80b6f3dc r4:00000000
[ 0.426912] [<804e20c8>] (bus_for_each_dev) from [<804e5468>] (driver_attach+0x28/0x30)
[ 0.426964] r6:00000000 r5:852aa660 r4:80b6f3dc
[ 0.426984] [<804e5440>] (driver_attach) from [<804e2ae8>] (bus_add_driver+0x114/0x200)
[ 0.427028] [<804e29d4>] (bus_add_driver) from [<804e5b04>] (driver_register+0x98/0x128)
[ 0.427080] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
[ 0.427100] [<804e5a6c>] (driver_register) from [<804e7c54>] (__platform_driver_register+0x2c/0x34)
[ 0.427159] r5:80c03e40 r4:80a1997c
[ 0.427179] [<804e7c28>] (__platform_driver_register) from [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
[ 0.427237] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from [<80a01408>] (do_one_initcall+0x64/0x144)
[ 0.427310] [<80a013a4>] (do_one_initcall) from [<80a016e4>] (kernel_init_freeable+0x198/0x218)
[ 0.427377] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
[ 0.427399] [<80a0154c>] (kernel_init_freeable) from [<807f0c48>] (kernel_init+0x20/0x134)
[ 0.427463] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:807f0c28
[ 0.427487] r4:00000000
[ 0.427506] [<807f0c28>] (kernel_init) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 0.427556] Exception stack(0x80cbdfb0 to 0x80cbdff8)
[ 0.427593] dfa0: 00000000 00000000 00000000 00000000
[ 0.427628] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 0.427660] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 0.427688] r5:807f0c28 r4:00000000
[ 0.427706] handlers:
[ 0.427723] [<(ptrval)>] aspeed_lpc_snoop_irq
[ 0.427791] Disabling IRQ #32
[ 0.638760] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
[ 0.649120] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32, base_baud = 1546875) is a 8250
[ 0.651220] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31, base_baud = 1500000) is a 16550A
[ 2.020143] Freeing initrd memory: 1072K
[ 2.234013] printk: console [ttyS4] enabled
[ 2.240436] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x5a0c8e0a @ 1us
[ 2.263519] loop: module loaded
[ 2.285336] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
[ 2.291781] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
[ 2.297774] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 - 0x24000000 ] 64MB
[ 2.305301] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 - 0x2a000000 ] 96MB
[ 2.312810] aspeed-smc 1e620000.spi: read control register: 203c0641
[ 2.543850] 5 fixed-partitions partitions found on MTD device bmc
[ 2.550093] Creating 5 MTD partitions on "bmc":
[ 2.554677] 0x000000000000-0x0000000e0000 : "u-boot"
[ 2.562517] 0x0000000e0000-0x000000100000 : "u-boot-env"
[ 2.570803] 0x000000100000-0x000000a00000 : "kernel"
[ 2.578741] 0x000000a00000-0x000002a00000 : "rofs"
[ 2.586351] 0x000002a00000-0x000004000000 : "rwfs"
[ 2.595769] aspeed-smc 1e630000.spi: Using 50 MHz SPI frequency
[ 2.601925] aspeed-smc 1e630000.spi: unrecognized JEDEC id bytes: 00 00 00 00 00 00
[ 2.609715] aspeed-smc 1e630000.spi: Aspeed SMC probe failed -2
[ 2.615673] aspeed-smc: probe of 1e630000.spi failed with error -2
[ 2.629807] libphy: Fixed MDIO Bus: probed
[ 2.635910] ftgmac100 1e660000.ethernet: Read MAC address d0:50:99:f4:1e:18 from chip
[ 2.652487] libphy: ftgmac100_mdio: probed
[ 2.657714] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00: attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
[ 2.671153] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 31b7a2b2
[ 2.681960] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in USB2 mode
[ 2.689974] Mass Storage Function, version: 2009/09/11
[ 2.695169] LUN: removable file: (no medium)
[ 2.699621] no file given for LUN0
[ 2.703126] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start g_mass_storage: -22
[ 2.711656] i2c /dev entries driver
[ 2.717000] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered, irq 33
[ 2.725583] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered, irq 34
[ 2.735502] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered, irq 35
[ 2.743830] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered, irq 36
[ 2.752145] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered, irq 37
[ 2.761322] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered, irq 38
[ 2.769610] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered, irq 39
[ 2.779443] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16 bytes/write
[ 2.786675] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered, irq 40
[ 2.794972] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered, irq 41
[ 2.803273] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered, irq 42
[ 2.816561] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
[ 2.822535] i2c i2c-2: Added multiplexed i2c bus 14
[ 2.828115] i2c i2c-2: Added multiplexed i2c bus 15
[ 2.833787] i2c i2c-2: Added multiplexed i2c bus 16
[ 2.839596] i2c i2c-2: Added multiplexed i2c bus 17
[ 2.844572] pca954x 2-0070: registered 4 multiplexed busses for I2C switch pca9545
[ 2.853735] i2c i2c-5: Added multiplexed i2c bus 18
[ 2.859577] i2c i2c-5: Added multiplexed i2c bus 19
[ 2.865233] i2c i2c-5: Added multiplexed i2c bus 20
[ 2.871052] i2c i2c-5: Added multiplexed i2c bus 21
[ 2.876022] pca954x 5-0073: registered 4 multiplexed busses for I2C switch pca9545
[ 2.886206] Driver for 1-wire Dallas network protocol.
[ 3.011064] NET: Registered PF_INET6 protocol family
[ 3.019138] Segment Routing with IPv6
[ 3.023663] NET: Registered PF_PACKET protocol family
[ 3.029388] 8021q: 802.1Q VLAN Support v1.8
[ 3.044832] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for channel 3
[ 3.052335] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for channel 3
[ 3.274513] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 3.281266] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 3.290082] Hardware name: Generic DT based system
[ 3.294891] Workqueue: events_unbound deferred_probe_work_func
[ 3.300786] Backtrace:
[ 3.303263] [<807e6504>] (dump_backtrace) from [<807e6758>] (show_stack+0x20/0x24)
[ 3.310902] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 3.316567] [<807e6738>] (show_stack) from [<807f09f0>] (dump_stack+0x28/0x30)
[ 3.323841] [<807f09c8>] (dump_stack) from [<807e76e0>] (__report_bad_irq+0x40/0xc0)
[ 3.331628] r5:00000000 r4:80d43900
[ 3.335217] [<807e76a0>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 3.343542] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 3.351293] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 3.359437] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 3.367270] r4:80d43900 r3:00000400
[ 3.370854] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 3.379251] r5:00000000 r4:80d43900
[ 3.382841] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 3.391239] r5:00000000 r4:80b8e7c8
[ 3.394826] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 3.403140] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
[ 3.408814] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 3.416417] Exception stack(0x80cc7c50 to 0x80cc7c98)
[ 3.421493] 7c40: 00000000 00000000 00000000 00000000
[ 3.429688] 7c60: 80d43900 8529d700 851206c0 00000020 80d439a8 a0000013 00000000 80cc7ccc
[ 3.437876] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
[ 3.444502] r5:40000013 r4:80157d4c
[ 3.448091] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 3.456407] r9:8505fb20 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:851206c0
[ 3.464160] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 3.473613] r10:80d4ea20 r9:00000000 r8:8505fb20 r7:80d42c10 r6:00000020 r5:8044fd64
[ 3.481452] r4:851207a0 r3:00000080
[ 3.485037] [<8015bd08>] (devm_request_threaded_irq) from [<804505f0>] (aspeed_kcs_probe+0x244/0x67c)
[ 3.494324] r10:8505fb54 r9:80833650 r8:ffffffea r7:80d42c10 r6:00000020 r5:8505fb20
[ 3.502166] r4:80d42c00
[ 3.504710] [<804503ac>] (aspeed_kcs_probe) from [<804e69a8>] (platform_probe+0x54/0x9c)
[ 3.512873] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10 r6:80b6e7b0 r5:80b6e7b0
[ 3.520712] r4:80d42c10
[ 3.523256] [<804e6954>] (platform_probe) from [<804e4534>] (really_probe+0x1c4/0x46c)
[ 3.531220] r5:00000000 r4:80d42c10
[ 3.534810] [<804e4370>] (really_probe) from [<804e48b0>] (__driver_probe_device+0xd4/0x1bc)
[ 3.543288] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
[ 3.548954] [<804e47dc>] (__driver_probe_device) from [<804e49d8>] (driver_probe_device+0x40/0xd8)
[ 3.557954] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
[ 3.564658] [<804e4998>] (driver_probe_device) from [<804e4c08>] (__device_attach_driver+0xb8/0x148)
[ 3.573831] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84 r5:80b6e7b0 r4:00000001
[ 3.581576] [<804e4b50>] (__device_attach_driver) from [<804e2670>] (bus_for_each_drv+0x90/0xe0)
[ 3.590408] r7:80b71484 r6:804e4b50 r5:80cc7e84 r4:00000000
[ 3.596074] [<804e25e0>] (bus_for_each_drv) from [<804e4f64>] (__device_attach+0x104/0x18c)
[ 3.604473] r6:80d42c54 r5:00000001 r4:80d42c10
[ 3.609101] [<804e4e60>] (__device_attach) from [<804e5394>] (device_initial_probe+0x1c/0x20)
[ 3.617673] r6:80d42c10 r5:80b71638 r4:80d4ca50
[ 3.622299] [<804e5378>] (device_initial_probe) from [<804e2888>] (bus_probe_device+0x94/0x9c)
[ 3.630944] [<804e27f4>] (bus_probe_device) from [<804e3f64>] (deferred_probe_work_func+0xa0/0xe8)
[ 3.639948] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
[ 3.645613] [<804e3ec4>] (deferred_probe_work_func) from [<801301ac>] (process_one_work+0x1b4/0x46c)
[ 3.654797] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00 r6:00000040 r5:80c045a0
[ 3.662640] r4:80b7148c r3:804e3ec4
[ 3.666223] [<8012fff8>] (process_one_work) from [<8013066c>] (worker_thread+0x208/0x528)
[ 3.674443] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14 r6:80c045b4 r5:80c08a00
[ 3.682284] r4:80c045a0
[ 3.684822] [<80130464>] (worker_thread) from [<80136f18>] (kthread+0x138/0x160)
[ 3.692272] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0 r6:80130464 r5:80c03840
[ 3.700112] r4:80c02b80
[ 3.702658] [<80136de0>] (kthread) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 3.709921] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
[ 3.714999] 7fa0: 00000000 00000000 00000000 00000000
[ 3.723192] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 3.731378] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 3.738012] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:80136de0
[ 3.745847] r4:80c02b80 r3:00000000
[ 3.749431] handlers:
[ 3.751710] [<7d4a6f47>] aspeed_lpc_snoop_irq
[ 3.756139] [<77501825>] aspeed_kcs_irq
[ 3.760031] Disabling IRQ #32
[ 3.763218] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 1:09 ` Zev Weiss
0 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-03 1:09 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Tue, Nov 02, 2021 at 05:54:30PM PDT, Jae Hyun Yoo wrote:
>
>
>On 11/2/2021 5:30 PM, Zev Weiss wrote:
>>On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>>>Hi Zev,
>>>
>>>On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>>>On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>>>On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>>
>>>>>>From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>>
>>>>>>Hello all,
>>>>>>
>>>>>>This series is for appliying below fix to all Aspped LPC sub drivers.
>>>>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>>
>>>>>>
>>>>>>
>>>>>>An LPC sub driver can be enabled without using the lpc-ctrl
>>>>>>driver or it
>>>>>>can be registered ahead of lpc-ctrl depends on each system
>>>>>>configuration and
>>>>>>this difference introduces that LPC can be enabled without
>>>>>>heart beating of
>>>>>>LCLK so it causes improper handling on host interrupts when
>>>>>>the host sends
>>>>>>interrupts in that time frame. Then kernel eventually
>>>>>>forcibly disables the
>>>>>>interrupt with dumping stack and printing a 'nobody cared
>>>>>>this irq' message
>>>>>>out.
>>>>>>
>>>>>>To prevent this issue, all LPC sub drivers should enable
>>>>>>LCLK individually
>>>>>>so this patch adds clock control logic into the remaining
>>>>>>Aspeed LPC sub
>>>>>>drivers.
>>>>>
>>>>>Thanks for sending this out!
>>>>>
>>>>>This will resolve a few of the issues we have in the issue tracker:
>>>>>
>>>>>https://github.com/openbmc/linux/issues/210
>>>>>https://github.com/openbmc/linux/issues/130
>>>>>
>>>>>The patches look good to me. I think you've just missed Corey's PR for
>>>>>v5.16, but I will stick them in the openbmc tree once they've had a
>>>>>review.
>>>>>
>>>>
>>>>Hi Jae,
>>>>
>>>>I tried this series out on the same in-progress OpenBMC port
>>>>from issue number 210 linked above and am still seeing problems
>>>>(dmesg pasted below).
>>>>
>>>>I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add
>>>>uart routing to device tree") from linux-next to allow the first
>>>>patch to apply cleanly; is there anything else I might be
>>>>missing that'd be needed to test the series properly?
>>>
>>>Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>>>which this series doesn't touch. Do you have below fix in your code
>>>tree?
>>>
>>>https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>
>>>
>>>Thanks,
>>>Jae
>>>
>>
>>Yes, I've got that patch (commit 3f94cf1558), and the accompanying
>>dts update to add the clocks property to the lpc-snoop device
>>(commit d050d049f8).
>>
>>However, while there is an aspeed_lpc_snoop_probe() backtrace there,
>>note that there's *also* one from aspeed_kcs_probe() further on
>>(starting at timestamp 3.263306).
>>
>>
>>Zev
>>
>
>Can you please test additional changes below?
>
No clear improvement with that unfortunately (note that the formatting
of the patch got pretty mangled there and required a lot of manual
tweaking to apply, but I think I tested the intended thing).
dmesg results below.
Zev
[ 0.425073] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 0.425118] CPU: 0 PID: 1 Comm: swapper Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 0.425161] Hardware name: Generic DT based system
[ 0.425185] Backtrace:
[ 0.425219] [<807e6504>] (dump_backtrace) from [<807e6758>] (show_stack+0x20/0x24)
[ 0.425315] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 0.425339] [<807e6738>] (show_stack) from [<807f09f0>] (dump_stack+0x28/0x30)
[ 0.425397] [<807f09c8>] (dump_stack) from [<807e76e0>] (__report_bad_irq+0x40/0xc0)
[ 0.425454] r5:00000000 r4:80d43900
[ 0.425473] [<807e76a0>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 0.425555] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 0.425577] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 0.425637] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 0.425663] r4:80d43900 r3:00000000
[ 0.425681] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 0.425738] r5:00000000 r4:80d43900
[ 0.425758] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 0.425811] r5:00000000 r4:80b8e7c8
[ 0.425829] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 0.425886] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
[ 0.425908] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 0.425954] Exception stack(0x80cbdc60 to 0x80cbdca8)
[ 0.425994] dc60: 00000000 00000000 00000000 00000000 80d43900 00000000 8529d700 00000020
[ 0.426029] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000 80cbdcb0 8015a520 80157d4c
[ 0.426057] dca0: 40000053 ffffffff
[ 0.426083] r5:40000053 r4:80157d4c
[ 0.426101] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 0.426166] r9:852b07a0 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:8529d700
[ 0.426186] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 0.426257] r10:8092ed9c r9:00000000 r8:852b07a0 r7:80d42410 r6:00000020 r5:804600bc
[ 0.426283] r4:8529d220 r3:00000080
[ 0.426302] [<8015bd08>] (devm_request_threaded_irq) from [<80460514>] (aspeed_lpc_snoop_probe+0x15c/0x2e0)
[ 0.426392] r10:80bab000 r9:80983b68 r8:80d42410 r7:8529d100 r6:80d42400 r5:852b07a0
[ 0.426414] r4:00000000
[ 0.426431] [<804603b8>] (aspeed_lpc_snoop_probe) from [<804e69a8>] (platform_probe+0x54/0x9c)
[ 0.426515] r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
[ 0.426535] [<804e6954>] (platform_probe) from [<804e4534>] (really_probe+0x1c4/0x46c)
[ 0.426588] r5:00000000 r4:80d42410
[ 0.426609] [<804e4370>] (really_probe) from [<804e48b0>] (__driver_probe_device+0xd4/0x1bc)
[ 0.426661] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
[ 0.426679] [<804e47dc>] (__driver_probe_device) from [<804e49d8>] (driver_probe_device+0x40/0xd8)
[ 0.426736] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
[ 0.426757] [<804e4998>] (driver_probe_device) from [<804e4d3c>] (__driver_attach+0xa4/0x1c8)
[ 0.426814] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc r5:80d42454 r4:80d42410
[ 0.426834] [<804e4c98>] (__driver_attach) from [<804e214c>] (bus_for_each_dev+0x84/0xd0)
[ 0.426890] r7:80b71638 r6:804e4c98 r5:80b6f3dc r4:00000000
[ 0.426912] [<804e20c8>] (bus_for_each_dev) from [<804e5468>] (driver_attach+0x28/0x30)
[ 0.426964] r6:00000000 r5:852aa660 r4:80b6f3dc
[ 0.426984] [<804e5440>] (driver_attach) from [<804e2ae8>] (bus_add_driver+0x114/0x200)
[ 0.427028] [<804e29d4>] (bus_add_driver) from [<804e5b04>] (driver_register+0x98/0x128)
[ 0.427080] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
[ 0.427100] [<804e5a6c>] (driver_register) from [<804e7c54>] (__platform_driver_register+0x2c/0x34)
[ 0.427159] r5:80c03e40 r4:80a1997c
[ 0.427179] [<804e7c28>] (__platform_driver_register) from [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
[ 0.427237] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from [<80a01408>] (do_one_initcall+0x64/0x144)
[ 0.427310] [<80a013a4>] (do_one_initcall) from [<80a016e4>] (kernel_init_freeable+0x198/0x218)
[ 0.427377] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
[ 0.427399] [<80a0154c>] (kernel_init_freeable) from [<807f0c48>] (kernel_init+0x20/0x134)
[ 0.427463] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:807f0c28
[ 0.427487] r4:00000000
[ 0.427506] [<807f0c28>] (kernel_init) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 0.427556] Exception stack(0x80cbdfb0 to 0x80cbdff8)
[ 0.427593] dfa0: 00000000 00000000 00000000 00000000
[ 0.427628] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 0.427660] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 0.427688] r5:807f0c28 r4:00000000
[ 0.427706] handlers:
[ 0.427723] [<(ptrval)>] aspeed_lpc_snoop_irq
[ 0.427791] Disabling IRQ #32
[ 0.638760] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
[ 0.649120] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32, base_baud = 1546875) is a 8250
[ 0.651220] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31, base_baud = 1500000) is a 16550A
[ 2.020143] Freeing initrd memory: 1072K
[ 2.234013] printk: console [ttyS4] enabled
[ 2.240436] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x5a0c8e0a @ 1us
[ 2.263519] loop: module loaded
[ 2.285336] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
[ 2.291781] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
[ 2.297774] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 - 0x24000000 ] 64MB
[ 2.305301] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 - 0x2a000000 ] 96MB
[ 2.312810] aspeed-smc 1e620000.spi: read control register: 203c0641
[ 2.543850] 5 fixed-partitions partitions found on MTD device bmc
[ 2.550093] Creating 5 MTD partitions on "bmc":
[ 2.554677] 0x000000000000-0x0000000e0000 : "u-boot"
[ 2.562517] 0x0000000e0000-0x000000100000 : "u-boot-env"
[ 2.570803] 0x000000100000-0x000000a00000 : "kernel"
[ 2.578741] 0x000000a00000-0x000002a00000 : "rofs"
[ 2.586351] 0x000002a00000-0x000004000000 : "rwfs"
[ 2.595769] aspeed-smc 1e630000.spi: Using 50 MHz SPI frequency
[ 2.601925] aspeed-smc 1e630000.spi: unrecognized JEDEC id bytes: 00 00 00 00 00 00
[ 2.609715] aspeed-smc 1e630000.spi: Aspeed SMC probe failed -2
[ 2.615673] aspeed-smc: probe of 1e630000.spi failed with error -2
[ 2.629807] libphy: Fixed MDIO Bus: probed
[ 2.635910] ftgmac100 1e660000.ethernet: Read MAC address d0:50:99:f4:1e:18 from chip
[ 2.652487] libphy: ftgmac100_mdio: probed
[ 2.657714] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00: attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
[ 2.671153] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 31b7a2b2
[ 2.681960] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in USB2 mode
[ 2.689974] Mass Storage Function, version: 2009/09/11
[ 2.695169] LUN: removable file: (no medium)
[ 2.699621] no file given for LUN0
[ 2.703126] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start g_mass_storage: -22
[ 2.711656] i2c /dev entries driver
[ 2.717000] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered, irq 33
[ 2.725583] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered, irq 34
[ 2.735502] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered, irq 35
[ 2.743830] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered, irq 36
[ 2.752145] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered, irq 37
[ 2.761322] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered, irq 38
[ 2.769610] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered, irq 39
[ 2.779443] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16 bytes/write
[ 2.786675] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered, irq 40
[ 2.794972] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered, irq 41
[ 2.803273] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered, irq 42
[ 2.816561] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
[ 2.822535] i2c i2c-2: Added multiplexed i2c bus 14
[ 2.828115] i2c i2c-2: Added multiplexed i2c bus 15
[ 2.833787] i2c i2c-2: Added multiplexed i2c bus 16
[ 2.839596] i2c i2c-2: Added multiplexed i2c bus 17
[ 2.844572] pca954x 2-0070: registered 4 multiplexed busses for I2C switch pca9545
[ 2.853735] i2c i2c-5: Added multiplexed i2c bus 18
[ 2.859577] i2c i2c-5: Added multiplexed i2c bus 19
[ 2.865233] i2c i2c-5: Added multiplexed i2c bus 20
[ 2.871052] i2c i2c-5: Added multiplexed i2c bus 21
[ 2.876022] pca954x 5-0073: registered 4 multiplexed busses for I2C switch pca9545
[ 2.886206] Driver for 1-wire Dallas network protocol.
[ 3.011064] NET: Registered PF_INET6 protocol family
[ 3.019138] Segment Routing with IPv6
[ 3.023663] NET: Registered PF_PACKET protocol family
[ 3.029388] 8021q: 802.1Q VLAN Support v1.8
[ 3.044832] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for channel 3
[ 3.052335] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for channel 3
[ 3.274513] irq 32: nobody cared (try booting with the "irqpoll" option)
[ 3.281266] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted 5.14.11-aee45db-dirty-4b119be-hacked #1
[ 3.290082] Hardware name: Generic DT based system
[ 3.294891] Workqueue: events_unbound deferred_probe_work_func
[ 3.300786] Backtrace:
[ 3.303263] [<807e6504>] (dump_backtrace) from [<807e6758>] (show_stack+0x20/0x24)
[ 3.310902] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
[ 3.316567] [<807e6738>] (show_stack) from [<807f09f0>] (dump_stack+0x28/0x30)
[ 3.323841] [<807f09c8>] (dump_stack) from [<807e76e0>] (__report_bad_irq+0x40/0xc0)
[ 3.331628] r5:00000000 r4:80d43900
[ 3.335217] [<807e76a0>] (__report_bad_irq) from [<80159c10>] (note_interrupt+0x284/0x2dc)
[ 3.343542] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008 r5:00000000 r4:80d43900
[ 3.351293] [<8015998c>] (note_interrupt) from [<801569d4>] (handle_irq_event+0xb4/0xc0)
[ 3.359437] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000 r6:00000008 r5:00000000
[ 3.367270] r4:80d43900 r3:00000400
[ 3.370854] [<80156920>] (handle_irq_event) from [<8015acd0>] (handle_level_irq+0xac/0x180)
[ 3.379251] r5:00000000 r4:80d43900
[ 3.382841] [<8015ac24>] (handle_level_irq) from [<80155fa4>] (handle_domain_irq+0x60/0x7c)
[ 3.391239] r5:00000000 r4:80b8e7c8
[ 3.394826] [<80155f44>] (handle_domain_irq) from [<8010121c>] (avic_handle_irq+0x64/0x6c)
[ 3.403140] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
[ 3.408814] [<801011b8>] (avic_handle_irq) from [<80100aec>] (__irq_svc+0x6c/0x90)
[ 3.416417] Exception stack(0x80cc7c50 to 0x80cc7c98)
[ 3.421493] 7c40: 00000000 00000000 00000000 00000000
[ 3.429688] 7c60: 80d43900 8529d700 851206c0 00000020 80d439a8 a0000013 00000000 80cc7ccc
[ 3.437876] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
[ 3.444502] r5:40000013 r4:80157d4c
[ 3.448091] [<80157a0c>] (__setup_irq) from [<8015844c>] (request_threaded_irq+0xe8/0x16c)
[ 3.456407] r9:8505fb20 r8:00000020 r7:80d43910 r6:80d43900 r5:00000000 r4:851206c0
[ 3.464160] [<80158364>] (request_threaded_irq) from [<8015bd80>] (devm_request_threaded_irq+0x78/0xd0)
[ 3.473613] r10:80d4ea20 r9:00000000 r8:8505fb20 r7:80d42c10 r6:00000020 r5:8044fd64
[ 3.481452] r4:851207a0 r3:00000080
[ 3.485037] [<8015bd08>] (devm_request_threaded_irq) from [<804505f0>] (aspeed_kcs_probe+0x244/0x67c)
[ 3.494324] r10:8505fb54 r9:80833650 r8:ffffffea r7:80d42c10 r6:00000020 r5:8505fb20
[ 3.502166] r4:80d42c00
[ 3.504710] [<804503ac>] (aspeed_kcs_probe) from [<804e69a8>] (platform_probe+0x54/0x9c)
[ 3.512873] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10 r6:80b6e7b0 r5:80b6e7b0
[ 3.520712] r4:80d42c10
[ 3.523256] [<804e6954>] (platform_probe) from [<804e4534>] (really_probe+0x1c4/0x46c)
[ 3.531220] r5:00000000 r4:80d42c10
[ 3.534810] [<804e4370>] (really_probe) from [<804e48b0>] (__driver_probe_device+0xd4/0x1bc)
[ 3.543288] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
[ 3.548954] [<804e47dc>] (__driver_probe_device) from [<804e49d8>] (driver_probe_device+0x40/0xd8)
[ 3.557954] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
[ 3.564658] [<804e4998>] (driver_probe_device) from [<804e4c08>] (__device_attach_driver+0xb8/0x148)
[ 3.573831] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84 r5:80b6e7b0 r4:00000001
[ 3.581576] [<804e4b50>] (__device_attach_driver) from [<804e2670>] (bus_for_each_drv+0x90/0xe0)
[ 3.590408] r7:80b71484 r6:804e4b50 r5:80cc7e84 r4:00000000
[ 3.596074] [<804e25e0>] (bus_for_each_drv) from [<804e4f64>] (__device_attach+0x104/0x18c)
[ 3.604473] r6:80d42c54 r5:00000001 r4:80d42c10
[ 3.609101] [<804e4e60>] (__device_attach) from [<804e5394>] (device_initial_probe+0x1c/0x20)
[ 3.617673] r6:80d42c10 r5:80b71638 r4:80d4ca50
[ 3.622299] [<804e5378>] (device_initial_probe) from [<804e2888>] (bus_probe_device+0x94/0x9c)
[ 3.630944] [<804e27f4>] (bus_probe_device) from [<804e3f64>] (deferred_probe_work_func+0xa0/0xe8)
[ 3.639948] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
[ 3.645613] [<804e3ec4>] (deferred_probe_work_func) from [<801301ac>] (process_one_work+0x1b4/0x46c)
[ 3.654797] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00 r6:00000040 r5:80c045a0
[ 3.662640] r4:80b7148c r3:804e3ec4
[ 3.666223] [<8012fff8>] (process_one_work) from [<8013066c>] (worker_thread+0x208/0x528)
[ 3.674443] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14 r6:80c045b4 r5:80c08a00
[ 3.682284] r4:80c045a0
[ 3.684822] [<80130464>] (worker_thread) from [<80136f18>] (kthread+0x138/0x160)
[ 3.692272] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0 r6:80130464 r5:80c03840
[ 3.700112] r4:80c02b80
[ 3.702658] [<80136de0>] (kthread) from [<80100130>] (ret_from_fork+0x14/0x24)
[ 3.709921] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
[ 3.714999] 7fa0: 00000000 00000000 00000000 00000000
[ 3.723192] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 3.731378] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 3.738012] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:80136de0
[ 3.745847] r4:80c02b80 r3:00000000
[ 3.749431] handlers:
[ 3.751710] [<7d4a6f47>] aspeed_lpc_snoop_irq
[ 3.756139] [<77501825>] aspeed_kcs_irq
[ 3.760031] Disabling IRQ #32
[ 3.763218] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 1:09 ` Zev Weiss
@ 2021-11-03 15:56 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 15:56 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/2/2021 6:09 PM, Zev Weiss wrote:
> On Tue, Nov 02, 2021 at 05:54:30PM PDT, Jae Hyun Yoo wrote:
>>
>>
>> On 11/2/2021 5:30 PM, Zev Weiss wrote:
>>> On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>>>> Hi Zev,
>>>>
>>>> On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>>>> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>>>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>>>
>>>>>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>>>
>>>>>>> Hello all,
>>>>>>>
>>>>>>> This series is for appliying below fix to all Aspped LPC sub
>>>>>>> drivers.
>>>>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> An LPC sub driver can be enabled without using the lpc-ctrl
>>>>>>> driver or it
>>>>>>> can be registered ahead of lpc-ctrl depends on each system
>>>>>>> configuration and
>>>>>>> this difference introduces that LPC can be enabled without heart
>>>>>>> beating of
>>>>>>> LCLK so it causes improper handling on host interrupts when the
>>>>>>> host sends
>>>>>>> interrupts in that time frame. Then kernel eventually forcibly
>>>>>>> disables the
>>>>>>> interrupt with dumping stack and printing a 'nobody cared this
>>>>>>> irq' message
>>>>>>> out.
>>>>>>>
>>>>>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>>>>>> individually
>>>>>>> so this patch adds clock control logic into the remaining Aspeed
>>>>>>> LPC sub
>>>>>>> drivers.
>>>>>>
>>>>>> Thanks for sending this out!
>>>>>>
>>>>>> This will resolve a few of the issues we have in the issue tracker:
>>>>>>
>>>>>> https://github.com/openbmc/linux/issues/210
>>>>>> https://github.com/openbmc/linux/issues/130
>>>>>>
>>>>>> The patches look good to me. I think you've just missed Corey's PR
>>>>>> for
>>>>>> v5.16, but I will stick them in the openbmc tree once they've had a
>>>>>> review.
>>>>>>
>>>>>
>>>>> Hi Jae,
>>>>>
>>>>> I tried this series out on the same in-progress OpenBMC port from
>>>>> issue number 210 linked above and am still seeing problems (dmesg
>>>>> pasted below).
>>>>>
>>>>> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>>>> routing to device tree") from linux-next to allow the first patch
>>>>> to apply cleanly; is there anything else I might be missing that'd
>>>>> be needed to test the series properly?
>>>>
>>>> Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>>>> which this series doesn't touch. Do you have below fix in your code
>>>> tree?
>>>>
>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Jae
>>>>
>>>
>>> Yes, I've got that patch (commit 3f94cf1558), and the accompanying
>>> dts update to add the clocks property to the lpc-snoop device (commit
>>> d050d049f8).
>>>
>>> However, while there is an aspeed_lpc_snoop_probe() backtrace there,
>>> note that there's *also* one from aspeed_kcs_probe() further on
>>> (starting at timestamp 3.263306).
>>>
>>>
>>> Zev
>>>
>>
>> Can you please test additional changes below?
>>
>
> No clear improvement with that unfortunately (note that the formatting
> of the patch got pretty mangled there and required a lot of manual
> tweaking to apply, but I think I tested the intended thing).
>
> dmesg results below.
>
>
> Zev
Hi Zev,
Not sure but looks like one of LPC functions is enabled while kernel
booting. What do you see if you remove all the changes in this series?
I'm also sharing my suggestions for testing below.
- Disable if any LPC function is enabled in boot loader and test it
again.
- If you see the issue when BMC reboots, check LPC is being reset by
EXTRST or watchdog resets. Means that WDT20[11] and SCU070[11] should
be set.
- Disable all LPC sub functions and see if the issue reproduced. And
then, enable the sub functions one by one and find out which sub
function causes the issue.
- Patches I provided should be applied without making any manual touch
if you apply this series on top of 'next-20211102' tag. Please check
cherry pick if you find any relevant changes in the next queue.
- As a last resort, enable LCLK always by adding CLK_IS_CRITICAL flag
in clk-ast2600.c as Chiawei mentioned. If it works, you may need to
wait for the fix from Chiawei.
Thanks,
Jae
>
> [ 0.425073] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 0.425118] CPU: 0 PID: 1 Comm: swapper Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 0.425161] Hardware name: Generic DT based system
> [ 0.425185] Backtrace: [ 0.425219] [<807e6504>] (dump_backtrace)
> from [<807e6758>] (show_stack+0x20/0x24)
> [ 0.425315] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 0.425339] [<807e6738>] (show_stack) from [<807f09f0>]
> (dump_stack+0x28/0x30)
> [ 0.425397] [<807f09c8>] (dump_stack) from [<807e76e0>]
> (__report_bad_irq+0x40/0xc0)
> [ 0.425454] r5:00000000 r4:80d43900
> [ 0.425473] [<807e76a0>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 0.425555] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 0.425577] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 0.425637] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 0.425663] r4:80d43900 r3:00000000
> [ 0.425681] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 0.425738] r5:00000000 r4:80d43900
> [ 0.425758] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 0.425811] r5:00000000 r4:80b8e7c8
> [ 0.425829] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 0.425886] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
> [ 0.425908] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 0.425954] Exception stack(0x80cbdc60 to 0x80cbdca8)
> [ 0.425994] dc60: 00000000 00000000 00000000 00000000 80d43900
> 00000000 8529d700 00000020
> [ 0.426029] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000
> 80cbdcb0 8015a520 80157d4c
> [ 0.426057] dca0: 40000053 ffffffff
> [ 0.426083] r5:40000053 r4:80157d4c
> [ 0.426101] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 0.426166] r9:852b07a0 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:8529d700
> [ 0.426186] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 0.426257] r10:8092ed9c r9:00000000 r8:852b07a0 r7:80d42410
> r6:00000020 r5:804600bc
> [ 0.426283] r4:8529d220 r3:00000080
> [ 0.426302] [<8015bd08>] (devm_request_threaded_irq) from
> [<80460514>] (aspeed_lpc_snoop_probe+0x15c/0x2e0)
> [ 0.426392] r10:80bab000 r9:80983b68 r8:80d42410 r7:8529d100
> r6:80d42400 r5:852b07a0
> [ 0.426414] r4:00000000
> [ 0.426431] [<804603b8>] (aspeed_lpc_snoop_probe) from [<804e69a8>]
> (platform_probe+0x54/0x9c)
> [ 0.426515] r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
> [ 0.426535] [<804e6954>] (platform_probe) from [<804e4534>]
> (really_probe+0x1c4/0x46c)
> [ 0.426588] r5:00000000 r4:80d42410
> [ 0.426609] [<804e4370>] (really_probe) from [<804e48b0>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 0.426661] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
> [ 0.426679] [<804e47dc>] (__driver_probe_device) from [<804e49d8>]
> (driver_probe_device+0x40/0xd8)
> [ 0.426736] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
> [ 0.426757] [<804e4998>] (driver_probe_device) from [<804e4d3c>]
> (__driver_attach+0xa4/0x1c8)
> [ 0.426814] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc
> r5:80d42454 r4:80d42410
> [ 0.426834] [<804e4c98>] (__driver_attach) from [<804e214c>]
> (bus_for_each_dev+0x84/0xd0)
> [ 0.426890] r7:80b71638 r6:804e4c98 r5:80b6f3dc r4:00000000
> [ 0.426912] [<804e20c8>] (bus_for_each_dev) from [<804e5468>]
> (driver_attach+0x28/0x30)
> [ 0.426964] r6:00000000 r5:852aa660 r4:80b6f3dc
> [ 0.426984] [<804e5440>] (driver_attach) from [<804e2ae8>]
> (bus_add_driver+0x114/0x200)
> [ 0.427028] [<804e29d4>] (bus_add_driver) from [<804e5b04>]
> (driver_register+0x98/0x128)
> [ 0.427080] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
> [ 0.427100] [<804e5a6c>] (driver_register) from [<804e7c54>]
> (__platform_driver_register+0x2c/0x34)
> [ 0.427159] r5:80c03e40 r4:80a1997c
> [ 0.427179] [<804e7c28>] (__platform_driver_register) from
> [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
> [ 0.427237] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from
> [<80a01408>] (do_one_initcall+0x64/0x144)
> [ 0.427310] [<80a013a4>] (do_one_initcall) from [<80a016e4>]
> (kernel_init_freeable+0x198/0x218)
> [ 0.427377] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
> [ 0.427399] [<80a0154c>] (kernel_init_freeable) from [<807f0c48>]
> (kernel_init+0x20/0x134)
> [ 0.427463] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:807f0c28
> [ 0.427487] r4:00000000
> [ 0.427506] [<807f0c28>] (kernel_init) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 0.427556] Exception stack(0x80cbdfb0 to 0x80cbdff8)
> [ 0.427593] dfa0: 00000000
> 00000000 00000000 00000000
> [ 0.427628] dfc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.427660] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 0.427688] r5:807f0c28 r4:00000000
> [ 0.427706] handlers:
> [ 0.427723] [<(ptrval)>] aspeed_lpc_snoop_irq
> [ 0.427791] Disabling IRQ #32
> [ 0.638760] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
> [ 0.649120] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32,
> base_baud = 1546875) is a 8250
> [ 0.651220] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31,
> base_baud = 1500000) is a 16550A
> [ 2.020143] Freeing initrd memory: 1072K
> [ 2.234013] printk: console [ttyS4] enabled
> [ 2.240436] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x5a0c8e0a @ 1us
> [ 2.263519] loop: module loaded
> [ 2.285336] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
> [ 2.291781] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
> [ 2.297774] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 -
> 0x24000000 ] 64MB
> [ 2.305301] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 -
> 0x2a000000 ] 96MB
> [ 2.312810] aspeed-smc 1e620000.spi: read control register: 203c0641
> [ 2.543850] 5 fixed-partitions partitions found on MTD device bmc
> [ 2.550093] Creating 5 MTD partitions on "bmc":
> [ 2.554677] 0x000000000000-0x0000000e0000 : "u-boot"
> [ 2.562517] 0x0000000e0000-0x000000100000 : "u-boot-env"
> [ 2.570803] 0x000000100000-0x000000a00000 : "kernel"
> [ 2.578741] 0x000000a00000-0x000002a00000 : "rofs"
> [ 2.586351] 0x000002a00000-0x000004000000 : "rwfs"
> [ 2.595769] aspeed-smc 1e630000.spi: Using 50 MHz SPI frequency
> [ 2.601925] aspeed-smc 1e630000.spi: unrecognized JEDEC id bytes: 00
> 00 00 00 00 00
> [ 2.609715] aspeed-smc 1e630000.spi: Aspeed SMC probe failed -2
> [ 2.615673] aspeed-smc: probe of 1e630000.spi failed with error -2
> [ 2.629807] libphy: Fixed MDIO Bus: probed
> [ 2.635910] ftgmac100 1e660000.ethernet: Read MAC address
> d0:50:99:f4:1e:18 from chip
> [ 2.652487] libphy: ftgmac100_mdio: probed
> [ 2.657714] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00:
> attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
> [ 2.671153] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 31b7a2b2
> [ 2.681960] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in
> USB2 mode
> [ 2.689974] Mass Storage Function, version: 2009/09/11
> [ 2.695169] LUN: removable file: (no medium)
> [ 2.699621] no file given for LUN0
> [ 2.703126] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start
> g_mass_storage: -22
> [ 2.711656] i2c /dev entries driver
> [ 2.717000] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered,
> irq 33
> [ 2.725583] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered,
> irq 34
> [ 2.735502] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered,
> irq 35
> [ 2.743830] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered,
> irq 36
> [ 2.752145] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered,
> irq 37
> [ 2.761322] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered,
> irq 38
> [ 2.769610] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered,
> irq 39
> [ 2.779443] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16
> bytes/write
> [ 2.786675] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered,
> irq 40
> [ 2.794972] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered,
> irq 41
> [ 2.803273] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered,
> irq 42
> [ 2.816561] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
> [ 2.822535] i2c i2c-2: Added multiplexed i2c bus 14
> [ 2.828115] i2c i2c-2: Added multiplexed i2c bus 15
> [ 2.833787] i2c i2c-2: Added multiplexed i2c bus 16
> [ 2.839596] i2c i2c-2: Added multiplexed i2c bus 17
> [ 2.844572] pca954x 2-0070: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.853735] i2c i2c-5: Added multiplexed i2c bus 18
> [ 2.859577] i2c i2c-5: Added multiplexed i2c bus 19
> [ 2.865233] i2c i2c-5: Added multiplexed i2c bus 20
> [ 2.871052] i2c i2c-5: Added multiplexed i2c bus 21
> [ 2.876022] pca954x 5-0073: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.886206] Driver for 1-wire Dallas network protocol.
> [ 3.011064] NET: Registered PF_INET6 protocol family
> [ 3.019138] Segment Routing with IPv6
> [ 3.023663] NET: Registered PF_PACKET protocol family
> [ 3.029388] 8021q: 802.1Q VLAN Support v1.8
> [ 3.044832] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for
> channel 3
> [ 3.052335] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for
> channel 3
> [ 3.274513] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 3.281266] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 3.290082] Hardware name: Generic DT based system
> [ 3.294891] Workqueue: events_unbound deferred_probe_work_func
> [ 3.300786] Backtrace: [ 3.303263] [<807e6504>] (dump_backtrace)
> from [<807e6758>] (show_stack+0x20/0x24)
> [ 3.310902] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 3.316567] [<807e6738>] (show_stack) from [<807f09f0>]
> (dump_stack+0x28/0x30)
> [ 3.323841] [<807f09c8>] (dump_stack) from [<807e76e0>]
> (__report_bad_irq+0x40/0xc0)
> [ 3.331628] r5:00000000 r4:80d43900
> [ 3.335217] [<807e76a0>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 3.343542] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 3.351293] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 3.359437] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 3.367270] r4:80d43900 r3:00000400
> [ 3.370854] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 3.379251] r5:00000000 r4:80d43900
> [ 3.382841] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 3.391239] r5:00000000 r4:80b8e7c8
> [ 3.394826] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 3.403140] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
> [ 3.408814] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 3.416417] Exception stack(0x80cc7c50 to 0x80cc7c98)
> [ 3.421493] 7c40: 00000000
> 00000000 00000000 00000000
> [ 3.429688] 7c60: 80d43900 8529d700 851206c0 00000020 80d439a8
> a0000013 00000000 80cc7ccc
> [ 3.437876] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
> [ 3.444502] r5:40000013 r4:80157d4c
> [ 3.448091] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 3.456407] r9:8505fb20 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:851206c0
> [ 3.464160] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 3.473613] r10:80d4ea20 r9:00000000 r8:8505fb20 r7:80d42c10
> r6:00000020 r5:8044fd64
> [ 3.481452] r4:851207a0 r3:00000080
> [ 3.485037] [<8015bd08>] (devm_request_threaded_irq) from
> [<804505f0>] (aspeed_kcs_probe+0x244/0x67c)
> [ 3.494324] r10:8505fb54 r9:80833650 r8:ffffffea r7:80d42c10
> r6:00000020 r5:8505fb20
> [ 3.502166] r4:80d42c00
> [ 3.504710] [<804503ac>] (aspeed_kcs_probe) from [<804e69a8>]
> (platform_probe+0x54/0x9c)
> [ 3.512873] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10
> r6:80b6e7b0 r5:80b6e7b0
> [ 3.520712] r4:80d42c10
> [ 3.523256] [<804e6954>] (platform_probe) from [<804e4534>]
> (really_probe+0x1c4/0x46c)
> [ 3.531220] r5:00000000 r4:80d42c10
> [ 3.534810] [<804e4370>] (really_probe) from [<804e48b0>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 3.543288] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
> [ 3.548954] [<804e47dc>] (__driver_probe_device) from [<804e49d8>]
> (driver_probe_device+0x40/0xd8)
> [ 3.557954] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
> [ 3.564658] [<804e4998>] (driver_probe_device) from [<804e4c08>]
> (__device_attach_driver+0xb8/0x148)
> [ 3.573831] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84
> r5:80b6e7b0 r4:00000001
> [ 3.581576] [<804e4b50>] (__device_attach_driver) from [<804e2670>]
> (bus_for_each_drv+0x90/0xe0)
> [ 3.590408] r7:80b71484 r6:804e4b50 r5:80cc7e84 r4:00000000
> [ 3.596074] [<804e25e0>] (bus_for_each_drv) from [<804e4f64>]
> (__device_attach+0x104/0x18c)
> [ 3.604473] r6:80d42c54 r5:00000001 r4:80d42c10
> [ 3.609101] [<804e4e60>] (__device_attach) from [<804e5394>]
> (device_initial_probe+0x1c/0x20)
> [ 3.617673] r6:80d42c10 r5:80b71638 r4:80d4ca50
> [ 3.622299] [<804e5378>] (device_initial_probe) from [<804e2888>]
> (bus_probe_device+0x94/0x9c)
> [ 3.630944] [<804e27f4>] (bus_probe_device) from [<804e3f64>]
> (deferred_probe_work_func+0xa0/0xe8)
> [ 3.639948] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
> [ 3.645613] [<804e3ec4>] (deferred_probe_work_func) from [<801301ac>]
> (process_one_work+0x1b4/0x46c)
> [ 3.654797] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00
> r6:00000040 r5:80c045a0
> [ 3.662640] r4:80b7148c r3:804e3ec4
> [ 3.666223] [<8012fff8>] (process_one_work) from [<8013066c>]
> (worker_thread+0x208/0x528)
> [ 3.674443] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14
> r6:80c045b4 r5:80c08a00
> [ 3.682284] r4:80c045a0
> [ 3.684822] [<80130464>] (worker_thread) from [<80136f18>]
> (kthread+0x138/0x160)
> [ 3.692272] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0
> r6:80130464 r5:80c03840
> [ 3.700112] r4:80c02b80
> [ 3.702658] [<80136de0>] (kthread) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 3.709921] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
> [ 3.714999] 7fa0: 00000000
> 00000000 00000000 00000000
> [ 3.723192] 7fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 3.731378] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 3.738012] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:80136de0
> [ 3.745847] r4:80c02b80 r3:00000000
> [ 3.749431] handlers:
> [ 3.751710] [<7d4a6f47>] aspeed_lpc_snoop_irq
> [ 3.756139] [<77501825>] aspeed_kcs_irq
> [ 3.760031] Disabling IRQ #32
> [ 3.763218] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-03 15:56 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 15:56 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/2/2021 6:09 PM, Zev Weiss wrote:
> On Tue, Nov 02, 2021 at 05:54:30PM PDT, Jae Hyun Yoo wrote:
>>
>>
>> On 11/2/2021 5:30 PM, Zev Weiss wrote:
>>> On Tue, Nov 02, 2021 at 05:17:30PM PDT, Jae Hyun Yoo wrote:
>>>> Hi Zev,
>>>>
>>>> On 11/2/2021 5:04 PM, Zev Weiss wrote:
>>>>> On Mon, Nov 01, 2021 at 04:36:38PM PDT, Joel Stanley wrote:
>>>>>> On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>>>>>>>
>>>>>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>>>>>
>>>>>>> Hello all,
>>>>>>>
>>>>>>> This series is for appliying below fix to all Aspped LPC sub
>>>>>>> drivers.
>>>>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> An LPC sub driver can be enabled without using the lpc-ctrl
>>>>>>> driver or it
>>>>>>> can be registered ahead of lpc-ctrl depends on each system
>>>>>>> configuration and
>>>>>>> this difference introduces that LPC can be enabled without heart
>>>>>>> beating of
>>>>>>> LCLK so it causes improper handling on host interrupts when the
>>>>>>> host sends
>>>>>>> interrupts in that time frame. Then kernel eventually forcibly
>>>>>>> disables the
>>>>>>> interrupt with dumping stack and printing a 'nobody cared this
>>>>>>> irq' message
>>>>>>> out.
>>>>>>>
>>>>>>> To prevent this issue, all LPC sub drivers should enable LCLK
>>>>>>> individually
>>>>>>> so this patch adds clock control logic into the remaining Aspeed
>>>>>>> LPC sub
>>>>>>> drivers.
>>>>>>
>>>>>> Thanks for sending this out!
>>>>>>
>>>>>> This will resolve a few of the issues we have in the issue tracker:
>>>>>>
>>>>>> https://github.com/openbmc/linux/issues/210
>>>>>> https://github.com/openbmc/linux/issues/130
>>>>>>
>>>>>> The patches look good to me. I think you've just missed Corey's PR
>>>>>> for
>>>>>> v5.16, but I will stick them in the openbmc tree once they've had a
>>>>>> review.
>>>>>>
>>>>>
>>>>> Hi Jae,
>>>>>
>>>>> I tried this series out on the same in-progress OpenBMC port from
>>>>> issue number 210 linked above and am still seeing problems (dmesg
>>>>> pasted below).
>>>>>
>>>>> I cherry-picked commit f9241fe8b9652 ("ARM: dts: aspeed: Add uart
>>>>> routing to device tree") from linux-next to allow the first patch
>>>>> to apply cleanly; is there anything else I might be missing that'd
>>>>> be needed to test the series properly?
>>>>
>>>> Looks like below dmesg shows an error from 'aspeed_lpc_snoop_probe'
>>>> which this series doesn't touch. Do you have below fix in your code
>>>> tree?
>>>>
>>>> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Jae
>>>>
>>>
>>> Yes, I've got that patch (commit 3f94cf1558), and the accompanying
>>> dts update to add the clocks property to the lpc-snoop device (commit
>>> d050d049f8).
>>>
>>> However, while there is an aspeed_lpc_snoop_probe() backtrace there,
>>> note that there's *also* one from aspeed_kcs_probe() further on
>>> (starting at timestamp 3.263306).
>>>
>>>
>>> Zev
>>>
>>
>> Can you please test additional changes below?
>>
>
> No clear improvement with that unfortunately (note that the formatting
> of the patch got pretty mangled there and required a lot of manual
> tweaking to apply, but I think I tested the intended thing).
>
> dmesg results below.
>
>
> Zev
Hi Zev,
Not sure but looks like one of LPC functions is enabled while kernel
booting. What do you see if you remove all the changes in this series?
I'm also sharing my suggestions for testing below.
- Disable if any LPC function is enabled in boot loader and test it
again.
- If you see the issue when BMC reboots, check LPC is being reset by
EXTRST or watchdog resets. Means that WDT20[11] and SCU070[11] should
be set.
- Disable all LPC sub functions and see if the issue reproduced. And
then, enable the sub functions one by one and find out which sub
function causes the issue.
- Patches I provided should be applied without making any manual touch
if you apply this series on top of 'next-20211102' tag. Please check
cherry pick if you find any relevant changes in the next queue.
- As a last resort, enable LCLK always by adding CLK_IS_CRITICAL flag
in clk-ast2600.c as Chiawei mentioned. If it works, you may need to
wait for the fix from Chiawei.
Thanks,
Jae
>
> [ 0.425073] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 0.425118] CPU: 0 PID: 1 Comm: swapper Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 0.425161] Hardware name: Generic DT based system
> [ 0.425185] Backtrace: [ 0.425219] [<807e6504>] (dump_backtrace)
> from [<807e6758>] (show_stack+0x20/0x24)
> [ 0.425315] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 0.425339] [<807e6738>] (show_stack) from [<807f09f0>]
> (dump_stack+0x28/0x30)
> [ 0.425397] [<807f09c8>] (dump_stack) from [<807e76e0>]
> (__report_bad_irq+0x40/0xc0)
> [ 0.425454] r5:00000000 r4:80d43900
> [ 0.425473] [<807e76a0>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 0.425555] r9:80cbc000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 0.425577] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 0.425637] r10:00000000 r9:80cbc000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 0.425663] r4:80d43900 r3:00000000
> [ 0.425681] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 0.425738] r5:00000000 r4:80d43900
> [ 0.425758] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 0.425811] r5:00000000 r4:80b8e7c8
> [ 0.425829] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 0.425886] r7:80cbdc94 r6:ffffffff r5:80cbdc60 r4:80c02420
> [ 0.425908] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 0.425954] Exception stack(0x80cbdc60 to 0x80cbdca8)
> [ 0.425994] dc60: 00000000 00000000 00000000 00000000 80d43900
> 00000000 8529d700 00000020
> [ 0.426029] dc80: 80d439a8 60000053 00000000 80cbdcdc 00000000
> 80cbdcb0 8015a520 80157d4c
> [ 0.426057] dca0: 40000053 ffffffff
> [ 0.426083] r5:40000053 r4:80157d4c
> [ 0.426101] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 0.426166] r9:852b07a0 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:8529d700
> [ 0.426186] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 0.426257] r10:8092ed9c r9:00000000 r8:852b07a0 r7:80d42410
> r6:00000020 r5:804600bc
> [ 0.426283] r4:8529d220 r3:00000080
> [ 0.426302] [<8015bd08>] (devm_request_threaded_irq) from
> [<80460514>] (aspeed_lpc_snoop_probe+0x15c/0x2e0)
> [ 0.426392] r10:80bab000 r9:80983b68 r8:80d42410 r7:8529d100
> r6:80d42400 r5:852b07a0
> [ 0.426414] r4:00000000
> [ 0.426431] [<804603b8>] (aspeed_lpc_snoop_probe) from [<804e69a8>]
> (platform_probe+0x54/0x9c)
> [ 0.426515] r8:00000000 r7:80d42410 r6:80b6f3dc r5:80b6f3dc r4:80d42410
> [ 0.426535] [<804e6954>] (platform_probe) from [<804e4534>]
> (really_probe+0x1c4/0x46c)
> [ 0.426588] r5:00000000 r4:80d42410
> [ 0.426609] [<804e4370>] (really_probe) from [<804e48b0>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 0.426661] r7:80d42410 r6:80d42410 r5:80bcb44c r4:80b6f3dc
> [ 0.426679] [<804e47dc>] (__driver_probe_device) from [<804e49d8>]
> (driver_probe_device+0x40/0xd8)
> [ 0.426736] r9:80983b68 r8:00000000 r7:80d42410 r6:80b6f3dc r4:80bcb340
> [ 0.426757] [<804e4998>] (driver_probe_device) from [<804e4d3c>]
> (__driver_attach+0xa4/0x1c8)
> [ 0.426814] r9:80983b68 r8:80a2c838 r7:80b71638 r6:80b6f3dc
> r5:80d42454 r4:80d42410
> [ 0.426834] [<804e4c98>] (__driver_attach) from [<804e214c>]
> (bus_for_each_dev+0x84/0xd0)
> [ 0.426890] r7:80b71638 r6:804e4c98 r5:80b6f3dc r4:00000000
> [ 0.426912] [<804e20c8>] (bus_for_each_dev) from [<804e5468>]
> (driver_attach+0x28/0x30)
> [ 0.426964] r6:00000000 r5:852aa660 r4:80b6f3dc
> [ 0.426984] [<804e5440>] (driver_attach) from [<804e2ae8>]
> (bus_add_driver+0x114/0x200)
> [ 0.427028] [<804e29d4>] (bus_add_driver) from [<804e5b04>]
> (driver_register+0x98/0x128)
> [ 0.427080] r7:00000000 r6:00000007 r5:00000000 r4:80b6f3dc
> [ 0.427100] [<804e5a6c>] (driver_register) from [<804e7c54>]
> (__platform_driver_register+0x2c/0x34)
> [ 0.427159] r5:80c03e40 r4:80a1997c
> [ 0.427179] [<804e7c28>] (__platform_driver_register) from
> [<80a1999c>] (aspeed_lpc_snoop_driver_init+0x20/0x28)
> [ 0.427237] [<80a1997c>] (aspeed_lpc_snoop_driver_init) from
> [<80a01408>] (do_one_initcall+0x64/0x144)
> [ 0.427310] [<80a013a4>] (do_one_initcall) from [<80a016e4>]
> (kernel_init_freeable+0x198/0x218)
> [ 0.427377] r7:80a2c858 r6:00000007 r5:80c03e40 r4:80a4c8f0
> [ 0.427399] [<80a0154c>] (kernel_init_freeable) from [<807f0c48>]
> (kernel_init+0x20/0x134)
> [ 0.427463] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:807f0c28
> [ 0.427487] r4:00000000
> [ 0.427506] [<807f0c28>] (kernel_init) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 0.427556] Exception stack(0x80cbdfb0 to 0x80cbdff8)
> [ 0.427593] dfa0: 00000000
> 00000000 00000000 00000000
> [ 0.427628] dfc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 0.427660] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 0.427688] r5:807f0c28 r4:00000000
> [ 0.427706] handlers:
> [ 0.427723] [<(ptrval)>] aspeed_lpc_snoop_irq
> [ 0.427791] Disabling IRQ #32
> [ 0.638760] Serial: 8250/16550 driver, 6 ports, IRQ sharing enabled
> [ 0.649120] 1e787000.serial: ttyS5 at MMIO 0x1e787000 (irq = 32,
> base_baud = 1546875) is a 8250
> [ 0.651220] 1e784000.serial: ttyS4 at MMIO 0x1e784000 (irq = 31,
> base_baud = 1500000) is a 16550A
> [ 2.020143] Freeing initrd memory: 1072K
> [ 2.234013] printk: console [ttyS4] enabled
> [ 2.240436] timeriomem_rng 1e6e2078.hwrng: 32bits from 0x5a0c8e0a @ 1us
> [ 2.263519] loop: module loaded
> [ 2.285336] aspeed-smc 1e620000.spi: Using 100 MHz SPI frequency
> [ 2.291781] aspeed-smc 1e620000.spi: mx66l51235f (65536 Kbytes)
> [ 2.297774] aspeed-smc 1e620000.spi: CE0 window [ 0x20000000 -
> 0x24000000 ] 64MB
> [ 2.305301] aspeed-smc 1e620000.spi: CE1 window [ 0x24000000 -
> 0x2a000000 ] 96MB
> [ 2.312810] aspeed-smc 1e620000.spi: read control register: 203c0641
> [ 2.543850] 5 fixed-partitions partitions found on MTD device bmc
> [ 2.550093] Creating 5 MTD partitions on "bmc":
> [ 2.554677] 0x000000000000-0x0000000e0000 : "u-boot"
> [ 2.562517] 0x0000000e0000-0x000000100000 : "u-boot-env"
> [ 2.570803] 0x000000100000-0x000000a00000 : "kernel"
> [ 2.578741] 0x000000a00000-0x000002a00000 : "rofs"
> [ 2.586351] 0x000002a00000-0x000004000000 : "rwfs"
> [ 2.595769] aspeed-smc 1e630000.spi: Using 50 MHz SPI frequency
> [ 2.601925] aspeed-smc 1e630000.spi: unrecognized JEDEC id bytes: 00
> 00 00 00 00 00
> [ 2.609715] aspeed-smc 1e630000.spi: Aspeed SMC probe failed -2
> [ 2.615673] aspeed-smc: probe of 1e630000.spi failed with error -2
> [ 2.629807] libphy: Fixed MDIO Bus: probed
> [ 2.635910] ftgmac100 1e660000.ethernet: Read MAC address
> d0:50:99:f4:1e:18 from chip
> [ 2.652487] libphy: ftgmac100_mdio: probed
> [ 2.657714] RTL8211E Gigabit Ethernet 1e660000.ethernet--1:00:
> attached PHY driver (mii_bus:phy_addr=1e660000.ethernet--1:00, irq=POLL)
> [ 2.671153] ftgmac100 1e660000.ethernet eth0: irq 20, mapped at 31b7a2b2
> [ 2.681960] aspeed_vhub 1e6a0000.usb-vhub: Initialized virtual hub in
> USB2 mode
> [ 2.689974] Mass Storage Function, version: 2009/09/11
> [ 2.695169] LUN: removable file: (no medium)
> [ 2.699621] no file given for LUN0
> [ 2.703126] g_mass_storage 1e6a0000.usb-vhub:p1: failed to start
> g_mass_storage: -22
> [ 2.711656] i2c /dev entries driver
> [ 2.717000] aspeed-i2c-bus 1e78a040.i2c-bus: i2c bus 0 registered,
> irq 33
> [ 2.725583] aspeed-i2c-bus 1e78a080.i2c-bus: i2c bus 1 registered,
> irq 34
> [ 2.735502] aspeed-i2c-bus 1e78a0c0.i2c-bus: i2c bus 2 registered,
> irq 35
> [ 2.743830] aspeed-i2c-bus 1e78a100.i2c-bus: i2c bus 3 registered,
> irq 36
> [ 2.752145] aspeed-i2c-bus 1e78a140.i2c-bus: i2c bus 4 registered,
> irq 37
> [ 2.761322] aspeed-i2c-bus 1e78a180.i2c-bus: i2c bus 5 registered,
> irq 38
> [ 2.769610] aspeed-i2c-bus 1e78a1c0.i2c-bus: i2c bus 6 registered,
> irq 39
> [ 2.779443] at24 7-0050: 16384 byte 24c128 EEPROM, writable, 16
> bytes/write
> [ 2.786675] aspeed-i2c-bus 1e78a300.i2c-bus: i2c bus 7 registered,
> irq 40
> [ 2.794972] aspeed-i2c-bus 1e78a340.i2c-bus: i2c bus 8 registered,
> irq 41
> [ 2.803273] aspeed-i2c-bus 1e78a380.i2c-bus: i2c bus 9 registered,
> irq 42
> [ 2.816561] at24 14-0050: 2048 byte 24c16 EEPROM, read-only
> [ 2.822535] i2c i2c-2: Added multiplexed i2c bus 14
> [ 2.828115] i2c i2c-2: Added multiplexed i2c bus 15
> [ 2.833787] i2c i2c-2: Added multiplexed i2c bus 16
> [ 2.839596] i2c i2c-2: Added multiplexed i2c bus 17
> [ 2.844572] pca954x 2-0070: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.853735] i2c i2c-5: Added multiplexed i2c bus 18
> [ 2.859577] i2c i2c-5: Added multiplexed i2c bus 19
> [ 2.865233] i2c i2c-5: Added multiplexed i2c bus 20
> [ 2.871052] i2c i2c-5: Added multiplexed i2c bus 21
> [ 2.876022] pca954x 5-0073: registered 4 multiplexed busses for I2C
> switch pca9545
> [ 2.886206] Driver for 1-wire Dallas network protocol.
> [ 3.011064] NET: Registered PF_INET6 protocol family
> [ 3.019138] Segment Routing with IPv6
> [ 3.023663] NET: Registered PF_PACKET protocol family
> [ 3.029388] 8021q: 802.1Q VLAN Support v1.8
> [ 3.044832] ast-kcs-bmc 1e78902c.kcs: Initialised raw client for
> channel 3
> [ 3.052335] ast-kcs-bmc 1e78902c.kcs: Initialised IPMI client for
> channel 3
> [ 3.274513] irq 32: nobody cared (try booting with the "irqpoll" option)
> [ 3.281266] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted
> 5.14.11-aee45db-dirty-4b119be-hacked #1
> [ 3.290082] Hardware name: Generic DT based system
> [ 3.294891] Workqueue: events_unbound deferred_probe_work_func
> [ 3.300786] Backtrace: [ 3.303263] [<807e6504>] (dump_backtrace)
> from [<807e6758>] (show_stack+0x20/0x24)
> [ 3.310902] r7:00000000 r6:00000008 r5:00000000 r4:80902b50
> [ 3.316567] [<807e6738>] (show_stack) from [<807f09f0>]
> (dump_stack+0x28/0x30)
> [ 3.323841] [<807f09c8>] (dump_stack) from [<807e76e0>]
> (__report_bad_irq+0x40/0xc0)
> [ 3.331628] r5:00000000 r4:80d43900
> [ 3.335217] [<807e76a0>] (__report_bad_irq) from [<80159c10>]
> (note_interrupt+0x284/0x2dc)
> [ 3.343542] r9:80cc6000 r8:00000020 r7:00000000 r6:00000008
> r5:00000000 r4:80d43900
> [ 3.351293] [<8015998c>] (note_interrupt) from [<801569d4>]
> (handle_irq_event+0xb4/0xc0)
> [ 3.359437] r10:00000000 r9:80cc6000 r8:80d439a8 r7:00000000
> r6:00000008 r5:00000000
> [ 3.367270] r4:80d43900 r3:00000400
> [ 3.370854] [<80156920>] (handle_irq_event) from [<8015acd0>]
> (handle_level_irq+0xac/0x180)
> [ 3.379251] r5:00000000 r4:80d43900
> [ 3.382841] [<8015ac24>] (handle_level_irq) from [<80155fa4>]
> (handle_domain_irq+0x60/0x7c)
> [ 3.391239] r5:00000000 r4:80b8e7c8
> [ 3.394826] [<80155f44>] (handle_domain_irq) from [<8010121c>]
> (avic_handle_irq+0x64/0x6c)
> [ 3.403140] r7:80cc7c84 r6:ffffffff r5:80cc7c50 r4:80c02420
> [ 3.408814] [<801011b8>] (avic_handle_irq) from [<80100aec>]
> (__irq_svc+0x6c/0x90)
> [ 3.416417] Exception stack(0x80cc7c50 to 0x80cc7c98)
> [ 3.421493] 7c40: 00000000
> 00000000 00000000 00000000
> [ 3.429688] 7c60: 80d43900 8529d700 851206c0 00000020 80d439a8
> a0000013 00000000 80cc7ccc
> [ 3.437876] 7c80: 00000400 80cc7ca0 8015a520 80157d4c 40000013 ffffffff
> [ 3.444502] r5:40000013 r4:80157d4c
> [ 3.448091] [<80157a0c>] (__setup_irq) from [<8015844c>]
> (request_threaded_irq+0xe8/0x16c)
> [ 3.456407] r9:8505fb20 r8:00000020 r7:80d43910 r6:80d43900
> r5:00000000 r4:851206c0
> [ 3.464160] [<80158364>] (request_threaded_irq) from [<8015bd80>]
> (devm_request_threaded_irq+0x78/0xd0)
> [ 3.473613] r10:80d4ea20 r9:00000000 r8:8505fb20 r7:80d42c10
> r6:00000020 r5:8044fd64
> [ 3.481452] r4:851207a0 r3:00000080
> [ 3.485037] [<8015bd08>] (devm_request_threaded_irq) from
> [<804505f0>] (aspeed_kcs_probe+0x244/0x67c)
> [ 3.494324] r10:8505fb54 r9:80833650 r8:ffffffea r7:80d42c10
> r6:00000020 r5:8505fb20
> [ 3.502166] r4:80d42c00
> [ 3.504710] [<804503ac>] (aspeed_kcs_probe) from [<804e69a8>]
> (platform_probe+0x54/0x9c)
> [ 3.512873] r10:8093c994 r9:80b9b840 r8:00000001 r7:80d42c10
> r6:80b6e7b0 r5:80b6e7b0
> [ 3.520712] r4:80d42c10
> [ 3.523256] [<804e6954>] (platform_probe) from [<804e4534>]
> (really_probe+0x1c4/0x46c)
> [ 3.531220] r5:00000000 r4:80d42c10
> [ 3.534810] [<804e4370>] (really_probe) from [<804e48b0>]
> (__driver_probe_device+0xd4/0x1bc)
> [ 3.543288] r7:80d42c10 r6:80d42c10 r5:80bcb44c r4:80b6e7b0
> [ 3.548954] [<804e47dc>] (__driver_probe_device) from [<804e49d8>]
> (driver_probe_device+0x40/0xd8)
> [ 3.557954] r9:80b9b840 r8:00000001 r7:80d42c10 r6:80cc7e84 r4:80bcb340
> [ 3.564658] [<804e4998>] (driver_probe_device) from [<804e4c08>]
> (__device_attach_driver+0xb8/0x148)
> [ 3.573831] r9:80b9b840 r8:00000000 r7:80d42c10 r6:80cc7e84
> r5:80b6e7b0 r4:00000001
> [ 3.581576] [<804e4b50>] (__device_attach_driver) from [<804e2670>]
> (bus_for_each_drv+0x90/0xe0)
> [ 3.590408] r7:80b71484 r6:804e4b50 r5:80cc7e84 r4:00000000
> [ 3.596074] [<804e25e0>] (bus_for_each_drv) from [<804e4f64>]
> (__device_attach+0x104/0x18c)
> [ 3.604473] r6:80d42c54 r5:00000001 r4:80d42c10
> [ 3.609101] [<804e4e60>] (__device_attach) from [<804e5394>]
> (device_initial_probe+0x1c/0x20)
> [ 3.617673] r6:80d42c10 r5:80b71638 r4:80d4ca50
> [ 3.622299] [<804e5378>] (device_initial_probe) from [<804e2888>]
> (bus_probe_device+0x94/0x9c)
> [ 3.630944] [<804e27f4>] (bus_probe_device) from [<804e3f64>]
> (deferred_probe_work_func+0xa0/0xe8)
> [ 3.639948] r7:80b71484 r6:80b71470 r5:80d42c10 r4:80d4ca50
> [ 3.645613] [<804e3ec4>] (deferred_probe_work_func) from [<801301ac>]
> (process_one_work+0x1b4/0x46c)
> [ 3.654797] r10:80b71490 r9:00000000 r8:00000000 r7:80c85d00
> r6:00000040 r5:80c045a0
> [ 3.662640] r4:80b7148c r3:804e3ec4
> [ 3.666223] [<8012fff8>] (process_one_work) from [<8013066c>]
> (worker_thread+0x208/0x528)
> [ 3.674443] r10:80c08a00 r9:00000088 r8:80b46840 r7:80c08a14
> r6:80c045b4 r5:80c08a00
> [ 3.682284] r4:80c045a0
> [ 3.684822] [<80130464>] (worker_thread) from [<80136f18>]
> (kthread+0x138/0x160)
> [ 3.692272] r10:80c03860 r9:80cbde60 r8:80cc6000 r7:80c045a0
> r6:80130464 r5:80c03840
> [ 3.700112] r4:80c02b80
> [ 3.702658] [<80136de0>] (kthread) from [<80100130>]
> (ret_from_fork+0x14/0x24)
> [ 3.709921] Exception stack(0x80cc7fb0 to 0x80cc7ff8)
> [ 3.714999] 7fa0: 00000000
> 00000000 00000000 00000000
> [ 3.723192] 7fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 3.731378] 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 3.738012] r10:00000000 r9:00000000 r8:00000000 r7:00000000
> r6:00000000 r5:80136de0
> [ 3.745847] r4:80c02b80 r3:00000000
> [ 3.749431] handlers:
> [ 3.751710] [<7d4a6f47>] aspeed_lpc_snoop_irq
> [ 3.756139] [<77501825>] aspeed_kcs_irq
> [ 3.760031] Disabling IRQ #32
> [ 3.763218] ast-kcs-bmc 1e78902c.kcs: Initialised channel 3 at 0xca2
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-03 15:56 ` Jae Hyun Yoo
@ 2021-11-04 1:48 ` Zev Weiss
-1 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-04 1:48 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Wed, Nov 03, 2021 at 08:56:10AM PDT, Jae Hyun Yoo wrote:
>
>Hi Zev,
>
>Not sure but looks like one of LPC functions is enabled while kernel
>booting.
>
Looks like that was exactly the clue I needed -- obvious in retrospect,
but I realize now that I'm only seeing this happen when I bypass the
normal shutdown sequence via 'reboot -f'; with a plain 'reboot' I don't
hit any problems. Can you reproduce it that way?
Zev
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-04 1:48 ` Zev Weiss
0 siblings, 0 replies; 66+ messages in thread
From: Zev Weiss @ 2021-11-04 1:48 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On Wed, Nov 03, 2021 at 08:56:10AM PDT, Jae Hyun Yoo wrote:
>
>Hi Zev,
>
>Not sure but looks like one of LPC functions is enabled while kernel
>booting.
>
Looks like that was exactly the clue I needed -- obvious in retrospect,
but I realize now that I'm only seeing this happen when I bypass the
normal shutdown sequence via 'reboot -f'; with a plain 'reboot' I don't
hit any problems. Can you reproduce it that way?
Zev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
2021-11-04 1:48 ` Zev Weiss
@ 2021-11-04 16:09 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-04 16:09 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/3/2021 6:48 PM, Zev Weiss wrote:
> On Wed, Nov 03, 2021 at 08:56:10AM PDT, Jae Hyun Yoo wrote:
>>
>> Hi Zev,
>>
>> Not sure but looks like one of LPC functions is enabled while kernel
>> booting.
>
> Looks like that was exactly the clue I needed -- obvious in retrospect,
> but I realize now that I'm only seeing this happen when I bypass the
> normal shutdown sequence via 'reboot -f'; with a plain 'reboot' I don't
> hit any problems. Can you reproduce it that way?
My system doesn't follow the reproduction pattern. What I usually do to
reproduce it is, making a host reset and followed by making a BMC reset
then host will try to send something through KCS channel and snoop-80
while BMC LPC drivers are being loaded. It's not easy to reproduce it
using my system and it's very timing sensitive.
As I suggested in previous email, disable all LPC sub functions and
enable back one by one. It could help for identifying which LPC sub
module causes the issue.
-Jae
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers
@ 2021-11-04 16:09 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-04 16:09 UTC (permalink / raw)
To: Zev Weiss
Cc: Joel Stanley, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, devicetree,
Linux ARM, linux-aspeed, openipmi-developer
On 11/3/2021 6:48 PM, Zev Weiss wrote:
> On Wed, Nov 03, 2021 at 08:56:10AM PDT, Jae Hyun Yoo wrote:
>>
>> Hi Zev,
>>
>> Not sure but looks like one of LPC functions is enabled while kernel
>> booting.
>
> Looks like that was exactly the clue I needed -- obvious in retrospect,
> but I realize now that I'm only seeing this happen when I bypass the
> normal shutdown sequence via 'reboot -f'; with a plain 'reboot' I don't
> hit any problems. Can you reproduce it that way?
My system doesn't follow the reproduction pattern. What I usually do to
reproduce it is, making a host reset and followed by making a BMC reset
then host will try to send something through KCS channel and snoop-80
while BMC LPC drivers are being loaded. It's not easy to reproduce it
using my system and it's very timing sensitive.
As I suggested in previous email, disable all LPC sub functions and
enable back one by one. It could help for identifying which LPC sub
module causes the issue.
-Jae
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:37 ` jae.hyun.yoo
-1 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Add LCLK clock setting into LPC IBT node to enable the LCLK by
individual LPC sub drivers.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
arch/arm/boot/dts/aspeed-g6.dtsi | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index b313a1cf5f73..f14dace34c5a 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -381,6 +381,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2400-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index c7049454c7cb..d0cc4be2de59 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -507,6 +507,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2500-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
};
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 5106a424f1ce..465c3549fdc3 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -581,6 +581,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2600-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 66+ messages in thread* [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-01 23:37 ` jae.hyun.yoo
0 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Add LCLK clock setting into LPC IBT node to enable the LCLK by
individual LPC sub drivers.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
arch/arm/boot/dts/aspeed-g6.dtsi | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index b313a1cf5f73..f14dace34c5a 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -381,6 +381,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2400-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index c7049454c7cb..d0cc4be2de59 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -507,6 +507,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2500-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
};
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 5106a424f1ce..465c3549fdc3 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -581,6 +581,7 @@ ibt: ibt@140 {
compatible = "aspeed,ast2600-ibt-bmc";
reg = <0x140 0x18>;
interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:33 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:33 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC IBT node to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Do you need to update the bindings too?
> ---
> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g6.dtsi | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index b313a1cf5f73..f14dace34c5a 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -381,6 +381,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2400-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index c7049454c7cb..d0cc4be2de59 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -507,6 +507,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2500-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 5106a424f1ce..465c3549fdc3 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -581,6 +581,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2600-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-01 23:33 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:33 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC IBT node to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Do you need to update the bindings too?
> ---
> arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
> arch/arm/boot/dts/aspeed-g6.dtsi | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index b313a1cf5f73..f14dace34c5a 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -381,6 +381,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2400-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index c7049454c7cb..d0cc4be2de59 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -507,6 +507,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2500-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 5106a424f1ce..465c3549fdc3 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -581,6 +581,7 @@ ibt: ibt@140 {
> compatible = "aspeed,ast2600-ibt-bmc";
> reg = <0x140 0x18>;
> interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
> };
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:33 ` Joel Stanley
@ 2021-11-01 23:48 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-01 23:48 UTC (permalink / raw)
To: Joel Stanley, Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Do you need to update the bindings too?
Hi Joel,
Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
in v2. Thanks a lot for your review and for reminding me. :)
Cheers,
Jae
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-01 23:48 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-01 23:48 UTC (permalink / raw)
To: Joel Stanley, Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Do you need to update the bindings too?
Hi Joel,
Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
in v2. Thanks a lot for your review and for reminding me. :)
Cheers,
Jae
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:48 ` Jae Hyun Yoo
@ 2021-11-01 23:52 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:52 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On Mon, 1 Nov 2021 at 23:48, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> >
> > Do you need to update the bindings too?
>
> Hi Joel,
>
> Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
> in v2. Thanks a lot for your review and for reminding me. :)
Note that they've moved to Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
You can find this commit in linux-next.
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-01 23:52 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:52 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On Mon, 1 Nov 2021 at 23:48, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> >
> > Do you need to update the bindings too?
>
> Hi Joel,
>
> Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
> in v2. Thanks a lot for your review and for reminding me. :)
Note that they've moved to Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
You can find this commit in linux-next.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:52 ` Joel Stanley
@ 2021-11-01 23:59 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-01 23:59 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On 11/1/2021 4:52 PM, Joel Stanley wrote:
> On Mon, 1 Nov 2021 at 23:48, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>>
>>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>>>
>>> Do you need to update the bindings too?
>>
>> Hi Joel,
>>
>> Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
>> in v2. Thanks a lot for your review and for reminding me. :)
>
> Note that they've moved to Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>
> You can find this commit in linux-next.
>
Got it. Thanks again!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-01 23:59 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-01 23:59 UTC (permalink / raw)
To: Joel Stanley
Cc: Jae Hyun Yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, Linux ARM,
linux-aspeed, openipmi-developer
On 11/1/2021 4:52 PM, Joel Stanley wrote:
> On Mon, 1 Nov 2021 at 23:48, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>>
>>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>>>
>>> Do you need to update the bindings too?
>>
>> Hi Joel,
>>
>> Right, I have to update 'aspeed,ast2400-ibt-bmc.txt'. Will add update
>> in v2. Thanks a lot for your review and for reminding me. :)
>
> Note that they've moved to Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
>
> You can find this commit in linux-next.
>
Got it. Thanks again!
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-02 22:21 ` Andrew Jeffery
-1 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:21 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC IBT node to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node
@ 2021-11-02 22:21 ` Andrew Jeffery
0 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:21 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC IBT node to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH -next 2/4] ipmi: bt: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:37 ` jae.hyun.yoo
-1 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
hardware block will be enabled without heart beating of LCLK until
lpc-ctrl enables the LCLK. This issue causes improper handling on
host interrupts when the host sends interrupts in that time frame.
Then kernel eventually forcibly disables the interrupt with
dumping stack and printing a 'nobody cared this irq' message out.
To prevent this issue, all LPC sub drivers should enable LCLK
individually so this patch adds clock control logic into the LPC
BT driver.
Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index 7450904e330a..a20f92cc7b18 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -5,6 +5,7 @@
#include <linux/atomic.h>
#include <linux/bt-bmc.h>
+#include <linux/clk.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -62,6 +63,7 @@ struct bt_bmc {
wait_queue_head_t queue;
struct timer_list poll_timer;
struct mutex mutex;
+ struct clk *clk;
};
static atomic_t open_count = ATOMIC_INIT(0);
@@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
if (IS_ERR(bt_bmc->base))
return PTR_ERR(bt_bmc->base);
+ bt_bmc->clk = devm_clk_get(dev, NULL);
+ if (IS_ERR(bt_bmc->clk)) {
+ rc = PTR_ERR(bt_bmc->clk);
+ if (rc != -EPROBE_DEFER)
+ dev_err(dev, "Unable to get clock\n");
+ return rc;
+ }
+ rc = clk_prepare_enable(bt_bmc->clk);
+ if (rc) {
+ dev_err(dev, "Unable to enable clock\n");
+ return rc;
+ }
+
mutex_init(&bt_bmc->mutex);
init_waitqueue_head(&bt_bmc->queue);
@@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
rc = misc_register(&bt_bmc->miscdev);
if (rc) {
dev_err(dev, "Unable to register misc device\n");
- return rc;
+ goto err;
}
bt_bmc_config_irq(bt_bmc, pdev);
@@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
clr_b_busy(bt_bmc);
return 0;
+
+err:
+ clk_disable_unprepare(bt_bmc->clk);
+
+ return rc;
}
static int bt_bmc_remove(struct platform_device *pdev)
@@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
misc_deregister(&bt_bmc->miscdev);
if (bt_bmc->irq < 0)
del_timer_sync(&bt_bmc->poll_timer);
+ clk_disable_unprepare(bt_bmc->clk);
+
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 66+ messages in thread* [PATCH -next 2/4] ipmi: bt: add clock control logic
@ 2021-11-01 23:37 ` jae.hyun.yoo
0 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
hardware block will be enabled without heart beating of LCLK until
lpc-ctrl enables the LCLK. This issue causes improper handling on
host interrupts when the host sends interrupts in that time frame.
Then kernel eventually forcibly disables the interrupt with
dumping stack and printing a 'nobody cared this irq' message out.
To prevent this issue, all LPC sub drivers should enable LCLK
individually so this patch adds clock control logic into the LPC
BT driver.
Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index 7450904e330a..a20f92cc7b18 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -5,6 +5,7 @@
#include <linux/atomic.h>
#include <linux/bt-bmc.h>
+#include <linux/clk.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -62,6 +63,7 @@ struct bt_bmc {
wait_queue_head_t queue;
struct timer_list poll_timer;
struct mutex mutex;
+ struct clk *clk;
};
static atomic_t open_count = ATOMIC_INIT(0);
@@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
if (IS_ERR(bt_bmc->base))
return PTR_ERR(bt_bmc->base);
+ bt_bmc->clk = devm_clk_get(dev, NULL);
+ if (IS_ERR(bt_bmc->clk)) {
+ rc = PTR_ERR(bt_bmc->clk);
+ if (rc != -EPROBE_DEFER)
+ dev_err(dev, "Unable to get clock\n");
+ return rc;
+ }
+ rc = clk_prepare_enable(bt_bmc->clk);
+ if (rc) {
+ dev_err(dev, "Unable to enable clock\n");
+ return rc;
+ }
+
mutex_init(&bt_bmc->mutex);
init_waitqueue_head(&bt_bmc->queue);
@@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
rc = misc_register(&bt_bmc->miscdev);
if (rc) {
dev_err(dev, "Unable to register misc device\n");
- return rc;
+ goto err;
}
bt_bmc_config_irq(bt_bmc, pdev);
@@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
clr_b_busy(bt_bmc);
return 0;
+
+err:
+ clk_disable_unprepare(bt_bmc->clk);
+
+ return rc;
}
static int bt_bmc_remove(struct platform_device *pdev)
@@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
misc_deregister(&bt_bmc->miscdev);
if (bt_bmc->irq < 0)
del_timer_sync(&bt_bmc->poll_timer);
+ clk_disable_unprepare(bt_bmc->clk);
+
return 0;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:32 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:32 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 7450904e330a..a20f92cc7b18 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -5,6 +5,7 @@
>
> #include <linux/atomic.h>
> #include <linux/bt-bmc.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -62,6 +63,7 @@ struct bt_bmc {
> wait_queue_head_t queue;
> struct timer_list poll_timer;
> struct mutex mutex;
> + struct clk *clk;
> };
>
> static atomic_t open_count = ATOMIC_INIT(0);
> @@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
> if (IS_ERR(bt_bmc->base))
> return PTR_ERR(bt_bmc->base);
>
> + bt_bmc->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(bt_bmc->clk)) {
> + rc = PTR_ERR(bt_bmc->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(dev, "Unable to get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(bt_bmc->clk);
> + if (rc) {
> + dev_err(dev, "Unable to enable clock\n");
> + return rc;
> + }
> +
> mutex_init(&bt_bmc->mutex);
> init_waitqueue_head(&bt_bmc->queue);
>
> @@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
> rc = misc_register(&bt_bmc->miscdev);
> if (rc) {
> dev_err(dev, "Unable to register misc device\n");
> - return rc;
> + goto err;
> }
>
> bt_bmc_config_irq(bt_bmc, pdev);
> @@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
> clr_b_busy(bt_bmc);
>
> return 0;
> +
> +err:
> + clk_disable_unprepare(bt_bmc->clk);
> +
> + return rc;
> }
>
> static int bt_bmc_remove(struct platform_device *pdev)
> @@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
> misc_deregister(&bt_bmc->miscdev);
> if (bt_bmc->irq < 0)
> del_timer_sync(&bt_bmc->poll_timer);
> + clk_disable_unprepare(bt_bmc->clk);
> +
> return 0;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
@ 2021-11-01 23:32 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:32 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 7450904e330a..a20f92cc7b18 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -5,6 +5,7 @@
>
> #include <linux/atomic.h>
> #include <linux/bt-bmc.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -62,6 +63,7 @@ struct bt_bmc {
> wait_queue_head_t queue;
> struct timer_list poll_timer;
> struct mutex mutex;
> + struct clk *clk;
> };
>
> static atomic_t open_count = ATOMIC_INIT(0);
> @@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
> if (IS_ERR(bt_bmc->base))
> return PTR_ERR(bt_bmc->base);
>
> + bt_bmc->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(bt_bmc->clk)) {
> + rc = PTR_ERR(bt_bmc->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(dev, "Unable to get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(bt_bmc->clk);
> + if (rc) {
> + dev_err(dev, "Unable to enable clock\n");
> + return rc;
> + }
> +
> mutex_init(&bt_bmc->mutex);
> init_waitqueue_head(&bt_bmc->queue);
>
> @@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
> rc = misc_register(&bt_bmc->miscdev);
> if (rc) {
> dev_err(dev, "Unable to register misc device\n");
> - return rc;
> + goto err;
> }
>
> bt_bmc_config_irq(bt_bmc, pdev);
> @@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
> clr_b_busy(bt_bmc);
>
> return 0;
> +
> +err:
> + clk_disable_unprepare(bt_bmc->clk);
> +
> + return rc;
> }
>
> static int bt_bmc_remove(struct platform_device *pdev)
> @@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
> misc_deregister(&bt_bmc->miscdev);
> if (bt_bmc->irq < 0)
> del_timer_sync(&bt_bmc->poll_timer);
> + clk_disable_unprepare(bt_bmc->clk);
> +
> return 0;
> }
>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-02 9:35 ` Cédric Le Goater
-1 siblings, 0 replies; 66+ messages in thread
From: Cédric Le Goater @ 2021-11-02 9:35 UTC (permalink / raw)
To: jae.hyun.yoo, Rob Herring, Corey Minyard, Joel Stanley,
Andrew Jeffery, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On 11/2/21 00:37, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
LGTM,
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 7450904e330a..a20f92cc7b18 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -5,6 +5,7 @@
>
> #include <linux/atomic.h>
> #include <linux/bt-bmc.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -62,6 +63,7 @@ struct bt_bmc {
> wait_queue_head_t queue;
> struct timer_list poll_timer;
> struct mutex mutex;
> + struct clk *clk;
> };
>
> static atomic_t open_count = ATOMIC_INIT(0);
> @@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
> if (IS_ERR(bt_bmc->base))
> return PTR_ERR(bt_bmc->base);
>
> + bt_bmc->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(bt_bmc->clk)) {
> + rc = PTR_ERR(bt_bmc->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(dev, "Unable to get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(bt_bmc->clk);
> + if (rc) {
> + dev_err(dev, "Unable to enable clock\n");
> + return rc;
> + }
> +
> mutex_init(&bt_bmc->mutex);
> init_waitqueue_head(&bt_bmc->queue);
>
> @@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
> rc = misc_register(&bt_bmc->miscdev);
> if (rc) {
> dev_err(dev, "Unable to register misc device\n");
> - return rc;
> + goto err;
> }
>
> bt_bmc_config_irq(bt_bmc, pdev);
> @@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
> clr_b_busy(bt_bmc);
>
> return 0;
> +
> +err:
> + clk_disable_unprepare(bt_bmc->clk);
> +
> + return rc;
> }
>
> static int bt_bmc_remove(struct platform_device *pdev)
> @@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
> misc_deregister(&bt_bmc->miscdev);
> if (bt_bmc->irq < 0)
> del_timer_sync(&bt_bmc->poll_timer);
> + clk_disable_unprepare(bt_bmc->clk);
> +
> return 0;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
@ 2021-11-02 9:35 ` Cédric Le Goater
0 siblings, 0 replies; 66+ messages in thread
From: Cédric Le Goater @ 2021-11-02 9:35 UTC (permalink / raw)
To: jae.hyun.yoo, Rob Herring, Corey Minyard, Joel Stanley,
Andrew Jeffery, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On 11/2/21 00:37, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
LGTM,
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> drivers/char/ipmi/bt-bmc.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 7450904e330a..a20f92cc7b18 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -5,6 +5,7 @@
>
> #include <linux/atomic.h>
> #include <linux/bt-bmc.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -62,6 +63,7 @@ struct bt_bmc {
> wait_queue_head_t queue;
> struct timer_list poll_timer;
> struct mutex mutex;
> + struct clk *clk;
> };
>
> static atomic_t open_count = ATOMIC_INIT(0);
> @@ -423,6 +425,19 @@ static int bt_bmc_probe(struct platform_device *pdev)
> if (IS_ERR(bt_bmc->base))
> return PTR_ERR(bt_bmc->base);
>
> + bt_bmc->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(bt_bmc->clk)) {
> + rc = PTR_ERR(bt_bmc->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(dev, "Unable to get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(bt_bmc->clk);
> + if (rc) {
> + dev_err(dev, "Unable to enable clock\n");
> + return rc;
> + }
> +
> mutex_init(&bt_bmc->mutex);
> init_waitqueue_head(&bt_bmc->queue);
>
> @@ -433,7 +448,7 @@ static int bt_bmc_probe(struct platform_device *pdev)
> rc = misc_register(&bt_bmc->miscdev);
> if (rc) {
> dev_err(dev, "Unable to register misc device\n");
> - return rc;
> + goto err;
> }
>
> bt_bmc_config_irq(bt_bmc, pdev);
> @@ -457,6 +472,11 @@ static int bt_bmc_probe(struct platform_device *pdev)
> clr_b_busy(bt_bmc);
>
> return 0;
> +
> +err:
> + clk_disable_unprepare(bt_bmc->clk);
> +
> + return rc;
> }
>
> static int bt_bmc_remove(struct platform_device *pdev)
> @@ -466,6 +486,8 @@ static int bt_bmc_remove(struct platform_device *pdev)
> misc_deregister(&bt_bmc->miscdev);
> if (bt_bmc->irq < 0)
> del_timer_sync(&bt_bmc->poll_timer);
> + clk_disable_unprepare(bt_bmc->clk);
> +
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
2021-11-02 9:35 ` Cédric Le Goater
@ 2021-11-02 16:36 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:36 UTC (permalink / raw)
To: Cédric Le Goater, jae.hyun.yoo, Rob Herring, Corey Minyard,
Joel Stanley, Andrew Jeffery, Haiyue Wang
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks a lot Cédric!
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
@ 2021-11-02 16:36 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:36 UTC (permalink / raw)
To: Cédric Le Goater, jae.hyun.yoo, Rob Herring, Corey Minyard,
Joel Stanley, Andrew Jeffery, Haiyue Wang
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks a lot Cédric!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-02 22:14 ` Andrew Jeffery
-1 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:14 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 2/4] ipmi: bt: add clock control logic
@ 2021-11-02 22:14 ` Andrew Jeffery
0 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:14 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC BT driver is registered ahead of lpc-ctrl module, LPC BT
> hardware block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> BT driver.
>
> Fixes: 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:37 ` jae.hyun.yoo
-1 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
individual LPC sub drivers.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++++
arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index d0cc4be2de59..7495f93c5069 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -446,6 +446,7 @@ kcs1: kcs@24 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -453,6 +454,7 @@ kcs2: kcs@28 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -460,6 +462,7 @@ kcs3: kcs@2c {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -467,6 +470,7 @@ kcs4: kcs@114 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 465c3549fdc3..891b862363a7 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -520,6 +520,7 @@ kcs1: kcs@24 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
kcs_chan = <1>;
status = "disabled";
};
@@ -528,6 +529,7 @@ kcs2: kcs@28 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -535,6 +537,7 @@ kcs3: kcs@2c {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -542,6 +545,7 @@ kcs4: kcs@114 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 66+ messages in thread* [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
@ 2021-11-01 23:37 ` jae.hyun.yoo
0 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
individual LPC sub drivers.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++++
arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index d0cc4be2de59..7495f93c5069 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -446,6 +446,7 @@ kcs1: kcs@24 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -453,6 +454,7 @@ kcs2: kcs@28 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -460,6 +462,7 @@ kcs3: kcs@2c {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -467,6 +470,7 @@ kcs4: kcs@114 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
interrupts = <8>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 465c3549fdc3..891b862363a7 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -520,6 +520,7 @@ kcs1: kcs@24 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
kcs_chan = <1>;
status = "disabled";
};
@@ -528,6 +529,7 @@ kcs2: kcs@28 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -535,6 +537,7 @@ kcs3: kcs@2c {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
@@ -542,6 +545,7 @@ kcs4: kcs@114 {
compatible = "aspeed,ast2500-kcs-bmc-v2";
reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
status = "disabled";
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:34 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:34 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++++
> arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index d0cc4be2de59..7495f93c5069 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -446,6 +446,7 @@ kcs1: kcs@24 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -453,6 +454,7 @@ kcs2: kcs@28 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -460,6 +462,7 @@ kcs3: kcs@2c {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -467,6 +470,7 @@ kcs4: kcs@114 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 465c3549fdc3..891b862363a7 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -520,6 +520,7 @@ kcs1: kcs@24 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> kcs_chan = <1>;
> status = "disabled";
> };
> @@ -528,6 +529,7 @@ kcs2: kcs@28 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
> interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -535,6 +537,7 @@ kcs3: kcs@2c {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -542,6 +545,7 @@ kcs4: kcs@114 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
> interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
@ 2021-11-01 23:34 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:34 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++++
> arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index d0cc4be2de59..7495f93c5069 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -446,6 +446,7 @@ kcs1: kcs@24 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -453,6 +454,7 @@ kcs2: kcs@28 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -460,6 +462,7 @@ kcs3: kcs@2c {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -467,6 +470,7 @@ kcs4: kcs@114 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
> interrupts = <8>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 465c3549fdc3..891b862363a7 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -520,6 +520,7 @@ kcs1: kcs@24 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> kcs_chan = <1>;
> status = "disabled";
> };
> @@ -528,6 +529,7 @@ kcs2: kcs@28 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x28 0x1>, <0x34 0x1>, <0x40 0x1>;
> interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -535,6 +537,7 @@ kcs3: kcs@2c {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x2c 0x1>, <0x38 0x1>, <0x44 0x1>;
> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> @@ -542,6 +545,7 @@ kcs4: kcs@114 {
> compatible = "aspeed,ast2500-kcs-bmc-v2";
> reg = <0x114 0x1>, <0x118 0x1>, <0x11c 0x1>;
> interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> status = "disabled";
> };
>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-02 22:22 ` Andrew Jeffery
-1 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:22 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
@ 2021-11-02 22:22 ` Andrew Jeffery
0 siblings, 0 replies; 66+ messages in thread
From: Andrew Jeffery @ 2021-11-02 22:22 UTC (permalink / raw)
To: Jae Hyun Yoo, Rob Herring, Corey Minyard, Joel Stanley,
Cédric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
> individual LPC sub drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
2021-11-02 22:22 ` Andrew Jeffery
@ 2021-11-03 16:15 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 16:15 UTC (permalink / raw)
To: Andrew Jeffery, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Joel Stanley, Cédric Le Goater, Haiyue Wang
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On 11/2/2021 3:22 PM, Andrew Jeffery wrote:
>
>
> On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>
>> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
>> individual LPC sub drivers.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Thanks Andrew for your review!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
@ 2021-11-03 16:15 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-03 16:15 UTC (permalink / raw)
To: Andrew Jeffery, Jae Hyun Yoo, Rob Herring, Corey Minyard,
Joel Stanley, Cédric Le Goater, Haiyue Wang
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
On 11/2/2021 3:22 PM, Andrew Jeffery wrote:
>
>
> On Tue, 2 Nov 2021, at 10:07, jae.hyun.yoo@intel.com wrote:
>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>
>> Add LCLK clock setting into LPC KCS nodes to enable the LCLK by
>> individual LPC sub drivers.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Thanks Andrew for your review!
^ permalink raw reply [flat|nested] 66+ messages in thread
* [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:37 ` jae.hyun.yoo
-1 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
If LPC KCS driver is registered ahead of lpc-ctrl module, LPC
KCS block will be enabled without heart beating of LCLK until
lpc-ctrl enables the LCLK. This issue causes improper handling on
host interrupts when the host sends interrupts in that time frame.
Then kernel eventually forcibly disables the interrupt with
dumping stack and printing a 'nobody cared this irq' message out.
To prevent this issue, all LPC sub drivers should enable LCLK
individually so this patch adds clock control logic into the LPC
KCS driver.
Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver")
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 92a37b33494c..00706472cc4d 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -6,6 +6,7 @@
#define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt
#include <linux/atomic.h>
+#include <linux/clk.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -126,6 +127,8 @@ struct aspeed_kcs_bmc {
bool remove;
struct timer_list timer;
} obe;
+
+ struct clk *clk;
};
struct aspeed_kcs_of_ops {
@@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
return -ENODEV;
}
+ priv->clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(priv->clk)) {
+ rc = PTR_ERR(priv->clk);
+ if (rc != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Couldn't get clock\n");
+ return rc;
+ }
+ rc = clk_prepare_enable(priv->clk);
+ if (rc) {
+ dev_err(&pdev->dev, "Couldn't enable clock\n");
+ return rc;
+ }
+
spin_lock_init(&priv->obe.lock);
priv->obe.remove = false;
timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0);
rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs);
if (rc)
- return rc;
+ goto err;
/* Host to BMC IRQ */
rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
if (rc)
- return rc;
+ goto err;
/* BMC to Host IRQ */
if (have_upstream_irq) {
rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]);
if (rc < 0)
- return rc;
+ goto err;
} else {
priv->upstream_irq.mode = aspeed_kcs_irq_none;
}
@@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
rc = kcs_bmc_add_device(&priv->kcs_bmc);
if (rc) {
dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc);
- return rc;
+ goto err;
}
dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
kcs_bmc->channel, addrs[0]);
return 0;
+
+err:
+ aspeed_kcs_enable_channel(kcs_bmc, false);
+ clk_disable_unprepare(priv->clk);
+
+ return rc;
}
static int aspeed_kcs_remove(struct platform_device *pdev)
@@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev)
struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev);
struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc;
+ clk_disable_unprepare(priv->clk);
kcs_bmc_remove_device(kcs_bmc);
aspeed_kcs_enable_channel(kcs_bmc, false);
--
2.25.1
^ permalink raw reply related [flat|nested] 66+ messages in thread* [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-01 23:37 ` jae.hyun.yoo
0 siblings, 0 replies; 66+ messages in thread
From: jae.hyun.yoo @ 2021-11-01 23:37 UTC (permalink / raw)
To: Rob Herring, Corey Minyard, Joel Stanley, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
If LPC KCS driver is registered ahead of lpc-ctrl module, LPC
KCS block will be enabled without heart beating of LCLK until
lpc-ctrl enables the LCLK. This issue causes improper handling on
host interrupts when the host sends interrupts in that time frame.
Then kernel eventually forcibly disables the interrupt with
dumping stack and printing a 'nobody cared this irq' message out.
To prevent this issue, all LPC sub drivers should enable LCLK
individually so this patch adds clock control logic into the LPC
KCS driver.
Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver")
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 92a37b33494c..00706472cc4d 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -6,6 +6,7 @@
#define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt
#include <linux/atomic.h>
+#include <linux/clk.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -126,6 +127,8 @@ struct aspeed_kcs_bmc {
bool remove;
struct timer_list timer;
} obe;
+
+ struct clk *clk;
};
struct aspeed_kcs_of_ops {
@@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
return -ENODEV;
}
+ priv->clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(priv->clk)) {
+ rc = PTR_ERR(priv->clk);
+ if (rc != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Couldn't get clock\n");
+ return rc;
+ }
+ rc = clk_prepare_enable(priv->clk);
+ if (rc) {
+ dev_err(&pdev->dev, "Couldn't enable clock\n");
+ return rc;
+ }
+
spin_lock_init(&priv->obe.lock);
priv->obe.remove = false;
timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0);
rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs);
if (rc)
- return rc;
+ goto err;
/* Host to BMC IRQ */
rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
if (rc)
- return rc;
+ goto err;
/* BMC to Host IRQ */
if (have_upstream_irq) {
rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]);
if (rc < 0)
- return rc;
+ goto err;
} else {
priv->upstream_irq.mode = aspeed_kcs_irq_none;
}
@@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
rc = kcs_bmc_add_device(&priv->kcs_bmc);
if (rc) {
dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc);
- return rc;
+ goto err;
}
dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
kcs_bmc->channel, addrs[0]);
return 0;
+
+err:
+ aspeed_kcs_enable_channel(kcs_bmc, false);
+ clk_disable_unprepare(priv->clk);
+
+ return rc;
}
static int aspeed_kcs_remove(struct platform_device *pdev)
@@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev)
struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev);
struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc;
+ clk_disable_unprepare(priv->clk);
kcs_bmc_remove_device(kcs_bmc);
aspeed_kcs_enable_channel(kcs_bmc, false);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 66+ messages in thread* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-01 23:33 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:33 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC
> KCS block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> KCS driver.
>
> Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> 1 file changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 92a37b33494c..00706472cc4d 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -6,6 +6,7 @@
> #define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt
>
> #include <linux/atomic.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -126,6 +127,8 @@ struct aspeed_kcs_bmc {
> bool remove;
> struct timer_list timer;
> } obe;
> +
> + struct clk *clk;
> };
>
> struct aspeed_kcs_of_ops {
> @@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> + priv->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR(priv->clk)) {
> + rc = PTR_ERR(priv->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Couldn't get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(priv->clk);
> + if (rc) {
> + dev_err(&pdev->dev, "Couldn't enable clock\n");
> + return rc;
> + }
> +
> spin_lock_init(&priv->obe.lock);
> priv->obe.remove = false;
> timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0);
>
> rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs);
> if (rc)
> - return rc;
> + goto err;
>
> /* Host to BMC IRQ */
> rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
> if (rc)
> - return rc;
> + goto err;
>
> /* BMC to Host IRQ */
> if (have_upstream_irq) {
> rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]);
> if (rc < 0)
> - return rc;
> + goto err;
> } else {
> priv->upstream_irq.mode = aspeed_kcs_irq_none;
> }
> @@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> rc = kcs_bmc_add_device(&priv->kcs_bmc);
> if (rc) {
> dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc);
> - return rc;
> + goto err;
> }
>
> dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
> kcs_bmc->channel, addrs[0]);
>
> return 0;
> +
> +err:
> + aspeed_kcs_enable_channel(kcs_bmc, false);
> + clk_disable_unprepare(priv->clk);
> +
> + return rc;
> }
>
> static int aspeed_kcs_remove(struct platform_device *pdev)
> @@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev)
> struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev);
> struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc;
>
> + clk_disable_unprepare(priv->clk);
> kcs_bmc_remove_device(kcs_bmc);
>
> aspeed_kcs_enable_channel(kcs_bmc, false);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 66+ messages in thread* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-01 23:33 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-01 23:33 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Rob Herring, Corey Minyard, Andrew Jeffery, Cedric Le Goater,
Haiyue Wang, Jae Hyun Yoo, devicetree, Linux ARM, linux-aspeed,
openipmi-developer
On Mon, 1 Nov 2021 at 23:18, <jae.hyun.yoo@intel.com> wrote:
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC
> KCS block will be enabled without heart beating of LCLK until
> lpc-ctrl enables the LCLK. This issue causes improper handling on
> host interrupts when the host sends interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with
> dumping stack and printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK
> individually so this patch adds clock control logic into the LPC
> KCS driver.
>
> Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++----
> 1 file changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 92a37b33494c..00706472cc4d 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -6,6 +6,7 @@
> #define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt
>
> #include <linux/atomic.h>
> +#include <linux/clk.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> @@ -126,6 +127,8 @@ struct aspeed_kcs_bmc {
> bool remove;
> struct timer_list timer;
> } obe;
> +
> + struct clk *clk;
> };
>
> struct aspeed_kcs_of_ops {
> @@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> + priv->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR(priv->clk)) {
> + rc = PTR_ERR(priv->clk);
> + if (rc != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Couldn't get clock\n");
> + return rc;
> + }
> + rc = clk_prepare_enable(priv->clk);
> + if (rc) {
> + dev_err(&pdev->dev, "Couldn't enable clock\n");
> + return rc;
> + }
> +
> spin_lock_init(&priv->obe.lock);
> priv->obe.remove = false;
> timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0);
>
> rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs);
> if (rc)
> - return rc;
> + goto err;
>
> /* Host to BMC IRQ */
> rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev);
> if (rc)
> - return rc;
> + goto err;
>
> /* BMC to Host IRQ */
> if (have_upstream_irq) {
> rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]);
> if (rc < 0)
> - return rc;
> + goto err;
> } else {
> priv->upstream_irq.mode = aspeed_kcs_irq_none;
> }
> @@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> rc = kcs_bmc_add_device(&priv->kcs_bmc);
> if (rc) {
> dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc);
> - return rc;
> + goto err;
> }
>
> dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n",
> kcs_bmc->channel, addrs[0]);
>
> return 0;
> +
> +err:
> + aspeed_kcs_enable_channel(kcs_bmc, false);
> + clk_disable_unprepare(priv->clk);
> +
> + return rc;
> }
>
> static int aspeed_kcs_remove(struct platform_device *pdev)
> @@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev)
> struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev);
> struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc;
>
> + clk_disable_unprepare(priv->clk);
> kcs_bmc_remove_device(kcs_bmc);
>
> aspeed_kcs_enable_channel(kcs_bmc, false);
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-01 23:37 ` jae.hyun.yoo
@ 2021-11-02 3:15 ` ChiaWei Wang
-1 siblings, 0 replies; 66+ messages in thread
From: ChiaWei Wang @ 2021-11-02 3:15 UTC (permalink / raw)
To: jae.hyun.yoo, Rob Herring, Corey Minyard, Joel Stanley,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer,
Ryan Chen, Jenmin Yuan
Hi Jae,
> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
> enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
> issue causes improper handling on host interrupts when the host sends
> interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with dumping stack and
> printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK individually so this
> patch adds clock control logic into the LPC KCS driver.
Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
The previous discussion for your reference:
https://lkml.org/lkml/2020/9/28/153
Regards,
Chiawei
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-02 3:15 ` ChiaWei Wang
0 siblings, 0 replies; 66+ messages in thread
From: ChiaWei Wang @ 2021-11-02 3:15 UTC (permalink / raw)
To: jae.hyun.yoo, Rob Herring, Corey Minyard, Joel Stanley,
Andrew Jeffery, Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo
Cc: devicetree, linux-arm-kernel, linux-aspeed, openipmi-developer,
Ryan Chen, Jenmin Yuan
Hi Jae,
> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
>
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
> enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
> issue causes improper handling on host interrupts when the host sends
> interrupts in that time frame.
> Then kernel eventually forcibly disables the interrupt with dumping stack and
> printing a 'nobody cared this irq' message out.
>
> To prevent this issue, all LPC sub drivers should enable LCLK individually so this
> patch adds clock control logic into the LPC KCS driver.
Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
The previous discussion for your reference:
https://lkml.org/lkml/2020/9/28/153
Regards,
Chiawei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-02 3:15 ` ChiaWei Wang
@ 2021-11-02 3:28 ` Joel Stanley
-1 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-02 3:28 UTC (permalink / raw)
To: ChiaWei Wang
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
linux-arm-kernel, linux-aspeed, openipmi-developer, Ryan Chen,
Jenmin Yuan
On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang <chiawei_wang@aspeedtech.com> wrote:
>
> Hi Jae,
>
> > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> >
> > From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >
> > If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
> > enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
> > issue causes improper handling on host interrupts when the host sends
> > interrupts in that time frame.
> > Then kernel eventually forcibly disables the interrupt with dumping stack and
> > printing a 'nobody cared this irq' message out.
> >
> > To prevent this issue, all LPC sub drivers should enable LCLK individually so this
> > patch adds clock control logic into the LPC KCS driver.
>
> Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
> The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
> Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
>
> The previous discussion for your reference:
> https://lkml.org/lkml/2020/9/28/153
Please read the entire thread. The conclusion:
https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c+5aneUMHZw@mail.gmail.com/
That is, for the devices that have a driver loaded can enable the
clock. When they are unloaded, they will reduce the reference count
until the last driver is unloaded. eg:
https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
There was another fork to the thread, where we suggested that a
protected clocks binding could be added:
https://lore.kernel.org/all/160269577311.884498.8429245140509326318@swboyd.mtv.corp.google.com/
If you wish to use this mechanism for eg. SIO clocks, then I encourage
Aspeed to submit a patch to do that.
Cheers,
Joel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-02 3:28 ` Joel Stanley
0 siblings, 0 replies; 66+ messages in thread
From: Joel Stanley @ 2021-11-02 3:28 UTC (permalink / raw)
To: ChiaWei Wang
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, Jae Hyun Yoo, devicetree,
linux-arm-kernel, linux-aspeed, openipmi-developer, Ryan Chen,
Jenmin Yuan
On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang <chiawei_wang@aspeedtech.com> wrote:
>
> Hi Jae,
>
> > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> >
> > From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >
> > If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
> > enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
> > issue causes improper handling on host interrupts when the host sends
> > interrupts in that time frame.
> > Then kernel eventually forcibly disables the interrupt with dumping stack and
> > printing a 'nobody cared this irq' message out.
> >
> > To prevent this issue, all LPC sub drivers should enable LCLK individually so this
> > patch adds clock control logic into the LPC KCS driver.
>
> Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
> The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
> Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
>
> The previous discussion for your reference:
> https://lkml.org/lkml/2020/9/28/153
Please read the entire thread. The conclusion:
https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c+5aneUMHZw@mail.gmail.com/
That is, for the devices that have a driver loaded can enable the
clock. When they are unloaded, they will reduce the reference count
until the last driver is unloaded. eg:
https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
There was another fork to the thread, where we suggested that a
protected clocks binding could be added:
https://lore.kernel.org/all/160269577311.884498.8429245140509326318@swboyd.mtv.corp.google.com/
If you wish to use this mechanism for eg. SIO clocks, then I encourage
Aspeed to submit a patch to do that.
Cheers,
Joel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-02 3:28 ` Joel Stanley
@ 2021-11-02 16:35 ` Jae Hyun Yoo
-1 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:35 UTC (permalink / raw)
To: Joel Stanley, ChiaWei Wang
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, linux-arm-kernel,
linux-aspeed, openipmi-developer, Ryan Chen, Jenmin Yuan
On 11/1/2021 8:28 PM, Joel Stanley wrote:
> On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang <chiawei_wang@aspeedtech.com> wrote:
>>
>> Hi Jae,
>>
>>> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
>>> enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
>>> issue causes improper handling on host interrupts when the host sends
>>> interrupts in that time frame.
>>> Then kernel eventually forcibly disables the interrupt with dumping stack and
>>> printing a 'nobody cared this irq' message out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK individually so this
>>> patch adds clock control logic into the LPC KCS driver.
>>
>> Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
>> The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
>> Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
>>
>> The previous discussion for your reference:
>> https://lkml.org/lkml/2020/9/28/153
>
> Please read the entire thread. The conclusion:
>
> https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c+5aneUMHZw@mail.gmail.com/
>
> That is, for the devices that have a driver loaded can enable the
> clock. When they are unloaded, they will reduce the reference count
> until the last driver is unloaded. eg:
>
> https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
>
> There was another fork to the thread, where we suggested that a
> protected clocks binding could be added:
>
> https://lore.kernel.org/all/160269577311.884498.8429245140509326318@swboyd.mtv.corp.google.com/
>
> If you wish to use this mechanism for eg. SIO clocks, then I encourage
> Aspeed to submit a patch to do that.
We are revisiting the aged discussion. Thanks for bringing it back.
I agree with Joel that a clock should be enabled only on systems that
need the clock actually so it should be configurable by a device driver
or through device tree setting, not by the static setting in
clk-ast2600.c code. So that's the reason why I stopped upstreaming below
change for making BCLK as a critical clock.
https://www.spinics.net/lists/linux-clk/msg44836.html
Instead, I submitted these two changes to make it configurable through
device tree setting.
https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003394.html
https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003339.html
But these were not accepted too.
And recently, Samuel introduced a better and more generic way.
https://lore.kernel.org/all/20200903040015.5627-2-samuel@sholland.org/
But it's not accepted yet either.
Chiawei,
Please refine the mechanism and submit a change to make SIO clocks
configurable through device tree setting. I believe that we can keep
this patch series even with the change, or it can be modified and
adjusted if needed after the SIO clocks fix is accepted.
Thanks,
Jae
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread
* Re: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-02 16:35 ` Jae Hyun Yoo
0 siblings, 0 replies; 66+ messages in thread
From: Jae Hyun Yoo @ 2021-11-02 16:35 UTC (permalink / raw)
To: Joel Stanley, ChiaWei Wang
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, linux-arm-kernel,
linux-aspeed, openipmi-developer, Ryan Chen, Jenmin Yuan
On 11/1/2021 8:28 PM, Joel Stanley wrote:
> On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang <chiawei_wang@aspeedtech.com> wrote:
>>
>> Hi Jae,
>>
>>> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
>>>
>>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>>>
>>> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be
>>> enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This
>>> issue causes improper handling on host interrupts when the host sends
>>> interrupts in that time frame.
>>> Then kernel eventually forcibly disables the interrupt with dumping stack and
>>> printing a 'nobody cared this irq' message out.
>>>
>>> To prevent this issue, all LPC sub drivers should enable LCLK individually so this
>>> patch adds clock control logic into the LPC KCS driver.
>>
>> Have all LPC sub drivers could result in entire LPC block down if any of them disables the clock (e.g. driver unload).
>> The LPC devices such as SIO can be used before kernel booting, even without any BMC firmware.
>> Thereby, we recommend to make LCLK critical or guarded by protected clock instead of having all LPC sub drivers hold the LCLK control.
>>
>> The previous discussion for your reference:
>> https://lkml.org/lkml/2020/9/28/153
>
> Please read the entire thread. The conclusion:
>
> https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c+5aneUMHZw@mail.gmail.com/
>
> That is, for the devices that have a driver loaded can enable the
> clock. When they are unloaded, they will reduce the reference count
> until the last driver is unloaded. eg:
>
> https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
>
> There was another fork to the thread, where we suggested that a
> protected clocks binding could be added:
>
> https://lore.kernel.org/all/160269577311.884498.8429245140509326318@swboyd.mtv.corp.google.com/
>
> If you wish to use this mechanism for eg. SIO clocks, then I encourage
> Aspeed to submit a patch to do that.
We are revisiting the aged discussion. Thanks for bringing it back.
I agree with Joel that a clock should be enabled only on systems that
need the clock actually so it should be configurable by a device driver
or through device tree setting, not by the static setting in
clk-ast2600.c code. So that's the reason why I stopped upstreaming below
change for making BCLK as a critical clock.
https://www.spinics.net/lists/linux-clk/msg44836.html
Instead, I submitted these two changes to make it configurable through
device tree setting.
https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003394.html
https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003339.html
But these were not accepted too.
And recently, Samuel introduced a better and more generic way.
https://lore.kernel.org/all/20200903040015.5627-2-samuel@sholland.org/
But it's not accepted yet either.
Chiawei,
Please refine the mechanism and submit a change to make SIO clocks
configurable through device tree setting. I believe that we can keep
this patch series even with the change, or it can be modified and
adjusted if needed after the SIO clocks fix is accepted.
Thanks,
Jae
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
2021-11-02 16:35 ` Jae Hyun Yoo
@ 2021-11-03 1:55 ` ChiaWei Wang
-1 siblings, 0 replies; 66+ messages in thread
From: ChiaWei Wang @ 2021-11-03 1:55 UTC (permalink / raw)
To: Jae Hyun Yoo, Joel Stanley
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, linux-arm-kernel,
linux-aspeed, openipmi-developer, Ryan Chen, Jenmin Yuan
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> Sent: Wednesday, November 3, 2021 12:36 AM
>
> On 11/1/2021 8:28 PM, Joel Stanley wrote:
> > On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang
> <chiawei_wang@aspeedtech.com> wrote:
> >>
> >> Hi Jae,
> >>
> >>> From: linux-arm-kernel
> >>> <linux-arm-kernel-bounces@lists.infradead.org> On
> >>>
> >>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >>>
> >>> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS
> >>> block will be enabled without heart beating of LCLK until lpc-ctrl
> >>> enables the LCLK. This issue causes improper handling on host
> >>> interrupts when the host sends interrupts in that time frame.
> >>> Then kernel eventually forcibly disables the interrupt with dumping
> >>> stack and printing a 'nobody cared this irq' message out.
> >>>
> >>> To prevent this issue, all LPC sub drivers should enable LCLK
> >>> individually so this patch adds clock control logic into the LPC KCS driver.
> >>
> >> Have all LPC sub drivers could result in entire LPC block down if any of them
> disables the clock (e.g. driver unload).
> >> The LPC devices such as SIO can be used before kernel booting, even
> without any BMC firmware.
> >> Thereby, we recommend to make LCLK critical or guarded by protected
> clock instead of having all LPC sub drivers hold the LCLK control.
> >>
> >> The previous discussion for your reference:
> >> https://lkml.org/lkml/2020/9/28/153
> >
> > Please read the entire thread. The conclusion:
> >
> >
> https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c
> +
> > 5aneUMHZw@mail.gmail.com/
> >
> > That is, for the devices that have a driver loaded can enable the
> > clock. When they are unloaded, they will reduce the reference count
> > until the last driver is unloaded. eg:
> >
> > https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
> >
> > There was another fork to the thread, where we suggested that a
> > protected clocks binding could be added:
> >
> >
> https://lore.kernel.org/all/160269577311.884498.8429245140509326318@sw
> > boyd.mtv.corp.google.com/
> >
> > If you wish to use this mechanism for eg. SIO clocks, then I encourage
> > Aspeed to submit a patch to do that.
>
> We are revisiting the aged discussion. Thanks for bringing it back.
>
> I agree with Joel that a clock should be enabled only on systems that need the
> clock actually so it should be configurable by a device driver or through device
> tree setting, not by the static setting in clk-ast2600.c code. So that's the
> reason why I stopped upstreaming below change for making BCLK as a critical
> clock.
>
> https://www.spinics.net/lists/linux-clk/msg44836.html
>
> Instead, I submitted these two changes to make it configurable through device
> tree setting.
>
> https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003394.html
> https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003339.html
>
> But these were not accepted too.
>
> And recently, Samuel introduced a better and more generic way.
>
> https://lore.kernel.org/all/20200903040015.5627-2-samuel@sholland.org/
>
> But it's not accepted yet either.
>
>
> Chiawei,
>
> Please refine the mechanism and submit a change to make SIO clocks
> configurable through device tree setting. I believe that we can keep this patch
> series even with the change, or it can be modified and adjusted if needed after
> the SIO clocks fix is accepted.
Thanks for your feedback and the information shared.
We will keep tracking these changes and construct a compatible patch for the SIO clocks.
Regards,
Chiawei
^ permalink raw reply [flat|nested] 66+ messages in thread
* RE: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic
@ 2021-11-03 1:55 ` ChiaWei Wang
0 siblings, 0 replies; 66+ messages in thread
From: ChiaWei Wang @ 2021-11-03 1:55 UTC (permalink / raw)
To: Jae Hyun Yoo, Joel Stanley
Cc: jae.hyun.yoo, Rob Herring, Corey Minyard, Andrew Jeffery,
Cedric Le Goater, Haiyue Wang, devicetree, linux-arm-kernel,
linux-aspeed, openipmi-developer, Ryan Chen, Jenmin Yuan
> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> Sent: Wednesday, November 3, 2021 12:36 AM
>
> On 11/1/2021 8:28 PM, Joel Stanley wrote:
> > On Tue, 2 Nov 2021 at 03:16, ChiaWei Wang
> <chiawei_wang@aspeedtech.com> wrote:
> >>
> >> Hi Jae,
> >>
> >>> From: linux-arm-kernel
> >>> <linux-arm-kernel-bounces@lists.infradead.org> On
> >>>
> >>> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> >>>
> >>> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS
> >>> block will be enabled without heart beating of LCLK until lpc-ctrl
> >>> enables the LCLK. This issue causes improper handling on host
> >>> interrupts when the host sends interrupts in that time frame.
> >>> Then kernel eventually forcibly disables the interrupt with dumping
> >>> stack and printing a 'nobody cared this irq' message out.
> >>>
> >>> To prevent this issue, all LPC sub drivers should enable LCLK
> >>> individually so this patch adds clock control logic into the LPC KCS driver.
> >>
> >> Have all LPC sub drivers could result in entire LPC block down if any of them
> disables the clock (e.g. driver unload).
> >> The LPC devices such as SIO can be used before kernel booting, even
> without any BMC firmware.
> >> Thereby, we recommend to make LCLK critical or guarded by protected
> clock instead of having all LPC sub drivers hold the LCLK control.
> >>
> >> The previous discussion for your reference:
> >> https://lkml.org/lkml/2020/9/28/153
> >
> > Please read the entire thread. The conclusion:
> >
> >
> https://lore.kernel.org/all/CACPK8XdBmkhZ8mcSFmDAFV8k7Qj7ajBL8TVKfK8c
> +
> > 5aneUMHZw@mail.gmail.com/
> >
> > That is, for the devices that have a driver loaded can enable the
> > clock. When they are unloaded, they will reduce the reference count
> > until the last driver is unloaded. eg:
> >
> > https://elixir.bootlin.com/linux/latest/source/drivers/clk/clk.c#L945
> >
> > There was another fork to the thread, where we suggested that a
> > protected clocks binding could be added:
> >
> >
> https://lore.kernel.org/all/160269577311.884498.8429245140509326318@sw
> > boyd.mtv.corp.google.com/
> >
> > If you wish to use this mechanism for eg. SIO clocks, then I encourage
> > Aspeed to submit a patch to do that.
>
> We are revisiting the aged discussion. Thanks for bringing it back.
>
> I agree with Joel that a clock should be enabled only on systems that need the
> clock actually so it should be configurable by a device driver or through device
> tree setting, not by the static setting in clk-ast2600.c code. So that's the
> reason why I stopped upstreaming below change for making BCLK as a critical
> clock.
>
> https://www.spinics.net/lists/linux-clk/msg44836.html
>
> Instead, I submitted these two changes to make it configurable through device
> tree setting.
>
> https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003394.html
> https://lists.ozlabs.org/pipermail/linux-aspeed/2020-January/003339.html
>
> But these were not accepted too.
>
> And recently, Samuel introduced a better and more generic way.
>
> https://lore.kernel.org/all/20200903040015.5627-2-samuel@sholland.org/
>
> But it's not accepted yet either.
>
>
> Chiawei,
>
> Please refine the mechanism and submit a change to make SIO clocks
> configurable through device tree setting. I believe that we can keep this patch
> series even with the change, or it can be modified and adjusted if needed after
> the SIO clocks fix is accepted.
Thanks for your feedback and the information shared.
We will keep tracking these changes and construct a compatible patch for the SIO clocks.
Regards,
Chiawei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 66+ messages in thread