From: Rob Herring <robh@kernel.org> To: Romain Perier <romain.perier@gmail.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Daniel Palmer <daniel@0x0f.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] dt-bindings: timer: Add Mstar MSC313e timer devicetree bindings documentation Date: Wed, 1 Dec 2021 18:11:19 -0600 [thread overview] Message-ID: <YagPJ6aWLKFunWlG@robh.at.kernel.org> (raw) In-Reply-To: <20211126202144.72936-5-romain.perier@gmail.com> On Fri, Nov 26, 2021 at 09:21:42PM +0100, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > MSC313e timer driver, found from MSC313e SoCs and newer. > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../bindings/timer/mstar,msc313e-timer.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > new file mode 100644 > index 000000000000..f4d43e141dd0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/mstar,msc313e-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar MSC313e Timer Device Tree Bindings > + > +maintainers: > + - Daniel Palmer <daniel@0x0f.com> > + - Romain Perier <romain.perier@gmail.com> > + > +properties: > + compatible: > + enum: > + - mstar,msc313e-timer > + - mstar,ssd20xd-timer > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + start-year: true This is an rtc property. You would need to $ref rtc.yaml, but then that also says the node name is 'rtc'. But why do you need a start year for a clocksource? > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + timer@6040 { > + compatible = "mstar,msc313e-timer"; > + reg = <0x6040 0x40>; > + clocks = <&xtal_div2>; > + interrupts-extended = <&intc_fiq GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + }; > +... > -- > 2.33.0 > >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Romain Perier <romain.perier@gmail.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Daniel Palmer <daniel@0x0f.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] dt-bindings: timer: Add Mstar MSC313e timer devicetree bindings documentation Date: Wed, 1 Dec 2021 18:11:19 -0600 [thread overview] Message-ID: <YagPJ6aWLKFunWlG@robh.at.kernel.org> (raw) In-Reply-To: <20211126202144.72936-5-romain.perier@gmail.com> On Fri, Nov 26, 2021 at 09:21:42PM +0100, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > MSC313e timer driver, found from MSC313e SoCs and newer. > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../bindings/timer/mstar,msc313e-timer.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > new file mode 100644 > index 000000000000..f4d43e141dd0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/mstar,msc313e-timer.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/mstar,msc313e-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar MSC313e Timer Device Tree Bindings > + > +maintainers: > + - Daniel Palmer <daniel@0x0f.com> > + - Romain Perier <romain.perier@gmail.com> > + > +properties: > + compatible: > + enum: > + - mstar,msc313e-timer > + - mstar,ssd20xd-timer > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + start-year: true This is an rtc property. You would need to $ref rtc.yaml, but then that also says the node name is 'rtc'. But why do you need a start year for a clocksource? > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + timer@6040 { > + compatible = "mstar,msc313e-timer"; > + reg = <0x6040 0x40>; > + clocks = <&xtal_div2>; > + interrupts-extended = <&intc_fiq GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + }; > +... > -- > 2.33.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-02 0:13 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-26 20:21 [PATCH 0/5] Add timers for Mstar SoCs Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-26 20:21 ` [PATCH 1/5] clocksource: Add MStar MSC313e timer support Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-29 17:02 ` Daniel Lezcano 2021-11-29 17:02 ` Daniel Lezcano [not found] ` <CABgxDo+W3vg_dDTphkOLxRPzKER891CxTJnPPVuryj9YQOg1EQ@mail.gmail.com> 2021-11-30 14:39 ` Daniel Lezcano 2021-11-30 14:39 ` Daniel Lezcano 2021-11-26 20:21 ` [PATCH 2/4] ARM: dts: mstar: Remove unused rtc_xtal Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-27 1:22 ` Daniel Palmer 2021-11-27 1:22 ` Daniel Palmer 2021-11-26 20:21 ` [PATCH 2/5] clocksource: msc313e: Add support for ssd20xd-based platforms Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-26 20:21 ` [PATCH 3/5] dt-bindings: timer: Add Mstar MSC313e timer devicetree bindings documentation Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-27 2:23 ` Daniel Palmer 2021-11-27 2:23 ` Daniel Palmer 2021-12-02 0:11 ` Rob Herring [this message] 2021-12-02 0:11 ` Rob Herring 2021-11-26 20:21 ` [PATCH 4/5] ARM: dts: mstar: Add timers device nodes Romain Perier 2021-11-26 20:21 ` Romain Perier 2021-11-26 20:21 ` [PATCH 5/5] ARM: dts: mstar: Switch to compatible "mstar,ssd20xd-timer" on ssd20xd Romain Perier 2021-11-26 20:21 ` [PATCH 5/5] ARM: dts: mstar: Switch to compatible "mstar, ssd20xd-timer" " Romain Perier 2021-11-27 2:34 ` [PATCH 5/5] ARM: dts: mstar: Switch to compatible "mstar,ssd20xd-timer" " Daniel Palmer 2021-11-27 2:34 ` Daniel Palmer 2021-11-28 13:17 ` Daniel Palmer 2021-11-28 13:17 ` Daniel Palmer [not found] ` <CABgxDo+pF0RKK+HL+MVv5s0pn1T9a9Mqp6uPEkT0YPEH9kvQqw@mail.gmail.com> 2021-12-12 16:44 ` Daniel Palmer 2021-12-12 16:44 ` Daniel Palmer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YagPJ6aWLKFunWlG@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=daniel@0x0f.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=romain.perier@gmail.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.