All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Conor.Dooley@microchip.com
Cc: palmer@rivosinc.com, apatel@ventanamicro.com,
	netdev@vger.kernel.org, Nicolas.Ferre@microchip.com,
	Claudiu.Beznea@microchip.com, linux@armlinux.org.uk,
	hkallweit1@gmail.com, linux-riscv@lists.infradead.org
Subject: Re: riscv defconfig CONFIG_PM/macb/generic PHY regression in v5.18-rc1
Date: Tue, 5 Apr 2022 16:49:15 +0200	[thread overview]
Message-ID: <YkxW68j5N4hVgY18@lunn.ch> (raw)
In-Reply-To: <98b571fb-993e-9fe1-1cf9-dc09651feb0b@microchip.com>

On Tue, Apr 05, 2022 at 02:18:17PM +0000, Conor.Dooley@microchip.com wrote:
> 
> 
> On 05/04/2022 13:25, Andrew Lunn wrote:
> > On Tue, Apr 05, 2022 at 01:05:12PM +0000, Conor.Dooley@microchip.com wrote:
> >> [ 2.818894] macb 20112000.ethernet eth0: PHY [20112000.ethernet-ffffffff:09] driver [Generic PHY] (irq=POLL)
> > 
> > Hi Conor
> > 
> > In general, it is better to use the specific PHY driver for the PHY
> > then rely on the generic PHY driver. I think the Icicle Kit has a
> > VSC8662? So i would suggest you enable the Vitesse PHYs.
> 
> Hi Andrew, thanks for the quick reply.
> It does indeed have a Vitesse VSC8662, but the link never seems to
> come up for me [1] so I have been using Generic PHY. I'll try look
> at why that is. Either way would like to know what's gone wrong in
> the Generic PHY case since that's what's available in the riscv
> defconfig.

Hi Conor

Generic PHY is purely best effort fall back for when there is nothing
better. It might work, it might not, depending on the PHY. If it is a
simple PHY which only implements the registers defined in 802.3 clause
22, and not much more, it has a good chance of working. Otherwise, you
really should be using the specific driver.

Don't worry too much about the defconfig, nobody actually uses
it. Distros have their own which turn on most things. So a real system
probably does have the correct PHY driver.

	 Andrew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Conor.Dooley@microchip.com
Cc: palmer@rivosinc.com, apatel@ventanamicro.com,
	netdev@vger.kernel.org, Nicolas.Ferre@microchip.com,
	Claudiu.Beznea@microchip.com, linux@armlinux.org.uk,
	hkallweit1@gmail.com, linux-riscv@lists.infradead.org
Subject: Re: riscv defconfig CONFIG_PM/macb/generic PHY regression in v5.18-rc1
Date: Tue, 5 Apr 2022 16:49:15 +0200	[thread overview]
Message-ID: <YkxW68j5N4hVgY18@lunn.ch> (raw)
In-Reply-To: <98b571fb-993e-9fe1-1cf9-dc09651feb0b@microchip.com>

On Tue, Apr 05, 2022 at 02:18:17PM +0000, Conor.Dooley@microchip.com wrote:
> 
> 
> On 05/04/2022 13:25, Andrew Lunn wrote:
> > On Tue, Apr 05, 2022 at 01:05:12PM +0000, Conor.Dooley@microchip.com wrote:
> >> [ 2.818894] macb 20112000.ethernet eth0: PHY [20112000.ethernet-ffffffff:09] driver [Generic PHY] (irq=POLL)
> > 
> > Hi Conor
> > 
> > In general, it is better to use the specific PHY driver for the PHY
> > then rely on the generic PHY driver. I think the Icicle Kit has a
> > VSC8662? So i would suggest you enable the Vitesse PHYs.
> 
> Hi Andrew, thanks for the quick reply.
> It does indeed have a Vitesse VSC8662, but the link never seems to
> come up for me [1] so I have been using Generic PHY. I'll try look
> at why that is. Either way would like to know what's gone wrong in
> the Generic PHY case since that's what's available in the riscv
> defconfig.

Hi Conor

Generic PHY is purely best effort fall back for when there is nothing
better. It might work, it might not, depending on the PHY. If it is a
simple PHY which only implements the registers defined in 802.3 clause
22, and not much more, it has a good chance of working. Otherwise, you
really should be using the specific driver.

Don't worry too much about the defconfig, nobody actually uses
it. Distros have their own which turn on most things. So a real system
probably does have the correct PHY driver.

	 Andrew

  parent reply	other threads:[~2022-04-05 14:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 13:05 riscv defconfig CONFIG_PM/macb/generic PHY regression in v5.18-rc1 Conor.Dooley
2022-04-05 13:05 ` Conor.Dooley
2022-04-05 13:25 ` Andrew Lunn
2022-04-05 13:25   ` Andrew Lunn
2022-04-05 14:18   ` Conor.Dooley
2022-04-05 14:18     ` Conor.Dooley
2022-04-05 14:41     ` Conor.Dooley
2022-04-05 14:41       ` Conor.Dooley
2022-04-05 14:49     ` Andrew Lunn [this message]
2022-04-05 14:49       ` Andrew Lunn
2022-04-05 14:56 ` Andrew Lunn
2022-04-05 14:56   ` Andrew Lunn
2022-04-05 15:04 ` Andrew Lunn
2022-04-05 15:04   ` Andrew Lunn
2022-04-05 16:25   ` Conor Dooley
2022-04-05 16:25     ` Conor Dooley
2022-04-06  8:36   ` Conor.Dooley
2022-04-06  8:36     ` Conor.Dooley
2022-04-07 14:30     ` Conor.Dooley
2022-04-07 14:30       ` Conor.Dooley
2022-04-05 15:53 ` Russell King (Oracle)
2022-04-05 15:53   ` Russell King (Oracle)
2022-04-05 16:56   ` Palmer Dabbelt
2022-04-05 16:56     ` Palmer Dabbelt
2022-04-05 17:23     ` Conor Dooley
2022-04-05 17:23       ` Conor Dooley
2022-04-05 18:06       ` Andrew Lunn
2022-04-05 18:06         ` Andrew Lunn
2022-04-05 18:35         ` Conor Dooley
2022-04-05 18:35           ` Conor Dooley
2022-04-05 16:58   ` Conor Dooley
2022-04-05 16:58     ` Conor Dooley
2022-04-05 18:55     ` Russell King (Oracle)
2022-04-05 18:55       ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkxW68j5N4hVgY18@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Conor.Dooley@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=apatel@ventanamicro.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=palmer@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.