All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	devicetree@vger.kernel.org, Dinh Nguyen <dinguyen@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Scott Branden <sbranden@broadcom.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Liviu Dudau <liviu.dudau@arm.com>, Ray Jui <rjui@broadcom.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/10] ARM: dts: exynos: use proper 'dma-channels/requests' properties
Date: Thu, 28 Apr 2022 08:33:13 -0500	[thread overview]
Message-ID: <YmqXmTau/YbZjrrn@robh.at.kernel.org> (raw)
In-Reply-To: <813bd5f2-38b6-9642-6993-94ad78f5c08a@linaro.org>

On Thu, Apr 28, 2022 at 12:09:02PM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2022 12:05, Marek Szyprowski wrote:
> >>>>> I also don't see any code that would read those properties. IMHO they
> >>>>> should be simply removed at all, at least for the PL330 related nodes.
> >>>> In current Linux implementation they indeed are not used. Nothing parses
> >>>> them. However:
> >>>> 1. They describe (hopefully correct) the hardware.
> >>>> 2. They might be used by other implementations of pl330 driver.
> >>>>
> >>>> I would not remove them from existing sources, but indeed maybe there is
> >>>> no need to add for new files.
> >>> What's the point in having dt properties duplicating data that might be
> >>> read from the driver registers?
> >> Hm, indeed, there is no point in this. Since they are read from
> >> registers, what was the idea behind in commit 42cf20980cde?
> > 
> > #dma-cells is indeed required, but the rest seems to be the cargo-cult 
> > of some kind.
> 
> Rob,
> 
> Any guidance from your side? Is there any benefit in describing the
> hadrware (dma-channels/dma-requests) if the same value can be read from
> registers?

Drop the properties. They should only be an override if ever needed.

Rob

WARNING: multiple messages have this Message-ID
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	devicetree@vger.kernel.org, Dinh Nguyen <dinguyen@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Scott Branden <sbranden@broadcom.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Liviu Dudau <liviu.dudau@arm.com>, Ray Jui <rjui@broadcom.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/10] ARM: dts: exynos: use proper 'dma-channels/requests' properties
Date: Thu, 28 Apr 2022 08:33:13 -0500	[thread overview]
Message-ID: <YmqXmTau/YbZjrrn@robh.at.kernel.org> (raw)
In-Reply-To: <813bd5f2-38b6-9642-6993-94ad78f5c08a@linaro.org>

On Thu, Apr 28, 2022 at 12:09:02PM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2022 12:05, Marek Szyprowski wrote:
> >>>>> I also don't see any code that would read those properties. IMHO they
> >>>>> should be simply removed at all, at least for the PL330 related nodes.
> >>>> In current Linux implementation they indeed are not used. Nothing parses
> >>>> them. However:
> >>>> 1. They describe (hopefully correct) the hardware.
> >>>> 2. They might be used by other implementations of pl330 driver.
> >>>>
> >>>> I would not remove them from existing sources, but indeed maybe there is
> >>>> no need to add for new files.
> >>> What's the point in having dt properties duplicating data that might be
> >>> read from the driver registers?
> >> Hm, indeed, there is no point in this. Since they are read from
> >> registers, what was the idea behind in commit 42cf20980cde?
> > 
> > #dma-cells is indeed required, but the rest seems to be the cargo-cult 
> > of some kind.
> 
> Rob,
> 
> Any guidance from your side? Is there any benefit in describing the
> hadrware (dma-channels/dma-requests) if the same value can be read from
> registers?

Drop the properties. They should only be an override if ever needed.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-28 13:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 15:58 [PATCH 00/10] ARM/arm64: dts: " Krzysztof Kozlowski
2022-04-27 15:58 ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 01/10] ARM: dts: zynq-7000: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-28  6:24   ` Michal Simek
2022-04-28  6:24     ` Michal Simek
2022-04-27 15:58 ` [PATCH 02/10] ARM: dts: socfpga: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 03/10] arm64: dts: stratix10/agilex: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 04/10] arm64: dts: juno: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-28 10:43   ` Robin Murphy
2022-04-28 10:43     ` Robin Murphy
2022-04-28 10:45     ` Krzysztof Kozlowski
2022-04-28 10:45       ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 05/10] arm64: dts: broadcom: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix " Krzysztof Kozlowski
2022-04-27 15:58   ` [PATCH 06/10] dt-bindings: mfd: samsung, exynos5433-lpass: " Krzysztof Kozlowski
2022-04-27 16:41   ` [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: " Alim Akhtar
2022-04-27 16:41     ` Alim Akhtar
2022-04-27 18:25   ` Rob Herring
2022-04-27 18:25     ` Rob Herring
2022-04-28  9:53   ` Lee Jones
2022-04-28  9:53     ` Lee Jones
2022-04-27 15:58 ` [PATCH 07/10] ARM: dts: s5pv210: use proper " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:45   ` Alim Akhtar
2022-04-27 16:45     ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 08/10] ARM: dts: exynos: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:44   ` Alim Akhtar
2022-04-27 16:44     ` Alim Akhtar
2022-04-28  9:50   ` Marek Szyprowski
2022-04-28  9:50     ` Marek Szyprowski
2022-04-28  9:54     ` Krzysztof Kozlowski
2022-04-28  9:54       ` Krzysztof Kozlowski
2022-04-28  9:57       ` Marek Szyprowski
2022-04-28  9:57         ` Marek Szyprowski
2022-04-28 10:00         ` Krzysztof Kozlowski
2022-04-28 10:00           ` Krzysztof Kozlowski
2022-04-28 10:05           ` Marek Szyprowski
2022-04-28 10:05             ` Marek Szyprowski
2022-04-28 10:09             ` Krzysztof Kozlowski
2022-04-28 10:09               ` Krzysztof Kozlowski
2022-04-28 13:33               ` Rob Herring [this message]
2022-04-28 13:33                 ` Rob Herring
2022-04-28  9:55     ` Alim Akhtar
2022-04-28  9:55       ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 09/10] arm64: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:46   ` Alim Akhtar
2022-04-27 16:46     ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 10/10] arm64: dts: fsd: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:49   ` Alim Akhtar
2022-04-27 16:49     ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmqXmTau/YbZjrrn@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=michal.simek@xilinx.com \
    --cc=rjui@broadcom.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sbranden@broadcom.com \
    --cc=sudeep.holla@arm.com \
    --subject='Re: [PATCH 08/10] ARM: dts: exynos: use proper '\''dma-channels/requests'\'' properties' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.