Re: [PATCH v2 0/2] perf: arm64: Tools support for Dwarf unwinding through SVE functions

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: German Gomez <german.gomez@arm.com>
Cc: James Clark <james.clark@arm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	broonie@kernel.org, leo.yan@linaro.org,
	mathieu.poirier@linaro.org, john.garry@huawei.com,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] perf: arm64: Tools support for Dwarf unwinding through SVE functions
Date: Fri, 20 May 2022 09:32:36 -0300	[thread overview]
Message-ID: <YoeKZFXO6zqFaqme@kernel.org> (raw)
In-Reply-To: <995099d3-a170-69dc-d12e-c9b2e4753f35@arm.com>

Em Fri, May 20, 2022 at 12:46:24PM +0100, German Gomez escreveu:
> 
> On 17/05/2022 15:58, Arnaldo Carvalho de Melo wrote:
> > Em Tue, May 17, 2022 at 11:20:01AM +0100, James Clark escreveu:
> >> Changes since v1:
> >>
> >>   * Split patchset into kernel side and Perf tool changes
> > Thanks, now I'll wait for the kernel side to be merged.
> >
> > - Arnaldo
> >  
> 
> Hi,
> 
> I think we also need to fix the below import (it's trying to import the
> perf_regs.h from the kernel, not the tools/ dir).

Sure, that is why it is important to do a:

make -C tools/perf build-test

before posting patches, as it will do, among other tests, a detached tarball test using:

⬢[acme@toolbox perf-urgent]$ make help | grep perf
  perf-tar-src-pkg    - Build perf-5.18.0-rc7.tar source tarball
  perf-targz-src-pkg  - Build perf-5.18.0-rc7.tar.gz source tarball
  perf-tarbz2-src-pkg - Build perf-5.18.0-rc7.tar.bz2 source tarball
  perf-tarxz-src-pkg  - Build perf-5.18.0-rc7.tar.xz source tarball
  perf-tarzst-src-pkg - Build perf-5.18.0-rc7.tar.zst source tarball
⬢[acme@toolbox perf-urgent]$

That will pick just what is in tools/perf/MANIFEST and that doesn´t
include the kernel headers, just what is in tools/ then building with
this patchkit would fail.

To recap:

⬢[acme@toolbox perf-urgent]$ make perf-tarxz-src-pkg
  TAR
  PERF_VERSION = 5.18.rc7.gc645054ef517
⬢[acme@toolbox perf-urgent]$ ls -la perf-5.18.0-rc7.tar.xz
-rw-r--r--. 1 acme acme 2364832 May 20 09:32 perf-5.18.0-rc7.tar.xz
⬢[acme@toolbox perf-urgent]$ tar tvf perf-5.18.0-rc7.tar.xz | tail
-rw-rw-r-- root/root      7364 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/vdso.c
-rw-rw-r-- root/root       639 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/vdso.h
-rw-rw-r-- root/root      1793 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/zlib.c
-rw-rw-r-- root/root      2672 2022-05-20 09:32 perf-5.18.0-rc7/tools/perf/util/zstd.c
drwxrwxr-x root/root         0 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/
-rw-rw-r-- root/root      1091 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/Makefile.arch
-rw-rw-r-- root/root      5905 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/Makefile.include
-rw-rw-r-- root/root      5288 2022-05-20 09:32 perf-5.18.0-rc7/tools/scripts/utilities.mak
-rw-r--r-- acme/acme        41 2022-05-20 09:32 perf-5.18.0-rc7/HEAD
-rw-r--r-- acme/acme        46 2022-05-20 09:32 perf-5.18.0-rc7/PERF-VERSION-FILE
⬢[acme@toolbox perf-urgent]$

- Arnaldo

> diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
> index 15f60fd09424..014d82159656 100644
> --- a/tools/perf/util/libunwind/arm64.c
> +++ b/tools/perf/util/libunwind/arm64.c
> @@ -24,7 +24,7 @@
>  #include "unwind.h"
>  #include "libunwind-aarch64.h"
>  #define perf_event_arm_regs perf_event_arm64_regs
> -#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
> +#include <../../../arch/arm64/include/uapi/asm/perf_regs.h>
>  #undef perf_event_arm_regs
>  #include "../../arch/arm64/util/unwind-libunwind.c"
> 

-- 

- Arnaldo