* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin.
@ 2022-06-20 7:03 sai.gowtham.ch
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-20 7:03 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_softpin.
Sai Gowtham Ch (2):
i915/gem_softpin: Added test description for test case.
HAX: don't do full run
tests/i915/gem_softpin.c | 37 +++++
tests/intel-ci/fast-feedback.testlist | 188 +-------------------------
2 files changed, 38 insertions(+), 187 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-20 7:03 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
@ 2022-06-20 7:03 ` sai.gowtham.ch
2022-06-22 16:14 ` Kamil Konieczny
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
2022-06-20 8:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_softpin Patchwork
2 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-20 7:03 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for test and to all the subtests that are
available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/i915/gem_softpin.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index b851c90e..417359d1 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -32,6 +32,10 @@
#include "igt_rand.h"
#include "intel_allocator.h"
+IGT_TEST_DESCRIPTION("Tests softpin feature, which contains error, normal usage"
+ " scenarios and couple of stress tests which copy buffers"
+ " between CPU and GPU.");
+
#define EXEC_OBJECT_PINNED (1<<4)
#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
@@ -1248,6 +1252,7 @@ igt_main
ctx = intel_ctx_create_all_physical(fd);
}
+ igt_describe("Check softpinnnig with invalid inputs.");
igt_subtest("invalid")
test_invalid(fd);
@@ -1258,30 +1263,44 @@ igt_main
igt_require(gem_uses_full_ppgtt(fd));
}
+ igt_describe("Check full placement control under full-ppgtt");
igt_subtest("zero")
test_zero(fd);
+ igt_describe("Check the last 32b page is excluded");
igt_subtest("32b-excludes-last-page")
test_32b_last_page(fd);
+ igt_describe("Check the total occupancy by using pad-to-size to fill"
+ " the entire GTT.");
igt_subtest("full")
test_full(fd);
+ igt_describe("Check that we can place objects at start/end of the GTT"
+ " using the allocator");
igt_subtest("allocator-basic")
test_allocator_basic(fd, false);
+ igt_describe("Check that if we can reserve a space for a object"
+ " starting from a given offset");
igt_subtest("allocator-basic-reserve")
test_allocator_basic(fd, true);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement");
igt_subtest("allocator-nopin")
test_allocator_nopin(fd, false);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement and reserves/unreserves space for objects");
igt_subtest("allocator-nopin-reserve")
test_allocator_nopin(fd, true);
+ igt_describe("Check if multiple process can be allocted");
igt_subtest("allocator-fork")
test_allocator_fork(fd);
+ igt_describe("Exercise eviction with softpinning");
test_each_engine("allocator-evict", fd, ctx, e)
test_allocator_evict(fd, ctx, e->flags, 20);
@@ -1294,28 +1313,46 @@ igt_main
igt_subtest("safe-alignment")
safe_alignment(fd);
+ igt_describe("Check softpinning of a gem buffer object ");
igt_subtest("softpin")
test_softpin(fd);
+
+ igt_describe("Checks the behaviour by runing on all possible"
+ " page alligned overlaps");
igt_subtest("overlap")
test_overlap(fd);
+
+ igt_describe("Check that if the user demands the vma be replaced, they are.");
igt_subtest("reverse")
test_reverse(fd);
+ igt_describe("Check that no relocation support works");
igt_subtest("noreloc")
test_noreloc(fd, NOSLEEP, 0);
+
+ igt_describe("Check no relocation support with interruptible");
igt_subtest("noreloc-interruptible")
test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
+
+ igt_describe("Check norelocations hold versus suspend/resume");
igt_subtest("noreloc-S3")
test_noreloc(fd, SUSPEND, 0);
+
+ igt_describe("Check norelocations hold versus suspend/resume");
igt_subtest("noreloc-S4")
test_noreloc(fd, HIBERNATE, 0);
for (int signal = 0; signal <= 1; signal++) {
+ igt_describe("This test checks the behaviour of softpin with busy batch");
igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
test_evict_active(fd, signal);
+
+ igt_describe("Snoop test by forcibly injecting signals");
igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
test_evict_snoop(fd, signal);
}
+
+ igt_describe("Checks behaviour of softpin with hung batch");
igt_subtest("evict-hang")
test_evict_hang(fd);
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
@ 2022-06-22 16:14 ` Kamil Konieczny
0 siblings, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2022-06-22 16:14 UTC (permalink / raw)
To: igt-dev; +Cc: Sai Gowtham Ch
Hi Sai,
On 2022-06-20 at 12:33:20 +0530, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all the subtests that are
> available.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_softpin.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
> index b851c90e..417359d1 100644
> --- a/tests/i915/gem_softpin.c
> +++ b/tests/i915/gem_softpin.c
> @@ -32,6 +32,10 @@
> #include "igt_rand.h"
> #include "intel_allocator.h"
>
> +IGT_TEST_DESCRIPTION("Tests softpin feature, which contains error, normal usage"
---------------------------------------------- ^
This reads strange, please rewrite, maybe you want to write
error checks for invalid input ?
Maybe also add here that sofpin is also known as no-reloc ? So
s/softpin/softpin aka no-relocations (no-reloc)/
> + " scenarios and couple of stress tests which copy buffers"
> + " between CPU and GPU.");
Which are these stress tests ? Is it eviction ?
> +
> #define EXEC_OBJECT_PINNED (1<<4)
> #define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
>
> @@ -1248,6 +1252,7 @@ igt_main
> ctx = intel_ctx_create_all_physical(fd);
> }
>
> + igt_describe("Check softpinnnig with invalid inputs.");
Rewrite this, for example:
"Check that invalid inputs are handled correctly." ?
> igt_subtest("invalid")
> test_invalid(fd);
>
> @@ -1258,30 +1263,44 @@ igt_main
> igt_require(gem_uses_full_ppgtt(fd));
> }
>
> + igt_describe("Check full placement control under full-ppgtt");
Put dot at end of sentence (here and almost all below).
s/full-ppgtt/full-ppGTT/
> igt_subtest("zero")
> test_zero(fd);
>
> + igt_describe("Check the last 32b page is excluded");
> igt_subtest("32b-excludes-last-page")
> test_32b_last_page(fd);
>
> + igt_describe("Check the total occupancy by using pad-to-size to fill"
> + " the entire GTT.");
> igt_subtest("full")
> test_full(fd);
>
> + igt_describe("Check that we can place objects at start/end of the GTT"
> + " using the allocator");
> igt_subtest("allocator-basic")
> test_allocator_basic(fd, false);
>
> + igt_describe("Check that if we can reserve a space for a object"
---------------------------------------------------------------------- ^
s/a object/an object/
> + " starting from a given offset");
> igt_subtest("allocator-basic-reserve")
> test_allocator_basic(fd, true);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement");
> igt_subtest("allocator-nopin")
> test_allocator_nopin(fd, false);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement and reserves/unreserves space for objects");
> igt_subtest("allocator-nopin-reserve")
> test_allocator_nopin(fd, true);
>
> + igt_describe("Check if multiple process can be allocted");
------------------------------------------------------- ^
s/process can be allocated/processes can use allocator./
> igt_subtest("allocator-fork")
> test_allocator_fork(fd);
>
> + igt_describe("Exercise eviction with softpinning");
> test_each_engine("allocator-evict", fd, ctx, e)
> test_allocator_evict(fd, ctx, e->flags, 20);
>
> @@ -1294,28 +1313,46 @@ igt_main
> igt_subtest("safe-alignment")
> safe_alignment(fd);
>
> + igt_describe("Check softpinning of a gem buffer object ");
------------------------------------------------------------- ^
Remove space from end.
> igt_subtest("softpin")
> test_softpin(fd);
> +
> + igt_describe("Checks the behaviour by runing on all possible"
s/Checks the behaviour by runing on all possible/Check all/
> + " page alligned overlaps");
---------------------------- ^
s/alligned/aligned/
> igt_subtest("overlap")
> test_overlap(fd);
> +
> + igt_describe("Check that if the user demands the vma be replaced, they are.");
Hmm, is user changing vma to second one ? Or reverses algo ?
> igt_subtest("reverse")
> test_reverse(fd);
>
> + igt_describe("Check that no relocation support works");
-------------------------------- ^--^
Please keep no-reloc word here and below.
> igt_subtest("noreloc")
> test_noreloc(fd, NOSLEEP, 0);
> +
> + igt_describe("Check no relocation support with interruptible");
> igt_subtest("noreloc-interruptible")
> test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
> +
> + igt_describe("Check norelocations hold versus suspend/resume");
--------------------------- ^
no-relocs
s/hold versus/survives after suspend to RAM/resume cycle./
> igt_subtest("noreloc-S3")
> test_noreloc(fd, SUSPEND, 0);
> +
> + igt_describe("Check norelocations hold versus suspend/resume");
s/hold versus/survive after suspend to disk/resume cycle./
> igt_subtest("noreloc-S4")
> test_noreloc(fd, HIBERNATE, 0);
>
> for (int signal = 0; signal <= 1; signal++) {
> + igt_describe("This test checks the behaviour of softpin with busy batch");
Maybe improve with igt_describe_f() ?
This is eviction, so it is a kind of stress test.
> igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
> test_evict_active(fd, signal);
> +
> + igt_describe("Snoop test by forcibly injecting signals");
Same here.
Regards,
Kamil
> igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
> test_evict_snoop(fd, signal);
> }
> +
> + igt_describe("Checks behaviour of softpin with hung batch");
> igt_subtest("evict-hang")
> test_evict_hang(fd);
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run
2022-06-20 7:03 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
@ 2022-06-20 7:03 ` sai.gowtham.ch
2022-06-20 8:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_softpin Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-20 7:03 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Just for test description, no full run is necessary.
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 188 +-------------------------
1 file changed, 1 insertion(+), 187 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 9c5dee44..9f8e18ce 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,187 +1 @@
-# Try to load the driver if it's not available yet.
-igt@i915_module_load@load
-
-# Keep alphabetically sorted by default
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@i915_pciid
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
+igt@meta_test@fail-result
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_softpin.
2022-06-20 7:03 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
@ 2022-06-20 8:15 ` Patchwork
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2022-06-20 8:15 UTC (permalink / raw)
To: sai.gowtham.ch; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7160 bytes --]
== Series Details ==
Series: HAX add description to gem_softpin.
URL : https://patchwork.freedesktop.org/series/105354/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11778 -> IGTPW_7341
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7341 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_7341, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/index.html
Participating hosts (35 -> 35)
------------------------------
Additional (1): bat-dg2-9
Missing (1): fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7341:
### IGT changes ###
#### Possible regressions ####
* igt@meta_test@fail-result (NEW):
- fi-apl-guc: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-apl-guc/igt@meta_test@fail-result.html
- fi-tgl-u2: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-tgl-u2/igt@meta_test@fail-result.html
- fi-bsw-nick: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-bsw-nick/igt@meta_test@fail-result.html
- fi-bxt-dsi: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-bxt-dsi/igt@meta_test@fail-result.html
- fi-snb-2520m: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-snb-2520m/igt@meta_test@fail-result.html
- {fi-jsl-1}: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-jsl-1/igt@meta_test@fail-result.html
- fi-rkl-11600: NOTRUN -> [FAIL][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-rkl-11600/igt@meta_test@fail-result.html
- fi-hsw-g3258: NOTRUN -> [FAIL][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-hsw-g3258/igt@meta_test@fail-result.html
- fi-blb-e6850: NOTRUN -> [FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-blb-e6850/igt@meta_test@fail-result.html
- fi-bsw-n3050: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-bsw-n3050/igt@meta_test@fail-result.html
- fi-skl-6600u: NOTRUN -> [FAIL][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-skl-6600u/igt@meta_test@fail-result.html
- fi-glk-dsi: NOTRUN -> [FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-glk-dsi/igt@meta_test@fail-result.html
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-bdw-gvtdvm/igt@meta_test@fail-result.html
- {fi-ehl-2}: NOTRUN -> [FAIL][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-ehl-2/igt@meta_test@fail-result.html
- fi-bsw-kefka: NOTRUN -> [FAIL][15]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-bsw-kefka/igt@meta_test@fail-result.html
- fi-adl-ddr5: NOTRUN -> [FAIL][16]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-adl-ddr5/igt@meta_test@fail-result.html
- fi-cfl-guc: NOTRUN -> [FAIL][17]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-cfl-guc/igt@meta_test@fail-result.html
- fi-pnv-d510: NOTRUN -> [FAIL][18]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-pnv-d510/igt@meta_test@fail-result.html
- {bat-dg2-9}: NOTRUN -> [FAIL][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/bat-dg2-9/igt@meta_test@fail-result.html
- fi-glk-j4005: NOTRUN -> [FAIL][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-glk-j4005/igt@meta_test@fail-result.html
- fi-hsw-4770: NOTRUN -> [FAIL][21]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-hsw-4770/igt@meta_test@fail-result.html
- fi-skl-6700k2: NOTRUN -> [FAIL][22]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-skl-6700k2/igt@meta_test@fail-result.html
- fi-cfl-8109u: NOTRUN -> [FAIL][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-cfl-8109u/igt@meta_test@fail-result.html
- fi-rkl-guc: NOTRUN -> [FAIL][24]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-rkl-guc/igt@meta_test@fail-result.html
- fi-kbl-8809g: NOTRUN -> [FAIL][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-kbl-8809g/igt@meta_test@fail-result.html
- fi-skl-guc: NOTRUN -> [FAIL][26]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-skl-guc/igt@meta_test@fail-result.html
- fi-ivb-3770: NOTRUN -> [FAIL][27]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-ivb-3770/igt@meta_test@fail-result.html
- fi-kbl-soraka: NOTRUN -> [FAIL][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-kbl-soraka/igt@meta_test@fail-result.html
- fi-elk-e7500: NOTRUN -> [FAIL][29]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-elk-e7500/igt@meta_test@fail-result.html
- fi-ilk-650: NOTRUN -> [FAIL][30]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-ilk-650/igt@meta_test@fail-result.html
- fi-kbl-guc: NOTRUN -> [FAIL][31]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-kbl-guc/igt@meta_test@fail-result.html
- fi-kbl-7567u: NOTRUN -> [FAIL][32]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-kbl-7567u/igt@meta_test@fail-result.html
- fi-cfl-8700k: NOTRUN -> [FAIL][33]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-cfl-8700k/igt@meta_test@fail-result.html
- {fi-tgl-dsi}: NOTRUN -> [FAIL][34]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-tgl-dsi/igt@meta_test@fail-result.html
- fi-snb-2600: NOTRUN -> [FAIL][35]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/fi-snb-2600/igt@meta_test@fail-result.html
New tests
---------
New tests have been introduced between CI_DRM_11778 and IGTPW_7341:
### New IGT tests (1) ###
* igt@meta_test@fail-result:
- Statuses : 35 fail(s)
- Exec time: [0.00, 0.21] s
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6536 -> IGTPW_7341
CI-20190529: 20190529
CI_DRM_11778: dd58ba5cb816d3e74056c3a28048893d8858ee7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7341: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/index.html
IGT_6536: e3de4d32b7a509635fbff4d5131c05a7767699f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7341/index.html
[-- Attachment #2: Type: text/html, Size: 8317 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin.
@ 2022-06-26 18:07 sai.gowtham.ch
2022-06-26 18:07 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
0 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-26 18:07 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_softpin.
Sai Gowtham Ch (2):
i915/gem_softpin: Added test description for test case.
HAX: don't do full run
tests/i915/gem_softpin.c | 36 ++++++
tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
2 files changed, 37 insertions(+), 177 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-26 18:07 [igt-dev] [PATCH i-g-t 0/2] " sai.gowtham.ch
@ 2022-06-26 18:07 ` sai.gowtham.ch
2022-06-28 17:18 ` Kamil Konieczny
0 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-26 18:07 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for test and to all the subtests that are
available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/i915/gem_softpin.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index b851c90e..ce62a584 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -32,6 +32,10 @@
#include "igt_rand.h"
#include "intel_allocator.h"
+IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
+ " scenarios and couple of eviction tests which copy buffers"
+ " between CPU and GPU.");
+
#define EXEC_OBJECT_PINNED (1<<4)
#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
@@ -1248,6 +1252,7 @@ igt_main
ctx = intel_ctx_create_all_physical(fd);
}
+ igt_describe("Check that invalid inputs are handled correctly.");
igt_subtest("invalid")
test_invalid(fd);
@@ -1258,30 +1263,44 @@ igt_main
igt_require(gem_uses_full_ppgtt(fd));
}
+ igt_describe("Check full placement control under full-ppGTT.");
igt_subtest("zero")
test_zero(fd);
+ igt_describe("Check the last 32b page is excluded.");
igt_subtest("32b-excludes-last-page")
test_32b_last_page(fd);
+ igt_describe("Check the total occupancy by using pad-to-size to fill"
+ " the entire GTT.");
igt_subtest("full")
test_full(fd);
+ igt_describe("Check that we can place objects at start/end of the GTT"
+ " using the allocator.");
igt_subtest("allocator-basic")
test_allocator_basic(fd, false);
+ igt_describe("Check that if we can reserve a space for an object"
+ " starting from a given offset.");
igt_subtest("allocator-basic-reserve")
test_allocator_basic(fd, true);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement.");
igt_subtest("allocator-nopin")
test_allocator_nopin(fd, false);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement and reserves/unreserves space for objects.");
igt_subtest("allocator-nopin-reserve")
test_allocator_nopin(fd, true);
+ igt_describe("Check if multiple processes can use alloctor.");
igt_subtest("allocator-fork")
test_allocator_fork(fd);
+ igt_describe("Exercise eviction with softpinning.");
test_each_engine("allocator-evict", fd, ctx, e)
test_allocator_evict(fd, ctx, e->flags, 20);
@@ -1294,28 +1313,45 @@ igt_main
igt_subtest("safe-alignment")
safe_alignment(fd);
+ igt_describe("Check softpinning of a gem buffer object.");
igt_subtest("softpin")
test_softpin(fd);
+
+ igt_describe("Check all the possible pages aligned overlaps.");
igt_subtest("overlap")
test_overlap(fd);
+
+ igt_describe("Check that if the user demands the vma be swapped.");
igt_subtest("reverse")
test_reverse(fd);
+ igt_describe("Check that no relocs support works.");
igt_subtest("noreloc")
test_noreloc(fd, NOSLEEP, 0);
+
+ igt_describe("Check no relocs support with interruptible.");
igt_subtest("noreloc-interruptible")
test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
+
+ igt_describe("Check norelocs survives after suspend to RAM/resume cycle.");
igt_subtest("noreloc-S3")
test_noreloc(fd, SUSPEND, 0);
+
+ igt_describe("Check norelocs survives after suspend to disk/resume cycle.");
igt_subtest("noreloc-S4")
test_noreloc(fd, HIBERNATE, 0);
for (int signal = 0; signal <= 1; signal++) {
+ igt_describe("Stress test which checks softpin with busy batch.");
igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
test_evict_active(fd, signal);
+
+ igt_describe("check that Snooping test by forcibly injecting signals works.");
igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
test_evict_snoop(fd, signal);
}
+
+ igt_describe("Checks behaviour of softpin with hung batch.");
igt_subtest("evict-hang")
test_evict_hang(fd);
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-26 18:07 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
@ 2022-06-28 17:18 ` Kamil Konieczny
0 siblings, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2022-06-28 17:18 UTC (permalink / raw)
To: igt-dev; +Cc: Sai Gowtham Ch
Hi Sai,
On 2022-06-26 at 23:37:49 +0530, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all the subtests that are
> available.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_softpin.c | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
> index b851c90e..ce62a584 100644
> --- a/tests/i915/gem_softpin.c
> +++ b/tests/i915/gem_softpin.c
> @@ -32,6 +32,10 @@
> #include "igt_rand.h"
> #include "intel_allocator.h"
>
> +IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
> + " scenarios and couple of eviction tests which copy buffers"
> + " between CPU and GPU.");
> +
> #define EXEC_OBJECT_PINNED (1<<4)
> #define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
>
> @@ -1248,6 +1252,7 @@ igt_main
> ctx = intel_ctx_create_all_physical(fd);
> }
>
> + igt_describe("Check that invalid inputs are handled correctly.");
> igt_subtest("invalid")
> test_invalid(fd);
>
> @@ -1258,30 +1263,44 @@ igt_main
> igt_require(gem_uses_full_ppgtt(fd));
> }
>
> + igt_describe("Check full placement control under full-ppGTT.");
> igt_subtest("zero")
> test_zero(fd);
>
> + igt_describe("Check the last 32b page is excluded.");
> igt_subtest("32b-excludes-last-page")
> test_32b_last_page(fd);
>
> + igt_describe("Check the total occupancy by using pad-to-size to fill"
> + " the entire GTT.");
> igt_subtest("full")
> test_full(fd);
>
> + igt_describe("Check that we can place objects at start/end of the GTT"
> + " using the allocator.");
> igt_subtest("allocator-basic")
> test_allocator_basic(fd, false);
>
> + igt_describe("Check that if we can reserve a space for an object"
> + " starting from a given offset.");
> igt_subtest("allocator-basic-reserve")
> test_allocator_basic(fd, true);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement.");
> igt_subtest("allocator-nopin")
> test_allocator_nopin(fd, false);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement and reserves/unreserves space for objects.");
> igt_subtest("allocator-nopin-reserve")
> test_allocator_nopin(fd, true);
>
> + igt_describe("Check if multiple processes can use alloctor.");
> igt_subtest("allocator-fork")
> test_allocator_fork(fd);
>
> + igt_describe("Exercise eviction with softpinning.");
> test_each_engine("allocator-evict", fd, ctx, e)
> test_allocator_evict(fd, ctx, e->flags, 20);
>
> @@ -1294,28 +1313,45 @@ igt_main
> igt_subtest("safe-alignment")
> safe_alignment(fd);
>
> + igt_describe("Check softpinning of a gem buffer object.");
> igt_subtest("softpin")
> test_softpin(fd);
> +
> + igt_describe("Check all the possible pages aligned overlaps.");
> igt_subtest("overlap")
> test_overlap(fd);
> +
> + igt_describe("Check that if the user demands the vma be swapped.");
----------------------------------------------------------- ^
s/vma be/vma will be/
> igt_subtest("reverse")
> test_reverse(fd);
>
> + igt_describe("Check that no relocs support works.");
-------------------------------- ^--^
Hmm, please make it noreloc here (sorry if I wrote otherwise
before).
> igt_subtest("noreloc")
> test_noreloc(fd, NOSLEEP, 0);
> +
> + igt_describe("Check no relocs support with interruptible.");
--------------------------- ^--^
Same here.
> igt_subtest("noreloc-interruptible")
> test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
> +
> + igt_describe("Check norelocs survives after suspend to RAM/resume cycle.");
s/norelocs/noreloc/
> igt_subtest("noreloc-S3")
> test_noreloc(fd, SUSPEND, 0);
> +
> + igt_describe("Check norelocs survives after suspend to disk/resume cycle.");
s/norelocs/noreloc/
> igt_subtest("noreloc-S4")
> test_noreloc(fd, HIBERNATE, 0);
>
> for (int signal = 0; signal <= 1; signal++) {
> + igt_describe("Stress test which checks softpin with busy batch.");
Please use ift_describe_f() here with optional " with interrupts",
also change the beginning to something like:
"Check eviction with active bo%s."
> igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
> test_evict_active(fd, signal);
> +
> + igt_describe("check that Snooping test by forcibly injecting signals works.");
Same here, maybe something like
"Check eviction against snooping%s."
> igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
> test_evict_snoop(fd, signal);
> }
> +
> + igt_describe("Checks behaviour of softpin with hung batch.");
---------------------------- ^
s/behaviour/eviction/
s/softpin/softpinned bo/
> igt_subtest("evict-hang")
> test_evict_hang(fd);
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin.
@ 2022-06-29 6:41 sai.gowtham.ch
2022-06-29 6:41 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
0 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-29 6:41 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_softpin.
Sai Gowtham Ch (2):
i915/gem_softpin: Added test description for test case.
HAX: don't do full run
tests/i915/gem_softpin.c | 40 +++++-
tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
2 files changed, 39 insertions(+), 179 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-29 6:41 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
@ 2022-06-29 6:41 ` sai.gowtham.ch
2022-06-29 7:03 ` Kamil Konieczny
0 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-29 6:41 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for test and to all the subtests that are
available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
tests/i915/gem_softpin.c | 40 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index b851c90e..153f5f6b 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -32,6 +32,10 @@
#include "igt_rand.h"
#include "intel_allocator.h"
+IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
+ " scenarios and couple of eviction tests which copy buffers"
+ " between CPU and GPU.");
+
#define EXEC_OBJECT_PINNED (1<<4)
#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
@@ -1248,6 +1252,7 @@ igt_main
ctx = intel_ctx_create_all_physical(fd);
}
+ igt_describe("Check that invalid inputs are handled correctly.");
igt_subtest("invalid")
test_invalid(fd);
@@ -1258,64 +1263,95 @@ igt_main
igt_require(gem_uses_full_ppgtt(fd));
}
+ igt_describe("Check full placement control under full-ppGTT.");
igt_subtest("zero")
test_zero(fd);
+ igt_describe("Check the last 32b page is excluded.");
igt_subtest("32b-excludes-last-page")
test_32b_last_page(fd);
+ igt_describe("Check the total occupancy by using pad-to-size to fill"
+ " the entire GTT.");
igt_subtest("full")
test_full(fd);
+ igt_describe("Check that we can place objects at start/end of the GTT"
+ " using the allocator.");
igt_subtest("allocator-basic")
test_allocator_basic(fd, false);
+ igt_describe("Check that if we can reserve a space for an object"
+ " starting from a given offset.");
igt_subtest("allocator-basic-reserve")
test_allocator_basic(fd, true);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement.");
igt_subtest("allocator-nopin")
test_allocator_nopin(fd, false);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement and reserves/unreserves space for objects.");
igt_subtest("allocator-nopin-reserve")
test_allocator_nopin(fd, true);
+ igt_describe("Check if multiple processes can use alloctor.");
igt_subtest("allocator-fork")
test_allocator_fork(fd);
+ igt_describe("Exercise eviction with softpinning.");
test_each_engine("allocator-evict", fd, ctx, e)
test_allocator_evict(fd, ctx, e->flags, 20);
- igt_describe("Use same offset for all engines and for different handles");
+ igt_describe("Use same offset for all engines and for different handles.");
igt_subtest("evict-single-offset")
evict_single_offset(fd, ctx, 20);
}
- igt_describe("Check start offset and alignment detection");
+ igt_describe("Check start offset and alignment detection.");
igt_subtest("safe-alignment")
safe_alignment(fd);
+ igt_describe("Check softpinning of a gem buffer object.");
igt_subtest("softpin")
test_softpin(fd);
+
+ igt_describe("Check all the possible pages aligned overlaps.");
igt_subtest("overlap")
test_overlap(fd);
+
+ igt_describe("Check that if the user demands the vma will be swapped.");
igt_subtest("reverse")
test_reverse(fd);
+ igt_describe("Check that noreloc support works.");
igt_subtest("noreloc")
test_noreloc(fd, NOSLEEP, 0);
+
+ igt_describe("Check noreloc support with interruptible.");
igt_subtest("noreloc-interruptible")
test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
+
+ igt_describe("Check noreloc survives after suspend to RAM/resume cycle.");
igt_subtest("noreloc-S3")
test_noreloc(fd, SUSPEND, 0);
+
+ igt_describe("Check noreloc survives after suspend to disk/resume cycle.");
igt_subtest("noreloc-S4")
test_noreloc(fd, HIBERNATE, 0);
for (int signal = 0; signal <= 1; signal++) {
+ igt_describe_f("Check eviction with active bo %s.", signal ? "with interrupts" : "");
igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
test_evict_active(fd, signal);
+
+ igt_describe_f("Check eviction against snooping %s.", signal ? "with interrupts" : "");
igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
test_evict_snoop(fd, signal);
}
+
+ igt_describe("Check eviction of softpinned bo with hung batch.");
igt_subtest("evict-hang")
test_evict_hang(fd);
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-29 6:41 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
@ 2022-06-29 7:03 ` Kamil Konieczny
0 siblings, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2022-06-29 7:03 UTC (permalink / raw)
To: igt-dev; +Cc: Sai Gowtham Ch
Hi Sai,
On 2022-06-29 at 12:11:27 +0530, sai.gowtham.ch@intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all the subtests that are
> available.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_softpin.c | 40 ++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
> index b851c90e..153f5f6b 100644
> --- a/tests/i915/gem_softpin.c
> +++ b/tests/i915/gem_softpin.c
> @@ -32,6 +32,10 @@
> #include "igt_rand.h"
> #include "intel_allocator.h"
>
> +IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
> + " scenarios and couple of eviction tests which copy buffers"
> + " between CPU and GPU.");
> +
> #define EXEC_OBJECT_PINNED (1<<4)
> #define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
>
> @@ -1248,6 +1252,7 @@ igt_main
> ctx = intel_ctx_create_all_physical(fd);
> }
>
> + igt_describe("Check that invalid inputs are handled correctly.");
> igt_subtest("invalid")
> test_invalid(fd);
>
> @@ -1258,64 +1263,95 @@ igt_main
> igt_require(gem_uses_full_ppgtt(fd));
> }
>
> + igt_describe("Check full placement control under full-ppGTT.");
> igt_subtest("zero")
> test_zero(fd);
>
> + igt_describe("Check the last 32b page is excluded.");
> igt_subtest("32b-excludes-last-page")
> test_32b_last_page(fd);
>
> + igt_describe("Check the total occupancy by using pad-to-size to fill"
> + " the entire GTT.");
> igt_subtest("full")
> test_full(fd);
>
> + igt_describe("Check that we can place objects at start/end of the GTT"
> + " using the allocator.");
> igt_subtest("allocator-basic")
> test_allocator_basic(fd, false);
>
> + igt_describe("Check that if we can reserve a space for an object"
> + " starting from a given offset.");
> igt_subtest("allocator-basic-reserve")
> test_allocator_basic(fd, true);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement.");
> igt_subtest("allocator-nopin")
> test_allocator_nopin(fd, false);
>
> + igt_describe("Check that we can combine manual placement with automatic"
> + " GTT placement and reserves/unreserves space for objects.");
> igt_subtest("allocator-nopin-reserve")
> test_allocator_nopin(fd, true);
>
> + igt_describe("Check if multiple processes can use alloctor.");
> igt_subtest("allocator-fork")
> test_allocator_fork(fd);
>
> + igt_describe("Exercise eviction with softpinning.");
> test_each_engine("allocator-evict", fd, ctx, e)
> test_allocator_evict(fd, ctx, e->flags, 20);
>
> - igt_describe("Use same offset for all engines and for different handles");
> + igt_describe("Use same offset for all engines and for different handles.");
> igt_subtest("evict-single-offset")
> evict_single_offset(fd, ctx, 20);
> }
>
> - igt_describe("Check start offset and alignment detection");
> + igt_describe("Check start offset and alignment detection.");
> igt_subtest("safe-alignment")
> safe_alignment(fd);
>
> + igt_describe("Check softpinning of a gem buffer object.");
> igt_subtest("softpin")
> test_softpin(fd);
> +
> + igt_describe("Check all the possible pages aligned overlaps.");
> igt_subtest("overlap")
> test_overlap(fd);
> +
> + igt_describe("Check that if the user demands the vma will be swapped.");
> igt_subtest("reverse")
> test_reverse(fd);
>
> + igt_describe("Check that noreloc support works.");
> igt_subtest("noreloc")
> test_noreloc(fd, NOSLEEP, 0);
> +
> + igt_describe("Check noreloc support with interruptible.");
> igt_subtest("noreloc-interruptible")
> test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
> +
> + igt_describe("Check noreloc survives after suspend to RAM/resume cycle.");
> igt_subtest("noreloc-S3")
> test_noreloc(fd, SUSPEND, 0);
> +
> + igt_describe("Check noreloc survives after suspend to disk/resume cycle.");
> igt_subtest("noreloc-S4")
> test_noreloc(fd, HIBERNATE, 0);
>
> for (int signal = 0; signal <= 1; signal++) {
> + igt_describe_f("Check eviction with active bo %s.", signal ? "with interrupts" : "");
------------------------------------------------------------ ^ -------------- ^
Move this space before "with":
s/bo /bo/
s/with/ with/
> igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
> test_evict_active(fd, signal);
> +
> + igt_describe_f("Check eviction against snooping %s.", signal ? "with interrupts" : "");
Same here.
With that fixed you can add my r-b tag,
Regards,
Kamil
> igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
> test_evict_snoop(fd, signal);
> }
> +
> + igt_describe("Check eviction of softpinned bo with hung batch.");
> igt_subtest("evict-hang")
> test_evict_hang(fd);
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin.
@ 2022-06-29 7:28 sai.gowtham.ch
2022-06-29 7:28 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
0 siblings, 1 reply; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-29 7:28 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Add test description to gem_softpin.
Sai Gowtham Ch (2):
i915/gem_softpin: Added test description for test case.
HAX: don't do full run
tests/i915/gem_softpin.c | 40 +++++-
tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
2 files changed, 39 insertions(+), 179 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
2022-06-29 7:28 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
@ 2022-06-29 7:28 ` sai.gowtham.ch
0 siblings, 0 replies; 10+ messages in thread
From: sai.gowtham.ch @ 2022-06-29 7:28 UTC (permalink / raw)
To: igt-dev, kamil.konieczny, sai.gowtham.ch
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Added test description for test and to all the subtests that are
available.
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/i915/gem_softpin.c | 40 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index b851c90e..a85a3664 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -32,6 +32,10 @@
#include "igt_rand.h"
#include "intel_allocator.h"
+IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
+ " scenarios and couple of eviction tests which copy buffers"
+ " between CPU and GPU.");
+
#define EXEC_OBJECT_PINNED (1<<4)
#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
@@ -1248,6 +1252,7 @@ igt_main
ctx = intel_ctx_create_all_physical(fd);
}
+ igt_describe("Check that invalid inputs are handled correctly.");
igt_subtest("invalid")
test_invalid(fd);
@@ -1258,64 +1263,95 @@ igt_main
igt_require(gem_uses_full_ppgtt(fd));
}
+ igt_describe("Check full placement control under full-ppGTT.");
igt_subtest("zero")
test_zero(fd);
+ igt_describe("Check the last 32b page is excluded.");
igt_subtest("32b-excludes-last-page")
test_32b_last_page(fd);
+ igt_describe("Check the total occupancy by using pad-to-size to fill"
+ " the entire GTT.");
igt_subtest("full")
test_full(fd);
+ igt_describe("Check that we can place objects at start/end of the GTT"
+ " using the allocator.");
igt_subtest("allocator-basic")
test_allocator_basic(fd, false);
+ igt_describe("Check that if we can reserve a space for an object"
+ " starting from a given offset.");
igt_subtest("allocator-basic-reserve")
test_allocator_basic(fd, true);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement.");
igt_subtest("allocator-nopin")
test_allocator_nopin(fd, false);
+ igt_describe("Check that we can combine manual placement with automatic"
+ " GTT placement and reserves/unreserves space for objects.");
igt_subtest("allocator-nopin-reserve")
test_allocator_nopin(fd, true);
+ igt_describe("Check if multiple processes can use alloctor.");
igt_subtest("allocator-fork")
test_allocator_fork(fd);
+ igt_describe("Exercise eviction with softpinning.");
test_each_engine("allocator-evict", fd, ctx, e)
test_allocator_evict(fd, ctx, e->flags, 20);
- igt_describe("Use same offset for all engines and for different handles");
+ igt_describe("Use same offset for all engines and for different handles.");
igt_subtest("evict-single-offset")
evict_single_offset(fd, ctx, 20);
}
- igt_describe("Check start offset and alignment detection");
+ igt_describe("Check start offset and alignment detection.");
igt_subtest("safe-alignment")
safe_alignment(fd);
+ igt_describe("Check softpinning of a gem buffer object.");
igt_subtest("softpin")
test_softpin(fd);
+
+ igt_describe("Check all the possible pages aligned overlaps.");
igt_subtest("overlap")
test_overlap(fd);
+
+ igt_describe("Check that if the user demands the vma will be swapped.");
igt_subtest("reverse")
test_reverse(fd);
+ igt_describe("Check that noreloc support works.");
igt_subtest("noreloc")
test_noreloc(fd, NOSLEEP, 0);
+
+ igt_describe("Check noreloc support with interruptible.");
igt_subtest("noreloc-interruptible")
test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
+
+ igt_describe("Check noreloc survives after suspend to RAM/resume cycle.");
igt_subtest("noreloc-S3")
test_noreloc(fd, SUSPEND, 0);
+
+ igt_describe("Check noreloc survives after suspend to disk/resume cycle.");
igt_subtest("noreloc-S4")
test_noreloc(fd, HIBERNATE, 0);
for (int signal = 0; signal <= 1; signal++) {
+ igt_describe_f("Check eviction with active bo%s.", signal ? " with interrupts" : "");
igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
test_evict_active(fd, signal);
+
+ igt_describe_f("Check eviction against snooping%s.", signal ? " with interrupts" : "");
igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
test_evict_snoop(fd, signal);
}
+
+ igt_describe("Check eviction of softpinned bo with hung batch.");
igt_subtest("evict-hang")
test_evict_hang(fd);
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-06-29 7:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 7:03 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-22 16:14 ` Kamil Konieczny
2022-06-20 7:03 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
2022-06-20 8:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_softpin Patchwork
2022-06-26 18:07 [igt-dev] [PATCH i-g-t 0/2] " sai.gowtham.ch
2022-06-26 18:07 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-28 17:18 ` Kamil Konieczny
2022-06-29 6:41 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-29 6:41 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-29 7:03 ` Kamil Konieczny
2022-06-29 7:28 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-29 7:28 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.