From: Richard Leitner <richard.leitner@linux.dev> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Ladislav Michl <ladis@linux-mips.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Benjamin Bara <benjamin.bara@skidata.com>, Benjamin Bara <bbara93@gmail.com>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner <richard.leitner@skidata.com> Subject: Re: [PATCH v2 2/3] ASoC: dt-bindings: maxim,max9867: add clocks property Date: Fri, 3 Mar 2023 11:19:00 +0100 [thread overview] Message-ID: <ZAHJlPlLRrz81hmv@g0hl1n.net> (raw) In-Reply-To: <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> Hi Krzysztof, thanks for the review and quick response! On Fri, Mar 03, 2023 at 11:09:15AM +0100, Krzysztof Kozlowski wrote: > On 03/03/2023 11:04, richard.leitner@linux.dev wrote: > > From: Richard Leitner <richard.leitner@skidata.com> > > > > Add clocks property to require a "mclk" definition for the > > maxim,max9867 codec. > > But why? You just wrote what the patch does, which is easy to see. > Commit msgs should explain why you are doing something. Ok. Will adapt the message in v3. > > > > > Signed-off-by: Richard Leitner <richard.leitner@skidata.com> > > --- > > Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > index 74cd163546ec..6f27029b137d 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > @@ -35,9 +35,13 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > + - clocks > > > > additionalProperties: false > > > > @@ -50,6 +54,13 @@ examples: > > compatible = "maxim,max9867"; > > #sound-dai-cells = <0>; > > reg = <0x18>; > > + clocks = <&codec_clk>; > > }; > > }; > > + > > + codec_clk: clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <12288000>; > > Drop the node, it's entirely common/regular stuff. True. I thought it is nessecary for "make DT_CHECKER_FLAGS=-m dt_binding_check" to succeed. But I just learned it in fact isn't. Thanks for the pointer and that eureka moment 😉. Will fix that in v3. > > Best regards, > Krzysztof > regards;rl
WARNING: multiple messages have this Message-ID (diff)
From: Richard Leitner <richard.leitner@linux.dev> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Ladislav Michl <ladis@linux-mips.org>, Takashi Iwai <tiwai@suse.com>, Benjamin Bara <benjamin.bara@skidata.com>, Benjamin Bara <bbara93@gmail.com>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner <richard.leitner@skidata.com> Subject: Re: [PATCH v2 2/3] ASoC: dt-bindings: maxim,max9867: add clocks property Date: Fri, 3 Mar 2023 11:19:00 +0100 [thread overview] Message-ID: <ZAHJlPlLRrz81hmv@g0hl1n.net> (raw) In-Reply-To: <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> Hi Krzysztof, thanks for the review and quick response! On Fri, Mar 03, 2023 at 11:09:15AM +0100, Krzysztof Kozlowski wrote: > On 03/03/2023 11:04, richard.leitner@linux.dev wrote: > > From: Richard Leitner <richard.leitner@skidata.com> > > > > Add clocks property to require a "mclk" definition for the > > maxim,max9867 codec. > > But why? You just wrote what the patch does, which is easy to see. > Commit msgs should explain why you are doing something. Ok. Will adapt the message in v3. > > > > > Signed-off-by: Richard Leitner <richard.leitner@skidata.com> > > --- > > Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > index 74cd163546ec..6f27029b137d 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > @@ -35,9 +35,13 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > + - clocks > > > > additionalProperties: false > > > > @@ -50,6 +54,13 @@ examples: > > compatible = "maxim,max9867"; > > #sound-dai-cells = <0>; > > reg = <0x18>; > > + clocks = <&codec_clk>; > > }; > > }; > > + > > + codec_clk: clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <12288000>; > > Drop the node, it's entirely common/regular stuff. True. I thought it is nessecary for "make DT_CHECKER_FLAGS=-m dt_binding_check" to succeed. But I just learned it in fact isn't. Thanks for the pointer and that eureka moment 😉. Will fix that in v3. > > Best regards, > Krzysztof > regards;rl
next prev parent reply other threads:[~2023-03-03 10:19 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 10:04 [PATCH v2 0/3] Add "mclk" support for maxim,max9867 richard.leitner 2023-03-03 10:04 ` [PATCH v2 1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml richard.leitner 2023-03-03 10:08 ` Krzysztof Kozlowski 2023-03-03 10:04 ` [PATCH v2 2/3] ASoC: dt-bindings: maxim,max9867: add clocks property richard.leitner 2023-03-03 10:09 ` Krzysztof Kozlowski 2023-03-03 10:19 ` Richard Leitner [this message] 2023-03-03 10:19 ` Richard Leitner 2023-03-03 10:04 ` [PATCH v2 3/3] ASoC: maxim,max9867: add "mclk" support richard.leitner 2023-03-06 13:32 ` [PATCH v2 0/3] Add "mclk" support for maxim,max9867 Mark Brown 2023-03-28 5:59 ` Richard Leitner 2023-03-28 5:59 ` Richard Leitner 2023-03-28 7:41 ` Krzysztof Kozlowski 2023-03-28 7:41 ` Krzysztof Kozlowski 2023-03-28 12:39 ` Mark Brown 2023-03-28 12:39 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZAHJlPlLRrz81hmv@g0hl1n.net \ --to=richard.leitner@linux.dev \ --cc=alsa-devel@alsa-project.org \ --cc=bbara93@gmail.com \ --cc=benjamin.bara@skidata.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=ladis@linux-mips.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=richard.leitner@skidata.com \ --cc=robh+dt@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.