All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
@ 2022-02-10 10:34 ` davidcomponentone
  0 siblings, 0 replies; 6+ messages in thread
From: davidcomponentone @ 2022-02-10 10:34 UTC (permalink / raw)
  To: gregkh
  Cc: davidcomponentone, jirislaby, joel, andrew, zev, johan,
	yang.guang5, linux-serial, linux-arm-kernel, linux-aspeed,
	linux-kernel, Zeal Robot

From: Yang Guang <yang.guang5@zte.com.cn>

coccinelle report:
./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
WARNING: use scnprintf or sprintf
./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
WARNING: use scnprintf or sprintf
./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
WARNING: use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
CC: David Yang <davidcomponentone@gmail.com>

---
Change from v1-v2:
- Modify the patch title
- Use the CC for patch sender

---
 drivers/tty/serial/8250/8250_aspeed_vuart.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
index 2350fb3bb5e4..36c39b8ea7af 100644
--- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
+++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
@@ -82,7 +82,7 @@ static ssize_t lpc_address_show(struct device *dev,
 	addr = (aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRH) << 8) |
 		(aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRL));
 
-	return snprintf(buf, PAGE_SIZE - 1, "0x%x\n", addr);
+	return sysfs_emit(buf, "0x%x\n", addr);
 }
 
 static int aspeed_vuart_set_lpc_address(struct aspeed_vuart *vuart, u32 addr)
@@ -124,7 +124,7 @@ static ssize_t sirq_show(struct device *dev,
 	reg &= ASPEED_VUART_GCRB_HOST_SIRQ_MASK;
 	reg >>= ASPEED_VUART_GCRB_HOST_SIRQ_SHIFT;
 
-	return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg);
+	return sysfs_emit(buf, "%u\n", reg);
 }
 
 static int aspeed_vuart_set_sirq(struct aspeed_vuart *vuart, u32 sirq)
@@ -171,7 +171,7 @@ static ssize_t sirq_polarity_show(struct device *dev,
 	reg = aspeed_vuart_readb(vuart, ASPEED_VUART_GCRA);
 	reg &= ASPEED_VUART_GCRA_HOST_SIRQ_POLARITY;
 
-	return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg ? 1 : 0);
+	return sysfs_emit(buf, "%u\n", reg ? 1 : 0);
 }
 
 static void aspeed_vuart_set_sirq_polarity(struct aspeed_vuart *vuart,
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
@ 2022-02-10 10:34 ` davidcomponentone
  0 siblings, 0 replies; 6+ messages in thread
From: davidcomponentone @ 2022-02-10 10:34 UTC (permalink / raw)
  To: gregkh
  Cc: davidcomponentone, jirislaby, joel, andrew, zev, johan,
	yang.guang5, linux-serial, linux-arm-kernel, linux-aspeed,
	linux-kernel, Zeal Robot

From: Yang Guang <yang.guang5@zte.com.cn>

coccinelle report:
./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
WARNING: use scnprintf or sprintf
./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
WARNING: use scnprintf or sprintf
./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
WARNING: use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
CC: David Yang <davidcomponentone@gmail.com>

---
Change from v1-v2:
- Modify the patch title
- Use the CC for patch sender

---
 drivers/tty/serial/8250/8250_aspeed_vuart.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
index 2350fb3bb5e4..36c39b8ea7af 100644
--- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
+++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
@@ -82,7 +82,7 @@ static ssize_t lpc_address_show(struct device *dev,
 	addr = (aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRH) << 8) |
 		(aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRL));
 
-	return snprintf(buf, PAGE_SIZE - 1, "0x%x\n", addr);
+	return sysfs_emit(buf, "0x%x\n", addr);
 }
 
 static int aspeed_vuart_set_lpc_address(struct aspeed_vuart *vuart, u32 addr)
@@ -124,7 +124,7 @@ static ssize_t sirq_show(struct device *dev,
 	reg &= ASPEED_VUART_GCRB_HOST_SIRQ_MASK;
 	reg >>= ASPEED_VUART_GCRB_HOST_SIRQ_SHIFT;
 
-	return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg);
+	return sysfs_emit(buf, "%u\n", reg);
 }
 
 static int aspeed_vuart_set_sirq(struct aspeed_vuart *vuart, u32 sirq)
@@ -171,7 +171,7 @@ static ssize_t sirq_polarity_show(struct device *dev,
 	reg = aspeed_vuart_readb(vuart, ASPEED_VUART_GCRA);
 	reg &= ASPEED_VUART_GCRA_HOST_SIRQ_POLARITY;
 
-	return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg ? 1 : 0);
+	return sysfs_emit(buf, "%u\n", reg ? 1 : 0);
 }
 
 static void aspeed_vuart_set_sirq_polarity(struct aspeed_vuart *vuart,
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
  2022-02-10 10:34 ` davidcomponentone
@ 2022-02-10 11:13   ` Andy Shevchenko
  -1 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-02-10 11:13 UTC (permalink / raw)
  To: davidcomponentone
  Cc: Greg Kroah-Hartman, Jiri Slaby, Joel Stanley, Andrew Jeffery,
	Zev Weiss, Johan Hovold, Yang Guang, open list:SERIAL DRIVERS,
	linux-arm Mailing List,
	moderated list:ARM/ASPEED MACHINE SUPPORT,
	Linux Kernel Mailing List, Zeal Robot

On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
>
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> coccinelle report:
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> WARNING: use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.

sysfs_emit()
scnprintf()
sprintf()

...

> CC: David Yang <davidcomponentone@gmail.com>

> - Use the CC for patch sender

This is incorrect. The submitter must have (the last) SoB tag.
Question was about authorship just to be clear.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
@ 2022-02-10 11:13   ` Andy Shevchenko
  0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-02-10 11:13 UTC (permalink / raw)
  To: davidcomponentone
  Cc: Greg Kroah-Hartman, Jiri Slaby, Joel Stanley, Andrew Jeffery,
	Zev Weiss, Johan Hovold, Yang Guang, open list:SERIAL DRIVERS,
	linux-arm Mailing List,
	moderated list:ARM/ASPEED MACHINE SUPPORT,
	Linux Kernel Mailing List, Zeal Robot

On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
>
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> coccinelle report:
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> WARNING: use scnprintf or sprintf
> ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> WARNING: use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.

sysfs_emit()
scnprintf()
sprintf()

...

> CC: David Yang <davidcomponentone@gmail.com>

> - Use the CC for patch sender

This is incorrect. The submitter must have (the last) SoB tag.
Question was about authorship just to be clear.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
  2022-02-10 11:13   ` Andy Shevchenko
@ 2022-02-10 11:26     ` Johan Hovold
  -1 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2022-02-10 11:26 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: davidcomponentone, Greg Kroah-Hartman, Jiri Slaby, Joel Stanley,
	Andrew Jeffery, Zev Weiss, Yang Guang, open list:SERIAL DRIVERS,
	linux-arm Mailing List,
	moderated list:ARM/ASPEED MACHINE SUPPORT,
	Linux Kernel Mailing List, Zeal Robot

On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
> >
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> sysfs_emit()
> scnprintf()
> sprintf()
> 
> ...
> 
> > CC: David Yang <davidcomponentone@gmail.com>
> 
> > - Use the CC for patch sender
> 
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.

Please fix up the subject prefix too ("8059").

Johan

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
@ 2022-02-10 11:26     ` Johan Hovold
  0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2022-02-10 11:26 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: davidcomponentone, Greg Kroah-Hartman, Jiri Slaby, Joel Stanley,
	Andrew Jeffery, Zev Weiss, Yang Guang, open list:SERIAL DRIVERS,
	linux-arm Mailing List,
	moderated list:ARM/ASPEED MACHINE SUPPORT,
	Linux Kernel Mailing List, Zeal Robot

On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
> >
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> sysfs_emit()
> scnprintf()
> sprintf()
> 
> ...
> 
> > CC: David Yang <davidcomponentone@gmail.com>
> 
> > - Use the CC for patch sender
> 
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.

Please fix up the subject prefix too ("8059").

Johan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-10 11:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 10:34 [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit davidcomponentone
2022-02-10 10:34 ` davidcomponentone
2022-02-10 11:13 ` Andy Shevchenko
2022-02-10 11:13   ` Andy Shevchenko
2022-02-10 11:26   ` Johan Hovold
2022-02-10 11:26     ` Johan Hovold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.