From: Denis Efremov <efremov@linux.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v3] coccinelle: api: add kzfree script Date: Thu, 18 Jun 2020 00:42:33 +0300 [thread overview] Message-ID: <aa7613e9-8152-0022-6d67-0706ce5983d0@linux.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2006172241551.3083@hadrien> >> +@rp_memset depends on patch@ >> +expression E, size; >> +position p : script:python() { relevant(p) }; >> +type T; >> +@@ >> + >> +- memset((T)E, size)@p; > > This is missing a 0 argument. > Thanks, I will send v4. > > >> + ... when != E >> + when strict >> +( >> +- kfree(E); >> ++ kzfree(E); >> +| >> +- \(vfree\|kvfree\)(E); >> ++ kvfree_sensitive(E, size); >> +) > > I'm not sure why you want kzfree in the first case, but kvfree_sensitive > in the second case. > As for now in kernel: memset(E,0,...) && kfree(E) is kzfree() There are no vzfree or kvzfree functions. Thus, we use kvfree_sensitive(). Maybe it's worth to wait for this patchset: https://lkml.org/lkml/2020/6/16/1163 With it the rule will use: ( - kfree(E); + kfree_sensitive(E); | - \(vfree\|kvfree\)(E); + kvfree_sensitive(E, size); ) Thanks, Denis
WARNING: multiple messages have this Message-ID (diff)
From: Denis Efremov <efremov@linux.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v3] coccinelle: api: add kzfree script Date: Thu, 18 Jun 2020 00:42:33 +0300 [thread overview] Message-ID: <aa7613e9-8152-0022-6d67-0706ce5983d0@linux.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2006172241551.3083@hadrien> >> +@rp_memset depends on patch@ >> +expression E, size; >> +position p : script:python() { relevant(p) }; >> +type T; >> +@@ >> + >> +- memset((T)E, size)@p; > > This is missing a 0 argument. > Thanks, I will send v4. > > >> + ... when != E >> + when strict >> +( >> +- kfree(E); >> ++ kzfree(E); >> +| >> +- \(vfree\|kvfree\)(E); >> ++ kvfree_sensitive(E, size); >> +) > > I'm not sure why you want kzfree in the first case, but kvfree_sensitive > in the second case. > As for now in kernel: memset(E,0,...) && kfree(E) is kzfree() There are no vzfree or kvzfree functions. Thus, we use kvfree_sensitive(). Maybe it's worth to wait for this patchset: https://lkml.org/lkml/2020/6/16/1163 With it the rule will use: ( - kfree(E); + kfree_sensitive(E); | - \(vfree\|kvfree\)(E); + kvfree_sensitive(E, size); ) Thanks, Denis _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-06-17 21:42 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 14:08 [PATCH] coccinelle: api: add kzfree script Denis Efremov 2020-06-04 14:08 ` [Cocci] " Denis Efremov 2020-06-04 14:15 ` Julia Lawall 2020-06-04 14:15 ` [Cocci] " Julia Lawall 2020-06-04 15:39 ` Denis Efremov 2020-06-04 15:39 ` [Cocci] " Denis Efremov 2020-06-04 15:51 ` Julia Lawall 2020-06-04 15:51 ` [Cocci] " Julia Lawall 2020-06-04 17:22 ` Denis Efremov 2020-06-04 17:22 ` [Cocci] " Denis Efremov 2020-06-04 17:28 ` Julia Lawall 2020-06-04 17:28 ` [Cocci] " Julia Lawall 2020-06-04 16:27 ` Joe Perches 2020-06-04 16:27 ` [Cocci] " Joe Perches 2020-06-04 17:30 ` Denis Efremov 2020-06-04 17:30 ` [Cocci] " Denis Efremov 2020-06-04 17:36 ` Joe Perches 2020-06-04 17:36 ` [Cocci] " Joe Perches 2020-06-14 19:42 ` Denis Efremov 2020-06-14 19:42 ` [Cocci] " Denis Efremov 2020-06-14 20:01 ` Joe Perches 2020-06-14 20:01 ` [Cocci] " Joe Perches 2020-06-15 12:03 ` Dan Carpenter 2020-06-15 12:03 ` [Cocci] " Dan Carpenter 2020-06-15 13:51 ` Denis Efremov 2020-06-15 13:51 ` [Cocci] " Denis Efremov 2020-06-04 20:48 ` [PATCH v2] " Denis Efremov 2020-06-04 20:48 ` [Cocci] " Denis Efremov 2020-06-04 20:57 ` Julia Lawall 2020-06-04 20:57 ` Julia Lawall 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-06 8:16 ` Julia Lawall 2020-06-06 8:16 ` Julia Lawall 2020-06-14 21:54 ` [PATCH v3] " Denis Efremov 2020-06-14 21:54 ` [Cocci] " Denis Efremov 2020-06-17 20:42 ` Julia Lawall 2020-06-17 20:42 ` Julia Lawall 2020-06-17 21:42 ` Denis Efremov [this message] 2020-06-17 21:42 ` Denis Efremov 2020-07-07 21:35 ` Julia Lawall 2020-07-07 21:35 ` Julia Lawall 2020-07-17 11:57 ` [PATCH v4] " Denis Efremov 2020-07-17 11:57 ` [Cocci] " Denis Efremov 2020-07-17 20:39 ` Julia Lawall 2020-07-17 20:39 ` [Cocci] " Julia Lawall 2020-08-10 23:45 ` Eric Biggers 2020-08-10 23:45 ` [Cocci] " Eric Biggers 2020-08-11 7:12 ` Denis Efremov 2020-08-11 7:12 ` [Cocci] " Denis Efremov 2020-08-11 7:49 ` [PATCH] coccinelle: api: update kzfree script to kfree_sensitive Denis Efremov 2020-08-11 7:49 ` [Cocci] " Denis Efremov 2020-08-26 8:12 ` Denis Efremov 2020-08-26 8:12 ` [Cocci] " Denis Efremov 2020-09-12 15:08 ` Julia Lawall 2020-09-12 15:08 ` [Cocci] " Julia Lawall 2020-06-15 13:26 [Cocci] [PATCH v3] coccinelle: api: add kzfree script Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=aa7613e9-8152-0022-6d67-0706ce5983d0@linux.com \ --to=efremov@linux.com \ --cc=cocci@systeme.lip6.fr \ --cc=julia.lawall@inria.fr \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.