From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: Joe Perches <joe@perches.com>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v2] coccinelle: api: add kzfree script Date: Thu, 4 Jun 2020 22:57:18 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.21.2006042254240.2577@hadrien> (raw) In-Reply-To: <20200604204846.15897-1-efremov@linux.com> On Thu, 4 Jun 2020, Denis Efremov wrote: > Check for memset()/memset_explicit() with 0 followed by > kfree()/vfree()/kvfree(). > > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > Changes in v2: > - memset_explicit() added > - kvfree_sensitive() added > - forall added to r1 > - ... between memset and kfree added > Unfortunately, it doesn't work as I would expect it to in "patch" > mode. I've added my comment about it in the rule. It can be safely > removed from the patch if I misunderstood something. > > Another "strange" behaviour that I faced that r2 rule works only if I > write 2 expression lines: > expression *E; > expression size; > If I try to use a single line "expression *E, size;" then r2 matches nothing. The parser for metavariables is not so smart. Everything to the left of the first metavariable name is the type. Everything after is the list of metavariables of that type. So if you put them together you require size to be a pointer. On the other hand, do you really require E to be a pointer? If you do that, it will have to find the type of E. If E refers to a structure field, then the type might not be available in the current function, and you may need command line argments like --all-includes or --recursive-includes. Is avoiding transforming the case where E is not verified to be a pointer a concern? julia > > scripts/coccinelle/api/kzfree.cocci | 65 +++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 scripts/coccinelle/api/kzfree.cocci > > diff --git a/scripts/coccinelle/api/kzfree.cocci b/scripts/coccinelle/api/kzfree.cocci > new file mode 100644 > index 000000000000..5c7e4bb13bb7 > --- /dev/null > +++ b/scripts/coccinelle/api/kzfree.cocci > @@ -0,0 +1,65 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Use kzfree, kvfree_sensitive rather than memset or > +/// memset_explicit with 0 followed by kfree > +/// > +// Confidence: High > +// Copyright: (C) 2020 Denis Efremov ISPRAS > +// Options: --no-includes --include-headers > +// > +// Keywords: kzfree, kvfree_sensitive > +// > + > +virtual context > +virtual patch > +virtual org > +virtual report > + > + > +// Ignore kzfree definition > +// Ignore kasan test > +@r depends on !patch && !(file in "lib/test_kasan.c") && !(file in "mm/slab_common.c") forall@ > +expression *E; > +position p; > +@@ > + > +* \(memset\|memset_explicit\)(E, 0, ...); > + ... when != E > + when strict > +* \(kfree\|vfree\|kvfree\)(E)@p; > + > +@r1 depends on patch && !(file in "lib/test_kasan.c") && !(file in "mm/slab_common.c")@ > +expression *E; > +expression size; > +@@ > + > +- \(memset\|memset_explicit\)(E, 0, size); > +/// Unfortunately, it doesn't work as in !patch mode. > +/// spatch (v1.0.8) should patch 4 functions in linux 5.7 with this rule > +/// and uncommented "when" lines. With only "... when != E" line 2 functions > +/// are patched, none with "when strict". 3 functions patch is produced by the > +/// rule with "when" lines commented out. > +// ... when != E > +// when strict > +( > +- kfree(E); > ++ kzfree(E); > +| > +- vfree(E); > ++ kvfree_sensitive(E, size); > +| > +- kvfree(E); > ++ kvfree_sensitive(E, size); > +) > + > +@script:python depends on report@ > +p << r.p; > +@@ > + > +coccilib.report.print_report(p[0], "WARNING opportunity for kzfree/kvfree_sensitive") > + > +@script:python depends on org@ > +p << r.p; > +@@ > + > +coccilib.org.print_todo(p[0], "WARNING opportunity for kzfree/kvfree_sensitive") > -- > 2.26.2 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: Joe Perches <joe@perches.com>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v2] coccinelle: api: add kzfree script Date: Thu, 4 Jun 2020 22:57:18 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.21.2006042254240.2577@hadrien> (raw) In-Reply-To: <20200604204846.15897-1-efremov@linux.com> On Thu, 4 Jun 2020, Denis Efremov wrote: > Check for memset()/memset_explicit() with 0 followed by > kfree()/vfree()/kvfree(). > > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > Changes in v2: > - memset_explicit() added > - kvfree_sensitive() added > - forall added to r1 > - ... between memset and kfree added > Unfortunately, it doesn't work as I would expect it to in "patch" > mode. I've added my comment about it in the rule. It can be safely > removed from the patch if I misunderstood something. > > Another "strange" behaviour that I faced that r2 rule works only if I > write 2 expression lines: > expression *E; > expression size; > If I try to use a single line "expression *E, size;" then r2 matches nothing. The parser for metavariables is not so smart. Everything to the left of the first metavariable name is the type. Everything after is the list of metavariables of that type. So if you put them together you require size to be a pointer. On the other hand, do you really require E to be a pointer? If you do that, it will have to find the type of E. If E refers to a structure field, then the type might not be available in the current function, and you may need command line argments like --all-includes or --recursive-includes. Is avoiding transforming the case where E is not verified to be a pointer a concern? julia > > scripts/coccinelle/api/kzfree.cocci | 65 +++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 scripts/coccinelle/api/kzfree.cocci > > diff --git a/scripts/coccinelle/api/kzfree.cocci b/scripts/coccinelle/api/kzfree.cocci > new file mode 100644 > index 000000000000..5c7e4bb13bb7 > --- /dev/null > +++ b/scripts/coccinelle/api/kzfree.cocci > @@ -0,0 +1,65 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Use kzfree, kvfree_sensitive rather than memset or > +/// memset_explicit with 0 followed by kfree > +/// > +// Confidence: High > +// Copyright: (C) 2020 Denis Efremov ISPRAS > +// Options: --no-includes --include-headers > +// > +// Keywords: kzfree, kvfree_sensitive > +// > + > +virtual context > +virtual patch > +virtual org > +virtual report > + > + > +// Ignore kzfree definition > +// Ignore kasan test > +@r depends on !patch && !(file in "lib/test_kasan.c") && !(file in "mm/slab_common.c") forall@ > +expression *E; > +position p; > +@@ > + > +* \(memset\|memset_explicit\)(E, 0, ...); > + ... when != E > + when strict > +* \(kfree\|vfree\|kvfree\)(E)@p; > + > +@r1 depends on patch && !(file in "lib/test_kasan.c") && !(file in "mm/slab_common.c")@ > +expression *E; > +expression size; > +@@ > + > +- \(memset\|memset_explicit\)(E, 0, size); > +/// Unfortunately, it doesn't work as in !patch mode. > +/// spatch (v1.0.8) should patch 4 functions in linux 5.7 with this rule > +/// and uncommented "when" lines. With only "... when != E" line 2 functions > +/// are patched, none with "when strict". 3 functions patch is produced by the > +/// rule with "when" lines commented out. > +// ... when != E > +// when strict > +( > +- kfree(E); > ++ kzfree(E); > +| > +- vfree(E); > ++ kvfree_sensitive(E, size); > +| > +- kvfree(E); > ++ kvfree_sensitive(E, size); > +) > + > +@script:python depends on report@ > +p << r.p; > +@@ > + > +coccilib.report.print_report(p[0], "WARNING opportunity for kzfree/kvfree_sensitive") > + > +@script:python depends on org@ > +p << r.p; > +@@ > + > +coccilib.org.print_todo(p[0], "WARNING opportunity for kzfree/kvfree_sensitive") > -- > 2.26.2 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-06-04 20:58 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 14:08 [PATCH] coccinelle: api: add kzfree script Denis Efremov 2020-06-04 14:08 ` [Cocci] " Denis Efremov 2020-06-04 14:15 ` Julia Lawall 2020-06-04 14:15 ` [Cocci] " Julia Lawall 2020-06-04 15:39 ` Denis Efremov 2020-06-04 15:39 ` [Cocci] " Denis Efremov 2020-06-04 15:51 ` Julia Lawall 2020-06-04 15:51 ` [Cocci] " Julia Lawall 2020-06-04 17:22 ` Denis Efremov 2020-06-04 17:22 ` [Cocci] " Denis Efremov 2020-06-04 17:28 ` Julia Lawall 2020-06-04 17:28 ` [Cocci] " Julia Lawall 2020-06-04 16:27 ` Joe Perches 2020-06-04 16:27 ` [Cocci] " Joe Perches 2020-06-04 17:30 ` Denis Efremov 2020-06-04 17:30 ` [Cocci] " Denis Efremov 2020-06-04 17:36 ` Joe Perches 2020-06-04 17:36 ` [Cocci] " Joe Perches 2020-06-14 19:42 ` Denis Efremov 2020-06-14 19:42 ` [Cocci] " Denis Efremov 2020-06-14 20:01 ` Joe Perches 2020-06-14 20:01 ` [Cocci] " Joe Perches 2020-06-15 12:03 ` Dan Carpenter 2020-06-15 12:03 ` [Cocci] " Dan Carpenter 2020-06-15 13:51 ` Denis Efremov 2020-06-15 13:51 ` [Cocci] " Denis Efremov 2020-06-04 20:48 ` [PATCH v2] " Denis Efremov 2020-06-04 20:48 ` [Cocci] " Denis Efremov 2020-06-04 20:57 ` Julia Lawall [this message] 2020-06-04 20:57 ` Julia Lawall 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-06 8:16 ` Julia Lawall 2020-06-06 8:16 ` Julia Lawall 2020-06-14 21:54 ` [PATCH v3] " Denis Efremov 2020-06-14 21:54 ` [Cocci] " Denis Efremov 2020-06-17 20:42 ` Julia Lawall 2020-06-17 20:42 ` Julia Lawall 2020-06-17 21:42 ` Denis Efremov 2020-06-17 21:42 ` Denis Efremov 2020-07-07 21:35 ` Julia Lawall 2020-07-07 21:35 ` Julia Lawall 2020-07-17 11:57 ` [PATCH v4] " Denis Efremov 2020-07-17 11:57 ` [Cocci] " Denis Efremov 2020-07-17 20:39 ` Julia Lawall 2020-07-17 20:39 ` [Cocci] " Julia Lawall 2020-08-10 23:45 ` Eric Biggers 2020-08-10 23:45 ` [Cocci] " Eric Biggers 2020-08-11 7:12 ` Denis Efremov 2020-08-11 7:12 ` [Cocci] " Denis Efremov 2020-08-11 7:49 ` [PATCH] coccinelle: api: update kzfree script to kfree_sensitive Denis Efremov 2020-08-11 7:49 ` [Cocci] " Denis Efremov 2020-08-26 8:12 ` Denis Efremov 2020-08-26 8:12 ` [Cocci] " Denis Efremov 2020-09-12 15:08 ` Julia Lawall 2020-09-12 15:08 ` [Cocci] " Julia Lawall 2020-06-05 5:50 [Cocci] [PATCH v2] coccinelle: api: add kzfree script Markus Elfring 2020-06-05 6:43 Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2006042254240.2577@hadrien \ --to=julia.lawall@inria.fr \ --cc=cocci@systeme.lip6.fr \ --cc=efremov@linux.com \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.