From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: Julia Lawall <julia.lawall@inria.fr>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>, alex.dewar90@gmail.com, alexandre.belloni@bootlin.com, corbet@lwn.net, mchehab+huawei@kernel.org Subject: Re: [PATCH] coccinelle: api: update kzfree script to kfree_sensitive Date: Sat, 12 Sep 2020 17:08:19 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.22.394.2009121707040.2362@hadrien> (raw) In-Reply-To: <20200811074953.73994-1-efremov@linux.com> On Tue, 11 Aug 2020, Denis Efremov wrote: > Commit 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") > renames kzfree to kfree_sensitive and uses memzero_explicit(...) instead of > memset(..., 0, ...) internally. Update cocci script to reflect these > changes. > > Signed-off-by: Denis Efremov <efremov@linux.com> Applied, thanks. > --- > Julia, I think you can squash this commit with original script, or I can > resend the whole script since it's not merged to the mainline. > > .../{kzfree.cocci => kfree_sensitive.cocci} | 29 +++++++++---------- > 1 file changed, 13 insertions(+), 16 deletions(-) > rename scripts/coccinelle/api/{kzfree.cocci => kfree_sensitive.cocci} (70%) > > diff --git a/scripts/coccinelle/api/kzfree.cocci b/scripts/coccinelle/api/kfree_sensitive.cocci > similarity index 70% > rename from scripts/coccinelle/api/kzfree.cocci > rename to scripts/coccinelle/api/kfree_sensitive.cocci > index 33625bd7cec9..e4a066a0b77d 100644 > --- a/scripts/coccinelle/api/kzfree.cocci > +++ b/scripts/coccinelle/api/kfree_sensitive.cocci > @@ -1,13 +1,13 @@ > // SPDX-License-Identifier: GPL-2.0-only > /// > -/// Use kzfree, kvfree_sensitive rather than memset or > -/// memzero_explicit followed by kfree > +/// Use kfree_sensitive, kvfree_sensitive rather than memset or > +/// memzero_explicit followed by kfree. > /// > // Confidence: High > // Copyright: (C) 2020 Denis Efremov ISPRAS > // Options: --no-includes --include-headers > // > -// Keywords: kzfree, kvfree_sensitive > +// Keywords: kfree_sensitive, kvfree_sensitive > // > > virtual context > @@ -18,7 +18,8 @@ virtual report > @initialize:python@ > @@ > # kmalloc_oob_in_memset uses memset to explicitly trigger out-of-bounds access > -filter = frozenset(['kmalloc_oob_in_memset', 'kzfree', 'kvfree_sensitive']) > +filter = frozenset(['kmalloc_oob_in_memset', > + 'kfree_sensitive', 'kvfree_sensitive']) > > def relevant(p): > return not (filter & {el.current_element for el in p}) > @@ -56,17 +57,13 @@ type T; > - memzero_explicit@m((T)E, size); > ... when != E > when strict > -// TODO: uncomment when kfree_sensitive will be merged. > -// Only this case is commented out because developers > -// may not like patches like this since kzfree uses memset > -// internally (not memzero_explicit). > -//( > -//- kfree(E)@p; > -//+ kfree_sensitive(E); > -//| > +( > +- kfree(E)@p; > ++ kfree_sensitive(E); > +| > - \(vfree\|kvfree\)(E)@p; > + kvfree_sensitive(E, size); > -//) > +) > > @rp_memset depends on patch@ > expression E, size; > @@ -80,7 +77,7 @@ type T; > when strict > ( > - kfree(E)@p; > -+ kzfree(E); > ++ kfree_sensitive(E); > | > - \(vfree\|kvfree\)(E)@p; > + kvfree_sensitive(E, size); > @@ -91,11 +88,11 @@ p << r.p; > @@ > > coccilib.report.print_report(p[0], > - "WARNING: opportunity for kzfree/kvfree_sensitive") > + "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > > @script:python depends on org@ > p << r.p; > @@ > > coccilib.org.print_todo(p[0], > - "WARNING: opportunity for kzfree/kvfree_sensitive") > + "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > -- > 2.26.2 > >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: Eric Biggers <ebiggers@kernel.org>, alexandre.belloni@bootlin.com, corbet@lwn.net, mchehab+huawei@kernel.org, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr, alex.dewar90@gmail.com Subject: Re: [Cocci] [PATCH] coccinelle: api: update kzfree script to kfree_sensitive Date: Sat, 12 Sep 2020 17:08:19 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.22.394.2009121707040.2362@hadrien> (raw) In-Reply-To: <20200811074953.73994-1-efremov@linux.com> On Tue, 11 Aug 2020, Denis Efremov wrote: > Commit 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") > renames kzfree to kfree_sensitive and uses memzero_explicit(...) instead of > memset(..., 0, ...) internally. Update cocci script to reflect these > changes. > > Signed-off-by: Denis Efremov <efremov@linux.com> Applied, thanks. > --- > Julia, I think you can squash this commit with original script, or I can > resend the whole script since it's not merged to the mainline. > > .../{kzfree.cocci => kfree_sensitive.cocci} | 29 +++++++++---------- > 1 file changed, 13 insertions(+), 16 deletions(-) > rename scripts/coccinelle/api/{kzfree.cocci => kfree_sensitive.cocci} (70%) > > diff --git a/scripts/coccinelle/api/kzfree.cocci b/scripts/coccinelle/api/kfree_sensitive.cocci > similarity index 70% > rename from scripts/coccinelle/api/kzfree.cocci > rename to scripts/coccinelle/api/kfree_sensitive.cocci > index 33625bd7cec9..e4a066a0b77d 100644 > --- a/scripts/coccinelle/api/kzfree.cocci > +++ b/scripts/coccinelle/api/kfree_sensitive.cocci > @@ -1,13 +1,13 @@ > // SPDX-License-Identifier: GPL-2.0-only > /// > -/// Use kzfree, kvfree_sensitive rather than memset or > -/// memzero_explicit followed by kfree > +/// Use kfree_sensitive, kvfree_sensitive rather than memset or > +/// memzero_explicit followed by kfree. > /// > // Confidence: High > // Copyright: (C) 2020 Denis Efremov ISPRAS > // Options: --no-includes --include-headers > // > -// Keywords: kzfree, kvfree_sensitive > +// Keywords: kfree_sensitive, kvfree_sensitive > // > > virtual context > @@ -18,7 +18,8 @@ virtual report > @initialize:python@ > @@ > # kmalloc_oob_in_memset uses memset to explicitly trigger out-of-bounds access > -filter = frozenset(['kmalloc_oob_in_memset', 'kzfree', 'kvfree_sensitive']) > +filter = frozenset(['kmalloc_oob_in_memset', > + 'kfree_sensitive', 'kvfree_sensitive']) > > def relevant(p): > return not (filter & {el.current_element for el in p}) > @@ -56,17 +57,13 @@ type T; > - memzero_explicit@m((T)E, size); > ... when != E > when strict > -// TODO: uncomment when kfree_sensitive will be merged. > -// Only this case is commented out because developers > -// may not like patches like this since kzfree uses memset > -// internally (not memzero_explicit). > -//( > -//- kfree(E)@p; > -//+ kfree_sensitive(E); > -//| > +( > +- kfree(E)@p; > ++ kfree_sensitive(E); > +| > - \(vfree\|kvfree\)(E)@p; > + kvfree_sensitive(E, size); > -//) > +) > > @rp_memset depends on patch@ > expression E, size; > @@ -80,7 +77,7 @@ type T; > when strict > ( > - kfree(E)@p; > -+ kzfree(E); > ++ kfree_sensitive(E); > | > - \(vfree\|kvfree\)(E)@p; > + kvfree_sensitive(E, size); > @@ -91,11 +88,11 @@ p << r.p; > @@ > > coccilib.report.print_report(p[0], > - "WARNING: opportunity for kzfree/kvfree_sensitive") > + "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > > @script:python depends on org@ > p << r.p; > @@ > > coccilib.org.print_todo(p[0], > - "WARNING: opportunity for kzfree/kvfree_sensitive") > + "WARNING: opportunity for kfree_sensitive/kvfree_sensitive") > -- > 2.26.2 > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-09-12 15:08 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 14:08 [PATCH] coccinelle: api: add kzfree script Denis Efremov 2020-06-04 14:08 ` [Cocci] " Denis Efremov 2020-06-04 14:15 ` Julia Lawall 2020-06-04 14:15 ` [Cocci] " Julia Lawall 2020-06-04 15:39 ` Denis Efremov 2020-06-04 15:39 ` [Cocci] " Denis Efremov 2020-06-04 15:51 ` Julia Lawall 2020-06-04 15:51 ` [Cocci] " Julia Lawall 2020-06-04 17:22 ` Denis Efremov 2020-06-04 17:22 ` [Cocci] " Denis Efremov 2020-06-04 17:28 ` Julia Lawall 2020-06-04 17:28 ` [Cocci] " Julia Lawall 2020-06-04 16:27 ` Joe Perches 2020-06-04 16:27 ` [Cocci] " Joe Perches 2020-06-04 17:30 ` Denis Efremov 2020-06-04 17:30 ` [Cocci] " Denis Efremov 2020-06-04 17:36 ` Joe Perches 2020-06-04 17:36 ` [Cocci] " Joe Perches 2020-06-14 19:42 ` Denis Efremov 2020-06-14 19:42 ` [Cocci] " Denis Efremov 2020-06-14 20:01 ` Joe Perches 2020-06-14 20:01 ` [Cocci] " Joe Perches 2020-06-15 12:03 ` Dan Carpenter 2020-06-15 12:03 ` [Cocci] " Dan Carpenter 2020-06-15 13:51 ` Denis Efremov 2020-06-15 13:51 ` [Cocci] " Denis Efremov 2020-06-04 20:48 ` [PATCH v2] " Denis Efremov 2020-06-04 20:48 ` [Cocci] " Denis Efremov 2020-06-04 20:57 ` Julia Lawall 2020-06-04 20:57 ` Julia Lawall 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:03 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-04 21:25 ` Denis Efremov 2020-06-06 8:16 ` Julia Lawall 2020-06-06 8:16 ` Julia Lawall 2020-06-14 21:54 ` [PATCH v3] " Denis Efremov 2020-06-14 21:54 ` [Cocci] " Denis Efremov 2020-06-17 20:42 ` Julia Lawall 2020-06-17 20:42 ` Julia Lawall 2020-06-17 21:42 ` Denis Efremov 2020-06-17 21:42 ` Denis Efremov 2020-07-07 21:35 ` Julia Lawall 2020-07-07 21:35 ` Julia Lawall 2020-07-17 11:57 ` [PATCH v4] " Denis Efremov 2020-07-17 11:57 ` [Cocci] " Denis Efremov 2020-07-17 20:39 ` Julia Lawall 2020-07-17 20:39 ` [Cocci] " Julia Lawall 2020-08-10 23:45 ` Eric Biggers 2020-08-10 23:45 ` [Cocci] " Eric Biggers 2020-08-11 7:12 ` Denis Efremov 2020-08-11 7:12 ` [Cocci] " Denis Efremov 2020-08-11 7:49 ` [PATCH] coccinelle: api: update kzfree script to kfree_sensitive Denis Efremov 2020-08-11 7:49 ` [Cocci] " Denis Efremov 2020-08-26 8:12 ` Denis Efremov 2020-08-26 8:12 ` [Cocci] " Denis Efremov 2020-09-12 15:08 ` Julia Lawall [this message] 2020-09-12 15:08 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.22.394.2009121707040.2362@hadrien \ --to=julia.lawall@inria.fr \ --cc=alex.dewar90@gmail.com \ --cc=alexandre.belloni@bootlin.com \ --cc=cocci@systeme.lip6.fr \ --cc=corbet@lwn.net \ --cc=ebiggers@kernel.org \ --cc=efremov@linux.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab+huawei@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.