From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
aik@ozlabs.ru, robh@kernel.org, joe@perches.com,
elfring@users.sourceforge.net, david@gibson.dropbear.id.au,
jasowang@redhat.com, mpe@ellerman.id.au
Subject: Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices
Date: Mon, 04 Jun 2018 23:14:36 +1000 [thread overview]
Message-ID: <acdfef1327f73f6ac67645d9f1a8e9204a0f22fb.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180604125530.GA16378@infradead.org>
On Mon, 2018-06-04 at 05:55 -0700, Christoph Hellwig wrote:
> On Mon, Jun 04, 2018 at 03:43:09PM +0300, Michael S. Tsirkin wrote:
> > Another is that given the basic functionality is in there, optimizations
> > can possibly wait until per-device quirks in DMA API are supported.
>
> We have had per-device dma_ops for quite a while.
I've asked Ansuman to start with a patch that converts virtio to use
DMA ops always, along with an init quirk to hookup "direct" ops when
the IOMMU flag isn't set.
This will at least remove that horrid duplication of code path we have
in there.
Then we can just involve the arch in that init quirk so we can chose an
alternate set of ops when running a secure VM.
This is completely orthogonal to whether an iommu exist qemu side or
not, and should be entirely solved on the Linux side.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: robh@kernel.org, mpe@ellerman.id.au,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, joe@perches.com,
david@gibson.dropbear.id.au, linuxppc-dev@lists.ozlabs.org,
elfring@users.sourceforge.net,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices
Date: Mon, 04 Jun 2018 23:14:36 +1000 [thread overview]
Message-ID: <acdfef1327f73f6ac67645d9f1a8e9204a0f22fb.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180604125530.GA16378@infradead.org>
On Mon, 2018-06-04 at 05:55 -0700, Christoph Hellwig wrote:
> On Mon, Jun 04, 2018 at 03:43:09PM +0300, Michael S. Tsirkin wrote:
> > Another is that given the basic functionality is in there, optimizations
> > can possibly wait until per-device quirks in DMA API are supported.
>
> We have had per-device dma_ops for quite a while.
I've asked Ansuman to start with a patch that converts virtio to use
DMA ops always, along with an init quirk to hookup "direct" ops when
the IOMMU flag isn't set.
This will at least remove that horrid duplication of code path we have
in there.
Then we can just involve the arch in that init quirk so we can chose an
alternate set of ops when running a secure VM.
This is completely orthogonal to whether an iommu exist qemu side or
not, and should be entirely solved on the Linux side.
Cheers,
Ben.
next prev parent reply other threads:[~2018-06-04 14:33 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 6:33 [RFC V2] virtio: Add platform specific DMA API translation for virito devices Anshuman Khandual
2018-05-23 18:50 ` Michael S. Tsirkin
2018-05-23 18:50 ` Michael S. Tsirkin
2018-05-23 22:27 ` Benjamin Herrenschmidt
2018-05-23 22:27 ` Benjamin Herrenschmidt
2018-05-24 7:17 ` Christoph Hellwig
2018-05-24 7:17 ` Christoph Hellwig
2018-05-25 17:45 ` Michael S. Tsirkin
2018-05-28 23:48 ` Benjamin Herrenschmidt
2018-05-28 23:48 ` Benjamin Herrenschmidt
2018-05-28 23:56 ` Benjamin Herrenschmidt
2018-05-28 23:56 ` Benjamin Herrenschmidt
2018-05-29 14:03 ` Christoph Hellwig
2018-05-29 14:03 ` Christoph Hellwig
2018-05-29 22:13 ` Benjamin Herrenschmidt
2018-05-29 22:13 ` Benjamin Herrenschmidt
2018-05-25 17:45 ` Michael S. Tsirkin
2018-06-04 8:57 ` David Gibson
2018-06-04 8:57 ` David Gibson
2018-06-04 9:48 ` Benjamin Herrenschmidt
2018-06-04 9:48 ` Benjamin Herrenschmidt
2018-06-04 12:50 ` Michael S. Tsirkin
2018-06-04 12:50 ` Michael S. Tsirkin
2018-06-05 1:52 ` David Gibson
2018-06-05 1:52 ` David Gibson
2018-06-04 12:43 ` Michael S. Tsirkin
2018-06-04 12:55 ` Christoph Hellwig
2018-06-04 13:14 ` Benjamin Herrenschmidt [this message]
2018-06-04 13:14 ` Benjamin Herrenschmidt
2018-06-04 16:34 ` Michael S. Tsirkin
2018-06-04 16:34 ` Michael S. Tsirkin
2018-06-04 12:55 ` Christoph Hellwig
2018-06-04 13:11 ` Benjamin Herrenschmidt
2018-06-04 13:11 ` Benjamin Herrenschmidt
2018-06-04 16:21 ` Michael S. Tsirkin
2018-06-04 23:26 ` Benjamin Herrenschmidt
2018-06-04 23:26 ` Benjamin Herrenschmidt
2018-06-05 1:25 ` Michael S. Tsirkin
2018-06-05 1:25 ` Michael S. Tsirkin
2018-06-05 4:52 ` Christoph Hellwig
2018-06-05 4:52 ` Christoph Hellwig
2018-06-04 16:21 ` Michael S. Tsirkin
2018-06-04 12:43 ` Michael S. Tsirkin
2018-05-24 7:21 ` Ram Pai
2018-05-31 3:39 ` Anshuman Khandual
2018-05-31 17:43 ` Michael S. Tsirkin
2018-05-31 17:43 ` Michael S. Tsirkin
2018-06-07 5:23 ` Christoph Hellwig
2018-06-07 16:28 ` Michael S. Tsirkin
2018-06-08 6:36 ` Christoph Hellwig
2018-06-08 6:36 ` Christoph Hellwig
2018-06-13 13:49 ` Michael S. Tsirkin
2018-06-13 13:49 ` Michael S. Tsirkin
2018-06-11 2:39 ` Ram Pai
2018-06-11 3:28 ` Michael S. Tsirkin
2018-06-11 3:28 ` Michael S. Tsirkin
2018-06-11 3:34 ` Benjamin Herrenschmidt
2018-06-11 3:34 ` Benjamin Herrenschmidt
2018-06-13 14:23 ` Michael S. Tsirkin
2018-06-13 14:23 ` Michael S. Tsirkin
2018-06-11 3:29 ` Benjamin Herrenschmidt
2018-06-11 3:29 ` Benjamin Herrenschmidt
2018-06-13 7:41 ` Christoph Hellwig
2018-06-13 7:41 ` Christoph Hellwig
2018-06-13 12:25 ` Benjamin Herrenschmidt
2018-06-13 12:25 ` Benjamin Herrenschmidt
2018-06-13 13:11 ` Benjamin Herrenschmidt
2018-06-13 13:11 ` Benjamin Herrenschmidt
2018-06-15 9:16 ` Christoph Hellwig
2018-06-15 9:16 ` Christoph Hellwig
2018-06-16 1:07 ` Benjamin Herrenschmidt
2018-06-16 1:07 ` Benjamin Herrenschmidt
2018-06-13 13:59 ` Michael S. Tsirkin
2018-06-13 13:59 ` Michael S. Tsirkin
2018-06-13 14:03 ` Michael S. Tsirkin
2018-06-13 14:03 ` Michael S. Tsirkin
2018-06-07 16:28 ` Michael S. Tsirkin
2018-06-07 5:23 ` Christoph Hellwig
2018-05-31 3:39 ` Anshuman Khandual
-- strict thread matches above, loose matches on Subject: below --
2018-05-22 6:33 Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdfef1327f73f6ac67645d9f1a8e9204a0f22fb.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=elfring@users.sourceforge.net \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=robh@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.