From: Christian Schoenebeck <qemu_oss@crudebyte.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Greg Kurz <groug@kaod.org>, Raphael Norwitz <raphael.norwitz@nutanix.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Amit Shah <amit@kernel.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Jason Wang <jasowang@redhat.com>, Fam Zheng <fam@euphon.net>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, David Hildenbrand <david@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Eric Auger <eric.auger@redhat.com>, qemu-block@nongnu.org, virtio-fs@redhat.com Subject: [PATCH v2 3/3] virtio-9p-device: switch to 32k max. transfer size Date: Mon, 4 Oct 2021 21:38:12 +0200 [thread overview] Message-ID: <ae0464f653ef20292e335ba3de0d62ab3ce8c72c.1633376313.git.qemu_oss@crudebyte.com> (raw) In-Reply-To: <cover.1633376313.git.qemu_oss@crudebyte.com> 9pfs supports the new maximum virtio queue size of 32k, so let's switch the 9pfs virtio transport from 1k to 32k. This will allow a maximum 'msize' option (maximum message size) by 9p client of approximately 128M (assuming 4k page size, in practice slightly smaller, e.g. with Linux client minus 2 pages). Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com> --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 9013e7df6e..cd5d95dd51 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -217,7 +217,7 @@ static void virtio_9p_device_realize(DeviceState *dev, Error **errp) v->config_size = sizeof(struct virtio_9p_config) + strlen(s->fsconf.tag); virtio_init(vdev, "virtio-9p", VIRTIO_ID_9P, v->config_size, - VIRTQUEUE_LEGACY_MAX_SIZE); + VIRTQUEUE_MAX_SIZE); v->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output); } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Christian Schoenebeck <qemu_oss@crudebyte.com> To: qemu-devel@nongnu.org Cc: "Kevin Wolf" <kwolf@redhat.com>, "Laurent Vivier" <lvivier@redhat.com>, qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Amit Shah" <amit@kernel.org>, "David Hildenbrand" <david@redhat.com>, "Raphael Norwitz" <raphael.norwitz@nutanix.com>, virtio-fs@redhat.com, "Eric Auger" <eric.auger@redhat.com>, "Hanna Reitz" <hreitz@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Fam Zheng" <fam@euphon.net> Subject: [Virtio-fs] [PATCH v2 3/3] virtio-9p-device: switch to 32k max. transfer size Date: Mon, 4 Oct 2021 21:38:12 +0200 [thread overview] Message-ID: <ae0464f653ef20292e335ba3de0d62ab3ce8c72c.1633376313.git.qemu_oss@crudebyte.com> (raw) In-Reply-To: <cover.1633376313.git.qemu_oss@crudebyte.com> 9pfs supports the new maximum virtio queue size of 32k, so let's switch the 9pfs virtio transport from 1k to 32k. This will allow a maximum 'msize' option (maximum message size) by 9p client of approximately 128M (assuming 4k page size, in practice slightly smaller, e.g. with Linux client minus 2 pages). Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com> --- hw/9pfs/virtio-9p-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 9013e7df6e..cd5d95dd51 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -217,7 +217,7 @@ static void virtio_9p_device_realize(DeviceState *dev, Error **errp) v->config_size = sizeof(struct virtio_9p_config) + strlen(s->fsconf.tag); virtio_init(vdev, "virtio-9p", VIRTIO_ID_9P, v->config_size, - VIRTQUEUE_LEGACY_MAX_SIZE); + VIRTQUEUE_MAX_SIZE); v->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output); } -- 2.20.1
next prev parent reply other threads:[~2021-10-04 20:10 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-04 19:38 [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k Christian Schoenebeck 2021-10-04 19:38 ` [Virtio-fs] " Christian Schoenebeck 2021-10-04 19:38 ` [PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable Christian Schoenebeck 2021-10-04 19:38 ` [Virtio-fs] " Christian Schoenebeck 2021-10-05 7:36 ` Greg Kurz 2021-10-05 7:36 ` [Virtio-fs] " Greg Kurz 2021-10-05 12:45 ` Stefan Hajnoczi 2021-10-05 12:45 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-05 13:15 ` Christian Schoenebeck 2021-10-05 13:15 ` [Virtio-fs] " Christian Schoenebeck 2021-10-05 15:10 ` Stefan Hajnoczi 2021-10-05 15:10 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-05 16:32 ` Christian Schoenebeck 2021-10-05 16:32 ` [Virtio-fs] " Christian Schoenebeck 2021-10-06 11:06 ` Stefan Hajnoczi 2021-10-06 11:06 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-06 12:50 ` Christian Schoenebeck 2021-10-06 12:50 ` [Virtio-fs] " Christian Schoenebeck 2021-10-06 14:42 ` Stefan Hajnoczi 2021-10-06 14:42 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-07 13:09 ` Christian Schoenebeck 2021-10-07 13:09 ` [Virtio-fs] " Christian Schoenebeck 2021-10-07 15:18 ` Stefan Hajnoczi 2021-10-07 15:18 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-08 14:48 ` Christian Schoenebeck 2021-10-08 14:48 ` [Virtio-fs] " Christian Schoenebeck 2021-10-04 19:38 ` [PATCH v2 2/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k Christian Schoenebeck 2021-10-04 19:38 ` [Virtio-fs] " Christian Schoenebeck 2021-10-05 7:16 ` Michael S. Tsirkin 2021-10-05 7:16 ` [Virtio-fs] " Michael S. Tsirkin 2021-10-05 7:35 ` Greg Kurz 2021-10-05 7:35 ` [Virtio-fs] " Greg Kurz 2021-10-05 11:17 ` Christian Schoenebeck 2021-10-05 11:17 ` [Virtio-fs] " Christian Schoenebeck 2021-10-05 11:24 ` Michael S. Tsirkin 2021-10-05 11:24 ` [Virtio-fs] " Michael S. Tsirkin 2021-10-05 12:01 ` Christian Schoenebeck 2021-10-05 12:01 ` [Virtio-fs] " Christian Schoenebeck 2021-10-04 19:38 ` Christian Schoenebeck [this message] 2021-10-04 19:38 ` [Virtio-fs] [PATCH v2 3/3] virtio-9p-device: switch to 32k max. transfer size Christian Schoenebeck 2021-10-05 7:38 ` [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k David Hildenbrand 2021-10-05 7:38 ` [Virtio-fs] " David Hildenbrand 2021-10-05 11:10 ` Christian Schoenebeck 2021-10-05 11:10 ` [Virtio-fs] " Christian Schoenebeck 2021-10-05 11:19 ` Michael S. Tsirkin 2021-10-05 11:19 ` [Virtio-fs] " Michael S. Tsirkin 2021-10-05 11:43 ` Christian Schoenebeck 2021-10-05 11:43 ` [Virtio-fs] " Christian Schoenebeck 2021-10-07 5:23 ` Stefan Hajnoczi 2021-10-07 5:23 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-07 12:51 ` Christian Schoenebeck 2021-10-07 12:51 ` [Virtio-fs] " Christian Schoenebeck 2021-10-07 15:42 ` Stefan Hajnoczi 2021-10-07 15:42 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-08 7:25 ` Greg Kurz 2021-10-08 7:25 ` [Virtio-fs] " Greg Kurz 2021-10-08 8:27 ` Greg Kurz 2021-10-08 14:24 ` Christian Schoenebeck 2021-10-08 14:24 ` [Virtio-fs] " Christian Schoenebeck 2021-10-08 16:08 ` Christian Schoenebeck 2021-10-08 16:08 ` [Virtio-fs] " Christian Schoenebeck 2021-10-21 15:39 ` Christian Schoenebeck 2021-10-21 15:39 ` [Virtio-fs] " Christian Schoenebeck 2021-10-25 10:30 ` Stefan Hajnoczi 2021-10-25 10:30 ` [Virtio-fs] " Stefan Hajnoczi 2021-10-25 15:03 ` Christian Schoenebeck 2021-10-25 15:03 ` [Virtio-fs] " Christian Schoenebeck 2021-10-28 9:00 ` Stefan Hajnoczi 2021-10-28 9:00 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-01 20:29 ` Christian Schoenebeck 2021-11-01 20:29 ` [Virtio-fs] " Christian Schoenebeck 2021-11-03 11:33 ` Stefan Hajnoczi 2021-11-03 11:33 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-04 14:41 ` Christian Schoenebeck 2021-11-04 14:41 ` [Virtio-fs] " Christian Schoenebeck 2021-11-09 10:56 ` Stefan Hajnoczi 2021-11-09 10:56 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-09 13:09 ` Christian Schoenebeck 2021-11-09 13:09 ` [Virtio-fs] " Christian Schoenebeck 2021-11-10 10:05 ` Stefan Hajnoczi 2021-11-10 10:05 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-10 13:14 ` Christian Schoenebeck 2021-11-10 13:14 ` [Virtio-fs] " Christian Schoenebeck 2021-11-10 15:14 ` Stefan Hajnoczi 2021-11-10 15:14 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-10 15:53 ` Christian Schoenebeck 2021-11-10 15:53 ` [Virtio-fs] " Christian Schoenebeck 2021-11-11 16:31 ` Stefan Hajnoczi 2021-11-11 16:31 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-11 17:54 ` Christian Schoenebeck 2021-11-11 17:54 ` [Virtio-fs] " Christian Schoenebeck 2021-11-15 11:54 ` Stefan Hajnoczi 2021-11-15 11:54 ` [Virtio-fs] " Stefan Hajnoczi 2021-11-15 14:32 ` Christian Schoenebeck 2021-11-15 14:32 ` [Virtio-fs] " Christian Schoenebeck 2021-11-16 11:13 ` Stefan Hajnoczi 2021-11-16 11:13 ` [Virtio-fs] " Stefan Hajnoczi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ae0464f653ef20292e335ba3de0d62ab3ce8c72c.1633376313.git.qemu_oss@crudebyte.com \ --to=qemu_oss@crudebyte.com \ --cc=amit@kernel.org \ --cc=arei.gonglei@huawei.com \ --cc=david@redhat.com \ --cc=dgilbert@redhat.com \ --cc=eric.auger@redhat.com \ --cc=fam@euphon.net \ --cc=groug@kaod.org \ --cc=hreitz@redhat.com \ --cc=jasowang@redhat.com \ --cc=kraxel@redhat.com \ --cc=kwolf@redhat.com \ --cc=lvivier@redhat.com \ --cc=marcandre.lureau@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=raphael.norwitz@nutanix.com \ --cc=stefanha@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.