All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <jweiner@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 3/4] mm: improve THP printk messages
Date: Tue, 21 Jun 2011 18:23:57 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1106211823310.5205@chino.kir.corp.google.com> (raw)
In-Reply-To: <1308643849-3325-3-git-send-email-amwang@redhat.com>

On Tue, 21 Jun 2011, Amerigo Wang wrote:

> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 126c96b..f9e720c 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -506,7 +506,7 @@ static int __init hugepage_init(void)
>  	if (no_hugepage_init) {
>  		err = 0;
>  		transparent_hugepage_flags = 0;
> -		printk(KERN_INFO "hugepage: totally disabled\n");
> +		printk(KERN_INFO "THP: totally disabled\n");
>  		goto out;
>  	}
>  
> @@ -514,19 +514,19 @@ static int __init hugepage_init(void)
>  	err = -ENOMEM;
>  	hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj);
>  	if (unlikely(!hugepage_kobj)) {
> -		printk(KERN_ERR "hugepage: failed kobject create\n");
> +		printk(KERN_ERR "THP: failed kobject create\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &hugepage_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &khugepaged_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  #endif

You're changing a printk() but not fixing the typos in it?

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <jweiner@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 3/4] mm: improve THP printk messages
Date: Tue, 21 Jun 2011 18:23:57 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1106211823310.5205@chino.kir.corp.google.com> (raw)
In-Reply-To: <1308643849-3325-3-git-send-email-amwang@redhat.com>

On Tue, 21 Jun 2011, Amerigo Wang wrote:

> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 126c96b..f9e720c 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -506,7 +506,7 @@ static int __init hugepage_init(void)
>  	if (no_hugepage_init) {
>  		err = 0;
>  		transparent_hugepage_flags = 0;
> -		printk(KERN_INFO "hugepage: totally disabled\n");
> +		printk(KERN_INFO "THP: totally disabled\n");
>  		goto out;
>  	}
>  
> @@ -514,19 +514,19 @@ static int __init hugepage_init(void)
>  	err = -ENOMEM;
>  	hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj);
>  	if (unlikely(!hugepage_kobj)) {
> -		printk(KERN_ERR "hugepage: failed kobject create\n");
> +		printk(KERN_ERR "THP: failed kobject create\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &hugepage_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &khugepaged_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  #endif

You're changing a printk() but not fixing the typos in it?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-22  1:24 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21  8:10 [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Amerigo Wang
2011-06-21  8:10 ` Amerigo Wang
2011-06-21  8:10 ` [PATCH v2 2/4] mm: make the threshold of enabling THP configurable Amerigo Wang
2011-06-21  8:10   ` Amerigo Wang
2011-06-21 14:44   ` Dave Hansen
2011-06-21 14:44     ` Dave Hansen
2011-06-21 20:17     ` Dave Hansen
2011-06-21 20:17       ` Dave Hansen
2011-06-22  1:23   ` David Rientjes
2011-06-22  1:23     ` David Rientjes
2011-06-22  3:06     ` Cong Wang
2011-06-22  3:06       ` Cong Wang
2011-06-22  3:29       ` David Rientjes
2011-06-22  3:29         ` David Rientjes
2011-06-22  5:40         ` Cong Wang
2011-06-22  5:40           ` Cong Wang
2011-06-22  6:32           ` David Rientjes
2011-06-22  6:32             ` David Rientjes
2011-06-22 11:07             ` Cong Wang
2011-06-22 11:07               ` Cong Wang
2011-06-22 14:40               ` Andrea Arcangeli
2011-06-22 14:40                 ` Andrea Arcangeli
2011-06-23  6:51                 ` Cong Wang
2011-06-23  6:51                   ` Cong Wang
2011-06-21  8:10 ` [PATCH 3/4] mm: improve THP printk messages Amerigo Wang
2011-06-21  8:10   ` Amerigo Wang
2011-06-22  1:23   ` David Rientjes [this message]
2011-06-22  1:23     ` David Rientjes
2011-06-22  3:04     ` Cong Wang
2011-06-22  3:04       ` Cong Wang
2011-06-21  8:10 ` [PATCH 4/4] mm: introduce no_ksm to disable totally KSM Amerigo Wang
2011-06-21  8:10   ` Amerigo Wang
2011-06-21 13:32   ` Andrea Arcangeli
2011-06-21 13:32     ` Andrea Arcangeli
2011-06-22  3:13     ` Cong Wang
2011-06-22  3:13       ` Cong Wang
2011-06-21 11:52 ` [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Michal Hocko
2011-06-21 11:52   ` Michal Hocko
2011-06-21 11:58   ` Michal Hocko
2011-06-21 11:58     ` Michal Hocko
2011-06-21 13:30 ` Andrea Arcangeli
2011-06-21 13:30   ` Andrea Arcangeli
2011-06-22  3:11   ` Cong Wang
2011-06-22  3:11     ` Cong Wang
2011-06-22  1:16 ` David Rientjes
2011-06-22  1:16   ` David Rientjes
2011-06-22  3:08   ` Cong Wang
2011-06-22  3:08     ` Cong Wang
2011-06-22  3:24     ` David Rientjes
2011-06-22  3:24       ` David Rientjes
2011-06-22  5:45       ` Cong Wang
2011-06-22  5:45         ` Cong Wang
2011-06-22  6:23         ` David Rientjes
2011-06-22  6:23           ` David Rientjes
2011-06-22 11:08           ` Cong Wang
2011-06-22 11:08             ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1106211823310.5205@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=jweiner@redhat.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.