From: David Rientjes <rientjes@google.com> To: Cong Wang <amwang@redhat.com> Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@xenotime.net>, Andrea Arcangeli <aarcange@redhat.com>, Rik van Riel <riel@redhat.com>, Johannes Weiner <jweiner@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Date: Tue, 21 Jun 2011 23:23:47 -0700 (PDT) [thread overview] Message-ID: <alpine.DEB.2.00.1106212322510.14693@chino.kir.corp.google.com> (raw) In-Reply-To: <4E01816A.3040309@redhat.com> On Wed, 22 Jun 2011, Cong Wang wrote: > > If you're proposing a patch for a specific purpose, it's appropriate to > > include that in the changelog. > > Sorry, I can't put everything you don't see into the changelog. > As far as changelogs go, yes, we can demand that. > > > > But now that I know what you're proposing this for, it's an easy NACK: > > transparent_hugepage=0 has no significant benefit over > > transparent_hugepage=never for kdump because the memory savings is > > negligible. > > I hate to repeat things, sorry, please go for the other thread where I > replied to Andrea. > All of this needs to be in the changelog if you want your patches to even be considered, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com> To: Cong Wang <amwang@redhat.com> Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@xenotime.net>, Andrea Arcangeli <aarcange@redhat.com>, Rik van Riel <riel@redhat.com>, Johannes Weiner <jweiner@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Date: Tue, 21 Jun 2011 23:23:47 -0700 (PDT) [thread overview] Message-ID: <alpine.DEB.2.00.1106212322510.14693@chino.kir.corp.google.com> (raw) In-Reply-To: <4E01816A.3040309@redhat.com> On Wed, 22 Jun 2011, Cong Wang wrote: > > If you're proposing a patch for a specific purpose, it's appropriate to > > include that in the changelog. > > Sorry, I can't put everything you don't see into the changelog. > As far as changelogs go, yes, we can demand that. > > > > But now that I know what you're proposing this for, it's an easy NACK: > > transparent_hugepage=0 has no significant benefit over > > transparent_hugepage=never for kdump because the memory savings is > > negligible. > > I hate to repeat things, sorry, please go for the other thread where I > replied to Andrea. > All of this needs to be in the changelog if you want your patches to even be considered, thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-22 6:23 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-21 8:10 [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Amerigo Wang 2011-06-21 8:10 ` Amerigo Wang 2011-06-21 8:10 ` [PATCH v2 2/4] mm: make the threshold of enabling THP configurable Amerigo Wang 2011-06-21 8:10 ` Amerigo Wang 2011-06-21 14:44 ` Dave Hansen 2011-06-21 14:44 ` Dave Hansen 2011-06-21 20:17 ` Dave Hansen 2011-06-21 20:17 ` Dave Hansen 2011-06-22 1:23 ` David Rientjes 2011-06-22 1:23 ` David Rientjes 2011-06-22 3:06 ` Cong Wang 2011-06-22 3:06 ` Cong Wang 2011-06-22 3:29 ` David Rientjes 2011-06-22 3:29 ` David Rientjes 2011-06-22 5:40 ` Cong Wang 2011-06-22 5:40 ` Cong Wang 2011-06-22 6:32 ` David Rientjes 2011-06-22 6:32 ` David Rientjes 2011-06-22 11:07 ` Cong Wang 2011-06-22 11:07 ` Cong Wang 2011-06-22 14:40 ` Andrea Arcangeli 2011-06-22 14:40 ` Andrea Arcangeli 2011-06-23 6:51 ` Cong Wang 2011-06-23 6:51 ` Cong Wang 2011-06-21 8:10 ` [PATCH 3/4] mm: improve THP printk messages Amerigo Wang 2011-06-21 8:10 ` Amerigo Wang 2011-06-22 1:23 ` David Rientjes 2011-06-22 1:23 ` David Rientjes 2011-06-22 3:04 ` Cong Wang 2011-06-22 3:04 ` Cong Wang 2011-06-21 8:10 ` [PATCH 4/4] mm: introduce no_ksm to disable totally KSM Amerigo Wang 2011-06-21 8:10 ` Amerigo Wang 2011-06-21 13:32 ` Andrea Arcangeli 2011-06-21 13:32 ` Andrea Arcangeli 2011-06-22 3:13 ` Cong Wang 2011-06-22 3:13 ` Cong Wang 2011-06-21 11:52 ` [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Michal Hocko 2011-06-21 11:52 ` Michal Hocko 2011-06-21 11:58 ` Michal Hocko 2011-06-21 11:58 ` Michal Hocko 2011-06-21 13:30 ` Andrea Arcangeli 2011-06-21 13:30 ` Andrea Arcangeli 2011-06-22 3:11 ` Cong Wang 2011-06-22 3:11 ` Cong Wang 2011-06-22 1:16 ` David Rientjes 2011-06-22 1:16 ` David Rientjes 2011-06-22 3:08 ` Cong Wang 2011-06-22 3:08 ` Cong Wang 2011-06-22 3:24 ` David Rientjes 2011-06-22 3:24 ` David Rientjes 2011-06-22 5:45 ` Cong Wang 2011-06-22 5:45 ` Cong Wang 2011-06-22 6:23 ` David Rientjes [this message] 2011-06-22 6:23 ` David Rientjes 2011-06-22 11:08 ` Cong Wang 2011-06-22 11:08 ` Cong Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.00.1106212322510.14693@chino.kir.corp.google.com \ --to=rientjes@google.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=amwang@redhat.com \ --cc=jweiner@redhat.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=rdunlap@xenotime.net \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.