All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	mhocko@kernel.org, okozina@redhat.com, jmarchan@redhat.com,
	skozina@redhat.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: System freezes after OOM
Date: Fri, 15 Jul 2016 14:21:54 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1607151420280.121215@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1607150722460.5034@file01.intranet.prod.int.rdu2.redhat.com>

On Fri, 15 Jul 2016, Mikulas Patocka wrote:

> > Umm, show me an explicit guarantee where the oom reaper will free memory 
> > such that other threads may return memory to this process's mempool so it 
> > can make forward progress in mempool_alloc() without the need of utilizing 
> > memory reserves.  First, it might be helpful to show that the oom reaper 
> > is ever guaranteed to free any memory for a selected oom victim.
> 
> The function mempool_alloc sleeps with "io_schedule_timeout(5*HZ);"
> 
> So, if the oom reaper frees some memory into the page allocator, the 
> process that is stuck in mempoo_alloc will sleep for up to 5 seconds, then 
> it will retry the allocation with "element = pool->alloc(gfp_temp, 
> pool->pool_data)" (that will allocate from the page allocator) and succed.
> 

No, the state of the 4.7 oom killer does not explicitly guarantee any 
memory freeing of the victim and there is no guarantee that elements will 
be returned to the mempool.  If you're talking about patches that you're 
proposing for the 4.8 merge window, please post them with complete 
changelogs.  Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	mhocko@kernel.org, okozina@redhat.com, jmarchan@redhat.com,
	skozina@redhat.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: System freezes after OOM
Date: Fri, 15 Jul 2016 14:21:54 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1607151420280.121215@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1607150722460.5034@file01.intranet.prod.int.rdu2.redhat.com>

On Fri, 15 Jul 2016, Mikulas Patocka wrote:

> > Umm, show me an explicit guarantee where the oom reaper will free memory 
> > such that other threads may return memory to this process's mempool so it 
> > can make forward progress in mempool_alloc() without the need of utilizing 
> > memory reserves.  First, it might be helpful to show that the oom reaper 
> > is ever guaranteed to free any memory for a selected oom victim.
> 
> The function mempool_alloc sleeps with "io_schedule_timeout(5*HZ);"
> 
> So, if the oom reaper frees some memory into the page allocator, the 
> process that is stuck in mempoo_alloc will sleep for up to 5 seconds, then 
> it will retry the allocation with "element = pool->alloc(gfp_temp, 
> pool->pool_data)" (that will allocate from the page allocator) and succed.
> 

No, the state of the 4.7 oom killer does not explicitly guarantee any 
memory freeing of the victim and there is no guarantee that elements will 
be returned to the mempool.  If you're talking about patches that you're 
proposing for the 4.8 merge window, please post them with complete 
changelogs.  Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-07-15 21:22 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <57837CEE.1010609@redhat.com>
     [not found] ` <f80dc690-7e71-26b2-59a2-5a1557d26713@redhat.com>
     [not found]   ` <9be09452-de7f-d8be-fd5d-4a80d1cd1ba3@redhat.com>
2016-07-11 15:43     ` System freezes after OOM Mikulas Patocka
2016-07-11 15:43       ` Mikulas Patocka
2016-07-12  6:49       ` Michal Hocko
2016-07-12  6:49         ` Michal Hocko
2016-07-12 23:44         ` Mikulas Patocka
2016-07-12 23:44         ` Mikulas Patocka
2016-07-12 23:44           ` Mikulas Patocka
2016-07-13  8:35           ` Jerome Marchand
2016-07-13  8:35           ` Jerome Marchand
2016-07-13 11:14             ` Michal Hocko
2016-07-13 11:14             ` Michal Hocko
2016-07-13 11:14               ` Michal Hocko
2016-07-13 14:21               ` Mikulas Patocka
2016-07-13 14:21                 ` Mikulas Patocka
2016-07-13 11:10           ` Michal Hocko
2016-07-13 11:10           ` Michal Hocko
2016-07-13 11:10             ` Michal Hocko
2016-07-13 12:50             ` Michal Hocko
2016-07-13 12:50               ` Michal Hocko
2016-07-13 13:44               ` Milan Broz
2016-07-13 13:44                 ` Milan Broz
2016-07-13 15:21                 ` Mikulas Patocka
2016-07-13 15:21                   ` Mikulas Patocka
2016-07-14  9:09                   ` Michal Hocko
2016-07-14  9:09                     ` Michal Hocko
2016-07-14  9:46                     ` Milan Broz
2016-07-14  9:46                       ` Milan Broz
2016-07-13 12:50             ` Michal Hocko
2016-07-13 15:02             ` Mikulas Patocka
2016-07-13 15:02             ` Mikulas Patocka
2016-07-13 15:02               ` Mikulas Patocka
2016-07-14 10:51               ` [dm-devel] " Ondrej Kozina
2016-07-14 10:51                 ` Ondrej Kozina
2016-07-14 12:51               ` Michal Hocko
2016-07-14 12:51                 ` Michal Hocko
2016-07-14 14:00                 ` Mikulas Patocka
2016-07-14 14:00                   ` Mikulas Patocka
2016-07-14 14:59                   ` Michal Hocko
2016-07-14 14:59                     ` Michal Hocko
2016-07-14 15:25                     ` Ondrej Kozina
2016-07-14 15:25                       ` Ondrej Kozina
2016-07-14 17:35                     ` Mikulas Patocka
2016-07-14 17:35                       ` Mikulas Patocka
2016-07-15  8:35                       ` Michal Hocko
2016-07-15  8:35                         ` Michal Hocko
2016-07-15 12:11                         ` Mikulas Patocka
2016-07-15 12:11                           ` Mikulas Patocka
2016-07-15 12:22                           ` Michal Hocko
2016-07-15 12:22                             ` Michal Hocko
2016-07-15 17:02                             ` Mikulas Patocka
2016-07-15 17:02                               ` Mikulas Patocka
2016-07-18  7:22                               ` Michal Hocko
2016-07-18  7:22                                 ` Michal Hocko
2016-07-14 14:08                 ` Ondrej Kozina
2016-07-14 14:08                   ` Ondrej Kozina
2016-07-14 14:08                   ` Ondrej Kozina
2016-07-14 15:31                   ` Michal Hocko
2016-07-14 15:31                     ` Michal Hocko
2016-07-14 17:07                     ` Ondrej Kozina
2016-07-14 17:07                       ` Ondrej Kozina
2016-07-14 17:36                       ` Michal Hocko
2016-07-14 17:36                         ` Michal Hocko
2016-07-14 17:39                         ` Michal Hocko
2016-07-14 17:39                           ` Michal Hocko
2016-07-15 11:42                       ` Tetsuo Handa
2016-07-15 11:42                         ` Tetsuo Handa
2016-07-13 13:19           ` Tetsuo Handa
2016-07-13 13:19             ` Tetsuo Handa
2016-07-13 13:39             ` Michal Hocko
2016-07-13 13:39               ` Michal Hocko
2016-07-13 14:18               ` Mikulas Patocka
2016-07-13 14:18               ` Mikulas Patocka
2016-07-13 14:18                 ` Mikulas Patocka
2016-07-13 14:56                 ` Michal Hocko
2016-07-13 14:56                   ` Michal Hocko
2016-07-13 15:11                   ` Mikulas Patocka
2016-07-13 15:11                     ` Mikulas Patocka
2016-07-13 23:53                     ` David Rientjes
2016-07-13 23:53                       ` David Rientjes
2016-07-14 11:01                       ` Tetsuo Handa
2016-07-14 11:01                         ` Tetsuo Handa
2016-07-14 12:29                         ` Mikulas Patocka
2016-07-14 12:29                           ` Mikulas Patocka
2016-07-14 20:26                         ` David Rientjes
2016-07-14 20:26                           ` David Rientjes
2016-07-14 21:40                           ` Tetsuo Handa
2016-07-14 21:40                             ` Tetsuo Handa
2016-07-14 22:04                             ` David Rientjes
2016-07-14 22:04                               ` David Rientjes
2016-07-15 11:25                           ` Mikulas Patocka
2016-07-15 11:25                             ` Mikulas Patocka
2016-07-15 21:21                             ` David Rientjes [this message]
2016-07-15 21:21                               ` David Rientjes
2016-07-14 11:01                       ` Tetsuo Handa
2016-07-14 12:27                       ` Mikulas Patocka
2016-07-14 12:27                         ` Mikulas Patocka
2016-07-14 20:22                         ` David Rientjes
2016-07-14 20:22                           ` David Rientjes
2016-07-15 11:21                           ` Mikulas Patocka
2016-07-15 11:21                             ` Mikulas Patocka
2016-07-15 21:25                             ` David Rientjes
2016-07-15 21:25                               ` David Rientjes
2016-07-15 21:39                               ` Mikulas Patocka
2016-07-15 21:39                                 ` Mikulas Patocka
2016-07-15 21:58                                 ` David Rientjes
2016-07-15 21:58                                   ` David Rientjes
2016-07-15 23:53                                   ` Mikulas Patocka
2016-07-15 23:53                                     ` Mikulas Patocka
2016-07-18 15:14                             ` Johannes Weiner
2016-07-18 15:14                               ` Johannes Weiner
2016-07-14 15:29                       ` Michal Hocko
2016-07-14 15:29                         ` Michal Hocko
2016-07-14 20:38                         ` David Rientjes
2016-07-14 20:38                           ` David Rientjes
2016-07-15  7:22                           ` Michal Hocko
2016-07-15  7:22                             ` Michal Hocko
2016-07-15  8:23                             ` Michal Hocko
2016-07-15  8:23                               ` Michal Hocko
2016-07-15 12:00                             ` Mikulas Patocka
2016-07-15 12:00                               ` Mikulas Patocka
2016-07-15 21:47                             ` David Rientjes
2016-07-15 21:47                               ` David Rientjes
2016-07-18  7:39                               ` Michal Hocko
2016-07-18  7:39                                 ` Michal Hocko
2016-07-18 21:03                                 ` David Rientjes
2016-07-18 21:03                                   ` David Rientjes
2016-07-13 23:53                     ` David Rientjes
2016-07-13 15:11                   ` Mikulas Patocka
2016-07-13 14:56                 ` Michal Hocko
2016-07-13 13:39             ` Michal Hocko
2016-07-14  0:01             ` David Rientjes
2016-07-14  0:01               ` David Rientjes
2016-07-14  0:01             ` David Rientjes
2016-07-13 13:19           ` Tetsuo Handa
2016-07-12  6:49       ` Michal Hocko
2016-07-11 15:43     ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1607151420280.121215@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=okozina@redhat.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=skozina@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.