All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: Kees Cook <keescook@chromium.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Thu, 7 Dec 2017 14:15:27 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712071413470.29779@nuc-kabylake> (raw)
In-Reply-To: <CAGXu5j+9qWBM3G1ZtBXPi35UGkcfXnSbgZCBjXJM35X9+hS4ug@mail.gmail.com>

On Thu, 7 Dec 2017, Kees Cook wrote:

> > These SLAB config options are only used for testing so this is ok.
>
> Most systems use SLUB so I can't say how common CONFIG_DEBUG_SLAB is.
> (Though, FWIW with SLUB, CONFIG_SLUB_DEBUG is very common.)

CONFIG_SLUB_DEBUG is on by default because it compiles into the kernel the
runtime configurable debugging framework. It does not activate any
debugging.

CONFIG_SLUB_DEBUG_ON is the equivalent to CONFIG_SLAB_DEBUG. The kernel
will boot with debugging on without any extra kernel options with these.

WARNING: multiple messages have this Message-ID (diff)
From: Christopher Lameter <cl@linux.com>
To: Kees Cook <keescook@chromium.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Thu, 7 Dec 2017 14:15:27 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712071413470.29779@nuc-kabylake> (raw)
In-Reply-To: <CAGXu5j+9qWBM3G1ZtBXPi35UGkcfXnSbgZCBjXJM35X9+hS4ug@mail.gmail.com>

On Thu, 7 Dec 2017, Kees Cook wrote:

> > These SLAB config options are only used for testing so this is ok.
>
> Most systems use SLUB so I can't say how common CONFIG_DEBUG_SLAB is.
> (Though, FWIW with SLUB, CONFIG_SLUB_DEBUG is very common.)

CONFIG_SLUB_DEBUG is on by default because it compiles into the kernel the
runtime configurable debugging framework. It does not activate any
debugging.

CONFIG_SLUB_DEBUG_ON is the equivalent to CONFIG_SLAB_DEBUG. The kernel
will boot with debugging on without any extra kernel options with these.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-12-07 20:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 10:17 [PATCH] mm/slab: Do not hash pointers when debugging slab Geert Uytterhoeven
2017-12-07 11:13 ` Christopher Lameter
2017-12-07 11:13   ` Christopher Lameter
2017-12-07 18:43   ` Kees Cook
2017-12-07 18:43     ` Kees Cook
2017-12-07 20:15     ` Christopher Lameter [this message]
2017-12-07 20:15       ` Christopher Lameter
2017-12-10 20:45 ` Linus Torvalds
2017-12-10 20:45   ` Linus Torvalds
2017-12-11  8:08   ` Geert Uytterhoeven
2017-12-11  8:08     ` Geert Uytterhoeven
2017-12-11 12:00   ` Christopher Lameter
2017-12-11 12:00     ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712071413470.29779@nuc-kabylake \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert+renesas@glider.be \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=me@tobin.cc \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.