All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Denis Efremov <efremov@linux.com>,
	cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] coccinelle: misc: add swap script
Date: Thu, 18 Feb 2021 21:03:16 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2102182102500.2748@hadrien> (raw)
In-Reply-To: <50eb8319-a552-c749-6143-7e24a8778a04@web.de>



On Thu, 18 Feb 2021, Markus Elfring wrote:

> > A disjunction basically says "at this node in the cfg, can I match the
> > first patter, or can I match the second pattern, etc."  Unfortunately in
> > this case the two branches start matching at different nodes, so the short
> > circuit aspect of a disjunction isn't used, and it matches both patterns.
> >
> > The solution is to just make two rules.  The first for the if case and the
> > second for everything else.
>
> Will such feedback trigger further software development considerations?

No.  This is never going to change, until someone completely redesigns
Coccinelle.

julia

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr,
	linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH] coccinelle: misc: add swap script
Date: Thu, 18 Feb 2021 21:03:16 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2102182102500.2748@hadrien> (raw)
In-Reply-To: <50eb8319-a552-c749-6143-7e24a8778a04@web.de>



On Thu, 18 Feb 2021, Markus Elfring wrote:

> > A disjunction basically says "at this node in the cfg, can I match the
> > first patter, or can I match the second pattern, etc."  Unfortunately in
> > this case the two branches start matching at different nodes, so the short
> > circuit aspect of a disjunction isn't used, and it matches both patterns.
> >
> > The solution is to just make two rules.  The first for the if case and the
> > second for everything else.
>
> Will such feedback trigger further software development considerations?

No.  This is never going to change, until someone completely redesigns
Coccinelle.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2021-02-18 20:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  8:01 [PATCH] coccinelle: misc: add swap script Denis Efremov
2021-02-16  8:01 ` [Cocci] " Denis Efremov
2021-02-16 18:05 ` Markus Elfring
2021-02-17 21:31 ` Julia Lawall
2021-02-17 21:31   ` [Cocci] " Julia Lawall
2021-02-18  6:13   ` Denis Efremov
2021-02-18  6:13     ` [Cocci] " Denis Efremov
2021-02-18 10:17     ` Julia Lawall
2021-02-18 10:17       ` [Cocci] " Julia Lawall
2021-02-18 11:03       ` Denis Efremov
2021-02-18 11:03         ` [Cocci] " Denis Efremov
2021-02-18 11:29         ` Julia Lawall
2021-02-18 11:29           ` [Cocci] " Julia Lawall
2021-02-18 11:34           ` Denis Efremov
2021-02-18 11:34             ` [Cocci] " Denis Efremov
     [not found]       ` <50eb8319-a552-c749-6143-7e24a8778a04@web.de>
2021-02-18 20:03         ` Julia Lawall [this message]
2021-02-18 20:03           ` Julia Lawall
2021-02-19  9:05 ` [PATCH v2] coccinelle: misc: add minmax script Denis Efremov
2021-02-19  9:05   ` [Cocci] " Denis Efremov
2021-02-19  9:07   ` Denis Efremov
2021-02-19  9:07     ` [Cocci] " Denis Efremov
2021-02-19  9:24 ` [PATCH v2] coccinelle: misc: add swap script Denis Efremov
2021-02-19  9:24   ` [Cocci] " Denis Efremov
2021-03-03 16:37   ` Julia Lawall
2021-03-03 16:37     ` [Cocci] " Julia Lawall
2021-03-05 10:09 ` [PATCH v3] " Denis Efremov
2021-03-05 10:09   ` [Cocci] " Denis Efremov
2021-03-28  9:19   ` Denis Efremov
2021-04-04 12:33     ` Julia Lawall
2021-04-04 12:33       ` [Cocci] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2102182102500.2748@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=efremov@linux.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.