From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: Julia Lawall <julia.lawall@inria.fr>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] coccinelle: misc: add swap script Date: Sun, 4 Apr 2021 14:33:58 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.22.394.2104041433430.2958@hadrien> (raw) In-Reply-To: <afb06bbc-5c28-8a92-f205-c9a1c87c707c@linux.com> On Sun, 28 Mar 2021, Denis Efremov wrote: > Ping? Applied. Thanks. > > On 3/5/21 1:09 PM, Denis Efremov wrote: > > Check for opencoded swap() implementation. > > > > Signed-off-by: Denis Efremov <efremov@linux.com> > > --- > > Changes in v2: > > - additional patch rule to drop excessive {} > > - fix indentation in patch mode by anchoring ; > > Changes in v3: > > - Rule added for simple (without var init) swap highlighting in !patch > > mode > > - "depends on patch && (rpvar || rp)" fixed > > > > scripts/coccinelle/misc/swap.cocci | 122 +++++++++++++++++++++++++++++ > > 1 file changed, 122 insertions(+) > > create mode 100644 scripts/coccinelle/misc/swap.cocci > > > > diff --git a/scripts/coccinelle/misc/swap.cocci > > b/scripts/coccinelle/misc/swap.cocci > > new file mode 100644 > > index 000000000000..c5e71b7ef7f5 > > --- /dev/null > > +++ b/scripts/coccinelle/misc/swap.cocci > > @@ -0,0 +1,122 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/// > > +/// Check for opencoded swap() implementation. > > +/// > > +// Confidence: High > > +// Copyright: (C) 2021 Denis Efremov ISPRAS > > +// Options: --no-includes --include-headers > > +// > > +// Keywords: swap > > +// > > + > > +virtual patch > > +virtual org > > +virtual report > > +virtual context > > + > > +@rvar depends on !patch@ > > +identifier tmp; > > +expression a, b; > > +type T; > > +position p; > > +@@ > > + > > +( > > +* T tmp; > > +| > > +* T tmp = 0; > > +| > > +* T *tmp = NULL; > > +) > > +... when != tmp > > +* tmp = a; > > +* a = b;@p > > +* b = tmp; > > +... when != tmp > > + > > +@r depends on !patch@ > > +identifier tmp; > > +expression a, b; > > +position p != rvar.p; > > +@@ > > + > > +* tmp = a; > > +* a = b;@p > > +* b = tmp; > > + > > +@rpvar depends on patch@ > > +identifier tmp; > > +expression a, b; > > +type T; > > +@@ > > + > > +( > > +- T tmp; > > +| > > +- T tmp = 0; > > +| > > +- T *tmp = NULL; > > +) > > +... when != tmp > > +- tmp = a; > > +- a = b; > > +- b = tmp > > ++ swap(a, b) > > + ; > > +... when != tmp > > + > > +@rp depends on patch@ > > +identifier tmp; > > +expression a, b; > > +@@ > > + > > +- tmp = a; > > +- a = b; > > +- b = tmp > > ++ swap(a, b) > > + ; > > + > > +@depends on patch && (rpvar || rp)@ > > +@@ > > + > > +( > > + for (...;...;...) > > +- { > > + swap(...); > > +- } > > +| > > + while (...) > > +- { > > + swap(...); > > +- } > > +| > > + if (...) > > +- { > > + swap(...); > > +- } > > +) > > + > > + > > +@script:python depends on report@ > > +p << r.p; > > +@@ > > + > > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on org@ > > +p << r.p; > > +@@ > > + > > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on report@ > > +p << rvar.p; > > +@@ > > + > > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on org@ > > +p << rvar.p; > > +@@ > > + > > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") > > >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr> To: Denis Efremov <efremov@linux.com> Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v3] coccinelle: misc: add swap script Date: Sun, 4 Apr 2021 14:33:58 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.22.394.2104041433430.2958@hadrien> (raw) In-Reply-To: <afb06bbc-5c28-8a92-f205-c9a1c87c707c@linux.com> On Sun, 28 Mar 2021, Denis Efremov wrote: > Ping? Applied. Thanks. > > On 3/5/21 1:09 PM, Denis Efremov wrote: > > Check for opencoded swap() implementation. > > > > Signed-off-by: Denis Efremov <efremov@linux.com> > > --- > > Changes in v2: > > - additional patch rule to drop excessive {} > > - fix indentation in patch mode by anchoring ; > > Changes in v3: > > - Rule added for simple (without var init) swap highlighting in !patch > > mode > > - "depends on patch && (rpvar || rp)" fixed > > > > scripts/coccinelle/misc/swap.cocci | 122 +++++++++++++++++++++++++++++ > > 1 file changed, 122 insertions(+) > > create mode 100644 scripts/coccinelle/misc/swap.cocci > > > > diff --git a/scripts/coccinelle/misc/swap.cocci > > b/scripts/coccinelle/misc/swap.cocci > > new file mode 100644 > > index 000000000000..c5e71b7ef7f5 > > --- /dev/null > > +++ b/scripts/coccinelle/misc/swap.cocci > > @@ -0,0 +1,122 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/// > > +/// Check for opencoded swap() implementation. > > +/// > > +// Confidence: High > > +// Copyright: (C) 2021 Denis Efremov ISPRAS > > +// Options: --no-includes --include-headers > > +// > > +// Keywords: swap > > +// > > + > > +virtual patch > > +virtual org > > +virtual report > > +virtual context > > + > > +@rvar depends on !patch@ > > +identifier tmp; > > +expression a, b; > > +type T; > > +position p; > > +@@ > > + > > +( > > +* T tmp; > > +| > > +* T tmp = 0; > > +| > > +* T *tmp = NULL; > > +) > > +... when != tmp > > +* tmp = a; > > +* a = b;@p > > +* b = tmp; > > +... when != tmp > > + > > +@r depends on !patch@ > > +identifier tmp; > > +expression a, b; > > +position p != rvar.p; > > +@@ > > + > > +* tmp = a; > > +* a = b;@p > > +* b = tmp; > > + > > +@rpvar depends on patch@ > > +identifier tmp; > > +expression a, b; > > +type T; > > +@@ > > + > > +( > > +- T tmp; > > +| > > +- T tmp = 0; > > +| > > +- T *tmp = NULL; > > +) > > +... when != tmp > > +- tmp = a; > > +- a = b; > > +- b = tmp > > ++ swap(a, b) > > + ; > > +... when != tmp > > + > > +@rp depends on patch@ > > +identifier tmp; > > +expression a, b; > > +@@ > > + > > +- tmp = a; > > +- a = b; > > +- b = tmp > > ++ swap(a, b) > > + ; > > + > > +@depends on patch && (rpvar || rp)@ > > +@@ > > + > > +( > > + for (...;...;...) > > +- { > > + swap(...); > > +- } > > +| > > + while (...) > > +- { > > + swap(...); > > +- } > > +| > > + if (...) > > +- { > > + swap(...); > > +- } > > +) > > + > > + > > +@script:python depends on report@ > > +p << r.p; > > +@@ > > + > > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on org@ > > +p << r.p; > > +@@ > > + > > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on report@ > > +p << rvar.p; > > +@@ > > + > > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > > + > > +@script:python depends on org@ > > +p << rvar.p; > > +@@ > > + > > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") > > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-04-04 12:42 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 8:01 [PATCH] coccinelle: misc: add swap script Denis Efremov 2021-02-16 8:01 ` [Cocci] " Denis Efremov 2021-02-16 18:05 ` Markus Elfring 2021-02-17 21:31 ` Julia Lawall 2021-02-17 21:31 ` [Cocci] " Julia Lawall 2021-02-18 6:13 ` Denis Efremov 2021-02-18 6:13 ` [Cocci] " Denis Efremov 2021-02-18 10:17 ` Julia Lawall 2021-02-18 10:17 ` [Cocci] " Julia Lawall 2021-02-18 11:03 ` Denis Efremov 2021-02-18 11:03 ` [Cocci] " Denis Efremov 2021-02-18 11:29 ` Julia Lawall 2021-02-18 11:29 ` [Cocci] " Julia Lawall 2021-02-18 11:34 ` Denis Efremov 2021-02-18 11:34 ` [Cocci] " Denis Efremov [not found] ` <50eb8319-a552-c749-6143-7e24a8778a04@web.de> 2021-02-18 20:03 ` Julia Lawall 2021-02-18 20:03 ` [Cocci] " Julia Lawall 2021-02-19 9:05 ` [PATCH v2] coccinelle: misc: add minmax script Denis Efremov 2021-02-19 9:05 ` [Cocci] " Denis Efremov 2021-02-19 9:07 ` Denis Efremov 2021-02-19 9:07 ` [Cocci] " Denis Efremov 2021-02-19 9:24 ` [PATCH v2] coccinelle: misc: add swap script Denis Efremov 2021-02-19 9:24 ` [Cocci] " Denis Efremov 2021-03-03 16:37 ` Julia Lawall 2021-03-03 16:37 ` [Cocci] " Julia Lawall 2021-03-05 10:09 ` [PATCH v3] " Denis Efremov 2021-03-05 10:09 ` [Cocci] " Denis Efremov 2021-03-28 9:19 ` Denis Efremov 2021-04-04 12:33 ` Julia Lawall [this message] 2021-04-04 12:33 ` [Cocci] " Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.22.394.2104041433430.2958@hadrien \ --to=julia.lawall@inria.fr \ --cc=cocci@systeme.lip6.fr \ --cc=efremov@linux.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.